simp-beaker-helpers 1.34.3 → 1.35.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (35) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/pr_acceptance.yml +1 -1
  3. data/.github/workflows/pr_tests.yml +6 -7
  4. data/.rubocop.yml +652 -495
  5. data/CHANGELOG.md +4 -0
  6. data/Gemfile +5 -2
  7. data/lib/simp/beaker_helpers/constants.rb +7 -5
  8. data/lib/simp/beaker_helpers/inspec.rb +52 -55
  9. data/lib/simp/beaker_helpers/snapshot.rb +126 -134
  10. data/lib/simp/beaker_helpers/ssg.rb +33 -34
  11. data/lib/simp/beaker_helpers/version.rb +2 -1
  12. data/lib/simp/beaker_helpers/windows.rb +4 -1
  13. data/lib/simp/beaker_helpers.rb +274 -291
  14. data/lib/simp/rake/beaker.rb +174 -177
  15. data/spec/acceptance/suites/default/check_puppet_version_spec.rb +3 -3
  16. data/spec/acceptance/suites/default/fixture_modules_spec.rb +9 -9
  17. data/spec/acceptance/suites/default/install_simp_deps_repo_spec.rb +7 -13
  18. data/spec/acceptance/suites/default/pki_tests_spec.rb +10 -16
  19. data/spec/acceptance/suites/fips_from_fixtures/00_default_spec.rb +4 -4
  20. data/spec/acceptance/suites/inspec/00_default_spec.rb +22 -22
  21. data/spec/acceptance/suites/offline/00_default_spec.rb +43 -12
  22. data/spec/acceptance/suites/offline/nodesets/default.yml +1 -3
  23. data/spec/acceptance/suites/puppet_collections/00_default_spec.rb +3 -3
  24. data/spec/acceptance/suites/snapshot/00_snapshot_test_spec.rb +27 -7
  25. data/spec/acceptance/suites/snapshot/10_general_usage_spec.rb +3 -3
  26. data/spec/acceptance/suites/ssg/00_default_spec.rb +20 -18
  27. data/spec/acceptance/suites/windows/00_default_spec.rb +47 -49
  28. data/spec/acceptance/suites/windows/nodesets/default.yml +3 -3
  29. data/spec/acceptance/suites/windows/nodesets/win2012.yml +3 -3
  30. data/spec/acceptance/suites/windows/nodesets/win2016.yml +3 -3
  31. data/spec/acceptance/suites/windows/nodesets/win2019.yml +3 -3
  32. data/spec/lib/simp/beaker_helpers_spec.rb +96 -66
  33. data/spec/spec_helper.rb +51 -53
  34. data/spec/spec_helper_acceptance.rb +17 -22
  35. metadata +5 -5
data/.rubocop.yml CHANGED
@@ -1,544 +1,701 @@
1
1
  ---
2
- require: rubocop-rspec
2
+ require:
3
+ - rubocop-performance
4
+ - rubocop-rake
5
+ - rubocop-rspec
3
6
  AllCops:
4
- TargetRubyVersion: 2.7
7
+ NewCops: enable
8
+ DisplayCopNames: true
9
+ TargetRubyVersion: "2.7"
5
10
  Include:
6
- - ./**/*.rb
11
+ - "**/*.rb"
7
12
  Exclude:
8
- - files/**/*
9
- - vendor/**/*
10
- - .vendor/**/*
13
+ - bin/*
14
+ - ".vendor/**/*"
11
15
  - pkg/**/*
12
16
  - spec/fixtures/**/*
13
- - Gemfile
14
- - Rakefile
15
- - Guardfile
16
- - Vagrantfile
17
- Layout/ConditionPosition:
17
+ - vendor/**/*
18
+ - "**/Puppetfile"
19
+ - "**/Vagrantfile"
20
+ - "**/Guardfile"
21
+ Layout/LineLength:
22
+ Description: People have wide screens, use them.
23
+ Max: 200
24
+ RSpec/BeforeAfterAll:
25
+ Description:
26
+ Beware of using after(:all) as it may cause state to leak between tests.
27
+ A necessary evil in acceptance testing.
28
+ Exclude:
29
+ - spec/acceptance/**/*.rb
30
+ RSpec/HookArgument:
31
+ Description: Prefer explicit :each argument, matching existing module's style
32
+ EnforcedStyle: each
33
+ RSpec/DescribeSymbol:
34
+ Exclude:
35
+ - spec/unit/facter/**/*.rb
36
+ Style/BlockDelimiters:
37
+ Description:
38
+ Prefer braces for chaining. Mostly an aesthetical choice. Better to
39
+ be consistent then.
40
+ EnforcedStyle: braces_for_chaining
41
+ Style/ClassAndModuleChildren:
42
+ Description: Compact style reduces the required amount of indentation.
43
+ EnforcedStyle: compact
44
+ Style/EmptyElse:
45
+ Description: Enforce against empty else clauses, but allow `nil` for clarity.
46
+ EnforcedStyle: empty
47
+ Style/FormatString:
48
+ Description: Following the main puppet project's style, prefer the % format format.
49
+ EnforcedStyle: percent
50
+ Style/FormatStringToken:
51
+ Description:
52
+ Following the main puppet project's style, prefer the simpler template
53
+ tokens over annotated ones.
54
+ EnforcedStyle: template
55
+ Style/Lambda:
56
+ Description: Prefer the keyword for easier discoverability.
57
+ EnforcedStyle: literal
58
+ Style/RegexpLiteral:
59
+ Description: Community preference. See https://github.com/voxpupuli/modulesync_config/issues/168
60
+ EnforcedStyle: percent_r
61
+ Style/TernaryParentheses:
62
+ Description:
63
+ Checks for use of parentheses around ternary conditions. Enforce parentheses
64
+ on complex expressions for better readability, but seriously consider breaking
65
+ it up.
66
+ EnforcedStyle: require_parentheses_when_complex
67
+ Style/TrailingCommaInArguments:
68
+ Description:
69
+ Prefer always trailing comma on multiline argument lists. This makes
70
+ diffs, and re-ordering nicer.
71
+ EnforcedStyleForMultiline: comma
72
+ Style/TrailingCommaInArrayLiteral:
73
+ Description:
74
+ Prefer always trailing comma on multiline literals. This makes diffs,
75
+ and re-ordering nicer.
76
+ EnforcedStyleForMultiline: comma
77
+ Style/SymbolArray:
78
+ Description: Using percent style obscures symbolic intent of array's contents.
79
+ EnforcedStyle: brackets
80
+ RSpec/MessageSpies:
81
+ EnforcedStyle: receive
82
+ Style/Documentation:
83
+ Exclude:
84
+ - lib/puppet/parser/functions/**/*
85
+ - spec/**/*
86
+ Style/WordArray:
87
+ EnforcedStyle: brackets
88
+ Performance/AncestorsInclude:
18
89
  Enabled: true
19
-
20
- Lint/ElseLayout:
90
+ Performance/BigDecimalWithNumericArgument:
21
91
  Enabled: true
22
-
23
- Lint/UnreachableCode:
92
+ Performance/BlockGivenWithExplicitBlock:
24
93
  Enabled: true
25
-
26
- Lint/BinaryOperatorWithIdenticalOperands:
94
+ Performance/CaseWhenSplat:
27
95
  Enabled: true
28
-
29
- Lint/EnsureReturn:
96
+ Performance/ConstantRegexp:
30
97
  Enabled: true
31
-
32
- Lint/SuppressedException:
98
+ Performance/MethodObjectAsBlock:
33
99
  Enabled: true
34
-
35
- Lint/LiteralAsCondition:
100
+ Performance/RedundantSortBlock:
36
101
  Enabled: true
37
-
38
- Lint/ShadowingOuterLocalVariable:
102
+ Performance/RedundantStringChars:
39
103
  Enabled: true
40
-
41
- Lint/LiteralInInterpolation:
104
+ Performance/ReverseFirst:
42
105
  Enabled: true
43
-
44
- Style/HashSyntax:
45
- Enabled: false
46
-
47
- Style/RedundantReturn:
106
+ Performance/SortReverse:
48
107
  Enabled: true
49
-
50
- Layout/EndOfLine:
51
- Enabled: false
52
-
53
- Lint/AmbiguousOperator:
108
+ Performance/Squeeze:
109
+ Enabled: true
110
+ Performance/StringInclude:
54
111
  Enabled: true
55
-
56
- Lint/AssignmentInCondition:
112
+ Performance/Sum:
57
113
  Enabled: true
58
-
59
- Layout/SpaceBeforeComment:
114
+ Style/CollectionMethods:
60
115
  Enabled: true
61
-
62
- Style/AndOr:
116
+ Style/MethodCalledOnDoEndBlock:
63
117
  Enabled: true
64
-
65
- Style/RedundantSelf:
118
+ Style/StringMethods:
66
119
  Enabled: true
67
-
68
- Metrics/BlockLength:
120
+ Bundler/GemFilename:
69
121
  Enabled: false
70
-
71
- # Method length is not necessarily an indicator of code quality
72
- Metrics/MethodLength:
122
+ Bundler/InsecureProtocolSource:
73
123
  Enabled: false
74
-
75
- # Module length is not necessarily an indicator of code quality
76
- Metrics/ModuleLength:
124
+ Gemspec/DuplicatedAssignment:
125
+ Enabled: false
126
+ Gemspec/OrderedDependencies:
127
+ Enabled: false
128
+ Gemspec/RequiredRubyVersion:
129
+ Enabled: false
130
+ Gemspec/RubyVersionGlobalsUsage:
131
+ Enabled: false
132
+ Layout/ArgumentAlignment:
133
+ Enabled: false
134
+ Layout/BeginEndAlignment:
135
+ Enabled: false
136
+ Layout/ClosingHeredocIndentation:
137
+ Enabled: false
138
+ Layout/EmptyComment:
139
+ Enabled: false
140
+ Layout/EmptyLineAfterGuardClause:
141
+ Enabled: false
142
+ Layout/EmptyLinesAroundArguments:
143
+ Enabled: false
144
+ Layout/EmptyLinesAroundAttributeAccessor:
145
+ Enabled: false
146
+ Layout/EndOfLine:
147
+ Enabled: false
148
+ Layout/FirstArgumentIndentation:
77
149
  Enabled: false
78
-
79
- Style/WhileUntilModifier:
80
- Enabled: true
81
-
82
- Lint/AmbiguousRegexpLiteral:
83
- Enabled: true
84
-
85
- Security/Eval:
86
- Enabled: true
87
-
88
- Layout/BlockAlignment:
89
- Enabled: true
90
-
91
- Layout/DefEndAlignment:
92
- Enabled: true
93
-
94
- Layout/EndAlignment:
95
- Enabled: true
96
-
97
- Lint/DeprecatedClassMethods:
98
- Enabled: true
99
-
100
- Lint/Loop:
101
- Enabled: true
102
-
103
- Lint/ParenthesesAsGroupedExpression:
104
- Enabled: true
105
-
106
- Lint/RescueException:
107
- Enabled: true
108
-
109
- Lint/RedundantStringCoercion:
110
- Enabled: true
111
-
112
- Lint/UnusedBlockArgument:
113
- Enabled: true
114
-
115
- Lint/UnusedMethodArgument:
116
- Enabled: true
117
-
118
- Lint/UselessAccessModifier:
119
- Enabled: true
120
-
121
- Lint/UselessAssignment:
122
- Enabled: true
123
-
124
- Lint/Void:
125
- Enabled: true
126
-
127
- Layout/AccessModifierIndentation:
128
- Enabled: true
129
-
130
- Naming/AccessorMethodName:
131
- Enabled: true
132
-
133
- Style/Alias:
134
- Enabled: true
135
-
136
- Layout/ArrayAlignment:
137
- Enabled: true
138
-
139
150
  Layout/HashAlignment:
140
- Enabled: true
141
-
142
- Layout/ParameterAlignment:
143
- Enabled: true
144
-
151
+ Enabled: false
152
+ Layout/HeredocIndentation:
153
+ Enabled: false
154
+ Layout/LeadingEmptyLines:
155
+ Enabled: false
156
+ Layout/SpaceAroundMethodCallOperator:
157
+ Enabled: false
158
+ Layout/SpaceInsideArrayLiteralBrackets:
159
+ Enabled: false
160
+ Layout/SpaceInsideReferenceBrackets:
161
+ Enabled: false
162
+ Lint/BigDecimalNew:
163
+ Enabled: false
164
+ Lint/BooleanSymbol:
165
+ Enabled: false
166
+ Lint/ConstantDefinitionInBlock:
167
+ Enabled: false
168
+ Lint/DeprecatedOpenSSLConstant:
169
+ Enabled: false
170
+ Lint/DisjunctiveAssignmentInConstructor:
171
+ Enabled: false
172
+ Lint/DuplicateElsifCondition:
173
+ Enabled: false
174
+ Lint/DuplicateRequire:
175
+ Enabled: false
176
+ Lint/DuplicateRescueException:
177
+ Enabled: false
178
+ Lint/EmptyConditionalBody:
179
+ Enabled: false
180
+ Lint/EmptyFile:
181
+ Enabled: false
182
+ Lint/ErbNewArguments:
183
+ Enabled: false
184
+ Lint/FloatComparison:
185
+ Enabled: false
186
+ Lint/HashCompareByIdentity:
187
+ Enabled: false
188
+ Lint/IdentityComparison:
189
+ Enabled: false
190
+ Lint/InterpolationCheck:
191
+ Enabled: false
192
+ Lint/MissingCopEnableDirective:
193
+ Enabled: false
194
+ Lint/MixedRegexpCaptureTypes:
195
+ Enabled: false
196
+ Lint/NestedPercentLiteral:
197
+ Enabled: false
198
+ Lint/NonDeterministicRequireOrder:
199
+ Enabled: false
200
+ Lint/OrderedMagicComments:
201
+ Enabled: false
202
+ Lint/OutOfRangeRegexpRef:
203
+ Enabled: false
204
+ Lint/RaiseException:
205
+ Enabled: false
206
+ Lint/RedundantCopEnableDirective:
207
+ Enabled: false
208
+ Lint/RedundantRequireStatement:
209
+ Enabled: false
210
+ Lint/RedundantSafeNavigation:
211
+ Enabled: false
212
+ Lint/RedundantWithIndex:
213
+ Enabled: false
214
+ Lint/RedundantWithObject:
215
+ Enabled: false
216
+ Lint/RegexpAsCondition:
217
+ Enabled: false
218
+ Lint/ReturnInVoidContext:
219
+ Enabled: false
220
+ Lint/SafeNavigationConsistency:
221
+ Enabled: false
222
+ Lint/SafeNavigationWithEmpty:
223
+ Enabled: false
224
+ Lint/SelfAssignment:
225
+ Enabled: false
226
+ Lint/SendWithMixinArgument:
227
+ Enabled: false
228
+ Lint/ShadowedArgument:
229
+ Enabled: false
230
+ Lint/StructNewOverride:
231
+ Enabled: false
232
+ Lint/ToJSON:
233
+ Enabled: false
234
+ Lint/TopLevelReturnWithArgument:
235
+ Enabled: false
236
+ Lint/TrailingCommaInAttributeDeclaration:
237
+ Enabled: false
238
+ Lint/UnreachableLoop:
239
+ Enabled: false
240
+ Lint/UriEscapeUnescape:
241
+ Enabled: false
242
+ Lint/UriRegexp:
243
+ Enabled: false
244
+ Lint/UselessMethodDefinition:
245
+ Enabled: false
246
+ Lint/UselessTimes:
247
+ Enabled: false
248
+ Metrics/AbcSize:
249
+ Enabled: false
250
+ Metrics/BlockLength:
251
+ Enabled: false
145
252
  Metrics/BlockNesting:
146
- Enabled: true
147
-
148
- Style/AsciiComments:
149
- Enabled: true
150
-
151
- Style/Attr:
152
- Enabled: true
153
-
154
- Style/CaseEquality:
155
- Enabled: true
156
-
157
- Layout/CaseIndentation:
158
- Enabled: true
159
-
160
- Style/CharacterLiteral:
161
- Enabled: true
162
-
163
- Naming/ClassAndModuleCamelCase:
164
- Enabled: true
165
-
166
- Style/ClassAndModuleChildren:
167
253
  Enabled: false
168
-
169
- Style/ClassCheck:
170
- Enabled: true
171
-
172
- # Class length is not necessarily an indicator of code quality
173
254
  Metrics/ClassLength:
174
255
  Enabled: false
175
-
176
- Style/ClassMethods:
177
- Enabled: true
178
-
179
- Style/ClassVars:
180
- Enabled: true
181
-
182
- Style/WhenThen:
183
- Enabled: true
184
-
185
- Style/WordArray:
186
- Enabled: true
187
-
188
- Style/RedundantPercentQ:
189
- Enabled: true
190
-
191
- Layout/IndentationStyle:
192
- Enabled: true
193
-
194
- Layout/SpaceBeforeSemicolon:
195
- Enabled: true
196
-
197
- Layout/TrailingEmptyLines:
198
- Enabled: true
199
-
200
- Layout/SpaceInsideBlockBraces:
201
- Enabled: true
202
-
203
- Layout/SpaceInsideHashLiteralBraces:
204
- Enabled: true
205
-
206
- Layout/SpaceInsideParens:
207
- Enabled: true
208
-
209
- Layout/LeadingCommentSpace:
210
- Enabled: true
211
-
212
- Layout/SpaceBeforeFirstArg:
213
- Enabled: true
214
-
215
- Layout/SpaceAfterColon:
216
- Enabled: true
217
-
218
- Layout/SpaceAfterComma:
219
- Enabled: true
220
-
221
- Layout/SpaceAfterMethodName:
222
- Enabled: true
223
-
224
- Layout/SpaceAfterNot:
225
- Enabled: true
226
-
227
- Layout/SpaceAfterSemicolon:
228
- Enabled: true
229
-
230
- Layout/SpaceAroundEqualsInParameterDefault:
231
- Enabled: true
232
-
233
- Layout/SpaceAroundOperators:
234
- Enabled: true
235
-
236
- Layout/SpaceBeforeBlockBraces:
237
- Enabled: true
238
-
239
- Layout/SpaceBeforeComma:
240
- Enabled: true
241
-
242
- Style/CollectionMethods:
243
- Enabled: true
244
-
245
- Layout/CommentIndentation:
246
- Enabled: true
247
-
248
- Style/ColonMethodCall:
249
- Enabled: true
250
-
251
- Style/CommentAnnotation:
252
- Enabled: true
253
-
254
- # 'Complexity' is very relative
255
256
  Metrics/CyclomaticComplexity:
256
257
  Enabled: false
257
-
258
- Naming/ConstantName:
259
- Enabled: true
260
-
261
- Style/Documentation:
258
+ Metrics/MethodLength:
262
259
  Enabled: false
263
-
264
- Style/DefWithParentheses:
265
- Enabled: true
266
-
267
- Style/PreferredHashMethods:
268
- Enabled: true
269
-
270
- Layout/DotPosition:
271
- EnforcedStyle: trailing
272
-
273
- Style/DoubleNegation:
274
- Enabled: true
275
-
276
- Style/EachWithObject:
277
- Enabled: true
278
-
279
- Layout/EmptyLineBetweenDefs:
280
- Enabled: true
281
-
282
- Layout/FirstArrayElementIndentation:
283
- Enabled: true
284
-
285
- Layout/FirstHashElementIndentation:
286
- Enabled: true
287
-
288
- Layout/IndentationConsistency:
289
- Enabled: true
290
-
291
- Layout/IndentationWidth:
292
- Enabled: true
293
-
294
- Layout/EmptyLines:
295
- Enabled: true
296
-
297
- Layout/EmptyLinesAroundAccessModifier:
298
- Enabled: true
299
-
300
- Style/EmptyLiteral:
301
- Enabled: true
302
-
303
- # Configuration parameters: AllowURI, URISchemes.
304
- Layout/TrailingWhitespace:
305
- Enabled: true
306
-
307
- Layout/LineLength:
260
+ Metrics/ModuleLength:
308
261
  Enabled: false
309
-
310
- Naming/BinaryOperatorParameterName:
311
- Enabled: true
312
-
313
- Style/CommandLiteral:
314
- EnforcedStyle: percent_x
315
- Enabled: true
316
-
317
- Style/MethodCallWithoutArgsParentheses:
318
- Enabled: true
319
-
320
- Style/MethodDefParentheses:
321
- Enabled: true
322
-
323
- Style/LineEndConcatenation:
324
- Enabled: true
325
-
326
- Style/StringLiterals:
327
- Enabled: true
328
-
329
- Style/TrailingCommaInArguments:
330
- Enabled: true
331
-
332
- Style/TrailingCommaInArrayLiteral:
333
- Enabled: true
334
-
335
- Style/TrailingCommaInHashLiteral:
336
- Enabled: true
337
-
338
- Style/GlobalVars:
339
- Enabled: true
340
-
341
- Style/GuardClause:
342
- Enabled: true
343
-
344
- Style/IfUnlessModifier:
345
- Enabled: true
346
-
347
- Style/MultilineIfThen:
348
- Enabled: true
349
-
350
- Style/NegatedIf:
351
- Enabled: true
352
-
353
- Style/NegatedWhile:
354
- Enabled: true
355
-
356
- Style/Next:
357
- Enabled: true
358
-
359
- Style/SingleLineBlockParams:
360
- Enabled: true
361
-
362
- Style/SingleLineMethods:
363
- Enabled: true
364
-
365
- Style/SpecialGlobalVars:
366
- Enabled: true
367
-
368
- Style/TrivialAccessors:
369
- Enabled: true
370
-
371
- Style/UnlessElse:
372
- Enabled: true
373
-
374
- Style/VariableInterpolation:
375
- Enabled: true
376
-
377
- Naming/VariableName:
378
- Enabled: true
379
-
380
- Style/WhileUntilDo:
381
- Enabled: true
382
-
383
- Style/EvenOdd:
384
- Enabled: true
385
-
386
- Naming/FileName:
387
- Enabled: true
388
-
389
- Style/For:
390
- Enabled: true
391
-
392
- Style/Lambda:
393
- Enabled: true
394
-
395
- Naming/MethodName:
396
- Enabled: true
397
-
398
- Style/MultilineTernaryOperator:
399
- Enabled: true
400
-
401
- Style/NestedTernaryOperator:
402
- Enabled: true
403
-
404
- Style/NilComparison:
405
- Enabled: true
406
-
407
- Style/FormatString:
408
- Enabled: true
409
-
410
- Style/MultilineBlockChain:
411
- Enabled: true
412
-
413
- Style/Semicolon:
414
- Enabled: true
415
-
416
- Style/SignalException:
417
- Enabled: true
418
-
419
- Style/NonNilCheck:
420
- Enabled: true
421
-
422
- Style/Not:
423
- Enabled: true
424
-
425
- Style/NumericLiterals:
426
- Enabled: true
427
-
428
- Style/OneLineConditional:
429
- Enabled: true
430
-
431
- Style/ParenthesesAroundCondition:
432
- Enabled: true
433
-
434
- Style/PercentLiteralDelimiters:
435
- Enabled: true
436
-
437
- Style/PerlBackrefs:
438
- Enabled: true
439
-
440
- Naming/PredicateName:
441
- Enabled: true
442
-
443
- Style/RedundantException:
444
- Enabled: true
445
-
446
- Style/SelfAssignment:
447
- Enabled: true
448
-
449
- Style/Proc:
450
- Enabled: true
451
-
452
- Style/RaiseArgs:
453
- Enabled: true
454
-
455
- Style/RedundantBegin:
456
- Enabled: true
457
-
458
- Style/RescueModifier:
459
- Enabled: true
460
-
461
- # based on https://github.com/voxpupuli/modulesync_config/issues/168
462
- Style/RegexpLiteral:
463
- EnforcedStyle: percent_r
464
- Enabled: true
465
-
466
- Lint/UnderscorePrefixedVariableName:
467
- Enabled: true
468
-
469
262
  Metrics/ParameterLists:
470
263
  Enabled: false
471
-
472
- Lint/RequireParentheses:
473
- Enabled: true
474
-
475
- Style/ModuleFunction:
476
- Enabled: true
477
-
478
- Lint/Debugger:
479
- Enabled: true
480
-
481
- Style/IfWithSemicolon:
482
- Enabled: true
483
-
484
- Style/Encoding:
485
- Enabled: true
486
-
487
- Style/BlockDelimiters:
488
- Enabled: true
489
-
490
- Layout/MultilineBlockLayout:
491
- Enabled: true
492
-
493
- # 'Complexity' is very relative
494
- Metrics/AbcSize:
495
- Enabled: false
496
-
497
- # 'Complexity' is very relative
498
264
  Metrics/PerceivedComplexity:
499
265
  Enabled: false
500
-
501
- Layout/ClosingParenthesisIndentation:
502
- Enabled: true
503
-
504
- # RSpec
505
-
506
- RSpec/BeforeAfterAll:
507
- Exclude:
508
- - spec/acceptance/**/*
509
-
510
- # We don't use rspec in this way
266
+ Migration/DepartmentName:
267
+ Enabled: false
268
+ Naming/AccessorMethodName:
269
+ Enabled: false
270
+ Naming/BlockParameterName:
271
+ Enabled: false
272
+ Naming/HeredocDelimiterCase:
273
+ Enabled: false
274
+ Naming/HeredocDelimiterNaming:
275
+ Enabled: false
276
+ Naming/MemoizedInstanceVariableName:
277
+ Enabled: false
278
+ Naming/MethodParameterName:
279
+ Enabled: false
280
+ Naming/RescuedExceptionsVariableName:
281
+ Enabled: false
282
+ Naming/VariableNumber:
283
+ Enabled: false
284
+ Performance/BindCall:
285
+ Enabled: false
286
+ Performance/DeletePrefix:
287
+ Enabled: false
288
+ Performance/DeleteSuffix:
289
+ Enabled: false
290
+ Performance/InefficientHashSearch:
291
+ Enabled: false
292
+ Performance/UnfreezeString:
293
+ Enabled: false
294
+ Performance/UriDefaultParser:
295
+ Enabled: false
296
+ RSpec/Be:
297
+ Enabled: false
298
+ RSpec/Dialect:
299
+ Enabled: false
300
+ RSpec/ContainExactly:
301
+ Enabled: false
302
+ RSpec/ContextMethod:
303
+ Enabled: false
304
+ RSpec/ContextWording:
305
+ Enabled: false
511
306
  RSpec/DescribeClass:
512
307
  Enabled: false
513
-
514
- # Example length is not necessarily an indicator of code quality
308
+ RSpec/EmptyHook:
309
+ Enabled: false
310
+ RSpec/EmptyLineAfterExample:
311
+ Enabled: false
312
+ RSpec/EmptyLineAfterExampleGroup:
313
+ Enabled: false
314
+ RSpec/EmptyLineAfterHook:
315
+ Enabled: false
515
316
  RSpec/ExampleLength:
516
317
  Enabled: false
517
-
518
- RSpec/NamedSubject:
318
+ RSpec/ExampleWithoutDescription:
319
+ Enabled: false
320
+ RSpec/ExpectChange:
321
+ Enabled: false
322
+ RSpec/ExpectInHook:
323
+ Enabled: false
324
+ RSpec/HooksBeforeExamples:
325
+ Enabled: false
326
+ RSpec/ImplicitBlockExpectation:
519
327
  Enabled: false
520
-
521
- # disabled for now since they cause a lot of issues
522
- # these issues aren't easy to fix
523
- RSpec/RepeatedDescription:
328
+ RSpec/ImplicitSubject:
329
+ Enabled: false
330
+ RSpec/LeakyConstantDeclaration:
331
+ Enabled: false
332
+ RSpec/LetBeforeExamples:
333
+ Enabled: false
334
+ RSpec/MatchArray:
335
+ Enabled: false
336
+ RSpec/MissingExampleGroupArgument:
337
+ Enabled: false
338
+ RSpec/MultipleExpectations:
339
+ Enabled: false
340
+ RSpec/MultipleMemoizedHelpers:
341
+ Enabled: false
342
+ RSpec/MultipleSubjects:
524
343
  Enabled: false
525
-
526
344
  RSpec/NestedGroups:
527
345
  Enabled: false
528
-
529
- # this is broken on ruby1.9
530
- Layout/HeredocIndentation:
346
+ RSpec/PredicateMatcher:
531
347
  Enabled: false
532
-
533
- # disable Yaml safe_load. This is needed to support ruby2.0.0 development envs
534
- Security/YAMLLoad:
348
+ RSpec/ReceiveCounts:
535
349
  Enabled: false
536
-
537
- # This affects hiera interpolation, as well as some configs that we push.
538
- Style/FormatStringToken:
350
+ RSpec/ReceiveNever:
351
+ Enabled: false
352
+ RSpec/RepeatedExampleGroupBody:
353
+ Enabled: false
354
+ RSpec/RepeatedExampleGroupDescription:
355
+ Enabled: false
356
+ RSpec/RepeatedIncludeExample:
357
+ Enabled: false
358
+ RSpec/ReturnFromStub:
359
+ Enabled: false
360
+ RSpec/SharedExamples:
361
+ Enabled: false
362
+ RSpec/StubbedMock:
363
+ Enabled: false
364
+ RSpec/UnspecifiedException:
365
+ Enabled: false
366
+ RSpec/VariableDefinition:
367
+ Enabled: false
368
+ RSpec/VoidExpect:
369
+ Enabled: false
370
+ RSpec/Yield:
371
+ Enabled: false
372
+ Security/Open:
373
+ Enabled: false
374
+ Style/AccessModifierDeclarations:
375
+ Enabled: false
376
+ Style/AccessorGrouping:
377
+ Enabled: false
378
+ Style/BisectedAttrAccessor:
379
+ Enabled: false
380
+ Style/CaseLikeIf:
381
+ Enabled: false
382
+ Style/ClassEqualityComparison:
383
+ Enabled: false
384
+ Style/ColonMethodDefinition:
385
+ Enabled: false
386
+ Style/CombinableLoops:
387
+ Enabled: false
388
+ Style/CommentedKeyword:
389
+ Enabled: false
390
+ Style/Dir:
391
+ Enabled: false
392
+ Style/DoubleCopDisableDirective:
393
+ Enabled: false
394
+ Style/EmptyBlockParameter:
395
+ Enabled: false
396
+ Style/EmptyLambdaParameter:
397
+ Enabled: false
398
+ Style/Encoding:
399
+ Enabled: false
400
+ Style/EvalWithLocation:
401
+ Enabled: false
402
+ Style/ExpandPathArguments:
403
+ Enabled: false
404
+ Style/ExplicitBlockArgument:
405
+ Enabled: false
406
+ Style/ExponentialNotation:
407
+ Enabled: false
408
+ Style/FloatDivision:
409
+ Enabled: false
410
+ Style/FrozenStringLiteralComment:
411
+ Enabled: false
412
+ Style/GlobalStdStream:
413
+ Enabled: false
414
+ Style/HashAsLastArrayItem:
415
+ Enabled: false
416
+ Style/HashLikeCase:
417
+ Enabled: false
418
+ Style/HashTransformKeys:
419
+ Enabled: false
420
+ Style/HashTransformValues:
421
+ Enabled: false
422
+ Style/IfUnlessModifier:
423
+ Enabled: false
424
+ Style/KeywordParametersOrder:
425
+ Enabled: false
426
+ Style/MinMax:
427
+ Enabled: false
428
+ Style/MixinUsage:
429
+ Enabled: false
430
+ Style/MultilineWhenThen:
431
+ Enabled: false
432
+ Style/NegatedUnless:
433
+ Enabled: false
434
+ Style/NumericPredicate:
435
+ Enabled: false
436
+ Style/OptionalBooleanParameter:
437
+ Enabled: false
438
+ Style/OrAssignment:
439
+ Enabled: false
440
+ Style/RandomWithOffset:
441
+ Enabled: false
442
+ Style/RedundantAssignment:
443
+ Enabled: false
444
+ Style/RedundantCondition:
445
+ Enabled: false
446
+ Style/RedundantConditional:
447
+ Enabled: false
448
+ Style/RedundantFetchBlock:
449
+ Enabled: false
450
+ Style/RedundantFileExtensionInRequire:
451
+ Enabled: false
452
+ Style/RedundantRegexpCharacterClass:
453
+ Enabled: false
454
+ Style/RedundantRegexpEscape:
455
+ Enabled: false
456
+ Style/RedundantSelfAssignment:
457
+ Enabled: false
458
+ Style/RedundantSort:
459
+ Enabled: false
460
+ Style/RescueStandardError:
461
+ Enabled: false
462
+ Style/SingleArgumentDig:
463
+ Enabled: false
464
+ Style/SlicingWithRange:
465
+ Enabled: false
466
+ Style/SoleNestedConditional:
467
+ Enabled: false
468
+ Style/StderrPuts:
469
+ Enabled: false
470
+ Style/StringConcatenation:
471
+ Enabled: false
472
+ Style/Strip:
539
473
  Enabled: false
540
-
541
- # This is useful, but sometimes a little too picky about where unit tests files
542
- # are located.
543
- RSpec/FilePath:
474
+ Style/SymbolProc:
475
+ Enabled: false
476
+ Style/TrailingBodyOnClass:
477
+ Enabled: false
478
+ Style/TrailingBodyOnMethodDefinition:
479
+ Enabled: false
480
+ Style/TrailingBodyOnModule:
481
+ Enabled: false
482
+ Style/TrailingCommaInHashLiteral:
483
+ Enabled: false
484
+ Style/TrailingMethodEndStatement:
485
+ Enabled: false
486
+ Style/UnpackFirst:
487
+ Enabled: false
488
+ Gemspec/DeprecatedAttributeAssignment:
489
+ Enabled: false
490
+ Gemspec/DevelopmentDependencies:
491
+ Enabled: false
492
+ Gemspec/RequireMFA:
493
+ Enabled: false
494
+ Layout/LineContinuationLeadingSpace:
495
+ Enabled: false
496
+ Layout/LineContinuationSpacing:
497
+ Enabled: false
498
+ Layout/LineEndStringConcatenationIndentation:
499
+ Enabled: false
500
+ Layout/SpaceBeforeBrackets:
501
+ Enabled: false
502
+ Lint/AmbiguousAssignment:
503
+ Enabled: false
504
+ Lint/AmbiguousOperatorPrecedence:
505
+ Enabled: false
506
+ Lint/AmbiguousRange:
507
+ Enabled: false
508
+ Lint/ConstantOverwrittenInRescue:
509
+ Enabled: false
510
+ Lint/DeprecatedConstants:
511
+ Enabled: false
512
+ Lint/DuplicateBranch:
513
+ Enabled: false
514
+ Lint/DuplicateMagicComment:
515
+ Enabled: false
516
+ Lint/DuplicateMatchPattern:
517
+ Enabled: false
518
+ Lint/DuplicateRegexpCharacterClassElement:
519
+ Enabled: false
520
+ Lint/EmptyBlock:
521
+ Enabled: false
522
+ Lint/EmptyClass:
523
+ Enabled: false
524
+ Lint/EmptyInPattern:
525
+ Enabled: false
526
+ Lint/IncompatibleIoSelectWithFiberScheduler:
527
+ Enabled: false
528
+ Lint/LambdaWithoutLiteralBlock:
529
+ Enabled: false
530
+ Lint/NoReturnInBeginEndBlocks:
531
+ Enabled: false
532
+ Lint/NonAtomicFileOperation:
533
+ Enabled: false
534
+ Lint/NumberedParameterAssignment:
535
+ Enabled: false
536
+ Lint/OrAssignmentToConstant:
537
+ Enabled: false
538
+ Lint/RedundantDirGlobSort:
539
+ Enabled: false
540
+ Lint/RefinementImportMethods:
541
+ Enabled: false
542
+ Lint/RequireRangeParentheses:
543
+ Enabled: false
544
+ Lint/RequireRelativeSelfPath:
545
+ Enabled: false
546
+ Lint/SymbolConversion:
547
+ Enabled: false
548
+ Lint/ToEnumArguments:
549
+ Enabled: false
550
+ Lint/TripleQuotes:
551
+ Enabled: false
552
+ Lint/UnexpectedBlockArity:
553
+ Enabled: false
554
+ Lint/UnmodifiedReduceAccumulator:
555
+ Enabled: false
556
+ Lint/UselessRescue:
557
+ Enabled: false
558
+ Lint/UselessRuby2Keywords:
559
+ Enabled: false
560
+ Metrics/CollectionLiteralLength:
561
+ Enabled: false
562
+ Naming/BlockForwarding:
563
+ Enabled: false
564
+ Performance/CollectionLiteralInLoop:
565
+ Enabled: false
566
+ Performance/ConcurrentMonotonicTime:
567
+ Enabled: false
568
+ Performance/MapCompact:
569
+ Enabled: false
570
+ Performance/RedundantEqualityComparisonBlock:
571
+ Enabled: false
572
+ Performance/RedundantSplitRegexpArgument:
573
+ Enabled: false
574
+ Performance/StringIdentifierArgument:
575
+ Enabled: false
576
+ RSpec/BeEq:
577
+ Enabled: false
578
+ RSpec/BeNil:
579
+ Enabled: false
580
+ RSpec/ChangeByZero:
581
+ Enabled: false
582
+ RSpec/ClassCheck:
583
+ Enabled: false
584
+ RSpec/DuplicatedMetadata:
585
+ Enabled: false
586
+ RSpec/ExcessiveDocstringSpacing:
587
+ Enabled: false
588
+ RSpec/IdenticalEqualityAssertion:
589
+ Enabled: false
590
+ RSpec/NoExpectationExample:
591
+ Enabled: false
592
+ RSpec/PendingWithoutReason:
593
+ Enabled: false
594
+ RSpec/RedundantAround:
595
+ Enabled: false
596
+ RSpec/SkipBlockInsideExample:
597
+ Enabled: false
598
+ RSpec/SortMetadata:
599
+ Enabled: false
600
+ RSpec/SubjectDeclaration:
601
+ Enabled: false
602
+ RSpec/VerifiedDoubleReference:
603
+ Enabled: false
604
+ Security/CompoundHash:
605
+ Enabled: false
606
+ Security/IoMethods:
607
+ Enabled: false
608
+ Style/ArgumentsForwarding:
609
+ Enabled: false
610
+ Style/ArrayIntersect:
611
+ Enabled: false
612
+ Style/CollectionCompact:
613
+ Enabled: false
614
+ Style/ComparableClamp:
615
+ Enabled: false
616
+ Style/ConcatArrayLiterals:
617
+ Enabled: false
618
+ Style/DataInheritance:
619
+ Enabled: false
620
+ Style/DirEmpty:
621
+ Enabled: false
622
+ Style/DocumentDynamicEvalDefinition:
623
+ Enabled: false
624
+ Style/EmptyHeredoc:
625
+ Enabled: false
626
+ Style/EndlessMethod:
627
+ Enabled: false
628
+ Style/EnvHome:
629
+ Enabled: false
630
+ Style/FetchEnvVar:
631
+ Enabled: false
632
+ Style/FileEmpty:
633
+ Enabled: false
634
+ Style/FileRead:
635
+ Enabled: false
636
+ Style/FileWrite:
637
+ Enabled: false
638
+ Style/HashConversion:
639
+ Enabled: false
640
+ Style/HashExcept:
641
+ Enabled: false
642
+ Style/IfWithBooleanLiteralBranches:
643
+ Enabled: false
644
+ Style/InPatternThen:
645
+ Enabled: false
646
+ Style/MagicCommentFormat:
647
+ Enabled: false
648
+ Style/MapCompactWithConditionalBlock:
649
+ Enabled: false
650
+ Style/MapToHash:
651
+ Enabled: false
652
+ Style/MapToSet:
653
+ Enabled: false
654
+ Style/MinMaxComparison:
655
+ Enabled: false
656
+ Style/MultilineInPatternThen:
657
+ Enabled: false
658
+ Style/NegatedIfElseCondition:
659
+ Enabled: false
660
+ Style/NestedFileDirname:
661
+ Enabled: false
662
+ Style/NilLambda:
663
+ Enabled: false
664
+ Style/NumberedParameters:
665
+ Enabled: false
666
+ Style/NumberedParametersLimit:
667
+ Enabled: false
668
+ Style/ObjectThen:
669
+ Enabled: false
670
+ Style/OpenStructUse:
671
+ Enabled: false
672
+ Style/OperatorMethodCall:
673
+ Enabled: false
674
+ Style/QuotedSymbols:
675
+ Enabled: false
676
+ Style/RedundantArgument:
677
+ Enabled: false
678
+ Style/RedundantConstantBase:
679
+ Enabled: false
680
+ Style/RedundantDoubleSplatHashBraces:
681
+ Enabled: false
682
+ Style/RedundantEach:
683
+ Enabled: false
684
+ Style/RedundantHeredocDelimiterQuotes:
685
+ Enabled: false
686
+ Style/RedundantInitialize:
687
+ Enabled: false
688
+ Style/RedundantLineContinuation:
689
+ Enabled: false
690
+ Style/RedundantSelfAssignmentBranch:
691
+ Enabled: false
692
+ Style/RedundantStringEscape:
693
+ Enabled: false
694
+ Style/SelectByRegexp:
695
+ Enabled: false
696
+ Style/StringChars:
697
+ Enabled: false
698
+ Style/SwapValues:
699
+ Enabled: false
700
+ Naming/PredicateName:
544
701
  Enabled: false