simp-beaker-helpers 1.34.2 → 1.35.0

data/spec/acceptance/suites/inspec/00_default_spec.rb

@@ -4,7 +4,6 @@ require 'json'
 test_name 'Inspec STIG Profile'
 
 describe 'Inspec STIG Profile' do
-
   profiles_to_validate = ['disa_stig']
 
   hosts.each do |host|
@@ -14,38 +13,39 @@ describe 'Inspec STIG Profile' do
           profile_path = File.join(
               fixtures_path,
               'inspec_profiles',
-              "#{fact_on(host, 'os.name')}-#{fact_on(host, 'os.release.major')}-#{profile}"
+              "#{fact_on(host, 'os.name')}-#{fact_on(host, 'os.release.major')}-#{profile}",
             )
 
-          unless File.exist?(profile_path)
-            it 'should run inspec' do
-              skip("No matching profile available at #{profile_path}")
-            end
-          else
-            before(:all) do
+          if File.exist?(profile_path)
+            let(:inspec) do
               Simp::BeakerHelpers::Inspec.enable_repo_on(hosts)
-              @inspec = Simp::BeakerHelpers::Inspec.new(host, profile)
-
-              # If we don't do this, the variable gets reset
-              @inspec_report = { :data => nil }
+              Simp::BeakerHelpers::Inspec.new(host, profile)
             end
 
-            it 'should run inspec' do
-              @inspec.run
-            end
+            let(:inspec_report_data) { inspec.process_inspec_results }
 
-            it 'should have an inspec report' do
-              @inspec_report[:data] = @inspec.process_inspec_results
+            # rubocop:disable RSpec/RepeatedDescription
+            it 'runs inspec' do
+              inspec.run
+            end
+            # rubocop:enable RSpec/RepeatedDescription
 
-              expect(@inspec_report[:data]).to_not be_nil
+            it 'has an inspec report' do
+              expect(inspec_report_data).not_to be_nil
 
-              @inspec.write_report(@inspec_report[:data])
+              inspec.write_report(inspec_report_data)
             end
 
-            it 'should have a report' do
-              expect(@inspec_report[:data][:report]).to_not be_nil
-              puts @inspec_report[:data][:report]
+            it 'has a report' do
+              expect(inspec_report_data[:report]).not_to be_nil
+              puts inspec_report_data[:report]
+            end
+          else
+            # rubocop:disable RSpec/RepeatedDescription
+            it 'runs inspec' do
+              skip("No matching profile available at #{profile_path}")
             end
+            # rubocop:enable RSpec/RepeatedDescription
           end
         end
       end

data/spec/acceptance/suites/offline/00_default_spec.rb

@@ -66,7 +66,7 @@ describe 'Offline mode' do
           'seabios',
           'sqlite-devel',
           'util-linux',
-          'which'
+          'which',
         ]
 
         on(host, %(yum -y install #{required_packages.join(' ')}))
@@ -84,7 +84,15 @@ describe 'Offline mode' do
       end
 
       it 'installs the VirtualBox extension pack' do
-        on(host, 'VERSION=$(VBoxManage --version | tail -1 | cut -f 1 -d "r") && curl -Lo ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack http://download.virtualbox.org/virtualbox/${VERSION}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack && yes | VBoxManage extpack install ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack && rm -rf ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack')
+        on(
+          host,
+          [
+            'VERSION=$(VBoxManage --version | tail -1 | cut -f 1 -d "r")',
+            '&& curl -Lo ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack http://download.virtualbox.org/virtualbox/${VERSION}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack',
+            '&& yes | VBoxManage extpack install ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack',
+            '&& rm -rf ${TMPDIR}/Oracle_VM_VirtualBox_Extension_Pack-${VERSION}.vbox-extpack',
+          ].join(' '),
+        )
       end
 
       it 'adds the build user to the vboxusers group' do
@@ -97,9 +105,28 @@ describe 'Offline mode' do
 
       it 'installs RPM for the build user' do
         # Install RVM
-        on(host, %(#{build_user_cmd} "for i in {1..5}; do { gpg2 --keyserver hkp://pgp.mit.edu --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 || gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 || gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3; } && { gpg2 --keyserver hkp://pgp.mit.edu --recv-keys 7D2BAF1CF37B13E2069D6956105BD0E739499BDB || gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 7D2BAF1CF37B13E2069D6956105BD0E739499BDB; } && break || sleep 1; done"))
+        on(
+          host,
+          [
+            %(#{build_user_cmd} "for i in {1..5}; do {),
+            'gpg2 --keyserver hkp://pgp.mit.edu --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3',
+            '|| gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3',
+            '|| gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3; }',
+            '&& { gpg2 --keyserver hkp://pgp.mit.edu --recv-keys 7D2BAF1CF37B13E2069D6956105BD0E739499BDB',
+            '|| gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 7D2BAF1CF37B13E2069D6956105BD0E739499BDB; }',
+            '&& break || sleep 1; done',
+          ].join(' '),
+        )
         on(host, %(#{build_user_cmd} "gpg2 --refresh-keys"))
-        on(host, %(#{build_user_cmd} "curl -sSL https://raw.githubusercontent.com/rvm/rvm/stable/binscripts/rvm-installer -o rvm-installer && curl -sSL https://raw.githubusercontent.com/rvm/rvm/stable/binscripts/rvm-installer.asc -o rvm-installer.asc && gpg2 --verify rvm-installer.asc rvm-installer && bash rvm-installer"))
+        on(
+          host,
+          [
+            %(#{build_user_cmd} "curl -sSL https://raw.githubusercontent.com/rvm/rvm/stable/binscripts/rvm-installer -o rvm-installer),
+            'curl -sSL https://raw.githubusercontent.com/rvm/rvm/stable/binscripts/rvm-installer.asc -o rvm-installer.asc',
+            'gpg2 --verify rvm-installer.asc rvm-installer',
+            'bash rvm-installer',
+          ].join(' && '),
+        )
         on(host, %(#{build_user_cmd} "rvm install 2.4.4 --disable-binary"))
         on(host, %(#{build_user_cmd} "rvm use --default 2.4.4"))
         on(host, %(#{build_user_cmd} "rvm all do gem install bundler -v '~> 1.16' --no-document"))
@@ -118,14 +145,14 @@ describe 'Offline mode' do
         build_user_homedir = on(host, "readlink -f ~#{build_user}").output.strip
         vagrant_testdir = "#{build_user_homedir}/vagrant_test"
 
-        vagrant_test_file = <<-EOM
-Vagrant.configure("2") do |c|
-  c.vm.define 'test' do |v|
-    v.vm.hostname = 'centos7.test.net'
-    v.vm.box = 'centos/7'
-    v.vm.box_check_update = 'false'
-  end
-end
+        vagrant_test_file = <<~EOM
+          Vagrant.configure("2") do |c|
+            c.vm.define 'test' do |v|
+              v.vm.hostname = 'centos7.test.net'
+              v.vm.box = 'centos/7'
+              v.vm.box_check_update = 'false'
+            end
+          end
         EOM
 
         host.mkdir_p(vagrant_testdir)
@@ -148,18 +175,22 @@ end
         on(host, %(#{build_user_cmd} "cd pupmod-simp-at; bundle update"))
       end
 
+      # rubocop:disable RSpec/RepeatedExample
       it 'runs a network-connected test' do
         on(host, %(#{build_user_cmd} "cd pupmod-simp-at; rake beaker:suites"))
       end
+      # rubocop:enable RSpec/RepeatedExample
 
       it 'disables all internet network traffic via iptables' do
         on(host, %(iptables -I OUTPUT -d `ip route | awk '/default/ {print $3}'`/16 -j ACCEPT))
         on(host, 'iptables -A OUTPUT -j DROP')
       end
 
+      # rubocop:disable RSpec/RepeatedExample
       xit 'runs a network-disconnected test' do
         on(host, %(#{build_user_cmd} "cd pupmod-simp-at; rake beaker:suites"))
       end
+      # rubocop:enable RSpec/RepeatedExample
     end
   end
 end

data/spec/acceptance/suites/offline/nodesets/default.yml

@@ -13,9 +13,7 @@ HOSTS:
 CONFIG:
   log_level: verbose
   type: aio
-<% if ENV['BEAKER_PUPPET_COLLECTION'] -%>
-  puppet_collection: <%= ENV['BEAKER_PUPPET_COLLECTION'] %>
-<% end -%>
+  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet8') %>"
   libvirt:
     # Ensure that we use the best option available
     'cpu_mode': 'host-passthrough'

data/spec/acceptance/suites/puppet_collections/00_default_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper_acceptance'
 
 unless ENV['PUPPET_VERSION'] || ENV['BEAKER_PUPPET_COLLECTION']
-  fail('You must set either PUPPET_VERSION or BEAKER_PUPPET_COLLECTION as an environment variable')
+  raise('You must set either PUPPET_VERSION or BEAKER_PUPPET_COLLECTION as an environment variable')
 end
 
 if ENV['BEAKER_PUPPET_COLLECTION']
-  target_version = ENV['BEAKER_PUPPET_COLLECTION'][/(\d+)$/,1]
+  target_version = ENV['BEAKER_PUPPET_COLLECTION'][%r{(\d+)$}, 1]
 elsif ENV['PUPPET_VERSION']
   target_version = ENV['PUPPET_VERSION'].split('.').first
 end
@@ -15,7 +15,7 @@ hosts.each do |host|
     context "on #{host}" do
       client_puppet_version = on(host, 'puppet --version').output.lines.last.strip
 
-      it "should be running puppet version #{target_version}" do
+      it "is running puppet version #{target_version}" do
         expect(Gem::Version.new(client_puppet_version)).to be >= Gem::Version.new(target_version)
       end
     end

data/spec/acceptance/suites/snapshot/00_snapshot_test_spec.rb

@@ -3,61 +3,79 @@ require 'spec_helper_acceptance'
 hosts.each do |host|
   describe 'take a snapshot' do
     context "on #{host}" do
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'creates a file that should be saved' do
         on(host, 'echo "keep" > /root/keep')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
+      # rubocop:disable RSpec/RepeatedExample
       it 'takes a snapshot' do
         Simp::BeakerHelpers::Snapshot.save(host, 'test')
       end
+      # rubocop:enable RSpec/RepeatedExample
 
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'creates a file that should be removed' do
         on(host, 'echo "trash" > /root/trash')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'restores a snapshot' do
         Simp::BeakerHelpers::Snapshot.restore(host, 'test')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
-      it 'should have the keep file' do
+      it 'has the keep file' do
         expect(host.file_exist?('/root/keep')).to be true
       end
 
-      it 'should not have the trash file' do
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
+      it 'does not have the trash file' do
         expect(host.file_exist?('/root/trash')).to be false
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
       it 'creates a second file that should be saved' do
         on(host, 'echo "keep2" > /root/keep2')
       end
 
+      # rubocop:disable RSpec/RepeatedExample
       it 'takes a snapshot with the same name' do
         Simp::BeakerHelpers::Snapshot.save(host, 'test')
       end
+      # rubocop:enable RSpec/RepeatedExample
 
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'creates a file that should be removed' do
         on(host, 'echo "trash" > /root/trash')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'restores a snapshot' do
         Simp::BeakerHelpers::Snapshot.restore(host, 'test')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
-      it 'should have all keep files' do
+      it 'has all keep files' do
         expect(host.file_exist?('/root/keep')).to be true
         expect(host.file_exist?('/root/keep2')).to be true
       end
 
-      it 'should not have the trash file' do
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
+      it 'does not have the trash file' do
         expect(host.file_exist?('/root/trash')).to be false
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
       it 'takes a snapshot with a different name' do
         Simp::BeakerHelpers::Snapshot.save(host, 'test2')
       end
 
       it 'can list the snapshots' do
-        expect(Simp::BeakerHelpers::Snapshot.list(host)).to eq ["#{host}", 'test', 'test2']
+        expect(Simp::BeakerHelpers::Snapshot.list(host)).to eq [host.to_s, 'test', 'test2']
       end
 
       it 'can query for a specific snapshot' do
@@ -67,12 +85,14 @@ hosts.each do |host|
       end
 
       it 'restores to the internal base' do
-         Simp::BeakerHelpers::Snapshot.restore_to_base(host)
-       end
+        Simp::BeakerHelpers::Snapshot.restore_to_base(host)
+      end
 
+      # rubocop:disable RSpec/RepeatedExample, RSpec/RepeatedDescription
       it 'creates a file that should be saved' do
         on(host, 'echo "keep" > /root/keep')
       end
+      # rubocop:enable RSpec/RepeatedExample, RSpec/RepeatedDescription
 
       it 'creates a handoff snapshot for further tests' do
         Simp::BeakerHelpers::Snapshot.save(host, 'handoff')

data/spec/acceptance/suites/snapshot/10_general_usage_spec.rb

@@ -24,18 +24,18 @@ hosts.each do |host|
 
         it 'restores the snapshot' do
           if init_snapshot == 'missing'
-            expect { Simp::BeakerHelpers::Snapshot.restore(host, init_snapshot) }.to raise_error(/not found/)
+            expect { Simp::BeakerHelpers::Snapshot.restore(host, init_snapshot) }.to raise_error(%r{not found})
             Simp::BeakerHelpers::Snapshot.restore_to_base(host)
           else
             Simp::BeakerHelpers::Snapshot.restore(host, init_snapshot)
           end
         end
 
-        it 'should have the keep file' do
+        it 'has the keep file' do
           expect(host.file_exist?('/root/keep')).to be true
         end
 
-        it 'should not have the tracking file' do
+        it 'does not have the tracking file' do
           expect(host.file_exist?('/root/tracking')).to be false
         end
       end

data/spec/acceptance/suites/ssg/00_default_spec.rb

@@ -3,44 +3,46 @@ require 'spec_helper_acceptance'
 test_name 'SSG Functionality Validation'
 
 describe 'run the SSG against an SCAP profile' do
-
   hosts.each do |host|
     context "on #{host}" do
+      ssg = nil
+      ssg_report = nil
+
       before(:all) do
-        @ssg = Simp::BeakerHelpers::SSG.new(host)
+        ssg = Simp::BeakerHelpers::SSG.new(host)
 
         # If we don't do this, the variable gets reset
-        @ssg_report = { :data => nil }
+        ssg_report = { data: nil }
       end
 
-      it 'should run the SSG' do
-        profiles = @ssg.get_profiles
+      it 'runs the SSG' do
+        profiles = ssg.get_profiles
 
-        profile = profiles.find{|x| x =~ /_stig/} ||
-          profiles.find{|x| x =~ /_cui/} ||
-          profiles.find{|x| x =~ /_ospp/} ||
-          profiles.find{|x| x =~ /_standard/} ||
-          profiles.last
+        profile = profiles.find { |x| x.include?('_stig') } ||
+                  profiles.find { |x| x.include?('_cui') } ||
+                  profiles.find { |x| x.include?('_ospp') } ||
+                  profiles.find { |x| x.include?('_standard') } ||
+                  profiles.last
 
         expect(profile).not_to be_nil
-        @ssg.evaluate(profile)
+        ssg.evaluate(profile)
       end
 
-      it 'should have an SSG report' do
+      it 'has an SSG report' do
         # Validate that the filter works
         filter = '_rule_audit'
         host_exclusions = ['ssh_']
 
-        @ssg_report[:data] = @ssg.process_ssg_results(filter, host_exclusions)
+        ssg_report[:data] = ssg.process_ssg_results(filter, host_exclusions)
 
-        expect(@ssg_report[:data]).to_not be_nil
+        expect(ssg_report[:data]).not_to be_nil
 
-        @ssg.write_report(@ssg_report[:data])
+        ssg.write_report(ssg_report[:data])
       end
 
-      it 'should have a report' do
-        expect(@ssg_report[:data][:report]).to_not be_nil
-        puts @ssg_report[:data][:report]
+      it 'has a report' do
+        expect(ssg_report[:data][:report]).not_to be_nil
+        puts ssg_report[:data][:report]
       end
     end
   end

data/spec/acceptance/suites/windows/00_default_spec.rb

@@ -27,63 +27,61 @@ RSpec.configure do |c|
 
   # Configure all nodes in nodeset
   c.before :suite do
-    begin
-      copy_fixture_modules_to( hosts )
-
-      nonwin = hosts.dup
-      nonwin.delete_if {|h| h[:platform] =~ /windows/ }
+    copy_fixture_modules_to(hosts)
 
-      begin
-        server = only_host_with_role(nonwin, 'server')
-      rescue ArgumentError => e
-        server = only_host_with_role(nonwin, 'default')
-      end
-      # Generate and install PKI certificates on each SUT
-      Dir.mktmpdir do |cert_dir|
-        run_fake_pki_ca_on(server, nonwin, cert_dir )
-        nonwin.each{ |sut| copy_pki_to( sut, cert_dir, '/etc/pki/simp-testing' )}
-      end
+    nonwin = hosts.dup
+    nonwin.delete_if { |h| h[:platform].include?('windows') }
 
-      # add PKI keys
-      copy_keydist_to(server)
-    rescue StandardError, ScriptError => e
-      if ENV['PRY']
-        require 'pry'; binding.pry
-      else
-        raise e
-      end
+    begin
+      server = only_host_with_role(nonwin, 'server')
+    rescue ArgumentError => e
+      server = only_host_with_role(nonwin, 'default')
     end
+    # Generate and install PKI certificates on each SUT
+    Dir.mktmpdir do |cert_dir|
+      run_fake_pki_ca_on(server, nonwin, cert_dir)
+      nonwin.each { |sut| copy_pki_to(sut, cert_dir, '/etc/pki/simp-testing') }
+    end
+
+    # add PKI keys
+    copy_keydist_to(server)
+  rescue StandardError, ScriptError => e
+    raise e unless ENV['PRY']
+    require 'pry'
+    binding.pry # rubocop:disable Lint/Debugger
   end
 end
 
 describe 'windows' do
+  let(:hieradata) do
+    {
+      'test::foo' => 'test'
+    }
+  end
 
-  let(:hieradata){{
-    'test::foo' => 'test'
-  }}
-
-  let(:manifest){ 'notify { "test": message => lookup("test::foo")}' }
+  let(:manifest) { 'notify { "test": message => lookup("test::foo")}' }
 
   hosts.each do |host|
     context "on #{host}" do
-
-      let(:hiera_config){{
-        'version' => 5,
-        'hierarchy' => [
-          {
-            'name' => 'Common',
-            'path' => 'common.yaml'
-          },
-          {
-            'name' => 'SIMP Compliance Engine',
-            'lookup_key' => 'compliance_markup::enforcement'
-          }
-        ],
-        'defaults' => {
-          'data_hash' => 'yaml_data',
-          'datadir' => hiera_datadir(host)
+      let(:hiera_config) do
+        {
+          'version' => 5,
+       'hierarchy' => [
+         {
+           'name' => 'Common',
+           'path' => 'common.yaml'
+         },
+         {
+           'name' => 'SIMP Compliance Engine',
+           'lookup_key' => 'compliance_markup::enforcement'
+         },
+       ],
+       'defaults' => {
+         'data_hash' => 'yaml_data',
+         'datadir' => hiera_datadir(host)
+       }
         }
-      }}
+      end
 
       if Simp::BeakerHelpers::Snapshot.exist?(host, 'puppet_installed')
         Simp::BeakerHelpers::Snapshot.restore(host, 'puppet_installed')
@@ -93,19 +91,19 @@ describe 'windows' do
 
       describe 'windows hosts coexising with linux hosts' do
         context "on #{host}" do
-          it 'should have puppet installed' do
+          it 'has puppet installed' do
             on(host, 'puppet --version')
           end
 
-          it 'should be able to set the hiera config' do
+          it 'is able to set the hiera config' do
             set_hiera_config_on(host, hiera_config)
           end
 
-          it 'should be able to set the hieradata' do
+          it 'is able to set the hieradata' do
             set_hieradata_on(host, hieradata)
           end
 
-          it 'should be able to run puppet' do
+          it 'is able to run puppet' do
             output = apply_manifest_on(host, manifest).stdout
 
             expect(output).to include "defined 'message' as 'test'"

data/spec/acceptance/suites/windows/nodesets/default.yml

@@ -2,7 +2,7 @@
 HOSTS:
   win:
     roles:
-    - windows
+      - windows
     platform: windows-server-amd64
     box: gusztavvargadr/windows-server
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -14,7 +14,7 @@ HOSTS:
     gce_machine_type: n1-standard-2
   el7:
     roles:
-    - default
+      - default
     platform: el-7-x86_64
     box: centos/7
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -23,4 +23,4 @@ HOSTS:
 CONFIG:
   log_level: verbose
   type: aio
-  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet7') %>"
+  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet8') %>"

data/spec/acceptance/suites/windows/nodesets/win2012.yml

@@ -2,7 +2,7 @@
 HOSTS:
   win:
     roles:
-    - windows
+      - windows
     platform: windows-server-amd64
     box: devopsgroup-io/windows_server-2012r2-standard-amd64-nocm
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -16,7 +16,7 @@ HOSTS:
     gce_machine_type: n1-standard-2
   el7:
     roles:
-    - default
+      - default
     platform: el-7-x86_64
     box: centos/7
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -25,4 +25,4 @@ HOSTS:
 CONFIG:
   log_level: verbose
   type: aio
-  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet7') %>"
+  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet8') %>"

data/spec/acceptance/suites/windows/nodesets/win2016.yml

@@ -2,7 +2,7 @@
 HOSTS:
   win:
     roles:
-    - windows
+      - windows
     platform: windows-server-amd64
     box: peru/windows-server-2016-standard-x64-eval
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -15,7 +15,7 @@ HOSTS:
     gce_machine_type: n1-standard-2
   el7:
     roles:
-    - default
+      - default
     platform: el-7-x86_64
     box: centos/7
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -24,4 +24,4 @@ HOSTS:
 CONFIG:
   log_level: verbose
   type: aio
-  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet7') %>"
+  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet8') %>"

data/spec/acceptance/suites/windows/nodesets/win2019.yml

@@ -2,7 +2,7 @@
 HOSTS:
   win:
     roles:
-    - windows
+      - windows
     platform: windows-server-amd64
     box: gusztavvargadr/windows-server
     box_version: "~> 1809"
@@ -15,7 +15,7 @@ HOSTS:
     gce_machine_type: n1-standard-2
   el7:
     roles:
-    - default
+      - default
     platform: el-7-x86_64
     box: centos/7
     hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
@@ -24,4 +24,4 @@ HOSTS:
 CONFIG:
   log_level: verbose
   type: aio
-  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet7') %>"
+  puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet8') %>"