similar_models 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2bf02e51c067023b861f64a73394be810f74ed007a4299a4cc4de18fb7e8ff71
-  data.tar.gz: ae0fdceeb1388fa7a247c89d892d812c2554ffb0c7f12c1389da6b313b3b3350
+  metadata.gz: 1512f7d1b0d895cc90aa6bf3357e8379aac8f57848de01f2a0d05816107e8936
+  data.tar.gz: 5001875c74fce6ba9bfbce5af20424742c87564d07a7b16393f953ada0b59cfa
 SHA512:
-  metadata.gz: 3ac48f199b64dc571a9f05caf15128429b809988d8d904750870fa30db3b74a3a5bb5a650862b3b97ce331bd5b9c250efe4efb090c96552c2610da8dbed46760
-  data.tar.gz: d0bbb042025768241fcc2b487b9767e19fbd8244f79653d213908added72df10a9368daba02f192390954ebf5f96618b035b49ae4dabbeae0d8c156a629d3dca
+  metadata.gz: 76f8b14e266fc0cf9063c19d5a39c6ce346b05539a450ab100e13e0440b7ea6293b4c02c1250f1e9a68a37fb9a7d952b3b6380bf3ea64bdd5c01984848d001a2
+  data.tar.gz: 51e379dc7d45bd905d0a52d791b8cd9a869ee5fe285848ced7ff3a579e4758ccb677095faadd5b55d812055acc87b4c0dbdc260e95aaa1ef8b51fa983d50b32b

data/README.md

@@ -4,9 +4,11 @@ Adds a `similar_#{model_name.plural}` instance and class method to an active rec
 
 The instance method returns models that have associated models in common ordered by most in common first.
 
+A practical example for this could be linking to related blog posts when rendering an individual blog post. Related blog posts could be related by author, tag or author and tag combined.
+
 The class method returns models ordered by most associated models in common.
 
-If the commonality count is the same then a second order clause of `created_at` if present takes precedence.
+If the commonality count is the same then a second order clause of `created_at` takes precedence if present.
 
 The association(s) have to be many to many, so either [habtm](https://guides.rubyonrails.org/association_basics.html#has-and-belongs-to-many) or [has_many :through](https://guides.rubyonrails.org/association_basics.html#has-many-through).
 

data/lib/similar_models/version.rb

@@ -1,3 +1,3 @@
 module SimilarModels
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/lib/similar_models.rb

@@ -39,9 +39,30 @@ module SimilarModels
     #   INNER JOIN author_posts ON author_posts.post_id = posts.alt_id
     #     WHERE "posts"."alt_id" != ? AND
     #       author_posts.author_id IN (select author_posts.author_id from author_posts where author_posts.post_id = ?)
-    #   GROUP BY posts.alt_id, posts.created_at, posts.updated_at
+    #   GROUP BY posts.alt_id
     #   ORDER BY similar_posts_commonality_count DESC, created_at DESC
     #
+    # example sql query for two many to many associations:
+    #
+    # SELECT posts.*, count(posts.alt_id) AS similar_posts_by_author_and_tag_commonality_count
+    #   FROM (
+    #     (SELECT "posts".* FROM "posts"
+    #       INNER JOIN author_posts ON author_posts.post_id = posts.alt_id
+    #       WHERE (author_posts.author_id IN
+    #         (select author_posts.author_id from author_posts where author_posts.post_id = ?)
+    #       )
+    #     )
+    #   UNION ALL
+    #     (SELECT "posts".* FROM "posts"
+    #       INNER JOIN posts_tags ON posts_tags.post_id = posts.alt_id
+    #       WHERE (posts_tags.tag_id IN
+    #         (select posts_tags.tag_id from posts_tags where posts_tags.post_id = ?)
+    #       )
+    #     )
+    #   )
+    #   AS posts WHERE "posts"."alt_id" != ? GROUP BY posts.alt_id, posts.created_at, posts.updated_at
+    #   ORDER BY similar_posts_by_author_and_tag_commonality_count DESC, created_at DESC
+    #
     define_method as do
       table_name = self.class.table_name
       primary_key = self.class.primary_key
@@ -63,12 +84,12 @@ module SimilarModels
       order_clause += ", created_at DESC" if self.class.column_names.include?('created_at')
       scope = self.class.select("#{table_name}.*, count(#{primary_key_ref}) AS #{as}_commonality_count").
         where.not(primary_key => self.id).order(order_clause)
-      group_by_clause = self.class.column_names.map { |column| "#{table_name}.#{column}"}.join(', ')
 
       # if there is only one many-to-many association no need to use UNION sql syntax
       if association_scopes.one?
-        scope.merge(association_scopes.first).group(group_by_clause)
+        scope.merge(association_scopes.first).group(primary_key_ref)
       else
+        group_by_clause = self.class.column_names.map { |column| "#{table_name}.#{column}"}.join(', ')
         scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) AS #{table_name}").group(group_by_clause)
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: similar_models
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Jolyon Pawlyn