silas 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36bc01dd259d8950ae57b75a3eb94f91065aed62d2b149d705959695bc8f323f
-  data.tar.gz: f2aa37ea2d83373d2252b594aaef87894f1da03adda08edfa746baa6e76c2dea
+  metadata.gz: a8ece90334c6059bd396179bfae54b62ebd8abc483d72309da718dbb8e147845
+  data.tar.gz: '014359b0b35a36e7b34b796fbb9194f99c49bf39a1901b4b82cb7b94a10c0ea0'
 SHA512:
-  metadata.gz: 43ba5370306adecd0c53f818d655a367748e5b3162559abca5e8eb2a5687410c8d145f8f8b545f98ca265961344378e1c0a474826b46853357f2bce4192aa12b
-  data.tar.gz: 3cf07dea2adbe6eb33ec3bf65401c96127c1a066fbb104ea2e945d42f5526e8272aebbf9561a5777d1c6278674b3bc386036d1aa2b01bcb37d99366822ac431b
+  metadata.gz: 25e3610da0c9a62b6e9f2a0f956e01c989c62eec40bfdee6703b1bd9206821bb6b4a7988726671b57cd53949ae518239a76d76511cc260b3279db9a36b4f38c4
+  data.tar.gz: f891bf52671a8cd2c7fdc9041b036194939995dc4de7dee7bdd8f09cea986593bc526681d161d41add81b16cfe9257d75df7599e09a7fb85d5af52a9b117828d

data/CHANGELOG.md

@@ -1,5 +1,31 @@
 # Changelog
 
+## 0.3.2
+
+- **The `timeout` budget no longer counts time spent parked for approval.**
+  The wall clock restarts when an approval resumes a turn, because any
+  approval slower than `limits.timeout` previously made the approved resume
+  *instantly* re-park on "timeout" — pathological for a gate whose whole point
+  is waiting for a person (found live in the playground: a 3-minute approval
+  against a 120s timeout). Timeout now bounds **active** stretches — hung
+  providers, runaway loops; crash-rescue resumes keep the original clock (the
+  turn was genuinely live), and cost/token budgets stay cumulative because
+  they measure real spend.
+- **Broadcast-rendered trace partials work in host apps.** The inbox's live
+  trace renders through Turbo's broadcast jobs — i.e. the HOST's default
+  renderer — where the engine-scoped `TraceHelper` and bare engine route
+  helpers didn't exist, so **every broadcast render raised and the live trace
+  silently never streamed in real host apps** (the gem's specs stubbed the
+  dispatch seam and never rendered). The helper is now registered host-wide,
+  partials build routes context-free via `silas_engine_path` (engine route
+  set + discovered mount point), and four host-renderer regression specs pin
+  the real path. `relative_time` is renamed `silas_relative_time` (it is now
+  host-visible, and the bare name is exactly what a host app would define).
+  Also new: `examples/playground` gets a customer-facing chat page that
+  renders and live-streams the engine's own trace partials with zero custom
+  streaming code, plus a scripted keyless demo mode (`bin/setup && bin/dev`
+  with no API key).
+
 ## 0.3.1
 
 - **Fixed: only the first scenario in a `silas:eval` run was really tested.**

data/app/helpers/silas/inbox/trace_helper.rb

@@ -37,11 +37,21 @@ module Silas
         end
       end
 
-      def relative_time(time)
+      # Prefixed: this helper is registered host-wide (broadcast renders need
+      # it), and "relative_time" is exactly the name a host app would define.
+      def silas_relative_time(time)
         return "" unless time
 
         "#{time_ago_in_words(time)} ago"
       end
+
+      # Engine paths that resolve in EVERY render context. The mounted proxy
+      # (`silas.`) leans on the rendering scope's url_options, which Turbo's
+      # bare broadcast renderer doesn't have — so broadcast-rendered partials
+      # build paths from the engine's own route set + the discovered mount.
+      def silas_engine_path(helper, *args)
+        Silas::Engine.routes.url_helpers.public_send(helper, *args, script_name: Silas::Inbox.mount_path)
+      end
     end
   end
 end

data/app/models/silas/tool_invocation.rb

@@ -84,7 +84,13 @@ module Silas
       return if turn.reload.canceled? || turn.failed? # settled turns never zombie-resume
       return if turn.tool_invocations.where(approval_state: "required").exists?
 
-      turn.update!(status: "queued")
+      # Restart the wall clock: `limits.timeout` bounds ACTIVE stretches (hung
+      # providers, runaway loops), not human deliberation. Without this, any
+      # approval that took longer than the timeout made the approved resume
+      # instantly re-park on "timeout" — pathological for a gate whose whole
+      # point is waiting for a person. Cost/token budgets stay cumulative;
+      # they measure real spend.
+      turn.update!(status: "queued", started_at: Time.current)
       AgentLoopJob.perform_later(turn.id)
     end
   end

data/app/views/silas/inbox/invocations/_approval_card.html.erb

@@ -1,10 +1,13 @@
 <div class="approval">
   <h3>Approval needed — <%= invocation.tool_name %></h3>
   <pre><%= pretty_args(invocation.arguments) %></pre>
-  <%= form_with url: approve_inbox_invocation_path(invocation), method: :post, class: "inline" do %>
+  <%# silas_engine_path, not bare helpers: this partial is broadcast-rendered
+      through the HOST's renderer, where engine route helpers don't exist and
+      the mounted proxy has no routing scope to lean on. %>
+  <%= form_with url: silas_engine_path(:approve_inbox_invocation_path, invocation), method: :post, class: "inline" do %>
     <button class="btn approve">Approve</button>
   <% end %>
-  <%= form_with url: decline_inbox_invocation_path(invocation), method: :post, class: "decline-form" do %>
+  <%= form_with url: silas_engine_path(:decline_inbox_invocation_path, invocation), method: :post, class: "decline-form" do %>
     <textarea name="reason" rows="2" placeholder="Reason (optional — sent back to the agent as the tool result)"></textarea>
     <button class="btn decline">Decline</button>
   <% end %>

data/app/views/silas/inbox/sessions/index.html.erb

@@ -45,7 +45,7 @@
       <div class="muted">
         <%= pluralize(session.turns.size, "turn") %> ·
         <%= session.channel.presence || "direct" %> ·
-        <%= relative_time(session.updated_at) %>
+        <%= silas_relative_time(session.updated_at) %>
       </div>
     <% end %>
   <% end %>

data/app/views/silas/inbox/sessions/show.html.erb

@@ -11,7 +11,7 @@
     <span class="name"><%= @session.agent_name %></span>
     <span class="muted">#<%= @session.id %></span>
   </div>
-  <div class="muted"><%= @session.channel.presence || "direct" %> · started <%= relative_time(@session.created_at) %></div>
+  <div class="muted"><%= @session.channel.presence || "direct" %> · started <%= silas_relative_time(@session.created_at) %></div>
   <div id="silas-session-<%= @session.id %>-cost"><%= render "silas/inbox/sessions/cost", session: @session %></div>
 </div>
 

data/app/views/silas/inbox/turns/_header.html.erb

@@ -2,7 +2,10 @@
   <span class="turn-input"><%= truncate(turn.input, length: 90) %></span>
   <%= status_pill(turn.status) %>
   <% if turn.active? && !turn.cancel_requested_at %>
-    <%= form_with url: cancel_inbox_turn_path(turn), method: :post, class: "inline" do %>
+    <%# silas_engine_path — this partial is broadcast-rendered through the
+        host renderer on every turn status change; bare engine helpers (and
+        the scope-dependent mounted proxy) 500 there. %>
+    <%= form_with url: silas_engine_path(:cancel_inbox_turn_path, turn), method: :post, class: "inline" do %>
       <button class="btn-cancel" title="Honored at the next step boundary">Cancel</button>
     <% end %>
   <% elsif turn.cancel_requested_at && turn.active? %>
@@ -14,7 +17,7 @@
     <h3>Budget reached — <%= turn.failure_reason %></h3>
     <div class="muted">Parked at zero compute. Raise the limit and the turn resumes
       by replaying completed work from rows — no re-calls, no re-effects.</div>
-    <%= form_with url: raise_budget_inbox_turn_path(turn), method: :post, class: "topup-form" do %>
+    <%= form_with url: silas_engine_path(:raise_budget_inbox_turn_path, turn), method: :post, class: "topup-form" do %>
       <input name="value" type="number" step="any" min="0" required class="topup-input"
              placeholder="<%= turn.failure_reason == "max_cost" ? "new limit in dollars, e.g. 2.50" : "new limit, e.g. 200000" %>">
       <button class="btn approve">Raise &amp; resume</button>

data/lib/silas/budget.rb

@@ -7,9 +7,11 @@ module Silas
   #
   # Token/cost checks are deterministic (persisted step data). The timeout check
   # reads the wall clock — benign non-determinism: a cap firing later on resume
-  # is correct (the turn genuinely ran too long across the crash). Note the
-  # timeout clock includes time spent parked, so a timeout top-up should be
-  # sized from Time.current - started_at, not from the original limit.
+  # is correct (the turn genuinely ran too long across the crash). The clock
+  # RESTARTS when an approval resumes the turn (resume_turn! resets
+  # started_at): timeout bounds active stretches, never the hours a human
+  # spends deciding. Crash-rescue resumes keep the original clock — the turn
+  # was live the whole time.
   module Budget
     REASONS = %w[max_input_tokens max_cost timeout].freeze
 

data/lib/silas/engine.rb

@@ -43,6 +43,17 @@ module Silas
       Silas::Inbox::DeltaBroadcaster.subscribe!
     end
 
+    # The trace partials render in TWO contexts: the inbox controllers (which
+    # declare this helper) and Turbo's broadcast jobs, which render through the
+    # HOST's default renderer — where an engine-scoped helper doesn't exist and
+    # every broadcast died silently inside Turbo's job. Register it host-wide
+    # so broadcast renders — and host apps embedding the trace partials in
+    # their own pages — resolve it. (Routes inside those partials go through
+    # TraceHelper#silas_engine_path, which needs no routing scope at all.)
+    initializer "silas.trace_helper" do
+      ActiveSupport.on_load(:action_controller_base) { helper Silas::Inbox::TraceHelper }
+    end
+
     # Registry rebuilds on every code reload in development, once in production.
     initializer "silas.registry" do |app|
       next unless app.root.join("app/agent").exist? || app.root.join("app/agents").exist?

data/lib/silas/inbox.rb

@@ -19,5 +19,20 @@ module Silas
     def stream_name(session_id)
       "silas:inbox:session:#{session_id}"
     end
+
+    # Where the host mounted the engine ("/silas" by the installer's
+    # convention), discovered from the app's route set. Used to build paths
+    # that work in EVERY render context — including Turbo's bare broadcast
+    # renderer, which has no routing scope for the mounted proxy to lean on.
+    def mount_path
+      @mount_path ||= begin
+        route = Rails.application.routes.routes.find do |r|
+          r.app.respond_to?(:app) && r.app.app == Silas::Engine
+        end
+        route&.path&.spec.to_s.sub(/\(.*\z/, "").presence || "/silas"
+      end
+    end
+
+    def reset_mount_path! = (@mount_path = nil) # specs remount
   end
 end

data/lib/silas/version.rb

@@ -1,3 +1,3 @@
 module Silas
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: silas
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Daniel St Paul