signed_form 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13a5bc0a03b358342f6a21ab3f109424efdc19aa
-  data.tar.gz: 7e3edc29f8b6ebb848f1d928802bc0f6b5cae985
+  metadata.gz: c2252f1f051eaa4aae342bebc6e18b690c1729e0
+  data.tar.gz: 14aed6537280fff1e06456e6810c3e82234482f8
 SHA512:
-  metadata.gz: c86f3310a481303031dbb197d4d383ea4e18f62b14eaa3a630bc2280147e55c61aadd624d8251de6549cfd1d5c7f58253f9c584cfd9e2cb2b128a3887361dedb
-  data.tar.gz: 40a338b8e5fece5f63a84feff4107f18c9007d2e5105803d584d0aee4c421ea4ccc2e54de6234b3030ac9c4df77f14bbc8bd13186f85eceb7b7079af48c1dc61
+  metadata.gz: b6ba4877c2618bfca2c6906a7ecc38fd2f86c138daafd6cee98945053ed773d615954dd0478d06059dd5bbc69a9275c612dc9f0618b7f9fe37bd7bf8e32b2879
+  data.tar.gz: 3d9aa7420195e95e2bf864482785675ac4e9e914ed257b6e9a017c6fec011533de4e12c95bb7d4f923bfdea3e698bf0845f737eba16d8d41129b00d96d09045d

data/README.md

@@ -49,7 +49,7 @@ way you use standard forms.
 SignedForm requires:
 
 * Ruby 1.9 or later
-* Ruby on Rails 4 or Rails 3 (3.0 not supported) ([strong_parameters](https://github.com/rails/strong_parameters) gem
+* Rails 4 or Rails 3.1+ ([strong_parameters](https://github.com/rails/strong_parameters) gem
   required for Rails 3)
 
 ## Installation
@@ -86,7 +86,7 @@ You'll also need to create an initializer:
 
 ## Support for other Builders
 
-* [SimpleForm](https://github.com/erichmenge/signed_form-simple_form)
+* [SimpleForm Adapter](https://github.com/erichmenge/signed_form-simple_form)
 
 ## Special Considerations
 

data/lib/signed_form/form_builder.rb

@@ -4,7 +4,21 @@ module SignedForm
     # Base methods for form signing. Include this module in your own builders to get signatures for the base input
     # helpers. Add fields to sign with #add_signed_fields
     module Methods
-      (::ActionView::Helpers::FormBuilder.field_helpers.map(&:to_s) - %w(label fields_for button apply_form_for_options!)).each do |h|
+      FIELDS_TO_SIGN = [:select, :collection_select, :grouped_collection_select,
+                        :time_zone_select, :collection_radio_buttons, :collection_check_boxes,
+                        :date_select, :datetime_select, :time_select,
+                        :text_field, :password_field, :hidden_field,
+                        :file_field, :text_area, :check_box,
+                        :radio_button, :color_field, :search_field,
+                        :telephone_field, :phone_field, :date_field,
+                        :time_field, :datetime_field, :datetime_local_field,
+                        :month_field, :week_field, :url_field,
+                        :email_field, :number_field, :range_field]
+
+      FIELDS_TO_SIGN.delete_if { |e| !::ActionView::Helpers::FormBuilder.instance_methods.include?(e) }
+      FIELDS_TO_SIGN.freeze
+
+      FIELDS_TO_SIGN.each do |h|
         define_method(h) do |field, *args|
           add_signed_fields field
           super(field, *args)

data/lib/signed_form/version.rb

@@ -1,7 +1,7 @@
 module SignedForm
   MAJOR = 0
   MINOR = 1
-  PATCH = 0
+  PATCH = 1
   PRE   = nil
 
   VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join '.'

data/spec/form_builder_spec.rb

@@ -58,27 +58,118 @@ describe SignedForm::FormBuilder do
   end
 
   describe "form inputs" do
-    (ActionView::Helpers::FormBuilder.field_helpers.map(&:to_s) - %w(label fields_for button radio_button apply_form_for_options!)).each do |field|
+    fields  = ActionView::Helpers::FormBuilder.instance_methods - Object.instance_methods
+    fields -= [:button, :multipart=, :submit,
+               :field_helpers, :label, :multipart,
+               :emitted_hidden_id?, :to_model, :field_helpers?,
+               :field_helpers=, :fields_for, :object_name=,
+               :object=, :object_name, :model_name_from_record_or_class,
+               :multipart?, :options, :options=,
+               :convert_to_model, :to_partial_path, :index,
+               :object, :radio_button, :parent_builder,
+               :collection_check_boxes, :grouped_collection_select, :select,
+               :collection_select, :collection_radio_buttons, :time_select,
+               :datetime_select, :time_zone_select, :date_select]
+
+    after do
+      @data.should be
+      @data.size.should == 1
+      @data['user'].size.should == 1
+      @data['user'].should include(:name)
+    end
+
+    fields.each do |field|
       it "should add to the allowed attributes when #{field} is used" do
         content = signed_form_for(User.new) do |f|
           f.send field, :name
         end
 
-        data = get_data_from_form(content)
-        data.size.should == 1
-        data['user'].size.should == 1
-        data['user'].should include(:name)
+        @data = get_data_from_form(content)
       end
     end
 
+    it "should add to the allowed attributes when collection_check_boxes is used", action_pack: /4\.\d+/ do
+      content = signed_form_for(User.new) do |f|
+        f.collection_check_boxes :name, ['a', 'b'], :to_s, :to_s
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when grouped_collection_select is used" do
+      continent   = Struct.new('Continent', :continent_name, :countries)
+      country     = Struct.new('Country', :country_id, :country_name)
+
+      content = signed_form_for(User.new) do |f|
+        f.grouped_collection_select(:name, [continent.new("<Africa>", [country.new("<sa>", "<South Africa>")])],
+                                    :countries, :continent_name, :country_id, :country_name)
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.select :name, %w(a b)
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when collection_select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.collection_select :name, %w(a b), :to_s, :to_s
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when collection_radio_buttons is used", action_pack: /4\.\d+/ do
+      content = signed_form_for(User.new) do |f|
+        f.collection_radio_buttons :name, %w(a b), :to_s, :to_s
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when date_select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.date_select :name
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when time_select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.time_select :name
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when datetime_select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.datetime_select :name
+      end
+
+      @data = get_data_from_form(content)
+    end
+
+    it "should add to the allowed attributes when time_zone_select is used" do
+      content = signed_form_for(User.new) do |f|
+        f.time_zone_select :name
+      end
+
+      @data = get_data_from_form(content)
+    end
+
     it "should add to the allowed attributes when radio_button is used" do
       content = signed_form_for(User.new) do |f|
         f.radio_button :name, ['bar']
       end
 
-      data = get_data_from_form(content)
-      data['user'].size.should == 1
-      data['user'].should include(:name)
+      @data = get_data_from_form(content)
     end
   end
 

data/spec/spec_helper.rb

@@ -8,7 +8,7 @@ require 'signed_form'
 require 'active_support/core_ext'
 
 module SignedFormViewHelper
-  include ActionView::Helpers::FormHelper
+  include ActionView::Helpers
 
   if defined?(ActionView::RecordIdentifier)
     include ActionView::RecordIdentifier
@@ -58,5 +58,7 @@ RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
 
+  config.filter_run_excluding action_pack: ->(version) { ActionPack::VERSION::STRING.match(/\d+\.\d+/)[0] !~ version }
+
   config.order = 'random'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: signed_form
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Erich Menge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-04 00:00:00.000000000 Z
+date: 2013-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler