signal 0.1.0 → 0.1.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: cbd0a814de4e6237f0b61910db55ee771bd2ed84
+  data.tar.gz: ac8b02d08b219eaac0850e4ae57fa054ec4d0053
+SHA512:
+  metadata.gz: 18d186c33d95751a355b9d16ff120bc9f88c2c0e9003897fee839b2643f68c9de61448729cceab114db489495cbfa9da28618038bd5c9b1693bfc759e5a4c0ec
+  data.tar.gz: cb6c62d5f1fb096e09b76ecbb36d3ef0eaf9140ed57ca662f65a65f8203a547497cd438995b042abad83957b37cffcc743fc11a03938cc7c32e88d238b87f836

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/Gemfile

@@ -1,2 +1,2 @@
-source :rubygems
+source "http://rubygems.org"
 gemspec

data/Gemfile.lock

@@ -0,0 +1,51 @@
+PATH
+  remote: .
+  specs:
+    signal (0.1.1)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    activemodel (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
+    activerecord (4.0.0)
+      activemodel (= 4.0.0)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.0)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    arel (4.0.0)
+    atomic (1.1.10)
+    builder (3.1.4)
+    diff-lcs (1.2.4)
+    i18n (0.6.4)
+    minitest (4.7.5)
+    multi_json (1.7.7)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.3)
+    rspec-expectations (2.14.0)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.1)
+    sqlite3 (1.3.7)
+    thread_safe (0.1.0)
+      atomic
+    tzinfo (0.3.37)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord
+  rspec
+  signal!
+  sqlite3

data/README.md

@@ -123,10 +123,10 @@ class Thing < ActiveRecord::Base
 end
 
 thing = Thing.new(:name => "Stuff")
-thing.on(:create) { puts updated_at, name }
-thing.on(:update) { puts updated_at, name }
-thing.on(:remove) { puts destroyed? }
-thing.on(:validation) { p errors.full_messages }
+thing.on(:create) {|thing| puts thing.updated_at, thing.name }
+thing.on(:update) {|thing| puts thing.updated_at, thing.name }
+thing.on(:remove) {|thing| puts thing.destroyed? }
+thing.on(:validation) {|thing| p thing.errors.full_messages }
 
 thing.save!
 #=> 2013-01-26 10:32:39 -0200

data/lib/signal/active_record.rb

@@ -16,11 +16,11 @@ module Signal
     module InstanceMethods
       private
       def around_create_signal
-        emit_signal(:before, :create)
+        emit_signal(:before, :create, self)
         yield
         return unless persisted?
-        emit_signal(:on, :create)
-        emit_signal(:after, :create)
+        emit_signal(:on, :create, self)
+        emit_signal(:after, :create, self)
       end
 
       def around_save_signal
@@ -29,26 +29,26 @@ module Signal
           return
         end
 
-        emit_signal(:before, :update)
+        emit_signal(:before, :update, self)
         yield
-        emit_signal(:on, :update)
-        emit_signal(:after, :update)
+        emit_signal(:on, :update, self)
+        emit_signal(:after, :update, self)
       end
 
       def around_destroy_signal
-        emit_signal(:before, :remove)
+        emit_signal(:before, :remove, self)
         yield
-        emit_signal(:on, :remove)
-        emit_signal(:after, :remove)
+        emit_signal(:on, :remove, self)
+        emit_signal(:after, :remove, self)
       end
 
       def before_validation_signal
-        emit_signal(:before, :validation)
+        emit_signal(:before, :validation, self)
       end
 
       def after_validation_signal
-        emit_signal(:on, :validation) if errors.any?
-        emit_signal(:after, :validation)
+        emit_signal(:on, :validation, self) if errors.any?
+        emit_signal(:after, :validation, self)
       end
     end
   end

data/lib/signal/listener.rb

@@ -8,9 +8,10 @@ module Signal
       @event_method = :"#{@type}_#{@event}"
     end
 
-    def method_missing(method, *args)
-      return super unless method == @event_method
-      @context.instance_exec(*args, &@block)
+    def method_missing(method_name, *args)
+      return super unless respond_to_missing?(method_name, false)
+      # @context.instance_exec(*args, &@block)
+      @block.call(*args)
     end
 
     def to_s

data/lib/signal/version.rb

@@ -1,3 +1,3 @@
 module Signal
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/signal_spec.rb

@@ -7,42 +7,42 @@ describe Signal do
   context "using blocks" do
     it "triggers event" do
       observable.on(:ready, &callable)
-      callable.should_receive(:called).with(observable)
+      callable.should_receive(:called).with(no_args)
 
       observable.emit(:ready)
     end
 
     it "triggers event with arguments" do
       observable.on(:ready, &callable)
-      callable.should_receive(:called).with(observable, 1, 2, 3)
+      callable.should_receive(:called).with(1, 2, 3)
 
       observable.emit(:ready, 1, 2, 3)
     end
 
     it "triggers before event" do
       observable.before(:ready, &callable)
-      callable.should_receive(:called).with(observable)
+      callable.should_receive(:called).with(no_args)
 
       observable.emit(:ready)
     end
 
     it "triggers before event with arguments" do
       observable.before(:ready, &callable)
-      callable.should_receive(:called).with(observable, 1, 2, 3)
+      callable.should_receive(:called).with(1, 2, 3)
 
       observable.emit(:ready, 1, 2, 3)
     end
 
     it "triggers after event" do
       observable.after(:ready, &callable)
-      callable.should_receive(:called).with(observable)
+      callable.should_receive(:called).with(no_args)
 
       observable.emit(:ready)
     end
 
     it "triggers after event with arguments" do
       observable.after(:ready, &callable)
-      callable.should_receive(:called).with(observable, 1, 2, 3)
+      callable.should_receive(:called).with(1, 2, 3)
 
       observable.emit(:ready, 1, 2, 3)
     end
@@ -57,19 +57,39 @@ describe Signal do
         .on(:ready, &on_callable)
         .after(:ready, &after_callable)
 
-      before_callable.should_receive(:called).with(observable).ordered
-      on_callable.should_receive(:called).with(observable).ordered
-      after_callable.should_receive(:called).with(observable).ordered
+      before_callable
+        .should_receive(:called)
+        .with(no_args)
+        .ordered
+
+      on_callable
+        .should_receive(:called)
+        .with(no_args)
+        .ordered
+
+      after_callable
+        .should_receive(:called)
+        .with(no_args)
+        .ordered
 
       observable.emit(:ready)
     end
+
+    it "keeps context" do
+      context = nil
+      callable = -> { context = self }
+      observable.on(:ready, &callable)
+      observable.emit(:ready)
+
+      expect(context).to eql(self)
+    end
   end
 
   context "using listeners" do
     it "triggers event for listener" do
       callable.respond_to(:on_ready)
       observable.listeners << callable
-      callable.should_receive(:called).with(callable)
+      callable.should_receive(:called).with(no_args)
 
       observable.emit(:ready)
     end
@@ -77,7 +97,7 @@ describe Signal do
     it "triggers event for listener with arguments" do
       callable.respond_to(:on_ready)
       observable.listeners << callable
-      callable.should_receive(:called).with(callable, 1, 2, 3)
+      callable.should_receive(:called).with(1, 2, 3)
 
       observable.emit(:ready, 1, 2, 3)
     end

data/spec/support/callable.rb

@@ -1,7 +1,7 @@
 class Callable
   def to_proc
     callable = self
-    proc {|*args| callable.called(self, *args) }
+    proc {|*args| callable.called(*args) }
   end
 
   def respond_to(method_name)

metadata

@@ -1,62 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: signal
 version: !ruby/object:Gem::Version
-  version: 0.1.0
-  prerelease: 
+  version: 0.1.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-26 00:00:00.000000000 Z
+date: 2013-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A simple observer implementation for POROs (Plain Old Ruby Object) and
@@ -70,6 +63,7 @@ files:
 - .gitignore
 - .rspec
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -92,27 +86,26 @@ files:
 - spec/support/user.rb
 homepage: http://github.com/fnando/signal
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A simple observer implementation for POROs (Plain Old Ruby Object) and ActiveRecord
   objects.
 test_files: