sift 1.1.0 → 4.0.0

data/spec/unit/validate/decision_spec.rb

@@ -0,0 +1,85 @@
+require_relative "../../spec_helper"
+
+require "sift/validate/decision"
+
+module Sift
+  module Validate
+    describe Decision do
+      describe "#valid_user?" do
+        it "will return true" do
+          validator = Decision.new(
+            user_id: "hello world",
+            source: :hello_world,
+            analyst: "asdfsadf@heyo.com"
+          )
+
+          expect(validator.valid_user?).to be(true)
+        end
+
+        it "with invalid user_id, will return false" do
+          validator = Decision.new(order_id: "asfasdf")
+          expect(validator.valid_user?).to be(false), "nil user is valid"
+
+          validator = Decision.new(order_id: "asfasdf", user_id: {})
+          expect(validator.valid_user?).to be(false), "user hash is valid"
+
+          validator = Decision.new(order_id: "asfasdf", user_id: /werwer/)
+          expect(validator.valid_user?).to be(false), "regex user is valid"
+        end
+      end
+
+      describe "#valid_order?" do
+        it "will return true with valid configs" do
+          validator = Decision.new(
+            order_id: "order_foo_bar_12354",
+            user_id: "hello world",
+            source: :hello_world,
+            analyst: "asdfsadf@heyo.com"
+          )
+
+          expect(validator.valid_order?).to be(true)
+        end
+
+        context "with invalid params:" do
+          it "user_id, will return false" do
+            validator = Decision.new(order_id: "asfasdf")
+            expect(validator.valid_order?).to be(false), "nil user is valid"
+
+            validator = Decision.new(order_id: "asfasdf", user_id: {})
+            expect(validator.valid_order?).to be(false), "user hash is valid"
+
+            validator = Decision.new(order_id: "asfasdf", user_id: /werwer/)
+            expect(validator.valid_order?).to be(false), "regex user is valid"
+          end
+
+          it "order_id, will return false" do
+            validator = Decision.new(user_id: 1235)
+            expect(validator.valid_order?).to be(false)
+
+            validator = Decision.new(user_id: 1235, order_id: {})
+            expect(validator.valid_order?).to be(false)
+
+            validator = Decision.new(user_id: 1235, order_id: /23424/)
+            expect(validator.valid_order?).to be(false)
+          end
+        end
+      end
+
+      describe "#error_messages" do
+        it "will return an array of error messages" do
+          validator = Decision.new
+
+          error_message =
+            "#{Primitive::ERROR_MESSAGES[:non_empty_string]}, got NilClass"
+
+          validator.valid_order?
+
+          expect(validator.error_messages).to contain_exactly(
+            "order_id #{error_message}",
+            "user_id #{error_message}"
+          )
+        end
+      end
+    end
+  end
+end

data/spec/unit/validate/primitive_spec.rb

@@ -0,0 +1,73 @@
+require_relative "../../spec_helper"
+
+require "sift/validate/primitive"
+
+module Sift
+  module Validate
+    describe Primitive do
+      describe ".non_empty_string" do
+        it "will return nil for valid values" do
+          expect(Primitive.non_empty_string("foobar")).to be_nil
+        end
+
+        it "will return an error message" do
+          [nil, 1, /asdfasdf/].each do |value|
+            error_message = "#{Primitive::ERROR_MESSAGES[:non_empty_string]}" \
+                            ", got #{value.class}"
+
+            expect(Primitive.non_empty_string(value)).to eq(error_message)
+          end
+
+          expect(Primitive.non_empty_string("")).to(
+            eq(Primitive.send(:empty_string_message, :non_empty_string))
+          )
+        end
+      end
+
+      describe ".is_numeric" do
+        it "will return nil for numeric values" do
+          [1, 29.01, 29 ** 1992848499198, -2].each do |value|
+            expect(Primitive.numeric(value)).to(
+              be_nil,
+              "#{value} is a non numeric value"
+            )
+          end
+        end
+
+        it "will return an error message for non numeric values" do
+          ["foobar", nil, :hello_world, {}].each do |value|
+            expect(Primitive.numeric(value)).to(
+              be(Primitive::ERROR_MESSAGES[:numeric]),
+              "#{value} is a numeric value"
+            )
+          end
+        end
+      end
+
+      describe ".is_string_or_number?" do
+        it "will return nil for numeric or strings" do
+          [1234, "asdfasdf", "1234_asdfsdf"].each do |value|
+            expect(Primitive.string_or_number(value)).to(
+              be_nil,
+              "#{value} is a non numeric value"
+            )
+          end
+        end
+
+        it "will return an error message for any other type" do
+          [{}, [], :hello_world, nil].each do |value|
+            error_message = "#{Primitive::ERROR_MESSAGES[:string_or_number]}," \
+                            " got #{value.class}"
+
+            expect(Primitive.string_or_number(value)).to eq(error_message)
+          end
+
+          error_message = "#{Primitive::ERROR_MESSAGES[:string_or_number]}, " \
+                          "got an empty string"
+          expect(Primitive.string_or_number("")).to eq(error_message)
+        end
+      end
+    end
+  end
+end
+

metadata

@@ -1,161 +1,190 @@
 --- !ruby/object:Gem::Specification
 name: sift
 version: !ruby/object:Gem::Version
-  version: 1.1.0
-  prerelease: 
+  version: 4.0.0
 platform: ruby
 authors:
 - Fred Sadaghiani
+- Yoav Schatzberg
+- Jacob Burnim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-09 00:00:00.000000000 Z
+date: 2019-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '3.5'
 - !ruby/object:Gem::Dependency
-  name: fakeweb
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: multi_json
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.16.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.16.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.2
+        version: 0.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.2
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: multi_json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
+        version: '1.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Sift Science Ruby API. Please see http://siftscience.com for more details.
 email:
-- freds@siftscience.com
+- support@siftscience.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".circleci/config.yml"
+- ".gitignore"
 - Gemfile
 - HISTORY
-- README.rdoc
+- LICENSE
+- README.md
 - Rakefile
 - examples/simple.rb
 - lib/sift.rb
 - lib/sift/client.rb
+- lib/sift/client/decision.rb
+- lib/sift/client/decision/apply_to.rb
+- lib/sift/error.rb
+- lib/sift/router.rb
+- lib/sift/utils/hash_getter.rb
+- lib/sift/validate/decision.rb
+- lib/sift/validate/primitive.rb
 - lib/sift/version.rb
 - sift.gemspec
+- spec/fixtures/fake_responses.rb
 - spec/integration/sift_spec.rb
 - spec/spec_helper.rb
+- spec/unit/client/decision/apply_to_spec.rb
+- spec/unit/client/decision_spec.rb
+- spec/unit/client_203_spec.rb
 - spec/unit/client_label_spec.rb
 - spec/unit/client_spec.rb
-- spec/unit/sift_spec.rb
+- spec/unit/router_spec.rb
+- spec/unit/validate/decision_spec.rb
+- spec/unit/validate/primitive_spec.rb
 homepage: http://siftscience.com
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: sift
-rubygems_version: 1.8.25
+rubygems_version: 2.5.2.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Sift Science Ruby API Gem
 test_files:
+- spec/fixtures/fake_responses.rb
 - spec/integration/sift_spec.rb
 - spec/spec_helper.rb
+- spec/unit/client/decision/apply_to_spec.rb
+- spec/unit/client/decision_spec.rb
+- spec/unit/client_203_spec.rb
 - spec/unit/client_label_spec.rb
 - spec/unit/client_spec.rb
-- spec/unit/sift_spec.rb
+- spec/unit/router_spec.rb
+- spec/unit/validate/decision_spec.rb
+- spec/unit/validate/primitive_spec.rb

data/README.rdoc

@@ -1,40 +0,0 @@
-= Sift Science Ruby bindings
-
-== Installation
-
-If you want to build the gem from source:
-
-  $ gem build sift.gemspec
-
-Alternatively, you can install the gem from Rubyforge:
-
-  $ gem install sift
-
-== Requirements
-
-  * Ruby 1.8.7 or above. (Ruby 1.8.6 might work if you load ActiveSupport.)
-  * HTTParty, 0.8.3 or greater
-
-For development only:
-  * bundler
-  * rspec, 2.9 or greater
-  * fakeweb, 1.3 or greater
-
-== Building
-
-Building and publishing the gem is captured by the following steps:
-
-  $ gem build sift.gemspec
-  $ gem push sift-<current version>.gem
-
-  $ bundle
-  $ rake -T
-  $ rake build
-  $ rake install
-  $ rake release
-
-== Testing
-
-To run the various tests use the rake command as follows:
-
-  $ rake spec

data/spec/unit/sift_spec.rb

@@ -1,6 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
-
-describe Sift do
-
-
-end