siebel_donations 1.0.11 → 1.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bca87e7e7adb117c59e7b15517b75b5c2fcf0c83143ea89dc800e3d6bbe602f
-  data.tar.gz: 3edc34cd4c90728e9e650d30e8b5ac13a48ccd498b0362c95e705c248a9d18d0
+  metadata.gz: 2524352a26b0a76d1a52e45580267a3ac9fc58ff9951e4cb942dce81a7d8237b
+  data.tar.gz: 3886685b60392bb80ad7909da1c256e362840e031826e2413d2c0eaac3010347
 SHA512:
-  metadata.gz: 48c44ad82bbd9738a017692e9416fb46174da48eb395a7da169398453311a64481de81fe2063983f3f03fd7e242bb537bcd957fdb79f3f42b3fc3e8380116b38
-  data.tar.gz: 26c77c7fe6924e23453cbe9b087f25dc12b95ea97a4637e1e80e0f8ab5524e1753c6c6d19789fe1fb648d12c1b5621376cd9e8bce0c2fea8c5c3c08a9cbf8518
+  metadata.gz: 7921b075c3bbccd78d9822597632975d2afa2f6e3da38e1fff7db500b4829a971104484b2a03e7afb2687438827b561ece8ad629c8921766b83d77406bc08efd
+  data.tar.gz: 161d4246544427d1daa88d9b910dadfc97722793b271fe636bf393c7c9c9f17d7ed09dff826fb87fe1e4917d2beab5a497ba62d02c65d231396d25ea543916ed

data/lib/siebel_donations/address.rb

@@ -2,7 +2,7 @@ module SiebelDonations
   class Address < Base
 
     attr_reader :id, :primary, :seasonal, :address1, :address2, :address3, :address4, :city,
-                :state, :zip, :updated_at
+                :state, :zip, :country, :updated_at
 
 
     def type

data/lib/siebel_donations/base.rb

@@ -14,7 +14,8 @@ module SiebelDonations
     def self.get(path, params)
       raise 'You need to configure SiebelDonations with your oauth_token.' unless SiebelDonations.oauth_token
 
-      params[:response_timeout] ||= SiebelDonations.default_timeout
+      request_timeout = params[:timeout] || SiebelDonations.default_timeout
+      params[:response_timeout] ||= request_timeout
       retry_count = params.delete(:retry_count) || SiebelDonations.default_retry_count
 
       url = SiebelDonations.base_url + path
@@ -23,7 +24,7 @@ module SiebelDonations
       retryable_errors = [RestClient::InternalServerError, Timeout::Error, Errno::ECONNRESET]
 
       Retryable.retryable on: retryable_errors, times: retry_count, sleep: 20 do
-        request_params = { method: :get, url: url, headers: headers, timeout: SiebelDonations.default_timeout }
+        request_params = { method: :get, url: url, headers: headers, timeout: request_timeout }
         RestClient::Request.execute(request_params) do |response, request, result, &block|
           case response.code
           when 200

data/lib/siebel_donations/version.rb

@@ -1,3 +1,3 @@
 module SiebelDonations
-  VERSION = "1.0.11"
+  VERSION = "1.0.14"
 end

data/lib/siebel_donations.rb

@@ -22,7 +22,7 @@ module SiebelDonations
     end
 
     def default_retry_count
-      @default_retry_count || 20
+      @default_retry_count || 2
     end
   end
 end

data/spec/base_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe SiebelDonations::Base do
+  context '.get' do
+    context 'with timeout param set' do
+      it 'passes param to RestClient' do
+        expect(RestClient::Request).to receive(:execute)
+          .with(hash_including(url: SiebelDonations.base_url, timeout: 123))
+          .and_return(nil)
+
+        described_class.get('', timeout: 123)
+      end
+    end
+
+    context 'without timeout param set' do
+      it 'passes default to RestClient' do
+        expect(RestClient::Request).to receive(:execute)
+          .with(hash_including(timeout: 6000))
+          .and_return(nil)
+
+        described_class.get('', {})
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: siebel_donations
 version: !ruby/object:Gem::Version
-  version: 1.0.11
+  version: 1.0.14
 platform: ruby
 authors:
 - Josh Starcher
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-06-24 00:00:00.000000000 Z
+date: 2022-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -92,12 +92,13 @@ files:
 - lib/siebel_donations/profile.rb
 - lib/siebel_donations/version.rb
 - siebel_donations.gemspec
+- spec/base_spec.rb
 - spec/donation_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -112,11 +113,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
-signing_key: 
+rubygems_version: 3.3.0
+signing_key:
 specification_version: 4
 summary: Get donation information from Siebel Donor
 test_files:
+- spec/base_spec.rb
 - spec/donation_spec.rb
 - spec/spec_helper.rb