sie 1.0.4 → 1.0.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZmU2YjMwNWYzNjk3NzUxYzUyZjAyODFiNWI3NzBkZTFjYjY0NmE5NQ==
+    NDlhZjFkZmQwYmY5YjFhMDQ5ODljYTU1ZGM1ODFkMzMxMmIxMTRhOA==
   data.tar.gz: !binary |-
-    NDA1YTYxYjExOTI1ODNiZDdmZDlmOTkyM2Y5MTliMDE2ZDIxNDQxZg==
+    OWIzMjZlMTE5YjAxZjg0MDE0YmNiOWE4MTljMDYzMGY4ZTE0NDc5Ng==
 SHA512:
   metadata.gz: !binary |-
-    YzYwOWJmYTBlNGI0MTg4ZTllZWU0ZWVhN2Y2OTcxNmNlMjc1MjA1M2ViNGUz
-    OTgwZDM2NzE2N2IzZDNmMWQ1YjhhYWUxZWZiN2M4NDk3ZjNiODRkYWQ5YzI5
-    MjRhODMwYWRlMWE1OGFjMGJiOGM0NmU2ZDk2OTYxMjAwNWY0YWM=
+    MDA2OWNhMjU2OWFmNzBkNjZlOTgzODQyODBjNGZhNzFkYThkZTU1Y2UxNTlk
+    YjhkNTNhNDUwOTcxMGQ3OGU3ZTFlYzkwNDIzMTgyZWYyMDIwYmY4NWEzNDU2
+    ZjEwNDYxZTg4ZTk4NTE4MGMzZTE0NGRkMjYwNzdlOTMxZGQ3ZDY=
   data.tar.gz: !binary |-
-    MmY0OWZiZGUyY2U1NDI3NWM3NDZkYjBlMzFhOWQ4MGM3ZGQ4MTJmODY2MzI2
-    ZGQxNzJjOWZhZTQ5NzRkY2UwN2I4MmIxMDU2NDAxMjJjMDNkNWU4MzhiMzA4
-    NWZmNDlmZWE5ZmJhNmU0YTk5NGQyYmIwZWEzZDY1MjUxYjA1NjI=
+    MWFlMzY5ZmI4YjljZGQwMzY5Y2U3ZmIyZWE0ZDE5ZGMxYWE1YjY1ODJhNjk2
+    NmE3MjE1OThlZTAxN2VkNzU0NzgyNWFhZjgyODhiNDUzMmEyMzBiYmQwZDM5
+    Yjg2ODMxYjQ3NGIzZmE2MzI5M2Q0OGQ1MjNiMjlkMDNiYjg0N2M=

data/lib/sie/document.rb

@@ -6,6 +6,7 @@ require "active_support/core_ext/module/delegation"
 
 class Sie::Document
   pattr_initialize :data_source
+  FORTNOX_DESCRIPTION_LENGTH_MAX = 30
 
   def render
     add_header
@@ -42,7 +43,7 @@ class Sie::Document
   def add_accounts
     accounts.each do |account|
       number      = account.fetch(:number)
-      description = account.fetch(:description)
+      description = account.fetch(:description).slice(0, FORTNOX_DESCRIPTION_LENGTH_MAX)
 
       add_line("KONTO", number, description)
     end
@@ -69,12 +70,13 @@ class Sie::Document
     end
   end
 
+
   def add_voucher(opts)
     creditor      = opts.fetch(:creditor)
     type          = opts.fetch(:type)
     number        = opts.fetch(:number)
     booked_on     = opts.fetch(:booked_on)
-    description   = opts.fetch(:description)
+    description   = opts.fetch(:description).slice(0, FORTNOX_DESCRIPTION_LENGTH_MAX)
     voucher_lines = opts.fetch(:voucher_lines)
 
     add_line("VER", voucher_series(creditor, type), number, booked_on, description)
@@ -84,9 +86,18 @@ class Sie::Document
         account_number = line.fetch(:account_number)
         amount         = line.fetch(:amount)
         booked_on      = line.fetch(:booked_on)
-        description    = line.fetch(:description)
+        # Some SIE-importers (fortnox) cannot handle descriptions longer than 30 characters,
+        # but the specification has no limit.
+        description    = line.fetch(:description).slice(0, FORTNOX_DESCRIPTION_LENGTH_MAX)
 
         add_line("TRANS", account_number, Renderer::EMPTY_ARRAY, amount, booked_on, description)
+
+        # Some consumers of SIE cannot handle single voucher lines (fortnox), so add another empty one to make
+        # it balance. The spec just requires the sum of lines to be 0, so single lines with zero amount would conform,
+        # but break for these implementations.
+        if voucher_lines.size < 2 && amount == 0
+          add_line("TRANS", account_number, Renderer::EMPTY_ARRAY, amount, booked_on, description)
+        end
       end
     end
   end

data/lib/sie/version.rb

@@ -1,3 +1,3 @@
 module Sie
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 end

data/spec/unit/document_spec.rb

@@ -9,7 +9,7 @@ describe Sie::Document, "#render" do
   let(:generated_on) { Date.yesterday }
   let(:accounts) {
     [
-      number: 1500, description: "Customer ledger"
+      number: 1500, description: "Customer ledger",
     ]
   }
   let(:vouchers) {
@@ -155,6 +155,48 @@ describe Sie::Document, "#render" do
     )
   end
 
+  context "with really long descriptions" do
+    let(:accounts) {
+      [
+        number: 1500, description: "Customer ledger with really really long description blablabla"
+      ]
+    }
+    let(:vouchers) {
+      [
+        {
+          creditor: true, type: :payment, number: 3, booked_on: from_date + 365, description: "Payout 1 with really really long description blablabla",
+          voucher_lines: [
+            { account_number: 2400, amount: 256.0, booked_on: from_date + 365, description: "Payout line 1 with really really long description blablabla" },
+            { account_number: 1970, amount: -256.0, booked_on: from_date + 365, description: "Payout line 2" },
+          ]
+        }
+      ]
+    }
+
+    it "truncates the descriptions" do
+      expect(indexed_entry_attributes("konto", 0)).to eq("kontonr" => "1500", "kontonamn" => "Customer ledger with really re")
+      expect(indexed_entry("ver", 0).attributes["vertext"]).to eq("Payout 1 with really really lo")
+      expect(indexed_voucher_entries(0)[0].attributes["transtext"]).to eq("Payout line 1 with really real")
+    end
+  end
+
+  context "with a zeroed single voucher line" do
+    let(:vouchers) {
+      [
+        {
+          creditor: false, type: :invoice, number: 1, booked_on: from_date + 2, description: "Invoice 1",
+          voucher_lines: [
+            { account_number: 1500, amount: 0, booked_on: from_date + 2, description: "Item 1" },
+          ]
+        },
+      ]
+    }
+
+    it "makes sure there is always a matching zeroed line" do
+      expect(indexed_voucher_entries(0).size).to eq(2)
+    end
+  end
+
   private
 
   def entry_attribute(label, attribute)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sie
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Barsoom AB
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-18 00:00:00.000000000 Z
+date: 2014-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: attr_extras
@@ -142,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Parses and generates SIE files (http://sie.se/)