sidekiq_utils 1.0.5 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1dc8efb624d5511e606a14b158b677906be6ef30
-  data.tar.gz: ecf07e503bfa7751c19528ab912dd45536fcbbfb
+  metadata.gz: 56c66fe07141a3c7a9c7dc02f9eb2d18c6490ec5
+  data.tar.gz: 872564437e8b12f063d533478bef291d1457a8e3
 SHA512:
-  metadata.gz: d5ff8cbcf128b4b897836b25ce393863f36e18ae4028fb78e86f5d17fe463019ad02787e65ebc59ae2647e716297be8eb6173fbd5448d900b98c18ec11d5ae23
-  data.tar.gz: 9a1839187a3e53ab5df6944262dac71d44cc4a33a576a86c8ff4b27a4e727f586fb25d00df2bdb8d6f6a145f10c14554edf8e797d6786ee0eedfb48ae04ee70f
+  metadata.gz: e595c6c645e728981d8f1866db71dd6794757467ff135c62497c040470f9ce67968d1b987565036199f562e1f00ecd1754c3671e6d473aed7baddd72059bd5e6
+  data.tar.gz: e46f265a6fc97af95229b22cdcaff141939f9e17535b9ccd1ad4c7861a56cbf487b282cf9abda3c1c4fff956c1023200fb7d9d623bba6585e5148fee753eacb9

data/README.md

@@ -153,26 +153,6 @@ slack:
 
 Simply call `SidekiqUtils::LatencyAlert.check!` at regular intervals.
 
-## Memory monitor
-
-This automatically checks memory usage before and after a worker is run and keeps track of which jobs consistently leak memory. Please note that this is very approximate. It also requires you running one worker process single-threaded with `-c 1`. It slows down jobs processed by that worker considerably.
-
-### Configuration
-
-```
-Sidekiq.configure_server do |config|
-  config.server_middleware do |chain|
-    chain.add SidekiqUtils::Middleware::Server::MemoryMonitor
-  end
-end
-Sidekiq::Web.register SidekiqUtils::WebExtensions::MemoryMonitor
-Sidekiq::Web.tabs["Memory"] = "memory"
-```
-
-### Usage
-
-This will add a "Memory" tab to your Sidekiq admin which will display memory usage information.
-
 ## Throughput monitor
 
 This will keep track of how many jobs of which worker class have run in the past week, as well as when it was last run.

data/VERSION

@@ -1 +1 @@
-1.0.5
+2.0.0

data/lib/sidekiq_utils.rb

@@ -3,10 +3,8 @@ require 'sidekiq_utils/middleware/client/deprioritize'
 
 require 'sidekiq_utils/middleware/server/additional_serialization'
 require 'sidekiq_utils/middleware/server/find_optional'
-require 'sidekiq_utils/middleware/server/memory_monitor'
 require 'sidekiq_utils/middleware/server/throughput_monitor'
 
-require 'sidekiq_utils/web_extensions/memory_monitor'
 require 'sidekiq_utils/web_extensions/throughput_monitor'
 
 require 'sidekiq_utils/redis_monitor_storage'

data/sidekiq_utils.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: sidekiq_utils 1.0.5 ruby lib
+# stub: sidekiq_utils 2.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "sidekiq_utils".freeze
-  s.version = "1.0.5"
+  s.version = "2.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Magnus von Koeller".freeze]
-  s.date = "2019-01-23"
+  s.date = "2019-01-28"
   s.description = "Tools that make working with a major Sidekiq installation more fun.".freeze
   s.email = "magnus@angel.co".freeze
   s.extra_rdoc_files = [
@@ -38,13 +38,10 @@ Gem::Specification.new do |s|
     "lib/sidekiq_utils/middleware/client/deprioritize.rb",
     "lib/sidekiq_utils/middleware/server/additional_serialization.rb",
     "lib/sidekiq_utils/middleware/server/find_optional.rb",
-    "lib/sidekiq_utils/middleware/server/memory_monitor.rb",
     "lib/sidekiq_utils/middleware/server/throughput_monitor.rb",
     "lib/sidekiq_utils/redis_monitor_storage.rb",
-    "lib/sidekiq_utils/web_extensions/memory_monitor.rb",
     "lib/sidekiq_utils/web_extensions/throughput_monitor.rb",
     "lib/sidekiq_utils/web_extensions/views/job_counts.erb",
-    "lib/sidekiq_utils/web_extensions/views/memory.erb",
     "lib/sidekiq_utils/web_extensions/views/throughput.erb",
     "sidekiq_utils.gemspec",
     "spec/spec_helper.rb"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq_utils
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 2.0.0
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-23 00:00:00.000000000 Z
+date: 2019-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -121,13 +121,10 @@ files:
 - lib/sidekiq_utils/middleware/client/deprioritize.rb
 - lib/sidekiq_utils/middleware/server/additional_serialization.rb
 - lib/sidekiq_utils/middleware/server/find_optional.rb
-- lib/sidekiq_utils/middleware/server/memory_monitor.rb
 - lib/sidekiq_utils/middleware/server/throughput_monitor.rb
 - lib/sidekiq_utils/redis_monitor_storage.rb
-- lib/sidekiq_utils/web_extensions/memory_monitor.rb
 - lib/sidekiq_utils/web_extensions/throughput_monitor.rb
 - lib/sidekiq_utils/web_extensions/views/job_counts.erb
-- lib/sidekiq_utils/web_extensions/views/memory.erb
 - lib/sidekiq_utils/web_extensions/views/throughput.erb
 - sidekiq_utils.gemspec
 - spec/spec_helper.rb

data/lib/sidekiq_utils/middleware/server/memory_monitor.rb

@@ -1,46 +0,0 @@
-require 'objspace'
-
-module SidekiqUtils
-  module Middleware
-    module Server
-      class MemoryMonitor
-        def call(worker, job, queue)
-          return yield unless Sidekiq.options[:concurrency] == 1
-
-          objects_before = count_allocated_objects
-          memory_before = get_allocated_memory
-
-          GC.start(full_mark: true)
-          GC.disable
-          begin
-            yield
-          ensure
-            GC.enable
-            GC.start(full_mark: true)
-            objects_after = count_allocated_objects
-            memory_after = get_allocated_memory
-
-            object_growth = objects_after - objects_before
-            SidekiqUtils::RedisMonitorStorage.store(
-              'sidekiq_memory', 'object', job, object_growth)
-            Sidekiq.logger.info("Object growth: #{object_growth}")
-
-            memory_growth = memory_after - memory_before
-            SidekiqUtils::RedisMonitorStorage.store(
-              'sidekiq_memory', 'memory', job, memory_growth)
-            Sidekiq.logger.info("Memory growth: #{memory_growth}")
-          end
-        end
-
-        private
-        def count_allocated_objects
-          ObjectSpace.each_object.inject(0) {|count, obj| count + 1 }
-        end
-
-        def get_allocated_memory
-          ObjectSpace.memsize_of_all
-        end
-      end
-    end
-  end
-end

data/lib/sidekiq_utils/web_extensions/memory_monitor.rb

@@ -1,26 +0,0 @@
-module SidekiqUtils
-  module WebExtensions
-    module MemoryMonitor
-      def self.registered(app)
-        view_path = File.join(File.expand_path("..", __FILE__), "views")
-
-        require 'active_support/number_helper'
-        app.get("/memory") do
-          memory = SidekiqUtils::RedisMonitorStorage.retrieve('sidekiq_memory', 'memory')
-          object = SidekiqUtils::RedisMonitorStorage.retrieve('sidekiq_memory', 'object')
-
-          @memory = (memory.keys | object.keys).map do |job|
-            [job,
-             memory[job]['average'],
-             object[job]['average'],
-             memory[job]['sum'],
-             object[job]['sum'],
-            ]
-          end.sort_by {|x| -x[3] }
-
-          render(:erb, File.read(File.join(view_path, "memory.erb")))
-        end
-      end
-    end
-  end
-end

data/lib/sidekiq_utils/web_extensions/views/memory.erb

@@ -1,33 +0,0 @@
-<header class='row'>
-  <div class='col-sm-5'>
-    <h3>Memory</h3>
-  </div>
-</header>
-
-<p>
-Data from the trailing seven days. Only a small percentage of jobs get
-profiled. The "absolute" numbers refer only to those jobs that did get
-profiled.
-</p>
-<table class='table table-striped table-bordered table-white'>
-  <thead>
-    <tr>
-      <th>Job</th>
-      <th>Memory growth (absolute)</th>
-      <th>Memory growth (per job)</th>
-      <th>Object growth (absolute)</th>
-      <th>Object growth (per job)</th>
-    </tr>
-  </thead>
-  <tbody>
-    <% @memory.each do |(job, avg_memory, avg_object, abs_memory, abs_object)| %>
-      <tr>
-        <td><%= job %></td>
-        <td><%= ActiveSupport::NumberHelper.number_to_human_size(abs_memory) %></td>
-        <td><%= ActiveSupport::NumberHelper.number_to_human_size(avg_memory) %></td>
-        <td><%= ActiveSupport::NumberHelper.number_to_delimited(abs_object) %></td>
-        <td><%= ActiveSupport::NumberHelper.number_to_delimited(avg_object) %></td>
-      </tr>
-    <% end %>
-  </tbody>
-</table