sidekiq_lifecycle_hooks 1.1.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87e878d6e4faa8edd1ddd411fd37ff636ab3178de43d50412224f152e4e609d2
-  data.tar.gz: 5e69ab953b3ace67e84015c4bbe44e1cc22af1fb406d79ed4adaceae5bc20e35
+  metadata.gz: e680eb3a1bd1a627e65eb60a1af029b7792fecf91af35eddac1219a82d83cbbe
+  data.tar.gz: d6160ba25cdc33755c531b8289da34c0b17627131142128d1c505f93d764efb1
 SHA512:
-  metadata.gz: fe5a1d94f1332b871acf7617474070bbbbe972e63e2b196a6eb28ea6695411f792e52d6a7fc31ba2b4d91e073ba3f33e9fe39bb69512e2fe0bcd5816bb4a2ee0
-  data.tar.gz: 90a73f90eae0d611a852a7f579d0de37e290ebe3dd6de9b85b9b2b37eba54886d1908573ad76301f08f84c114262d138b783caac42d41c21d9c98773ddee187e
+  metadata.gz: 2cc51496cd0b9d004f488d924714e700c1725e2c8ec03d5394ab23a71a5a731562a50b555837ee952dd788cb3dfea573a65c1e4dd5aa39286be76f3224f61206
+  data.tar.gz: 260dafdde9bb4f6347c41beba08686c08d68c6f81b7b37c469fb906a5eb9413b6395eb3595b81ec010931be52da14ce11d759f0f63112b8f7e841b1343f44a85

data/CHANGELOG.md

@@ -1,4 +1,13 @@
 
+### 1.3.0
+
+- Move to after_commit
+
+### 1.2.0
+
+- Added a retry in Async job where record cannot be found, in case
+attempt to find record occurred too early. This can happen when the initial record creation is delayed by e.g. after_create hooks and indexes.
+
 ### 1.1.0
 
 - Add early return in Async Job for when record cannot be found

data/README.md

@@ -102,3 +102,11 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/WillTa
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+
+## Notes to self
+
+To deploy a new version
+- Update the version number & changelog
+- gem build sidekiq_lifecycle_hooks.gemspec
+- gem push sidekiq_lifecycle_hooks-1.X.0.gem
+

data/lib/lifecycle_job.rb

@@ -3,11 +3,14 @@ class LifecycleJob
   sidekiq_options queue: :default, retry: 1
 
   def perform(class_name, record_id, action, previous_attrs = '{}')
-    return unless (record = if action == 'destroy'
-               class_name.constantize.new(JSON.parse(previous_attrs))
-             else
-               class_name.constantize.find_by(id: record_id)
-             end)
+    
+    record = fetch_record(class_name, record_id, action, previous_attrs)
+    unless record
+      sleep 3 # waits for 3 seconds before retrying
+      record = fetch_record(class_name, record_id, action, previous_attrs)
+    end
+
+    return unless record
 
     case action
     when 'create'
@@ -18,4 +21,14 @@ class LifecycleJob
       record.async_after_destroy_actions
     end
   end
+
+  private
+
+  def fetch_record(class_name, record_id, action, previous_attrs)
+    if action == 'destroy'
+      class_name.constantize.new(JSON.parse(previous_attrs))
+    else
+      class_name.constantize.find_by(id: record_id)
+    end
+  end
 end

data/lib/sidekiq_lifecycle_hooks/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SidekiqLifecycleHooks
-  VERSION = "1.1.0"
+  VERSION = "1.3.0"
 end

data/lib/sidekiq_lifecycle_hooks.rb

@@ -4,22 +4,27 @@ module SidekiqLifecycleHooks
   extend ActiveSupport::Concern
 
   included do
-    after_create :enqueue_async_after_create_actions, if: -> { self.class.method_defined?(:async_after_create_actions) }
-    after_update :enqueue_async_after_update_actions, if: -> { self.class.method_defined?(:async_after_update_actions) }
-    after_destroy :enqueue_async_after_destroy_actions, if: -> { self.class.method_defined?(:async_after_destroy_actions) }
+    after_create_commit :enqueue_async_after_create_actions, if: -> { self.class.method_defined?(:async_after_create_actions) }
+    after_update_commit :enqueue_async_after_update_actions, if: -> { self.class.method_defined?(:async_after_update_actions) }
+    before_destroy :prepare_async_after_destroy_actions, if: -> { self.class.method_defined?(:async_after_destroy_actions) }
+    after_destroy_commit :enqueue_async_after_destroy_actions, if: -> { self.class.method_defined?(:async_after_destroy_actions) }
   end
 
   private
 
   def enqueue_async_after_create_actions
-    LifecycleJob.perform_in(1.second, self.class.name, id, 'create')
+    LifecycleJob.perform_async(self.class.name, id, 'create')
   end
 
   def enqueue_async_after_update_actions
-    LifecycleJob.perform_in(1.second, self.class.name, id, 'update')
+    LifecycleJob.perform_async(self.class.name, id, 'update')
+  end
+
+  def prepare_async_after_destroy_actions
+    @destroyed_attributes = attributes.to_json
   end
 
   def enqueue_async_after_destroy_actions
-    LifecycleJob.perform_in(1.second, self.class.name, id, 'destroy', attributes.to_json)
+    LifecycleJob.perform_async(self.class.name, id, 'destroy', @destroyed_attributes)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq_lifecycle_hooks
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Will Taylor
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-07 00:00:00.000000000 Z
+date: 2024-09-03 00:00:00.000000000 Z
 dependencies: []
 description:
 email: