sidekiq-unique-jobs 6.0.25 → 7.1.33

data/lib/sidekiq_unique_jobs/orphans/reaper_resurrector.rb

@@ -0,0 +1,170 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Orphans
+    # Restarts orphan manager if it is considered dead
+    module ReaperResurrector
+      module_function
+
+      include SidekiqUniqueJobs::Connection
+      include SidekiqUniqueJobs::Logging
+
+      DRIFT_FACTOR = 0.1
+      REAPERS = [:ruby, :lua].freeze
+
+      #
+      # Starts reaper resurrector that watches orphans reaper
+      #
+      # @return [SidekiqUniqueJobs::TimerTask] the task that was started
+      #
+      def start
+        return if resurrector_disabled?
+        return if reaper_disabled?
+
+        with_logging_context do
+          run_task
+        end
+      end
+
+      #
+      # Runs reaper resurrector task
+      #
+      # @return [SidekiqUniqueJobs::TimerTask]
+      def run_task
+        log_info("Starting Reaper Resurrector")
+        task.execute
+        task
+      end
+
+      #
+      # The task that runs the resurrector
+      #
+      # @return [SidekiqUniqueJobs::TimerTask]
+      def task
+        SidekiqUniqueJobs::TimerTask.new(timer_task_options) do
+          with_logging_context do
+            restart_if_dead
+          end
+        end
+      end
+
+      #
+      # Starts new instance of orphan reaper if reaper is considered dead (reaper mutex has not been refreshed lately)
+      #
+      def restart_if_dead
+        return if reaper_registered?
+
+        log_info("Reaper is considered dead. Starting new reaper instance")
+        orphans_manager.start
+      end
+
+      #
+      # Returns orphan manager
+      #
+      # @return [SidekiqUniqueJobs::Orphans::Manager]
+      def orphans_manager
+        SidekiqUniqueJobs::Orphans::Manager
+      end
+
+      #
+      # Checks if resurrector is disabled
+      #
+      # @see resurrector_enabled?
+      #
+      # @return [true, false]
+      def resurrector_disabled?
+        !resurrector_enabled?
+      end
+
+      #
+      # Checks if resurrector is enabled
+      #
+      # @return [true, false]
+      def resurrector_enabled?
+        SidekiqUniqueJobs.config.reaper_resurrector_enabled
+      end
+
+      #
+      # Checks if reaping is disabled
+      #
+      # @see reaper_enabled?
+      #
+      # @return [true, false]
+      #
+      def reaper_disabled?
+        !reaper_enabled?
+      end
+
+      #
+      # Checks if reaping is enabled
+      #
+      # @return [true, false]
+      #
+      def reaper_enabled?
+        REAPERS.include?(reaper)
+      end
+
+      #
+      # Checks if reaper is registered
+      #
+      # @return [true, false]
+      def reaper_registered?
+        redis do |conn|
+          conn.get(UNIQUE_REAPER).to_i + drift_reaper_interval > current_timestamp
+        end
+      end
+
+      #
+      # @see SidekiqUniqueJobs::Config#reaper
+      #
+      def reaper
+        SidekiqUniqueJobs.config.reaper
+      end
+
+      #
+      # Arguments passed on to the timer task
+      #
+      #
+      # @return [Hash]
+      #
+      def timer_task_options
+        { run_now: false,
+          execution_interval: reaper_resurrector_interval }
+      end
+
+      #
+      # A context to use for all log entries
+      #
+      #
+      # @return [Hash] when logger responds to `:with_context`
+      # @return [String] when logger does not responds to `:with_context`
+      #
+      def logging_context
+        if logger_context_hash?
+          { "uniquejobs" => "reaper-resurrector" }
+        else
+          "uniquejobs=reaper-resurrector"
+        end
+      end
+
+      #
+      # @see SidekiqUniqueJobs::Config#reaper_resurrector_interval
+      #
+      def reaper_resurrector_interval
+        SidekiqUniqueJobs.config.reaper_resurrector_interval
+      end
+
+      def reaper_interval
+        SidekiqUniqueJobs.config.reaper_interval
+      end
+
+      def drift_reaper_interval
+        reaper_interval + (reaper_interval * DRIFT_FACTOR).to_i
+      end
+
+      def current_timestamp
+        Time.now.to_i
+      end
+    end
+  end
+end

data/lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb

@@ -0,0 +1,298 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Orphans
+    #
+    # Class DeleteOrphans provides deletion of orphaned digests
+    #
+    # @note this is a much slower version of the lua script but does not crash redis
+    #
+    # @author Mikael Henriksson <mikael@mhenrixon.com>
+    #
+    # rubocop:disable Metrics/ClassLength
+    class RubyReaper < Reaper
+      include SidekiqUniqueJobs::Timing
+
+      #
+      # @return [String] the suffix for :RUN locks
+      RUN_SUFFIX = ":RUN"
+      #
+      # @return [Integer] the maximum combined length of sidekiq queues for running the reaper
+      MAX_QUEUE_LENGTH = 1000
+      #
+      # @!attribute [r] digests
+      #   @return [SidekiqUniqueJobs::Digests] digest collection
+      attr_reader :digests
+      #
+      # @!attribute [r] scheduled
+      #   @return [Redis::SortedSet] the Sidekiq ScheduleSet
+      attr_reader :scheduled
+      #
+      # @!attribute [r] retried
+      #   @return [Redis::SortedSet] the Sidekiq RetrySet
+      attr_reader :retried
+
+      #
+      # @!attribute [r] start_time
+      #   @return [Integer] The timestamp this execution started represented as Time (used for locks)
+      attr_reader :start_time
+
+      #
+      # @!attribute [r] start_time
+      #   @return [Integer] The clock stamp this execution started represented as integer
+      #      (used for redis compatibility as it is more accurate than time)
+      attr_reader :start_source
+
+      #
+      # @!attribute [r] timeout_ms
+      #   @return [Integer] The allowed ms before timeout
+      attr_reader :timeout_ms
+
+      #
+      # Initialize a new instance of DeleteOrphans
+      #
+      # @param [Redis] conn a connection to redis
+      #
+      def initialize(conn)
+        super(conn)
+        @digests      = SidekiqUniqueJobs::Digests.new
+        @scheduled    = Redis::SortedSet.new(SCHEDULE)
+        @retried      = Redis::SortedSet.new(RETRY)
+        @start_time   = Time.now
+        @start_source = time_source.call
+        @timeout_ms   = SidekiqUniqueJobs.config.reaper_timeout * 1000
+      end
+
+      #
+      # Delete orphaned digests
+      #
+      #
+      # @return [Integer] the number of reaped locks
+      #
+      def call
+        return if queues_very_full?
+
+        BatchDelete.call(expired_digests, conn)
+        BatchDelete.call(orphans, conn)
+      end
+
+      def expired_digests
+        max_score = (start_time - reaper_timeout).to_f
+
+        if VersionCheck.satisfied?(redis_version, ">= 6.2.0") && VersionCheck.satisfied?(::Redis::VERSION, ">= 4.6.0")
+          conn.zrange(EXPIRING_DIGESTS, 0, max_score, byscore: true)
+        else
+          conn.zrangebyscore(EXPIRING_DIGESTS, 0, max_score)
+        end
+      end
+
+      #
+      # Find orphaned digests
+      #
+      #
+      # @return [Array<String>] an array of orphaned digests
+      #
+      def orphans # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
+        page = 0
+        per = reaper_count * 2
+        orphans = []
+        results = conn.zrange(digests.key, page * per, (page + 1) * per)
+
+        while results.size.positive?
+          results.each do |digest|
+            break if timeout?
+            next if belongs_to_job?(digest)
+
+            orphans << digest
+            break if orphans.size >= reaper_count
+          end
+
+          break if timeout?
+          break if orphans.size >= reaper_count
+
+          page += 1
+          results = conn.zrange(digests.key, page * per, (page + 1) * per)
+        end
+
+        orphans
+      end
+
+      def timeout?
+        elapsed_ms >= timeout_ms
+      end
+
+      def elapsed_ms
+        time_source.call - start_source
+      end
+
+      #
+      # Checks if the digest has a matching job.
+      #   1. It checks the scheduled set
+      #   2. It checks the retry set
+      #   3. It goes through all queues
+      #
+      #
+      # @param [String] digest the digest to search for
+      #
+      # @return [true] when either of the checks return true
+      # @return [false] when no job was found for this digest
+      #
+      def belongs_to_job?(digest)
+        scheduled?(digest) || retried?(digest) || enqueued?(digest) || active?(digest)
+      end
+
+      #
+      # Checks if the digest exists in the Sidekiq::ScheduledSet
+      #
+      # @param [String] digest the current digest
+      #
+      # @return [true] when digest exists in scheduled set
+      #
+      def scheduled?(digest)
+        in_sorted_set?(SCHEDULE, digest)
+      end
+
+      #
+      # Checks if the digest exists in the Sidekiq::RetrySet
+      #
+      # @param [String] digest the current digest
+      #
+      # @return [true] when digest exists in retry set
+      #
+      def retried?(digest)
+        in_sorted_set?(RETRY, digest)
+      end
+
+      #
+      # Checks if the digest exists in a Sidekiq::Queue
+      #
+      # @param [String] digest the current digest
+      #
+      # @return [true] when digest exists in any queue
+      #
+      def enqueued?(digest)
+        Sidekiq.redis do |conn|
+          queues(conn) do |queue|
+            entries(conn, queue) do |entry|
+              return true if entry.include?(digest)
+            end
+          end
+
+          false
+        end
+      end
+
+      def active?(digest) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        Sidekiq.redis do |conn|
+          procs = conn.sscan_each("processes").to_a
+          return false if procs.empty?
+
+          procs.sort.each do |key|
+            valid, workers = conn.pipelined do |pipeline|
+              # TODO: Remove the if statement in the future
+              if pipeline.respond_to?(:exists?)
+                pipeline.exists?(key)
+              else
+                pipeline.exists(key)
+              end
+              pipeline.hgetall("#{key}:work")
+            end
+
+            next unless valid
+            next unless workers.any?
+
+            workers.each_pair do |_tid, job|
+              next unless (item = safe_load_json(job))
+
+              payload = safe_load_json(item[PAYLOAD])
+
+              return true if match?(digest, payload[LOCK_DIGEST])
+              return true if considered_active?(payload[CREATED_AT])
+            end
+          end
+
+          false
+        end
+      end
+
+      def match?(key_one, key_two)
+        return false if key_one.nil? || key_two.nil?
+
+        key_one.delete_suffix(RUN_SUFFIX) == key_two.delete_suffix(RUN_SUFFIX)
+      end
+
+      def considered_active?(time_f)
+        (Time.now - reaper_timeout).to_f < time_f
+      end
+
+      #
+      # Loops through all the redis queues and yields them one by one
+      #
+      # @param [Redis] conn the connection to use for fetching queues
+      #
+      # @return [void]
+      #
+      # @yield queues one at a time
+      #
+      def queues(conn, &block)
+        conn.sscan_each("queues", &block)
+      end
+
+      def entries(conn, queue, &block) # rubocop:disable Metrics/MethodLength
+        queue_key    = "queue:#{queue}"
+        initial_size = conn.llen(queue_key)
+        deleted_size = 0
+        page         = 0
+        page_size    = 50
+
+        loop do
+          range_start = (page * page_size) - deleted_size
+
+          range_end   = range_start + page_size - 1
+          entries     = conn.lrange(queue_key, range_start, range_end)
+          page       += 1
+
+          break if entries.empty?
+
+          entries.each(&block)
+
+          deleted_size = initial_size - conn.llen(queue_key)
+
+          # The queue is growing, not shrinking, just keep looping
+          deleted_size = 0 if deleted_size.negative?
+        end
+      end
+
+      # If sidekiq queues are very full, it becomes highly inefficient for the reaper
+      # because it must check every queued job to verify a digest is safe to delete
+      # The reaper checks queued jobs in batches of 50, adding 2 reads per digest
+      # With a queue length of 1,000 jobs, that's over 20 extra reads per digest.
+      def queues_very_full?
+        total_queue_size = 0
+        Sidekiq.redis do |conn|
+          queues(conn) do |queue|
+            total_queue_size += conn.llen("queue:#{queue}")
+
+            return true if total_queue_size > MAX_QUEUE_LENGTH
+          end
+        end
+        false
+      end
+
+      #
+      # Checks a sorted set for the existance of this digest
+      #
+      #
+      # @param [String] key the key for the sorted set
+      # @param [String] digest the digest to scan for
+      #
+      # @return [true] when found
+      # @return [false] when missing
+      #
+      def in_sorted_set?(key, digest)
+        conn.zscan_each(key, match: "*#{digest}*", count: 1).to_a.any?
+      end
+    end
+    # rubocop:enable Metrics/ClassLength
+  end
+end

data/lib/sidekiq_unique_jobs/redis/entity.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Redis
+    #
+    # Class Entity functions as a base class for redis types
+    #
+    # @author Mikael Henriksson <mikael@mhenrixon.com>
+    #
+    class Entity
+      # includes "SidekiqUniqueJobs::Logging"
+      # @!parse include SidekiqUniqueJobs::Logging
+      include SidekiqUniqueJobs::Logging
+
+      # includes "SidekiqUniqueJobs::Script::Caller"
+      # @!parse include SidekiqUniqueJobs::Script::Caller
+      include SidekiqUniqueJobs::Script::Caller
+
+      # includes "SidekiqUniqueJobs::JSON"
+      # @!parse include SidekiqUniqueJobs::JSON
+      include SidekiqUniqueJobs::JSON
+
+      # includes "SidekiqUniqueJobs::Timing"
+      # @!parse include SidekiqUniqueJobs::Timing
+      include SidekiqUniqueJobs::Timing
+
+      #
+      # @!attribute [r] key
+      #   @return [String] the redis key for this entity
+      attr_reader :key
+
+      #
+      # Initialize a new Entity
+      #
+      # @param [String] key the redis key for this entity
+      #
+      def initialize(key)
+        @key = key
+      end
+
+      #
+      # Checks if the key for this entity exists in redis
+      #
+      #
+      # @return [true] when exists
+      # @return [false] when not exists
+      #
+      def exist?
+        redis do |conn|
+          # TODO: Remove the if statement in the future
+          value =
+            if conn.respond_to?(:exists?)
+              conn.exists?(key)
+            else
+              conn.exists(key)
+            end
+
+          return value if boolean?(value)
+
+          value.to_i.positive?
+        end
+      end
+
+      #
+      # The number of microseconds until the key expires
+      #
+      #
+      # @return [Integer] expiration in milliseconds
+      #
+      def pttl
+        redis { |conn| conn.pttl(key) }
+      end
+
+      #
+      # The number of seconds until the key expires
+      #
+      #
+      # @return [Integer] expiration in seconds
+      #
+      def ttl
+        redis { |conn| conn.ttl(key) }
+      end
+
+      #
+      # Check if the entity has expiration
+      #
+      #
+      # @return [true] when entity is set to exire
+      # @return [false] when entity isn't expiring
+      #
+      def expires?
+        pttl.positive? || ttl.positive?
+      end
+
+      #
+      # Returns the number of entries in this entity
+      #
+      #
+      # @return [Integer] 0
+      #
+      def count
+        0
+      end
+
+      private
+
+      def boolean?(value)
+        [TrueClass, FalseClass].any? { |klazz| value.is_a?(klazz) }
+      end
+    end
+  end
+end

data/lib/sidekiq_unique_jobs/redis/hash.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Redis
+    #
+    # Class Hash provides convenient access to redis hashes
+    #
+    # @author Mikael Henriksson <mikael@mhenrixon.com>
+    #
+    class Hash < Entity
+      #
+      # Return entries for this hash
+      #
+      # @param [true,false] with_values false return hash
+      #
+      # @return [Array<Object>] when given with_values: false
+      # @return [Hash<String, String>] when given with_values: true
+      #
+      def entries(with_values: false)
+        if with_values
+          redis { |conn| conn.hgetall(key) }
+        else
+          redis { |conn| conn.hkeys(key) }
+        end
+      end
+
+      #
+      # Removes the key from redis
+      #
+      def del(*fields)
+        redis { |conn| conn.hdel(key, *fields) }
+      end
+
+      #
+      # Get a members value
+      #
+      # @param [String] member the member who's value to get
+      #
+      # @return [Object] whatever is stored on this hash member
+      #
+      def [](member)
+        redis { |conn| conn.hget(key, member) }
+      end
+
+      #
+      # Returns the count for this hash
+      #
+      #
+      # @return [Integer] the length of this hash
+      #
+      def count
+        redis { |conn| conn.hlen(key) }
+      end
+    end
+  end
+end

data/lib/sidekiq_unique_jobs/redis/list.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Redis
+    #
+    # Class List provides convenient access to redis hashes
+    #
+    # @author Mikael Henriksson <mikael@mhenrixon.com>
+    #
+    class List < Entity
+      #
+      # Entries in this list
+      #
+      #
+      # @return [Array<Object>] the elements in this list
+      #
+      def entries
+        redis { |conn| conn.lrange(key, 0, -1) }
+      end
+
+      #
+      # The number of entries in this list
+      #
+      #
+      # @return [Integer] the total number of entries
+      #
+      def count
+        redis { |conn| conn.llen(key) }
+      end
+    end
+  end
+end

data/lib/sidekiq_unique_jobs/redis/set.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module SidekiqUniqueJobs
+  module Redis
+    #
+    # Class Set provides convenient access to redis sets
+    #
+    # @author Mikael Henriksson <mikael@mhenrixon.com>
+    #
+    class Set < Entity
+      #
+      # Return entries for this set
+      #
+      #
+      # @return [Array<String>]
+      #
+      def entries
+        redis { |conn| conn.smembers(key) }
+      end
+
+      #
+      # Returns the count for this sorted set
+      #
+      #
+      # @return [Integer] the number of entries
+      #
+      def count
+        redis { |conn| conn.scard(key) }
+      end
+    end
+  end
+end