sidekiq-undertaker 1.0.0 → 1.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (20) hide show
  1. checksums.yaml +4 -4
  2. data/.codeclimate.yml +9 -2
  3. data/.gitignore +1 -0
  4. data/.rubocop.yml +0 -1
  5. data/.rubocop_codeclimate.yml +5 -0
  6. data/.rubocop_todo.yml +1 -1
  7. data/.travis.yml +9 -6
  8. data/lib/sidekiq/undertaker/version.rb +1 -1
  9. data/lib/sidekiq/undertaker/web_extension/api_helpers.rb +5 -1
  10. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_all_failures_and_errors/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt +4 -1
  11. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_all_failures_and_errors/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt +4 -1
  12. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt +4 -1
  13. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt +4 -1
  14. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt +1303 -0
  15. data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt +1304 -0
  16. data/spec/sidekiq/undertaker/dead_jobs_spec.rb +1 -1
  17. data/spec/sidekiq/undertaker/job_filter_spec.rb +1 -0
  18. data/spec/sidekiq/undertaker/web_extension_spec.rb +11 -1
  19. data/web/views/morgue.erb +3 -5
  20. metadata +49 -45
data/spec/sidekiq/undertaker/dead_jobs_spec.rb CHANGED
@@ -50,7 +50,7 @@ module Sidekiq
50
50
 
51
51
  describe ".for_each" do
52
52
  let(:expected_dead_job) do
53
- DeadJob.new(
53
+ described_class.new(
54
54
  job_class: "HardWorkTask",
55
55
  time_elapsed_since_failure: time_elapsed,
56
56
  error_class: "NoMethodError",
data/spec/sidekiq/undertaker/job_filter_spec.rb CHANGED
@@ -81,6 +81,7 @@ module Sidekiq
81
81
  expect(dead_job.error_class).to eq "NoMethodError"
82
82
  end
83
83
  end
84
+
84
85
  it { expect(dead_jobs.size).to eq 2 }
85
86
  end
86
87
 
data/spec/sidekiq/undertaker/web_extension_spec.rb CHANGED
@@ -49,7 +49,7 @@ module Sidekiq
49
49
  after { Timecop.return }
50
50
 
51
51
  def add_dead(opts = {})
52
- opts = default_job_opts.merge!(opts)
52
+ opts = default_job_opts.merge(opts)
53
53
 
54
54
  job = build_job(opts)
55
55
  killed_job = kill_job(job)
@@ -98,6 +98,16 @@ module Sidekiq
98
98
  subject { get "/undertaker/morgue/HardWorker/RuntimeError/1_hour" }
99
99
 
100
100
  it_behaves_like "a page"
101
+
102
+ context "with pagination" do
103
+ before do
104
+ 50.times do |i|
105
+ job_refs.push add_dead("jid" => i.to_s)
106
+ end
107
+ end
108
+
109
+ it_behaves_like "a page"
110
+ end
101
111
  end
102
112
 
103
113
  context "with all failures and errors" do
data/web/views/morgue.erb CHANGED
@@ -8,11 +8,9 @@
8
8
  </h3>
9
9
  </div>
10
10
  <div class="col-sm-12">
11
- <% if @total_dead > 0 && @total_dead > @count %>
12
- <div class="col-sm-4">
13
- <%= erb :_paging, :locals => { :url => "#{root_path}" + @undertaker_path } %>
14
- </div>
15
- <% end %>
11
+ <div class="col-sm-4">
12
+ <%= erb :_paging, :locals => { :url => "#{root_path}" + @undertaker_path } %>
13
+ </div>
16
14
  </div>
17
15
  </header>
18
16
 
metadata CHANGED
@@ -1,16 +1,17 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: sidekiq-undertaker
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.0
4
+ version: 1.0.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Thomas Koppensteiner
8
- autorequire:
8
+ autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-12-24 00:00:00.000000000 Z
11
+ date: 2020-02-03 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
+ name: bundler
14
15
  requirement: !ruby/object:Gem::Requirement
15
16
  requirements:
16
17
  - - ">="
@@ -19,9 +20,8 @@ dependencies:
19
20
  - - "<"
20
21
  - !ruby/object:Gem::Version
21
22
  version: '3'
22
- name: bundler
23
- prerelease: false
24
23
  type: :development
24
+ prerelease: false
25
25
  version_requirements: !ruby/object:Gem::Requirement
26
26
  requirements:
27
27
  - - ">="
@@ -31,20 +31,21 @@ dependencies:
31
31
  - !ruby/object:Gem::Version
32
32
  version: '3'
33
33
  - !ruby/object:Gem::Dependency
34
+ name: rake
34
35
  requirement: !ruby/object:Gem::Requirement
35
36
  requirements:
36
37
  - - "~>"
37
38
  - !ruby/object:Gem::Version
38
39
  version: '12.3'
39
- name: rake
40
- prerelease: false
41
40
  type: :development
41
+ prerelease: false
42
42
  version_requirements: !ruby/object:Gem::Requirement
43
43
  requirements:
44
44
  - - "~>"
45
45
  - !ruby/object:Gem::Version
46
46
  version: '12.3'
47
47
  - !ruby/object:Gem::Dependency
48
+ name: approvals
48
49
  requirement: !ruby/object:Gem::Requirement
49
50
  requirements:
50
51
  - - "~>"
@@ -53,9 +54,8 @@ dependencies:
53
54
  - - ">="
54
55
  - !ruby/object:Gem::Version
55
56
  version: 0.0.24
56
- name: approvals
57
- prerelease: false
58
57
  type: :development
58
+ prerelease: false
59
59
  version_requirements: !ruby/object:Gem::Requirement
60
60
  requirements:
61
61
  - - "~>"
@@ -65,216 +65,217 @@ dependencies:
65
65
  - !ruby/object:Gem::Version
66
66
  version: 0.0.24
67
67
  - !ruby/object:Gem::Dependency
68
+ name: mock_redis
68
69
  requirement: !ruby/object:Gem::Requirement
69
70
  requirements:
70
71
  - - "~>"
71
72
  - !ruby/object:Gem::Version
72
73
  version: '0.19'
73
- name: mock_redis
74
- prerelease: false
75
74
  type: :development
75
+ prerelease: false
76
76
  version_requirements: !ruby/object:Gem::Requirement
77
77
  requirements:
78
78
  - - "~>"
79
79
  - !ruby/object:Gem::Version
80
80
  version: '0.19'
81
81
  - !ruby/object:Gem::Dependency
82
+ name: pry
82
83
  requirement: !ruby/object:Gem::Requirement
83
84
  requirements:
84
85
  - - "~>"
85
86
  - !ruby/object:Gem::Version
86
87
  version: '0.12'
87
- name: pry
88
- prerelease: false
89
88
  type: :development
89
+ prerelease: false
90
90
  version_requirements: !ruby/object:Gem::Requirement
91
91
  requirements:
92
92
  - - "~>"
93
93
  - !ruby/object:Gem::Version
94
94
  version: '0.12'
95
95
  - !ruby/object:Gem::Dependency
96
+ name: rack-test
96
97
  requirement: !ruby/object:Gem::Requirement
97
98
  requirements:
98
99
  - - "~>"
99
100
  - !ruby/object:Gem::Version
100
101
  version: '1.1'
101
- name: rack-test
102
- prerelease: false
103
102
  type: :development
103
+ prerelease: false
104
104
  version_requirements: !ruby/object:Gem::Requirement
105
105
  requirements:
106
106
  - - "~>"
107
107
  - !ruby/object:Gem::Version
108
108
  version: '1.1'
109
109
  - !ruby/object:Gem::Dependency
110
+ name: rb-readline
110
111
  requirement: !ruby/object:Gem::Requirement
111
112
  requirements:
112
113
  - - "~>"
113
114
  - !ruby/object:Gem::Version
114
115
  version: '0.5'
115
- name: rb-readline
116
- prerelease: false
117
116
  type: :development
117
+ prerelease: false
118
118
  version_requirements: !ruby/object:Gem::Requirement
119
119
  requirements:
120
120
  - - "~>"
121
121
  - !ruby/object:Gem::Version
122
122
  version: '0.5'
123
123
  - !ruby/object:Gem::Dependency
124
+ name: rspec
124
125
  requirement: !ruby/object:Gem::Requirement
125
126
  requirements:
126
127
  - - "~>"
127
128
  - !ruby/object:Gem::Version
128
129
  version: '3.8'
129
- name: rspec
130
- prerelease: false
131
130
  type: :development
131
+ prerelease: false
132
132
  version_requirements: !ruby/object:Gem::Requirement
133
133
  requirements:
134
134
  - - "~>"
135
135
  - !ruby/object:Gem::Version
136
136
  version: '3.8'
137
137
  - !ruby/object:Gem::Dependency
138
+ name: rspec-core
138
139
  requirement: !ruby/object:Gem::Requirement
139
140
  requirements:
140
141
  - - "~>"
141
142
  - !ruby/object:Gem::Version
142
143
  version: '3.8'
143
- name: rspec-core
144
- prerelease: false
145
144
  type: :development
145
+ prerelease: false
146
146
  version_requirements: !ruby/object:Gem::Requirement
147
147
  requirements:
148
148
  - - "~>"
149
149
  - !ruby/object:Gem::Version
150
150
  version: '3.8'
151
151
  - !ruby/object:Gem::Dependency
152
+ name: rspec-mocks
152
153
  requirement: !ruby/object:Gem::Requirement
153
154
  requirements:
154
155
  - - "~>"
155
156
  - !ruby/object:Gem::Version
156
157
  version: '3.8'
157
- name: rspec-mocks
158
- prerelease: false
159
158
  type: :development
159
+ prerelease: false
160
160
  version_requirements: !ruby/object:Gem::Requirement
161
161
  requirements:
162
162
  - - "~>"
163
163
  - !ruby/object:Gem::Version
164
164
  version: '3.8'
165
165
  - !ruby/object:Gem::Dependency
166
+ name: rspec-sidekiq
166
167
  requirement: !ruby/object:Gem::Requirement
167
168
  requirements:
168
169
  - - "~>"
169
170
  - !ruby/object:Gem::Version
170
171
  version: '3.0'
171
- name: rspec-sidekiq
172
- prerelease: false
173
172
  type: :development
173
+ prerelease: false
174
174
  version_requirements: !ruby/object:Gem::Requirement
175
175
  requirements:
176
176
  - - "~>"
177
177
  - !ruby/object:Gem::Version
178
178
  version: '3.0'
179
179
  - !ruby/object:Gem::Dependency
180
+ name: rt_rubocop_defaults
180
181
  requirement: !ruby/object:Gem::Requirement
181
182
  requirements:
182
183
  - - "~>"
183
184
  - !ruby/object:Gem::Version
184
185
  version: '1.2'
185
- name: rt_rubocop_defaults
186
- prerelease: false
187
186
  type: :development
187
+ prerelease: false
188
188
  version_requirements: !ruby/object:Gem::Requirement
189
189
  requirements:
190
190
  - - "~>"
191
191
  - !ruby/object:Gem::Version
192
192
  version: '1.2'
193
193
  - !ruby/object:Gem::Dependency
194
+ name: rubocop
194
195
  requirement: !ruby/object:Gem::Requirement
195
196
  requirements:
196
197
  - - "~>"
197
198
  - !ruby/object:Gem::Version
198
199
  version: '0.77'
199
- name: rubocop
200
- prerelease: false
201
200
  type: :development
201
+ prerelease: false
202
202
  version_requirements: !ruby/object:Gem::Requirement
203
203
  requirements:
204
204
  - - "~>"
205
205
  - !ruby/object:Gem::Version
206
206
  version: '0.77'
207
207
  - !ruby/object:Gem::Dependency
208
+ name: rubocop-rspec
208
209
  requirement: !ruby/object:Gem::Requirement
209
210
  requirements:
210
211
  - - "~>"
211
212
  - !ruby/object:Gem::Version
212
213
  version: '1.30'
213
- name: rubocop-rspec
214
- prerelease: false
215
214
  type: :development
215
+ prerelease: false
216
216
  version_requirements: !ruby/object:Gem::Requirement
217
217
  requirements:
218
218
  - - "~>"
219
219
  - !ruby/object:Gem::Version
220
220
  version: '1.30'
221
221
  - !ruby/object:Gem::Dependency
222
+ name: rubocop_runner
222
223
  requirement: !ruby/object:Gem::Requirement
223
224
  requirements:
224
225
  - - "~>"
225
226
  - !ruby/object:Gem::Version
226
227
  version: '2.1'
227
- name: rubocop_runner
228
- prerelease: false
229
228
  type: :development
229
+ prerelease: false
230
230
  version_requirements: !ruby/object:Gem::Requirement
231
231
  requirements:
232
232
  - - "~>"
233
233
  - !ruby/object:Gem::Version
234
234
  version: '2.1'
235
235
  - !ruby/object:Gem::Dependency
236
+ name: simplecov
236
237
  requirement: !ruby/object:Gem::Requirement
237
238
  requirements:
238
239
  - - "~>"
239
240
  - !ruby/object:Gem::Version
240
241
  version: '0.14'
241
- name: simplecov
242
- prerelease: false
243
242
  type: :development
243
+ prerelease: false
244
244
  version_requirements: !ruby/object:Gem::Requirement
245
245
  requirements:
246
246
  - - "~>"
247
247
  - !ruby/object:Gem::Version
248
248
  version: '0.14'
249
249
  - !ruby/object:Gem::Dependency
250
+ name: sinatra
250
251
  requirement: !ruby/object:Gem::Requirement
251
252
  requirements:
252
253
  - - "~>"
253
254
  - !ruby/object:Gem::Version
254
255
  version: '2.0'
255
- name: sinatra
256
- prerelease: false
257
256
  type: :development
257
+ prerelease: false
258
258
  version_requirements: !ruby/object:Gem::Requirement
259
259
  requirements:
260
260
  - - "~>"
261
261
  - !ruby/object:Gem::Version
262
262
  version: '2.0'
263
263
  - !ruby/object:Gem::Dependency
264
+ name: timecop
264
265
  requirement: !ruby/object:Gem::Requirement
265
266
  requirements:
266
267
  - - "~>"
267
268
  - !ruby/object:Gem::Version
268
269
  version: '0.9'
269
- name: timecop
270
- prerelease: false
271
270
  type: :development
271
+ prerelease: false
272
272
  version_requirements: !ruby/object:Gem::Requirement
273
273
  requirements:
274
274
  - - "~>"
275
275
  - !ruby/object:Gem::Version
276
276
  version: '0.9'
277
277
  - !ruby/object:Gem::Dependency
278
+ name: sidekiq
278
279
  requirement: !ruby/object:Gem::Requirement
279
280
  requirements:
280
281
  - - ">="
@@ -283,9 +284,8 @@ dependencies:
283
284
  - - "<"
284
285
  - !ruby/object:Gem::Version
285
286
  version: '7'
286
- name: sidekiq
287
- prerelease: false
288
287
  type: :runtime
288
+ prerelease: false
289
289
  version_requirements: !ruby/object:Gem::Requirement
290
290
  requirements:
291
291
  - - ">="
@@ -307,6 +307,7 @@ files:
307
307
  - ".codeclimate.yml"
308
308
  - ".gitignore"
309
309
  - ".rubocop.yml"
310
+ - ".rubocop_codeclimate.yml"
310
311
  - ".rubocop_todo.yml"
311
312
  - ".travis.yml"
312
313
  - Demo_Filter.png
@@ -336,6 +337,8 @@ files:
336
337
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_all_failures_and_errors/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
337
338
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt
338
339
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
340
+ - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt
341
+ - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
339
342
  - spec/sidekiq/undertaker/bucket_spec.rb
340
343
  - spec/sidekiq/undertaker/dead_jobs_spec.rb
341
344
  - spec/sidekiq/undertaker/job_distributor_spec.rb
@@ -354,7 +357,7 @@ metadata:
354
357
  source_code_uri: https://github.com/ThomasKoppensteiner/sidekiq-undertaker
355
358
  bug_tracker_uri: https://github.com/ThomasKoppensteiner/sidekiq-undertaker/issues
356
359
  build_status_uri: https://travis-ci.org/ThomasKoppensteiner/sidekiq-undertaker
357
- post_install_message:
360
+ post_install_message:
358
361
  rdoc_options: []
359
362
  require_paths:
360
363
  - lib
@@ -370,9 +373,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
370
373
  - !ruby/object:Gem::Version
371
374
  version: '0'
372
375
  requirements: []
373
- rubyforge_project:
374
- rubygems_version: 2.7.6
375
- signing_key:
376
+ rubygems_version: 3.1.2
377
+ signing_key:
376
378
  specification_version: 4
377
379
  summary: Sidekiq::Undertaker allows exploring, reviving or burying dead jobs
378
380
  test_files:
@@ -386,6 +388,8 @@ test_files:
386
388
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_all_failures_and_errors/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
387
389
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt
388
390
  - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
391
+ - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv5.approved.txt
392
+ - spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt
389
393
  - spec/sidekiq/undertaker/bucket_spec.rb
390
394
  - spec/sidekiq/undertaker/dead_jobs_spec.rb
391
395
  - spec/sidekiq/undertaker/job_distributor_spec.rb