sidekiq-logstash 0.3.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 25dbb440e6e8695797cc7857512139580ea799dc
-  data.tar.gz: adc96a196faa34ee2b45822bca2cb6328fe1061c
+SHA256:
+  metadata.gz: 2a99b4b463ed0d2801d2a32447a29767572a979675d6fca72781fbf0c1971fd9
+  data.tar.gz: dfbfffd67d75c8e0aff617ff8da1a219b264e72e84431632131ec346d4d0dcbb
 SHA512:
-  metadata.gz: f10f38029bd0168fe3306fba03d3d7b6cce126a78333e7ce8e791194332988979a37d07d4bf5ea00c65e606f233e153cfc91af2702b26d2810adbd679e57dd4e
-  data.tar.gz: 52fcd3c3e046e03b7e1c464d1eff487a916f06ebfd51fb435f9539650a2d690241ff8548136385bbac93f1e5f345ff0a260d4ba1072fc04d7515011538bb700c
+  metadata.gz: 38a2a810c8af2eb4afda4f2a340ee39680c4c768d6a9714d897950d23630c189063bf84001f60c97a57ca94c5f0ab03a2464fd9ea8d50803321ac3cfdae86d8d
+  data.tar.gz: 7c4338444e79978f20322d8491e8f4b1b04ff95c643f89fd8d51b92b8379e5b39265190f0b0b0c201ccc6081e89317eec8cedbc9f9fdbe72f505a23e8d705433

data/.github/workflows/ci.yaml

@@ -0,0 +1,42 @@
+name: CI
+
+on:
+  pull_request:
+
+  push:
+    branches: [master]
+
+env:
+  GIT_COMMIT_SHA: ${{ github.sha }}
+  GIT_BRANCH: ${{ github.ref }}
+
+jobs:
+  linting:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+      - name: Install dependencies
+        run: bundle install
+      - name: Run rubocop
+        run: bundle exec rubocop --format progress
+  build:
+    needs: [linting]
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.5, 2.6, 2.7]
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/.github/workflows/publish.yml

@@ -0,0 +1,29 @@
+name: Publish
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build:
+    name: Publish to Rubygems
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up Ruby 2.7
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+
+      - name: Publish to RubyGems
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 0600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+          gem build sidekiq-logstash.gemspec
+          gem push sidekiq-logstash-*.gem
+        env:
+          GEM_HOST_API_KEY: ${{ secrets.RUBYGEMS_AUTH_TOKEN }}

data/.rubocop.yml

@@ -0,0 +1,22 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  TargetRubyVersion: 2.3
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*.rb
+
+Metrics/LineLength:
+  Max: 120
+  Exclude:
+    - spec/**/*.rb
+
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'

data/.rubocop_todo.yml

@@ -0,0 +1,41 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-04-20 13:23:53 +0200 using RuboCop version 0.67.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/sidekiq/logstash/configuration.rb'
+
+# Offense count: 4
+Metrics/AbcSize:
+  Max: 31
+
+# Offense count: 1
+Metrics/CyclomaticComplexity:
+  Max: 13
+
+# Offense count: 6
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 28
+
+# Offense count: 1
+Metrics/PerceivedComplexity:
+  Max: 14
+
+# Offense count: 7
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/sidekiq/logging/argument_filter.rb'
+    - 'lib/sidekiq/logging/logstash_formatter.rb'
+    - 'lib/sidekiq/logging/shared.rb'
+    - 'lib/sidekiq/logstash.rb'
+    - 'lib/sidekiq/logstash/configuration.rb'
+    - 'lib/sidekiq/logstash_job_logger.rb'
+    - 'lib/sidekiq/middleware/server/logstash_logging.rb'

data/.ruby-version

@@ -1 +1 @@
-2.3.0
+2.6.6

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in sidekiq-logstash.gemspec

data/README.md

@@ -68,6 +68,11 @@ Sidekiq::Logstash.configure do |config|
   # it works just like rails params filtering (http://guides.rubyonrails.org/action_controller_overview.html#parameters-filtering)
   config.filter_args << 'foo'
   
+  # by default, the "job started" logs are omitted from the logs
+  # to have one-line logs for each log (following Lograge), but you can
+  # enable job start logs by setting the following flag:
+  config.job_start_log = true
+  
   # custom_option is a Proc that will be called before logging the payload, allowing you to add fields to it
   config.custom_options = lambda do |payload|
     payload['my_custom_field'] = 'my_custom_value'

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'sidekiq/logstash'

data/bin/test_console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'sidekiq/logstash'

data/gemfiles/sidekiq3.gemfile

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
+
+gem 'sidekiq', '~> 3.0'
+
+gemspec path: '../'

data/gemfiles/sidekiq4.gemfile

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'sidekiq', '~> 4.0'
 
-gemspec path: '../'
+gemspec path: '../'

data/gemfiles/sidekiq5.gemfile

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'sidekiq', '~> 5.0'
 
-gemspec path: '../'
+gemspec path: '../'

data/lib/sidekiq/logging/argument_filter.rb

@@ -1,15 +1,20 @@
+# frozen_string_literal: true
+
 # This implementation is taken directly from https://github.com/rails/rails/blob/52ce6ece8c8f74064bb64e0a0b1ddd83092718e1/actionpack/lib/action_dispatch/http/parameter_filter.rb
 # Adding actionpack to the gem dependencies would have been too heavy, so here is just what we need.
-
 module Sidekiq
   module Logging
+    # Class that allows to filter-out sensible arguments.
     class ArgumentFilter
-      FILTERED = '[FILTERED]'.freeze
+      # String used to replace sensible arguments.
+      FILTERED = '[FILTERED]'
 
       def initialize(filters = [])
         @filters = filters
       end
 
+      # Filters argument by using the filters provided upon initialization.
+      # @param args [Array] the list of arguments.
       def filter(args)
         compiled_filter.call(args)
       end
@@ -22,8 +27,11 @@ module Sidekiq
 
       class CompiledFilter # :nodoc:
         def self.compile(filters)
-          return lambda { |args| args.dup } if filters.empty?
-          strings, regexps, blocks = [], [], []
+          return ->(args) { args.dup } if filters.empty?
+
+          strings = []
+          regexps = []
+          blocks = []
           filters.each do |item|
             case item
             when Proc
@@ -34,10 +42,10 @@ module Sidekiq
               strings << Regexp.escape(item.to_s)
             end
           end
-          deep_regexps, regexps = regexps.partition { |r| r.to_s.include?("\\.".freeze) }
-          deep_strings, strings = strings.partition { |s| s.include?("\\.".freeze) }
-          regexps << Regexp.new(strings.join('|'.freeze), true) unless strings.empty?
-          deep_regexps << Regexp.new(deep_strings.join('|'.freeze), true) unless deep_strings.empty?
+          deep_regexps, regexps = regexps.partition { |r| r.to_s.include?('\\.') }
+          deep_strings, strings = strings.partition { |s| s.include?('\\.') }
+          regexps << Regexp.new(strings.join('|'), true) unless strings.empty?
+          deep_regexps << Regexp.new(deep_strings.join('|'), true) unless deep_strings.empty?
           new regexps, deep_regexps, blocks
         end
 
@@ -62,8 +70,16 @@ module Sidekiq
             elsif value.is_a?(Array)
               value = value.map { |v| v.is_a?(Hash) ? call(v, parents) : v }
             elsif blocks.any?
-              key = key.dup rescue key
-              value = value.dup rescue value
+              key = begin
+                      key.dup
+                    rescue StandardError
+                      key
+                    end
+              value = begin
+                        value.dup
+                      rescue StandardError
+                        value
+                      end
               blocks.each { |b| b.call(key, value) }
             end
             parents.pop if deep_regexps
@@ -74,4 +90,4 @@ module Sidekiq
       end
     end
   end
-end
+end

data/lib/sidekiq/logging/logstash_formatter.rb

@@ -1,25 +1,33 @@
+# frozen_string_literal: true
+
 require 'logstash-event'
 
 module Sidekiq
   module Logging
+    # Class that takes a log payload and format it to be Logstash-compatible.
     class LogstashFormatter
-      def call(severity, time, progname, data)
+      def call(severity, _time, _progname, data)
+        json_data = { severity: severity }
+
         if data.is_a? Hash
-          json_data = data
+          json_data.merge!(data)
         else
-          json_data = {
-              severity: severity,
-              message:  data
-          }
+          json_data[:message] = data
         end
 
         # Merge custom_options to provide customization
-        custom_options.call(json_data) if custom_options rescue nil
+        begin
+          custom_options&.call(json_data)
+        rescue StandardError
+          nil
+        end
         event = LogStash::Event.new(json_data)
 
         "#{event.to_json}\n"
       end
 
+      private
+
       def custom_options
         Sidekiq::Logstash.configuration.custom_options
       end

data/lib/sidekiq/logging/shared.rb

@@ -1,62 +1,140 @@
+# frozen_string_literal: true
+
 module Sidekiq
   module Logging
+    # Shared module with all the logics used by job loggers.
     module Shared
-      def log_job(payload, started_at, exc = nil)
+      ENCRYPTED = '[ENCRYPTED]'
+
+      def log_job(job)
+        started_at = Time.now.utc
+        log_start = log_job_start(job)
+        Sidekiq.logger.info log_start if log_start
+        yield if block_given?
+        Sidekiq.logger.info log_job_exec(job, started_at)
+      rescue StandardError => e
+        begin
+          Sidekiq.logger.warn log_job_exception(job, started_at, e)
+        rescue StandardError => ex
+          log_standard_error(job, e, ex)
+        end
+        raise
+      end
+
+      def log_job_start(job)
+        return unless Sidekiq::Logstash.configuration.job_start_log
+        # Skips start logs for retrying jobs
+        return if job['failed_at']
+
+        payload = setup_payload(job)
+        payload['job_status'] = 'started'
+        payload['message'] += ': started'
+        process_payload(payload)
+      end
+
+      def log_job_exec(job, started_at)
+        payload = setup_payload(job)
+        payload['duration'] = elapsed(started_at)
+
+        payload['message'] += ": done: #{payload['duration']} sec"
+        payload['job_status'] = 'done'
+        payload['completed_at'] = Time.now.utc
+
+        process_payload(payload)
+      end
+
+      def log_job_exception(job, started_at, exc)
+        payload = setup_payload(job)
+        payload['duration'] = elapsed(started_at)
+
+        payload['message'] += ": fail: #{payload['duration']} sec"
+        payload['job_status'] = 'fail'
+        payload['error_message'] = exc.message
+        payload['error'] = exc.class
+        payload['error_backtrace'] = %('#{exc.backtrace.join("\n")}')
+
+        process_payload(payload)
+      end
+
+      private
+
+      def setup_payload(job)
         # Create a copy of the payload using JSON
         # This should always be possible since Sidekiq store it in Redis
-        payload = JSON.parse(JSON.unparse(payload))
+        payload = JSON.parse(JSON.unparse(job))
 
         # Convert timestamps into Time instances
-        %w( created_at enqueued_at retried_at failed_at completed_at ).each do |key|
+        %w[created_at enqueued_at retried_at failed_at completed_at].each do |key|
           payload[key] = parse_time(payload[key]) if payload[key]
         end
 
-        # Add process id params
-        payload['pid']      = ::Process.pid
-        payload['duration'] = elapsed(started_at)
+        # Sets the initial message
+        payload['message'] = "#{payload['class']} JID-#{payload['jid']}"
 
-        message = "#{payload['class']} JID-#{payload['jid']}"
+        # Add process id params
+        payload['pid'] = ::Process.pid
 
-        if exc
-          payload['message']         = "#{message}: fail: #{payload['duration']} sec"
-          payload['job_status']      = 'fail'
-          payload['error_message']   = exc.message
-          payload['error']           = exc.class
-          payload['error_backtrace'] = %('#{exc.backtrace.join("\n")}')
-        else
-          payload['message']      = "#{message}: done: #{payload['duration']} sec"
-          payload['job_status']   = 'done'
-          payload['completed_at'] = Time.now.utc
-        end
+        payload
+      end
 
+      def process_payload(payload)
         # Filter sensitive parameters
         unless filter_args.empty?
-          args_filter     = Sidekiq::Logging::ArgumentFilter.new(filter_args)
-          payload['args'] = args_filter.filter({ args: payload['args'] })[:args]
+          args_filter = Sidekiq::Logging::ArgumentFilter.new(filter_args)
+          payload['args'] = args_filter.filter(args: payload['args'])[:args]
         end
 
+        # If encrypt is true, the last arg is encrypted so hide it
+        payload['args'][-1] = ENCRYPTED if payload['encrypt']
+
         # Needs to map all args to strings for ElasticSearch compatibility
-        payload['args'].map!(&:to_s)
+        deep_stringify!(payload['args'])
+
+        # Needs to map all unique_args to strings for ElasticSearch
+        # compatibility in case sidekiq-unique-jobs is used
+        deep_stringify!(payload['unique_args'])
+
+        if payload['retry'].is_a?(Integer)
+          payload['max_retries'] = payload['retry']
+          payload['retry'] = true
+        end
 
         payload
       end
 
+      def log_standard_error(job, job_exc, log_exc)
+        Sidekiq.logger.error 'Error logging the job execution!'
+        Sidekiq.logger.error "Job: #{job}"
+        Sidekiq.logger.error "Job Exception: #{job_exc}"
+        Sidekiq.logger.error "Log Exception: #{log_exc}"
+      end
+
       def elapsed(start)
         (Time.now.utc - start).round(3)
       end
 
       def parse_time(timestamp)
         return timestamp if timestamp.is_a? Time
-        timestamp.is_a?(Float) ?
-            Time.at(timestamp).utc :
-            Time.parse(timestamp)
-      rescue
+
+        timestamp.is_a?(Float) ? Time.at(timestamp).utc : Time.parse(timestamp)
+      rescue StandardError
         timestamp
       end
 
       def filter_args
         Sidekiq::Logstash.configuration.filter_args
       end
+
+      def deep_stringify!(args)
+        case args
+        when Hash
+          Hash[args.map { |key, value| [deep_stringify!(key), deep_stringify!(value)] }]
+        when Array
+          args.map! { |val| deep_stringify!(val) }
+        else
+          args.to_s
+        end
+      end
     end
   end
 end

data/lib/sidekiq/logstash.rb

@@ -1,11 +1,16 @@
+# frozen_string_literal: true
+
 require 'sidekiq/logstash/configuration'
 require 'sidekiq/logstash/version'
-require 'sidekiq/middleware/server/logstah_logging'
+require 'sidekiq/middleware/server/logstash_logging'
 require 'sidekiq/logging/logstash_formatter'
 require 'sidekiq/logging/argument_filter'
 require 'sidekiq/logstash_job_logger'
 
 module Sidekiq
+  # Main level module for Sidekiq::Logstash.
+  # Provides integration between Sidekiq and Logstash by changing the way
+  # Sidekiq jobs are logged.
   module Logstash
     def self.configuration
       @configuration ||= Configuration.new
@@ -15,7 +20,7 @@ module Sidekiq
       yield(configuration)
     end
 
-    def self.setup(opts = {})
+    def self.setup(_opts = {})
       # Calls Sidekiq.configure_server to inject logics
       Sidekiq.configure_server do |config|
         # Remove default Sidekiq error_handler that logs errors

data/lib/sidekiq/logstash/configuration.rb

@@ -1,17 +1,22 @@
+# frozen_string_literal: true
+
 module Sidekiq
   module Logstash
+    # Class that allows to configure the gem behaviour.
     class Configuration
-      attr_accessor :custom_options, :filter_args
+      attr_accessor :custom_options, :filter_args, :job_start_log
 
       def initialize
         @filter_args = []
+        @job_start_log = false
       end
 
       # Added to ensure custom_options is a Proc
       def custom_options=(proc)
         raise ArgumentError, 'Argument must be a Proc.' unless proc.is_a?(Proc)
+
         @custom_options = proc
       end
     end
   end
-end
+end

data/lib/sidekiq/logstash/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Sidekiq
   module Logstash
-    VERSION = '0.3.0'
+    VERSION = '1.2.1'
   end
 end

data/lib/sidekiq/logstash_job_logger.rb

@@ -1,23 +1,14 @@
+# frozen_string_literal: true
+
 require 'sidekiq/logging/shared'
 
 module Sidekiq
+  # Class used to replace Sidekiq 5 job logger.
   class LogstashJobLogger
     include Sidekiq::Logging::Shared
 
-    def call(job, _queue)
-      started_at = Time.now.utc
-      yield
-      Sidekiq.logger.info log_job(job, started_at)
-    rescue => exc
-      begin
-        Sidekiq.logger.warn log_job(job, started_at, exc)
-      rescue => ex
-        Sidekiq.logger.error 'Error logging the job execution!'
-        Sidekiq.logger.error "Job: #{job}"
-        Sidekiq.logger.error "Job Exception: #{exc}"
-        Sidekiq.logger.error "Log Exception: #{ex}"
-      end
-      raise
+    def call(job, _queue, &block)
+      log_job(job, &block)
     end
   end
-end
+end

data/lib/sidekiq/middleware/server/logstash_logging.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'sidekiq/logging/shared'
+
+module Sidekiq
+  module Middleware
+    module Server
+      # Class used to replace Sidekiq 4 job logger.
+      class LogstashLogging
+        include Sidekiq::Logging::Shared
+
+        def call(_, job, _, &block)
+          log_job(job, &block)
+        end
+      end
+    end
+  end
+end

data/sidekiq-logstash.gemspec

@@ -1,31 +1,35 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'sidekiq/logstash/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'sidekiq-logstash'
-  spec.version       = Sidekiq::Logstash::VERSION
-  spec.authors       = ['Mattia Giuffrida']
-  spec.email         = ['giuffrida.mattia@gmail.com']
+  spec.name = 'sidekiq-logstash'
+  spec.version = Sidekiq::Logstash::VERSION
+  spec.authors = ['Mattia Giuffrida']
+  spec.email = ['giuffrida.mattia@gmail.com']
 
-  spec.summary       = %q{Logstash plugin for Sidekiq}
-  spec.description   = <<-DESC
-Sidekiq::Logstash turns your Sidekiq log into an organised, aggregated, JSON-syntax log ready to be sent to a logstash server.
-DESC
-  spec.homepage      = 'https://github.com/iMacTia/sidekiq-logstash'
-  spec.license       = 'MIT'
+  spec.summary = 'Logstash plugin for Sidekiq'
+  spec.description = <<~DESC
+    Sidekiq::Logstash turns your Sidekiq log into an organised, aggregated, JSON-syntax log ready to be sent to a logstash server.
+  DESC
+  spec.homepage = 'https://github.com/iMacTia/sidekiq-logstash'
+  spec.license = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_dependency 'logstash-event', '~> 1.2'
-  spec.add_runtime_dependency 'sidekiq', '>= 4.0' , '<6'
+  spec.add_runtime_dependency 'sidekiq', '>= 3.0', '<6'
+  spec.required_ruby_version = '>= 2.3.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.add_development_dependency 'factory_girl', '~> 4.0'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'factory_girl', '~> 4.0'
+  spec.add_development_dependency 'rspec-json_expectations', '~> 2.1.0'
+  spec.add_development_dependency 'rubocop', '~> 0.67.2'
+  spec.add_development_dependency 'rubocop-performance'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-logstash
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Mattia Giuffrida
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-12 00:00:00.000000000 Z
+date: 2021-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-event
@@ -30,7 +30,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '6'
@@ -40,24 +40,24 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '6'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -87,40 +87,72 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: rspec-json_expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.67.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.67.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'Sidekiq::Logstash turns your Sidekiq log into an organised, aggregated,
   JSON-syntax log ready to be sent to a logstash server.
 
-'
+  '
 email:
 - giuffrida.mattia@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yaml"
+- ".github/workflows/publish.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
 - bin/console
 - bin/setup
 - bin/test_console
+- gemfiles/sidekiq3.gemfile
 - gemfiles/sidekiq4.gemfile
 - gemfiles/sidekiq5.gemfile
 - lib/sidekiq/logging/argument_filter.rb
@@ -130,7 +162,7 @@ files:
 - lib/sidekiq/logstash/configuration.rb
 - lib/sidekiq/logstash/version.rb
 - lib/sidekiq/logstash_job_logger.rb
-- lib/sidekiq/middleware/server/logstah_logging.rb
+- lib/sidekiq/middleware/server/logstash_logging.rb
 - sidekiq-logstash.gemspec
 homepage: https://github.com/iMacTia/sidekiq-logstash
 licenses:
@@ -144,15 +176,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Logstash plugin for Sidekiq

data/.travis.yml

@@ -1,10 +0,0 @@
-language: ruby
-rvm:
-  - 2.2.2
-  - 2.3.0
-  - 2.4.0
-before_install: gem install bundler -v 1.11.2
-
-gemfile:
-  - gemfiles/sidekiq4.gemfile
-  - gemfiles/sidekiq5.gemfile

data/lib/sidekiq/middleware/server/logstah_logging.rb

@@ -1,27 +0,0 @@
-require 'sidekiq/logging/shared'
-
-module Sidekiq
-  module Middleware
-    module Server
-      class LogstashLogging
-        include Sidekiq::Logging::Shared
-
-        def call(_, job, _)
-          started_at = Time.now.utc
-          yield
-          Sidekiq.logger.info log_job(job, started_at)
-        rescue => exc
-          begin
-            Sidekiq.logger.warn log_job(job, started_at, exc)
-          rescue => ex
-            Sidekiq.logger.error 'Error logging the job execution!'
-            Sidekiq.logger.error "Job: #{job}"
-            Sidekiq.logger.error "Job Exception: #{exc}"
-            Sidekiq.logger.error "Log Exception: #{ex}"
-          end
-          raise
-        end
-      end
-    end
-  end
-end