sidekiq-failures 1.0.0 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e856dd820aab39c74c1206b00aecebfaa2b1532d
-  data.tar.gz: 0c639951b4f5f9b6e0621e59a13fd839c67c7400
+SHA256:
+  metadata.gz: 71e370c4485d8ecc481914afd5d8a489c9f2743c1749975dceb536977607230a
+  data.tar.gz: 1a8e989912c378459e478eb9f29c0dd1d53128c126cc135c2bf597375e26ed84
 SHA512:
-  metadata.gz: 99093da61f43fa228f73cf872e3e2a8d38a38745acdf7ca0bddca02de9e36cce1092f8ab3cb0a9f0cc20823a37ac21743fecedc2d17c1a57194fa9c9670e951e
-  data.tar.gz: b04bf490ec4caa513fee332c21fb317bed2cf41192b0da42199aa79f5d7ec19c0713a4fde3047b091c4650efd7a4db059de452ac40f0e1f0aff191ac47d1ede2
+  metadata.gz: 49f99dbee68555a41e53d615e27afa48f5852d0f887fd96891864c89fd86f5d72fe552d9eefa5b22f860502d6bed321c38f5a4fd28ea5c4f1dfeea703c9d17eb
+  data.tar.gz: f59b94960937b9f7d3482c79f79b905015fac87df83bcde5db946023383658138d7226003431a4ece758780f0ad06e7a1b2785258917d19fc5a9278fe6583267

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

data/.github/workflows/ci.yml

@@ -0,0 +1,37 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [2.6, 2.7, '3.0', 3.1]
+        sidekiq: [4.2, 5.2, 6.2]
+    services:
+      redis:
+        image: redis
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 6379:6379
+    env:
+      SIDEKIQ_VERSION: ~> ${{ matrix.sidekiq }}
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        bundler-cache: true # 'bundle install' and cache gems
+        ruby-version: ${{ matrix.ruby }}
+    - name: Run tests
+      run: bundle exec rake

data/.gitignore

@@ -17,4 +17,4 @@ tmp
 Gemfile.lock
 .ruby-version
 .ruby-gemset
-
+.tool-versions

data/CHANGELOG.md

@@ -1,5 +1,23 @@
 ## Unreleased
 
+## 1.0.4
+
+  * Sanitize failure text on the failure details page (#144 @mcasper)
+
+## 1.0.3
+
+  * Expand failure descriptions with pure JS (#141 @icyleaf)
+
+## 1.0.2
+
+  * Pass now required argument to Sidekiq's JobRetry.new (#140 @mcasper)
+
+## 1.0.1
+
+  * Add license config to the gemspec (#115 @reiz)
+  * Guard against failure error_message being `nil` (#122 @mcasper)
+  * Fix filtering failures with 0 results on Sidekiq Pro (#125 @substars)
+
 ## 1.0.0
 
   * WebUI improvements (@bbtfr)

data/Gemfile

@@ -4,3 +4,9 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'sidekiq', ENV['SIDEKIQ_VERSION'] if ENV['SIDEKIQ_VERSION']
+
+# to test Pro-specific functionality, set SIDEKIQ_PRO_CREDS on `bundle install`
+# and SIDEKIQ_PRO_VERSION on `bundle install` and `rake test`
+source "https://#{ENV['SIDEKIQ_PRO_CREDS']}@enterprise.contribsys.com/" do    
+    gem 'sidekiq-pro', ENV['SIDEKIQ_PRO_VERSION'] if ENV['SIDEKIQ_PRO_VERSION']
+end if ENV['SIDEKIQ_PRO_VERSION']

data/README.md

@@ -1,4 +1,4 @@
-# Sidekiq::Failures [![Build Status](https://secure.travis-ci.org/mhfs/sidekiq-failures.png)](http://travis-ci.org/mhfs/sidekiq-failures)
+# Sidekiq::Failures ![Build Status](https://github.com/mhfs/sidekiq-failures/workflows/CI/badge.svg)
 
 Keeps track of Sidekiq failed jobs and adds a tab to the Web UI to let you browse
 them. Makes use of Sidekiq's custom tabs and middleware chain.
@@ -20,6 +20,8 @@ gem 'sidekiq-failures'
 Simply having the gem in your Gemfile is enough to get you started. Your failed
 jobs will be visible via a Failures tab in the Web UI.
 
+If you have not previously used the Web UI, it is a part of the Sidekiq gem. [See Sidekiq's docs about Web UI here.](https://github.com/mperham/sidekiq/wiki/Monitoring#web-ui)
+
 ## Configuring
 
 ### Maximum Tracked Failures

data/lib/sidekiq/failures/locales/zh-cn.yml

@@ -0,0 +1,5 @@
+zh-cn:
+  FailedJobs: 失败的任务
+  FailedAt: 失败时间
+  ResetCounter: 重置计数器
+  NoFailedJobsFound: 没有发现失败的任务

data/lib/sidekiq/failures/middleware.rb

@@ -81,7 +81,7 @@ module Sidekiq
 
       def retry_middleware
         @retry_middleware ||=
-          Sidekiq::Failures.retry_middleware_class.new
+          Sidekiq::Failures.retry_middleware_class.new(@config || {})
       end
 
       def default_max_retries

data/lib/sidekiq/failures/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Failures
-    VERSION = "1.0.0"
+    VERSION = "1.0.4"
   end
 end

data/lib/sidekiq/failures/views/failure.erb

@@ -6,12 +6,12 @@
     <tr>
       <th><%= t('ErrorClass') %></th>
       <td>
-        <code><%= @failure['error_class'] %></code>
+        <code><%= h @failure['error_class'] %></code>
       </td>
     </tr>
     <tr>
       <th><%= t('ErrorMessage') %></th>
-      <td><%= @failure['error_message'] %></td>
+      <td><%= h @failure['error_message'] %></td>
     </tr>
     <% if !@failure['error_backtrace'].nil? %>
       <tr>

data/lib/sidekiq/failures/views/failures.erb

@@ -2,7 +2,7 @@
   <div class="col-sm-5">
     <h3><%= t('FailedJobs') %></h3>
   </div>
-  <% if @failures.size > 0 && @total_size > @count %>
+  <% if @failures.count > 0 && @total_size > @count %>
     <div class="col-sm-4">
       <%= erb :_paging, :locals => { :url => "#{root_path}failures" } %>
     </div>
@@ -10,7 +10,7 @@
   <%= filtering('failures') if respond_to?(:filtering) %>
 </header>
 
-<% if @failures.size > 0 %>
+<% if @failures.count > 0 %>
   <form action="<%= root_path %>failures" method="post">
     <%= csrf_tag if respond_to?(:csrf_tag) %>
     <table class="table table-striped table-bordered table-white">
@@ -35,7 +35,9 @@
               <input type='checkbox' name='key[]' value='<%= job_params(entry.item, entry.score) %>' />
             </label>
           </td>
-          <td><a href="<%= root_path %>failures/<%= job_params(entry.item, entry.score) %>"><%= safe_relative_time(entry['failed_at']) %></a></td>
+          <td>
+            <a href="<%= root_path %>failures/<%= job_params(entry.item, entry.score) %>"><%= safe_relative_time(entry['failed_at']) %></a>
+          </td>
           <td>
             <a href="<%= root_path %>queues/<%= entry.queue %>"><%= entry.queue %></a>
           </td>
@@ -44,8 +46,8 @@
             <div class="args"><%= display_args(entry.respond_to?(:display_args) ? entry.display_args : entry.args) %></div>
           </td>
           <td style="overflow: auto; padding: 10px;">
-            <a class="backtrace" href="#" onclick="$(this).next().toggle(); return false">
-              <%= h entry['error_class'] %>: <%= h entry['error_message'].size > 500 ? entry['error_message'][0..500] + '...' : entry['error_message'] %>
+            <a class="backtrace" href="javascript:void(0)", onclick="toggle_error_backtrace(this)">
+              <%= h entry['error_class'] %>: <%= h entry['error_message'].to_s.size > 500 ? entry['error_message'][0..500] + '...' : entry['error_message'] %>
             </a>
             <pre style="display: none; background: none; border: 0; width: 100%; max-height: 30em; font-size: 0.8em; white-space: nowrap; overflow: auto;">
               <%= entry['error_backtrace'].join("<br />") if entry['error_backtrace'] %>
@@ -70,16 +72,34 @@
     <input class="btn btn-danger btn-xs pull-right" type="submit" name="retry" value="<%= t('RetryAll') %>" data-confirm="<%= t('AreYouSure') %>" />
   </form>
 
-  <% if @failures.size > 0 && @total_size > @count %>
+  <% if @failures.count > 0 && @total_size > @count %>
     <div class="col-sm-4">
       <%= erb :_paging, :locals => { :url => "#{root_path}failures" } %>
     </div>
   <% end %>
 
+  <script>
+  function toggle_error_backtrace(e) {
+    let x = e.nextElementSibling;
+    if (x.style.display === "none") {
+      x.style.display = "block";
+    } else {
+      x.style.display = "none";
+    }
+  }
+  </script>
+
+  <style type="text/css">
+  @media only screen and (prefers-color-scheme: dark) {
+    pre {
+      color: white
+    }
+  }
+  </style>
 <% else %>
   <div class="alert alert-success"><%= t('NoFailedJobsFound') %></div>
 <% end %>
 <form action="<%= root_path %>failures/all/reset" method="post">
   <%= csrf_tag if respond_to?(:csrf_tag) %>
-  <input class="btn btn-danger btn-xs pull-right" type="submit" name="reset" value="<%= t('Reset Counter') %>" data-confirm="<%= t('AreYouSure') %>" />
+  <input class="btn btn-danger btn-xs pull-right" type="submit" name="reset" value="<%= t('ResetCounter') %>" data-confirm="<%= t('AreYouSure') %>" />
 </form>

data/lib/sidekiq/failures/web_extension.rb

@@ -86,7 +86,7 @@ module Sidekiq
         app.post '/filter/failures' do
           @failures = Sidekiq::Failures::FailureSet.new.scan("*#{params[:substr]}*")
           @current_page = 1
-          @count = @total_size = @failures.size
+          @count = @total_size = @failures.count          
           render(:erb, File.read(File.join(view_path, "failures.erb")))
         end
       end

data/sidekiq-failures.gemspec

@@ -7,19 +7,26 @@ Gem::Specification.new do |gem|
   gem.description   = %q{Keep track of Sidekiq failed jobs}
   gem.summary       = %q{Keeps track of Sidekiq failed jobs and adds a tab to the Web UI to let you browse them. Makes use of Sidekiq's custom tabs and middleware chain.}
   gem.homepage      = "https://github.com/mhfs/sidekiq-failures/"
+  gem.license       = "MIT"
 
   gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "sidekiq-failures"
   gem.require_paths = ["lib"]
   gem.version       = Sidekiq::Failures::VERSION
 
   gem.add_dependency "sidekiq", ">= 4.0.0"
 
+  # Redis 4.X is incompatible with Ruby < 2.3, but the Ruby version constraint
+  # wasn't added until 4.1.2, meaning you can get an incompatible version of the
+  # redis gem when running Ruby 2.2 without this constraint.
+  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.3.0")
+    gem.add_dependency "redis", "< 4.0"
+  end
+
   gem.add_development_dependency "minitest"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "rack-test"
   gem.add_development_dependency "sprockets"
   gem.add_development_dependency "sinatra"
+  gem.add_development_dependency "pry"
 end

data/test/middleware_test.rb

@@ -1,19 +1,72 @@
 require "test_helper"
 
+class SidekiqPre6
+  def new_processor(boss)
+    num_options_calls.times { boss.expect(:options, {:queues => ['default'] }, []) }
+    ::Sidekiq::Processor.new(boss)
+  end
+
+  private
+
+  def num_options_calls
+    if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('5.0.3')
+      3
+    else
+      2
+    end
+  end
+end
+
+class SidekiqPre63
+  def new_processor(boss)
+    opts = {
+      queues: ['default'],
+    }
+    opts[:fetch] = Sidekiq::BasicFetch.new(opts)
+    ::Sidekiq::Processor.new(boss, opts)
+  end
+end
+
+class SidekiqPost63
+  def new_processor(boss)
+    config = Sidekiq
+    config[:queues] = ['default']
+    config[:fetch] = Sidekiq::BasicFetch.new(config)
+    config[:error_handlers] << Sidekiq.method(:default_error_handler)
+    ::Sidekiq::Processor.new(config) { |processor, reason = nil| }
+  end
+end
+
 module Sidekiq
   module Failures
     describe "Middleware" do
+      def new_provider
+        version = Gem::Version.new(Sidekiq::VERSION)
+        if version >= Gem::Version.new('6.4.0')
+          SidekiqPost63
+        elsif version >= Gem::Version.new('6.0')
+          SidekiqPre63
+        else
+          SidekiqPre6
+        end.new
+      end
+
       before do
         $invokes = 0
         @boss = MiniTest::Mock.new
-        2.times { @boss.expect(:options, {:queues => ['default'] }, []) }
-        @processor = ::Sidekiq::Processor.new(@boss)
+        @provider = new_provider
+        @processor = @provider.new_processor(@boss)
+
         Sidekiq.server_middleware {|chain| chain.add Sidekiq::Failures::Middleware }
         Sidekiq.redis = REDIS
         Sidekiq.redis { |c| c.flushdb }
         Sidekiq.instance_eval { @failures_default_mode = nil }
       end
 
+      after do
+        @boss.verify
+      end
+
       TestException = Class.new(Exception)
       ShutdownException = Class.new(Sidekiq::Shutdown)
 
@@ -42,11 +95,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -60,11 +108,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -78,12 +121,7 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-
         @processor.process(msg)
-        @boss.verify
 
         assert_equal 0, failures_count
         assert_equal 1, $invokes
@@ -94,11 +132,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -114,11 +147,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -133,11 +161,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -151,11 +174,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -169,11 +187,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -189,11 +202,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -209,11 +217,6 @@ module Sidekiq
 
         assert_equal 0, failures_count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        2.times { @boss.expect(:async, actor, []) }
-
         assert_raises TestException do
           @processor.process(msg)
         end
@@ -232,17 +235,13 @@ module Sidekiq
 
         3.times do
           boss = MiniTest::Mock.new
-          2.times { boss.expect(:options, {:queues => ['default'] }, []) }
-          processor = ::Sidekiq::Processor.new(boss)
-
-          actor = MiniTest::Mock.new
-          actor.expect(:processor_done, nil, [processor])
-          actor.expect(:real_thread, nil, [nil, nil])
-          2.times { boss.expect(:async, actor, []) }
+          processor = @provider.new_processor(boss)
 
           assert_raises TestException do
             processor.process(msg)
           end
+
+          boss.verify
         end
 
         assert_equal 2, failures_count
@@ -259,11 +258,6 @@ module Sidekiq
 
         assert_equal 0, Sidekiq::Failures.count
 
-        actor = MiniTest::Mock.new
-        actor.expect(:processor_done, nil, [@processor])
-        actor.expect(:real_thread, nil, [nil, nil])
-        @boss.expect(:async, actor, [])
-
         assert_raises TestException do
           @processor.process(msg)
         end

data/test/test_helper.rb

@@ -7,6 +7,7 @@ require "minitest/mock"
 require "rack/test"
 
 require "sidekiq"
+require "sidekiq-pro" if ENV['SIDEKIQ_PRO_VERSION']
 require "sidekiq-failures"
 require "sidekiq/processor"
 require "sidekiq/fetch"

data/test/web_extension_test.rb

@@ -5,7 +5,7 @@ module Sidekiq
   describe "WebExtension" do
     include Rack::Test::Methods
 
-    TOKEN = rand(2**128-1).freeze
+    TOKEN = SecureRandom.base64(32).freeze
 
     def app
       Sidekiq::Web
@@ -21,22 +21,22 @@ module Sidekiq
     it 'can display home with failures tab' do
       get '/'
 
-      last_response.status.must_equal 200
-      last_response.body.must_match(/Sidekiq/)
-      last_response.body.must_match(/Failures/)
+      _(last_response.status).must_equal 200
+      _(last_response.body).must_match(/Sidekiq/)
+      _(last_response.body).must_match(/Failures/)
     end
 
     it 'can display failures page without any failures' do
       get '/failures'
-      last_response.status.must_equal 200
-      last_response.body.must_match(/Failed Jobs/)
-      last_response.body.must_match(/No failed jobs found/)
+      _(last_response.status).must_equal 200
+      _(last_response.body).must_match(/Failed Jobs/)
+      _(last_response.body).must_match(/No failed jobs found/)
     end
 
     it 'has the reset counter form and action' do
       get '/failures'
-      last_response.body.must_match(/failures\/all\/reset/)
-      last_response.body.must_match(/Reset Counter/)
+      _(last_response.body).must_match(/failures\/all\/reset/)
+      _(last_response.body).must_match(/Reset Counter/)
     end
 
     describe 'when there are failures' do
@@ -46,97 +46,105 @@ module Sidekiq
       end
 
       it 'should be successful' do
-        last_response.status.must_equal 200
+        _(last_response.status).must_equal 200
       end
 
       it 'can display failures page with failures listed' do
-        last_response.body.must_match(/Failed Jobs/)
-        last_response.body.must_match(/HardWorker/)
-        last_response.body.must_match(/ArgumentError/)
-        last_response.body.wont_match(/No failed jobs found/)
+        _(last_response.body).must_match(/Failed Jobs/)
+        _(last_response.body).must_match(/HardWorker/)
+        _(last_response.body).must_match(/ArgumentError/)
+        _(last_response.body).wont_match(/No failed jobs found/)
       end
 
       it 'can reset counter' do
         assert_equal failed_count, "1"
 
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post '/failures/all/reset'
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures$/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures$/)
 
         get '/failures'
-        last_response.status.must_equal 200
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.status).must_equal 200
+        _(last_response.body).must_match(/HardWorker/)
 
         assert_equal failed_count, "0"
       end
 
       it 'has the delete all form and action' do
-        last_response.body.must_match(/failures\/all\/delete/)
-        last_response.body.must_match(/Delete All/)
+        _(last_response.body).must_match(/failures\/all\/delete/)
+        _(last_response.body).must_match(/Delete All/)
       end
 
       it 'can delete all failures' do
         assert_equal failed_count, "1"
 
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post '/failures/all/delete'
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures$/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures$/)
 
         get '/failures'
-        last_response.status.must_equal 200
-        last_response.body.must_match(/No failed jobs found/)
+        _(last_response.status).must_equal 200
+        _(last_response.body).must_match(/No failed jobs found/)
 
         assert_equal failed_count, "1"
       end
 
       it 'has the retry all form and action' do
-        last_response.body.must_match(/failures\/all\/retry/)
-        last_response.body.must_match(/Retry All/)
+        _(last_response.body).must_match(/failures\/all\/retry/)
+        _(last_response.body).must_match(/Retry All/)
       end
 
       it 'can retry all failures' do
         assert_equal failed_count, "1"
 
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
         post '/failures/all/retry'
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
 
         get '/failures'
-        last_response.status.must_equal 200
-        last_response.body.must_match(/No failed jobs found/)
+        _(last_response.status).must_equal 200
+        _(last_response.body).must_match(/No failed jobs found/)
       end
 
       it 'can delete failure from the list' do
         assert_equal failed_count, "1"
 
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post '/failures', { :key => [failure_score], :delete => 'Delete' }
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
 
         get '/failures'
-        last_response.status.must_equal 200
-        last_response.body.must_match(/No failed jobs found/)
+        _(last_response.status).must_equal 200
+        _(last_response.body).must_match(/No failed jobs found/)
       end
 
       it 'can retry failure from the list' do
         assert_equal failed_count, "1"
 
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post '/failures', { :key => [failure_score], :retry => 'Retry Now' }
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
 
         get '/failures'
-        last_response.status.must_equal 200
-        last_response.body.must_match(/No failed jobs found/)
+        _(last_response.status).must_equal 200
+        _(last_response.body).must_match(/No failed jobs found/)
+      end
+
+      it 'can handle failures with nil error_message' do
+        create_sample_failure(error_message: nil)
+
+        get '/failures'
+
+        _(last_response.status).must_equal 200
       end
     end
 
@@ -147,38 +155,38 @@ module Sidekiq
       end
 
       it 'should be successful' do
-        last_response.status.must_equal 200
+        _(last_response.status).must_equal 200
       end
 
       it 'can display failure page' do
-        last_response.body.must_match(/Job/)
-        last_response.body.must_match(/HardWorker/)
-        last_response.body.must_match(/ArgumentError/)
-        last_response.body.must_match(/file1/)
+        _(last_response.body).must_match(/Job/)
+        _(last_response.body).must_match(/HardWorker/)
+        _(last_response.body).must_match(/ArgumentError/)
+        _(last_response.body).must_match(/file1/)
       end
 
       it 'can delete failure' do
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post "/failures/#{failure_score}", :delete => 'Delete'
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
 
         get "/failures/#{failure_score}"
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
       end
 
       it 'can retry failure' do
-        last_response.body.must_match(/HardWorker/)
+        _(last_response.body).must_match(/HardWorker/)
 
         post "/failures/#{failure_score}", :retry => 'Retry Now'
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
 
         get "/failures/#{failure_score}"
-        last_response.status.must_equal 302
-        last_response.location.must_match(/failures/)
+        _(last_response.status).must_equal 302
+        _(last_response.location).must_match(/failures/)
       end
 
       if defined? Sidekiq::Pro
@@ -186,24 +194,43 @@ module Sidekiq
           create_sample_failure
           post '/filter/failures', substr: 'new'
 
-          last_response.status.must_equal 200
+          _(last_response.status).must_equal 200
         end
       end
     end
 
     describe 'when there is specific failure' do
       describe 'with unescaped data' do
-        before do
-          create_sample_failure(args: ['<h1>omg</h1>'], error_message: '<p>wow</p>')
-          get '/failures'
+        describe 'the index page' do
+          before do
+            create_sample_failure(args: ['<h1>omg</h1>'], error_message: '<p>wow</p>')
+            get '/failures'
+          end
+
+          it 'can escape arguments' do
+            _(last_response.body).must_match(/&quot;&lt;h1&gt;omg&lt;&#x2F;h1&gt;&quot;/)
+          end
+
+          it 'can escape error message' do
+            _(last_response.body).must_match(/ArgumentError: &lt;p&gt;wow&lt;&#x2F;p&gt;/)
+          end
         end
 
-        it 'can escape arguments' do
-          last_response.body.must_match(/&quot;&lt;h1&gt;omg&lt;&#x2F;h1&gt;&quot;/)
-        end
-
-        it 'can escape error message' do
-          last_response.body.must_match(/ArgumentError: &lt;p&gt;wow&lt;&#x2F;p&gt;/)
+        describe 'the details page' do
+          before do
+            failure = create_sample_failure(args: ['<h1>omg</h1>'], error_message: '<p>wow</p>')
+            get "/failures/#{failure[:jid]}"
+          end
+
+          it 'can escape arguments' do
+            _(last_response.status).must_equal 200
+            _(last_response.body).must_match(/<th>Error Message<\/th>\n      <td>&lt;p&gt;wow&lt;&#x2F;p&gt;<\/td>/)
+          end
+
+          it 'can escape error message' do
+            _(last_response.status).must_equal 200
+            _(last_response.body).must_match(/<th>Error Message<\/th>\n      <td>&lt;p&gt;wow&lt;&#x2F;p&gt;<\/td>/)
+          end
         end
       end
 
@@ -214,8 +241,8 @@ module Sidekiq
         end
 
         it 'should be successful' do
-          last_response.status.must_equal 200
-          last_response.body.wont_match(/No failed jobs found/)
+          _(last_response.status).must_equal 200
+          _(last_response.body).wont_match(/No failed jobs found/)
         end
       end
 
@@ -226,8 +253,8 @@ module Sidekiq
         end
 
         it 'should be successful' do
-          last_response.status.must_equal 200
-          last_response.body.wont_match(/No failed jobs found/)
+          _(last_response.status).must_equal 200
+          _(last_response.body).wont_match(/No failed jobs found/)
         end
       end
     end
@@ -251,6 +278,8 @@ module Sidekiq
           c.set("stat:failed", 1)
         end
       end
+
+      data
     end
 
     def failed_count

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-failures
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.4
 platform: ruby
 authors:
 - Marcelo Silveira
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-06-12 00:00:00.000000000 Z
+date: 2022-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Keep track of Sidekiq failed jobs
 email:
 - marcelo@mhfs.com.br
@@ -101,8 +115,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -114,6 +129,7 @@ files:
 - lib/sidekiq/failures/locales/en.yml
 - lib/sidekiq/failures/locales/ja.yml
 - lib/sidekiq/failures/locales/pt-BR.yml
+- lib/sidekiq/failures/locales/zh-cn.yml
 - lib/sidekiq/failures/middleware.rb
 - lib/sidekiq/failures/sorted_entry.rb
 - lib/sidekiq/failures/version.rb
@@ -126,9 +142,10 @@ files:
 - test/test_helper.rb
 - test/web_extension_test.rb
 homepage: https://github.com/mhfs/sidekiq-failures/
-licenses: []
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -143,14 +160,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.0.3.1
+signing_key:
 specification_version: 4
 summary: Keeps track of Sidekiq failed jobs and adds a tab to the Web UI to let you
   browse them. Makes use of Sidekiq's custom tabs and middleware chain.
-test_files:
-- test/failures_test.rb
-- test/middleware_test.rb
-- test/test_helper.rb
-- test/web_extension_test.rb
+test_files: []

data/.travis.yml

@@ -1,21 +0,0 @@
-language: ruby
-sudo: false
-cache: bundler
-services:
-  - redis-server
-before_install:
-  - gem install bundler
-  - gem update bundler
-rvm:
-  - jruby-9.1.6.0
-  - 2.2.4
-  - 2.3.0
-  - 2.4.0
-env:
-  matrix:
-    - SIDEKIQ_VERSION="~> 4.0"
-    - SIDEKIQ_VERSION="~> 4.2"
-    - SIDEKIQ_VERSION="~> 5.0"
-matrix:
-  allow_failures:
-    - rvm: jruby-9.1.6.0