sidekiq-failures 0.0.2 → 0.0.3

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## Unreleased
 
+## 0.0.3
+
+  * Adequate layout to new sidekiq web ui design (@krasnoukhov)
+  * Improve backtrace view (@krasnoukhov)
+  * Remove unnecessary slash in redirect (@krasnoukhov)
+  * Invert order of failed jobs (@krasnoukhov)
+
 ## 0.0.2
 
   * Show backtrace similar to resque (Kunal Modi)

data/lib/sidekiq/failures.rb

@@ -10,7 +10,13 @@ module Sidekiq
 end
 
 Sidekiq::Web.register Sidekiq::Failures::WebExtension
-Sidekiq::Web.tabs << "Failures"
+
+if Sidekiq::Web.tabs.is_a?(Array)
+  # For sidekiq < 2.5
+  Sidekiq::Web.tabs << "failures"
+else
+  Sidekiq::Web.tabs["Failures"] = "failures"
+end
 
 Sidekiq.server_middleware do |chain|
   chain.add Sidekiq::Failures::Middleware

data/lib/sidekiq/failures/middleware.rb

@@ -14,7 +14,7 @@ module Sidekiq
           :queue => queue
         }
 
-        Sidekiq.redis { |conn| conn.rpush(:failed, Sidekiq.dump_json(data)) }
+        Sidekiq.redis { |conn| conn.lpush(:failed, Sidekiq.dump_json(data)) }
 
         raise
       end

data/lib/sidekiq/failures/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Failures
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/sidekiq/failures/views/failures.slim

@@ -1,30 +1,36 @@
-h1 Failed Jobs
+header.row
+  .span5
+    h3 Failed Jobs
+  .span4
+    - if @messages.size > 0
+      == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
 
 - if @messages.size > 0
-  == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
-
-  table class="table table-striped table-bordered"
-    tr
-      th Worker
-      th Args
-      th Queue
-      th Failed At
-      th Exception
+  table class="table table-striped table-bordered table-white" style="width: 100%; margin: 0; table-layout:fixed;"
+    thead
+      th style="width: 25%" Worker, Args
+      th style="width: 10%" Queue
+      th style="width: 15%" Failed At
+      th style="width: 50%" Exception
     - @messages.each do |msg|
       tr
-        td= msg['worker']
-        td= msg['payload']['args'].inspect[0..100]
+        td style="overflow: hidden; text-overflow: ellipsis;"
+          = msg['worker']
+          br
+          = msg['payload']['args'].inspect[0..100]
         td= msg['queue']
-        td= msg['failed_at']
         td
-          = "#{msg['exception']}: "
-          a.backtrace href="#" onclick="$(this).next().toggle()"  =msg['error']
-          pre style="display:none; font-size: 0.8em" = msg['backtrace'].join("\n")
-
-  form.form-horizontal action="#{root_path}failures/remove" method="post"
-    input.btn.btn-danger type="submit" name="delete" value="Clear All"
+          time datetime="#{Time.parse(msg['failed_at']).getutc.iso8601}"
+            = msg['failed_at']
+        td style="overflow: auto; padding: 10px;"
+          a.backtrace href="#" onclick="$(this).next().toggle(); return false"  = "#{msg['exception']}: #{msg['error']}"
+          pre style="display: none; background: none; border: 0; width: 100%; max-height: 30em; font-size: 0.8em; white-space: nowrap;" == msg['backtrace'].join("<br />")
 
-  == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
+  div.row
+    .span5
+      form.form-horizontal action="#{root_path}failures/remove" method="post" style="margin: 20px 0"
+        input.btn.btn-danger.btn-small type="submit" name="delete" value="Clear All"
+    .span4
+      == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
 - else
-  p No failed jobs found.
-  a href="#{root_path}" Back
+  .alert.alert-success  No failed jobs found.

data/lib/sidekiq/failures/web_extension.rb

@@ -22,7 +22,7 @@ module Sidekiq
         app.post "/failures/remove" do
           Sidekiq.redis {|c| c.del(:failed) }
 
-          redirect "#{root_path}/failures"
+          redirect "#{root_path}failures"
         end
       end
     end

data/test/test_helper.rb

@@ -1,3 +1,6 @@
+Encoding.default_external = Encoding::UTF_8
+Encoding.default_internal = Encoding::UTF_8
+
 require "minitest/autorun"
 require "minitest/spec"
 require "minitest/mock"

data/test/web_extension_test.rb

@@ -17,7 +17,7 @@ module Sidekiq
       get '/'
 
       last_response.status.must_equal 200
-      last_response.body.must_match /Sidekiq is idle/
+      last_response.body.must_match /Sidekiq/
       last_response.body.must_match /Failures/
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-failures
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-30 00:00:00.000000000 Z
+date: 2012-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -144,7 +144,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1783905454239624780
+      hash: -2051440200690725249
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -153,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1783905454239624780
+      hash: -2051440200690725249
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23