sidekiq-failures 0.0.1.pre → 0.0.1

data/README.md

@@ -1,4 +1,4 @@
-# Sidekiq::Failures
+# Sidekiq::Failures [![Build Status](https://secure.travis-ci.org/mhfs/sidekiq-failures.png)](http://travis-ci.org/mhfs/sidekiq-failures)
 
 Keeps track of Sidekiq failed jobs and adds a tab to the Web UI to let you browse
 them. Makes use of Sidekiq's custom tabs and middleware chain.
@@ -9,10 +9,6 @@ Note that each failed retry will create a new failed job. This might result in a
 pretty big failures list. Think twice before using this project. In most cases
 automatic retries allied to exception notifications will be enough.
 
-## Important Note!
-
-This is an ongoing, alpha level project. Be prepared that the API might change and bugs might occur.
-
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -31,6 +27,12 @@ Simply having the gem in your Gemfile should be enough.
 
 Your failed jobs will be visible via a Failures tab in the Web UI.
 
+## TODO and Limitations
+
+* Skip failures of specific workers (or the opposite).
+* Trigger retry of specific failed jobs via Web UI.
+* Deal with retries. Maybe just track a failure when there's no attempt left.
+
 ## Contributing
 
 1. Fork it

data/lib/sidekiq/failures/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Failures
-    VERSION = "0.0.1.pre"
+    VERSION = "0.0.1"
   end
 end

data/lib/sidekiq/failures/views/failures.slim

@@ -1,7 +1,7 @@
 h1 Failed Jobs
 
 - if @messages.size > 0
-  == slim :_paging, :locals => { :url => "#{root_path}queues/#{@name}" }
+  == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
 
   table class="table table-striped table-bordered"
     tr
@@ -20,7 +20,10 @@ h1 Failed Jobs
         td= msg['error']
         td= msg['failed_at']
 
-  == slim :_paging, :locals => { :url => "#{root_path}queues/#{@name}" }
+  form.form-horizontal action="#{root_path}failures/remove" method="post"
+    input.btn.btn-danger type="submit" name="delete" value="Clear All"
+
+  == slim :_paging, :locals => { :url => "#{root_path}failures/#@name" }
 - else
   p No failed jobs found.
   a href="#{root_path}" Back

data/lib/sidekiq/failures/web_extension.rb

@@ -18,6 +18,12 @@ module Sidekiq
 
           slim :failures
         end
+
+        app.post "/failures/remove" do
+          Sidekiq.redis {|c| c.del(:failed) }
+
+          redirect "#{root_path}/failures"
+        end
       end
     end
   end

data/test/web_extension_test.rb

@@ -28,13 +28,40 @@ module Sidekiq
       last_response.body.must_match /No failed jobs found/
     end
 
-    it 'can display failures page with failures listed' do
-      create_sample_failure
-      get '/failures'
-      last_response.status.must_equal 200
-      last_response.body.must_match /HardWorker/
-      last_response.body.must_match /ArgumentError/
-      last_response.body.wont_match /No failed jobs found/
+    describe 'when there are failures' do
+      before do
+        create_sample_failure
+        get '/failures'
+      end
+
+      it 'should be successful' do
+        last_response.status.must_equal 200
+      end
+
+      it 'can display failures page with failures listed' do
+        last_response.body.must_match /Failed Jobs/
+        last_response.body.must_match /HardWorker/
+        last_response.body.must_match /ArgumentError/
+        last_response.body.wont_match /No failed jobs found/
+      end
+
+      it 'has the clear all form and action' do
+        last_response.body.must_match /failures\/remove/
+        last_response.body.must_match /method=\"post/
+        last_response.body.must_match /Clear All/
+      end
+
+      it 'can remove all failures' do
+        last_response.body.must_match /HardWorker/
+
+        post '/failures/remove'
+        last_response.status.must_equal 302
+        last_response.location.must_match /failures$/
+
+        get '/failures'
+        last_response.status.must_equal 200
+        last_response.body.must_match /No failed jobs found/
+      end
     end
 
     def create_sample_failure

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-failures
 version: !ruby/object:Gem::Version
-  version: 0.0.1.pre
-  prerelease: 6
+  version: 0.0.1
+  prerelease: 
 platform: ruby
 authors:
 - Marcelo Silveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-24 00:00:00.000000000 Z
+date: 2012-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -143,13 +143,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3924324367283502437
+      hash: -2307367845449667201
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>'
+  - - ! '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
+      segments:
+      - 0
+      hash: -2307367845449667201
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23