sidekiq-expected_failures 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c5ff08635fbb2ba6755c5db477d062def09307d
-  data.tar.gz: 4c871c3c875ff8fdfaf7dbb6fc6508e2e8b9aa44
+  metadata.gz: 9e25fbc9e0f8ec213cdd6737e9a512829b84bd0c
+  data.tar.gz: 0c1d1cfdf2fa3be4dfdadd1be0cf9ccba959f580
 SHA512:
-  metadata.gz: cb77f825aaac8dbca440a8af215efe6b1ce991112ab103fde6b171a6442754d8a635c9c40e6f760aeef5175021a13f31b9e07588cbb160a5488e27db5b41dd10
-  data.tar.gz: b7dcf1451697e9d872ac843265629e094640ca08d383327f3cdb244acb949bc211d304d972c143fbb5cb93fb818c4e646f50657b8ca29122734326bf3a8cacb6
+  metadata.gz: a18b6fea8db4e17c0110a3c52e27a9ae4cd055804536f7e6d1b9d8aa3d2e87c811a09484cca87a30559649caf91b23ff6cf440de561dec0d205f861122ce3f0c
+  data.tar.gz: 3e01243030006b880b7d421d994a867002b8030129d99672c3eb19e3695d8188c455e9a8631de8c3d36c9e52e27a704c851df974a117d550a677065bdf8a5044

data/.travis.yml

@@ -2,11 +2,11 @@ language: ruby
 
 rvm:
   - 1.9.3
-  - jruby-19mode
-  - rbx
+  - jruby-1.7.11
+  - rbx-2.2.9
   - 2.0.0
   - 2.1.0
-  - ruby-head
+  - 2.1.2
 
 services:
   - redis-server

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.2.4
+
+- `Sidekiq::ExpectedFailures.clear_old` can now accept argument - will remove failures
+  that are n days old (1 by default) - useful if you want to clear some of old failures
+  using cronjob
+
 ## 0.2.3
 
 - removed (unnecessary) dependency on `Sidekiq::Util` (now Sidekiq 3.0 compatible)

data/README.md

@@ -77,7 +77,7 @@ Just be sure to load this one after `sidekiq-failures`, otherwise failed jobs wi
 At the moment you have 3 public methods in `Sidekiq::ExpectedFailures` module:
 
 - `clear_counters` - clears all counters (as I mentioned - it's stored inside single redis hash, but I doubt anyone would like to log more than 500 different exceptions, right?)
-- `clear_old` - clears failed jobs older than today
+- `clear_old(days_ago)` - clears failed jobs older than days_ago days (this is 1 by default)
 - `clear_all` - clears all failed jobs
 
 This might change in the future to something more sane.

data/lib/sidekiq/expected_failures/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module ExpectedFailures
-    VERSION = "0.2.3"
+    VERSION = "0.2.4"
   end
 end

data/lib/sidekiq/expected_failures.rb

@@ -35,8 +35,8 @@ module Sidekiq
       clear(dates.keys)
     end
 
-    def self.clear_old
-      range = dates.keys.delete_if { |d| Date.parse(d) > Date.today.prev_day }
+    def self.clear_old(days_ago = 1)
+      range = dates.keys.delete_if { |d| Date.parse(d) > Date.today.prev_day(days_ago) }
       clear(range)
     end
 

data/test/lib/expected_failures_test.rb

@@ -0,0 +1,47 @@
+require "test_helper"
+
+module Sidekiq
+  module ExpectedFailures
+    describe "clear_old (helper method)" do
+      before do
+        Sidekiq.redis = REDIS
+        Sidekiq.redis {|c| c.flushdb }
+        Timecop.freeze(Time.local(2014, 6, 10))
+
+        # fresh failure
+        Sidekiq.redis do |c|
+          c.lpush("expected:2014-06-10", Sidekiq.dump_json({}))
+          c.sadd("expected:dates", "2014-06-10")
+        end
+
+        # 1 day old
+        Sidekiq.redis do |c|
+          c.lpush("expected:2014-06-09", Sidekiq.dump_json({}))
+          c.sadd("expected:dates", "2014-06-09")
+        end
+
+        # 3 days old
+        Sidekiq.redis do |c|
+          c.lpush("expected:2014-06-07", Sidekiq.dump_json({}))
+          c.sadd("expected:dates", "2014-06-07")
+        end
+      end
+
+      after do
+        Timecop.return
+      end
+
+      it "clears failures older than 1 day by default" do
+        Sidekiq::ExpectedFailures.clear_old
+        assert_equal ["2014-06-10"], redis("smembers", "expected:dates")
+        assert_nil redis("get", "expected:2014-06-09")
+        assert_nil redis("get", "expected:2014-06-07")
+      end
+
+      it "can be called with days_old argument" do
+        Sidekiq::ExpectedFailures.clear_old(2)
+        assert_equal ["2014-06-09", "2014-06-10"], redis("smembers", "expected:dates").sort
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-expected_failures
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Rafal Wojsznis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2014-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -143,6 +143,7 @@ files:
 - lib/sidekiq/expected_failures/version.rb
 - lib/sidekiq/expected_failures/web.rb
 - sidekiq-expected_failures.gemspec
+- test/lib/expected_failures_test.rb
 - test/lib/middleware_test.rb
 - test/lib/web_test.rb
 - test/test_helper.rb
@@ -176,6 +177,7 @@ specification_version: 4
 summary: If you don't rely on sidekiq' retry behavior, you handle exceptions on your
   own and want to keep track of them - this thing is for you.
 test_files:
+- test/lib/expected_failures_test.rb
 - test/lib/middleware_test.rb
 - test/lib/web_test.rb
 - test/test_helper.rb