sidekiq-cron 1.6.0 → 1.8.0

data/test/unit/launcher_test.rb

@@ -0,0 +1,33 @@
+require './test/test_helper'
+
+describe 'Cron launcher' do
+  describe 'initialization' do
+    before do
+      Sidekiq[:cron_poll_interval] = nil
+    end
+
+    it 'initializes poller with default poll interval when not configured' do
+      Sidekiq::Cron::Poller.expects(:new).with do |options|
+        assert_equal Sidekiq::Cron::Launcher::DEFAULT_POLL_INTERVAL, options[:cron_poll_interval]
+      end
+
+      Sidekiq::Launcher.new(Sidekiq)
+    end
+
+    it 'initializes poller with the configured poll interval' do
+      Sidekiq::Cron::Poller.expects(:new).with do |options|
+        assert_equal 99, options[:cron_poll_interval]
+      end
+
+      Sidekiq[:cron_poll_interval] = 99
+      Sidekiq::Launcher.new(Sidekiq)
+    end
+
+    it 'does not initialize the poller when interval is 0' do
+      Sidekiq::Cron::Poller.expects(:new).never
+
+      Sidekiq[:cron_poll_interval] = 0
+      Sidekiq::Launcher.new(Sidekiq)
+    end
+  end
+end

data/test/unit/poller_test.rb

@@ -5,7 +5,7 @@ describe 'Cron Poller' do
     REDIS.with { |c| c.respond_to?(:redis) ? c.redis.flushdb : c.flushdb }
     Sidekiq.redis = REDIS
 
-    #clear all previous saved data from redis
+    # Clear all previous saved data from Redis.
     Sidekiq.redis do |conn|
       conn.keys("cron_job*").each do |key|
         conn.del(key)
@@ -27,7 +27,7 @@ describe 'Cron Poller' do
     now = Time.now.utc + 3600
     enqueued_time = Time.new(now.year, now.month, now.day, now.hour, 5, 1)
     Time.stubs(:now).returns(enqueued_time)
-    #new jobs!
+
     Sidekiq::Cron::Job.create(@args)
     Sidekiq::Cron::Job.create(@args2)
 
@@ -38,7 +38,7 @@ describe 'Cron Poller' do
       assert_equal 0, conn.llen("queue:super")
     end
 
-    #30 seconds after!
+    # 30 seconds after!
     enqueued_time = Time.new(now.year, now.month, now.day, now.hour, 5, 30)
     Time.stubs(:now).returns(enqueued_time)
 
@@ -54,7 +54,7 @@ describe 'Cron Poller' do
     now = Time.now.utc + 3600
     enqueued_time = Time.new(now.year, now.month, now.day, now.hour, 5, 1)
     Time.stubs(:now).returns(enqueued_time)
-    #new jobs!
+
     Sidekiq::Cron::Job.create(@args)
     Sidekiq::Cron::Job.create(@args2)
 
@@ -79,7 +79,7 @@ describe 'Cron Poller' do
     now = Time.now.utc + 3600
     enqueued_time = Time.new(now.year, now.month, now.day, now.hour, 8, 1)
     Time.stubs(:now).returns(enqueued_time)
-    #new jobs!
+
     Sidekiq::Cron::Job.create(@args)
     Sidekiq::Cron::Job.create(@args2)
 
@@ -104,7 +104,7 @@ describe 'Cron Poller' do
     now = Time.now.utc + 3600
     enqueued_time = Time.new(now.year, now.month, now.day, now.hour, 8, 1)
     Time.stubs(:now).returns(enqueued_time)
-    #new jobs!
+
     Sidekiq::Cron::Job.create(@args)
     Sidekiq::Cron::Job.create(@args2)
 

data/test/unit/schedule_loader_test.rb

@@ -0,0 +1,45 @@
+require './test/test_helper'
+
+describe 'ScheduleLoader' do
+  before do
+    Sidekiq.options[:lifecycle_events][:startup].clear
+  end
+
+  describe 'Schedule is defined in hash' do
+    before do
+      Sidekiq::Options[:cron_schedule_file] = 'test/unit/fixtures/schedule_hash.yml'
+      load 'sidekiq/cron/schedule_loader.rb'
+    end
+
+    it 'calls Sidekiq::Cron::Job.load_from_hash' do
+      Sidekiq::Cron::Job.expects(:load_from_hash)
+      Sidekiq.options[:lifecycle_events][:startup].first.call
+    end
+  end
+
+  describe 'Schedule is defined in array' do
+    before do
+      Sidekiq::Options[:cron_schedule_file] = 'test/unit/fixtures/schedule_array.yml'
+      load 'sidekiq/cron/schedule_loader.rb'
+    end
+
+    it 'calls Sidekiq::Cron::Job.load_from_array' do
+      Sidekiq::Cron::Job.expects(:load_from_array)
+      Sidekiq.options[:lifecycle_events][:startup].first.call
+    end
+  end
+
+  describe 'Schedule is not defined in hash nor array' do
+    before do
+      Sidekiq::Options[:cron_schedule_file] = 'test/unit/fixtures/schedule_string.yml'
+      load 'sidekiq/cron/schedule_loader.rb'
+    end
+
+    it 'raises an error' do
+      e = assert_raises StandardError do
+        Sidekiq.options[:lifecycle_events][:startup].first.call
+      end
+      assert_equal 'Not supported schedule format. Confirm your test/unit/fixtures/schedule_string.yml', e.message
+    end
+  end
+end

data/test/unit/web_extension_test.rb

@@ -125,14 +125,14 @@ describe 'Cron web' do
         assert_equal 1, conn.llen("queue:default"), "Queue should have 1 job"
       end
 
-      #should enqueue more times
+      # Should enqueue more times.
       post "/cron/#{job_name}/enque"
 
       Sidekiq.redis do |conn|
         assert_equal 2, conn.llen("queue:default"), "Queue should have 2 job"
       end
 
-      #should enqueue to cron job queue
+      # Should enqueue to cron job queue.
       post "/cron/#{cron_job_name}/enque"
 
       Sidekiq.redis do |conn|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-cron
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.8.0
 platform: ruby
 authors:
 - Ondrej Bartas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-30 00:00:00.000000000 Z
+date: 2022-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fugit
@@ -136,7 +136,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.21'
-description: Enables to set jobs to be run in specified time (using CRON notation)
+description: Enables to set jobs to be run in specified time (using CRON notation
+  or natural language)
 email: ondrej@bartas.cz
 executables: []
 extensions: []
@@ -155,6 +156,7 @@ files:
 - lib/sidekiq/cron/launcher.rb
 - lib/sidekiq/cron/locales/de.yml
 - lib/sidekiq/cron/locales/en.yml
+- lib/sidekiq/cron/locales/it.yml
 - lib/sidekiq/cron/locales/ja.yml
 - lib/sidekiq/cron/locales/pt.yml
 - lib/sidekiq/cron/locales/ru.yml
@@ -167,11 +169,17 @@ files:
 - lib/sidekiq/cron/views/cron_show.erb
 - lib/sidekiq/cron/web.rb
 - lib/sidekiq/cron/web_extension.rb
+- lib/sidekiq/options.rb
 - sidekiq-cron.gemspec
 - test/integration/performance_test.rb
 - test/test_helper.rb
+- test/unit/fixtures/schedule_array.yml
+- test/unit/fixtures/schedule_hash.yml
+- test/unit/fixtures/schedule_string.yml
 - test/unit/job_test.rb
+- test/unit/launcher_test.rb
 - test/unit/poller_test.rb
+- test/unit/schedule_loader_test.rb
 - test/unit/web_extension_test.rb
 homepage: https://github.com/ondrejbartas/sidekiq-cron
 licenses:
@@ -192,8 +200,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
-summary: Sidekiq-Cron helps to add repeated scheduled jobs
+summary: Scheduler/Cron for Sidekiq jobs
 test_files: []