sidekiq-cron 1.3.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '091abb12b81574bf5fad5130f4e343aaad6adeceb0daae8c46a6d09dbaa7ee58'
-  data.tar.gz: 1ecbf9ba2fd82ff69a423993e7aa3678e7fabc6fb55e2acea74ec1cb83a8af3d
+  metadata.gz: 2d138bcaa8a86a88e84e5cd8b5b9188e68217e268a466aef03f2b5dd30a7226d
+  data.tar.gz: 8cae5daa6693161b48b71b40607a0c8182764a82ffc3efd5eb8fd7bd0df65da7
 SHA512:
-  metadata.gz: 9cfd9a8e2efdcf3ae293533421a1c09b7dcc3154e90d749fd3e3a47ccaff6d673daa68877b2ca3b7939139603ee04e816c8c5ae51ef64d818d8d013eff43d9f0
-  data.tar.gz: 0d86e3bb4b06869889934a37ef30f117a4a28769a07e75b3d7547c49d9d8e5dfe4931f608b8b7b18cdc1b70cfdaf6be55aa043844b047b877ff7dfa21271a9f4
+  metadata.gz: 0dd9f32211d51bbd71fadbd36b30970193fc725408207fe255ff58f88b56dc484815a0f52c788acebbcc6230665cf7c02ccdbd4f7425dd4d9414cd8dd098dbf7
+  data.tar.gz: 73e8040c64d5de227d0077a1d95081d47140ec0481706b16c00e830f421ce8952f0fb48a991f71033c65a115dc0f29f06e2a6c56aae38565ed5dae6bfcaea14d

data/Changes.md

@@ -1,11 +1,33 @@
-v 1.3.0
--------
-
-- add confirmation dialog when enquing jobs from UI
-- start to support Sidekiq `average_scheduled_poll_interval` option (replaced `poll_interval`)
-- enable to use latest fugit to parse cron notation alowing use of natural language (ie `"every 30 minutes"`)
-- fix deprecation warning for redis 4.6.x
-- fix different response from Redis#exists in different redis versions
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## 1.5.1
+
+-  Fixes an issue that prevented the gem to work in previous Sidekiq versions (https://github.com/ondrejbartas/sidekiq-cron/pull/335)
+
+## 1.5.0
+
+- Integrate Sidekiq v6.5 breaking changes (https://github.com/ondrejbartas/sidekiq-cron/pull/331)
+- Add portuguese translations (https://github.com/ondrejbartas/sidekiq-cron/pull/332)
+
+## 1.4.0
+
+- Fix buttons order in job show view (https://github.com/ondrejbartas/sidekiq-cron/pull/302)
+- Dark Mode support in UI (https://github.com/ondrejbartas/sidekiq-cron/pull/317/282)
+- Remove invocation of deprecated Redis functionality (https://github.com/ondrejbartas/sidekiq-cron/pull/318)
+- Internal code cleanup (https://github.com/ondrejbartas/sidekiq-cron/pull/317)
+- Optimize gem size (https://github.com/ondrejbartas/sidekiq-cron/pull/322)
+- Fix "Show All" button on cron jobs view with Sidekiq 6.3.0+ (https://github.com/ondrejbartas/sidekiq-cron/pull/321)
+- Documentation updates
+
+## 1.3.0
+
+- Add confirmation dialog when enquing jobs from UI
+- Start to support Sidekiq `average_scheduled_poll_interval` option (replaced `poll_interval`)
+- Enable to use latest fugit to parse cron notation alowing use of natural language (ie `"every 30 minutes"`)
+- Fix deprecation warning for Redis 4.6.x
+- Fix different response from Redis#exists in different Redis versions
 - All PRs:
   - https://github.com/ondrejbartas/sidekiq-cron/pull/275
   - https://github.com/ondrejbartas/sidekiq-cron/pull/287
@@ -14,85 +36,76 @@ v 1.3.0
   - https://github.com/ondrejbartas/sidekiq-cron/pull/314
   - https://github.com/ondrejbartas/sidekiq-cron/pull/288
 
-v 1.2.0
--------
-
-- updated readme
-- fix problem with Sidekiq::Launcher and requiring it when not needed
-- better patching of Sidekiq::Launcher
-- fixed Dockerfile
-
-v 1.1.0
--------
-
-- updated readme
-- fix unit tests - changed argument error when getting invalid cron format
-- when fallbacking old job enqueued time use `Time.parse` šwithout format (so ruby can decide best method to parse it)
-- add option `date_as_argument` which will add to your job arguments on last place `Time.now.to_f` when it was eneuqued
-- add option `description` which will allow you to add notes to your jobs so in web view you can see it
-- fixed translations
-
-v 1.0.4
--------
-
-- fix problem with upgrading to 1.0.x - parsing last enqued time didn't count with old time format stored in redis
-
-v 1.0.0
--------
-
-- use [fugit](https://github.com/floraison/fugit) instead of [rufus-scheduler](https://github.com/jmettraux/rufus-scheduler) - API of cron didn't change (rufus scheduler is using fugit)
-- better working with Timezones
-- translations for JA, zh-CN
-- cron without timezone are considered as UTC, to add Timezone to cron use format `* * * * * Europe/Berlin`
-- be aware that this release can change when your jobs are enqueued (for me it didn't change but it is in one project, in other it can shift by different timezone setup)
-
-v 0.6.0
--------
-
-- set poller to check jobs every 30s by default (possible to override by `Sidekiq.options[:poll_interval] = 10`)
-- add group actions (enqueue, enable, disable, delete) all in web view
-- fix poller to enqueu all jobs in poll start time
-- add performance test for enqueue of jobs (10 000 jobs in less than 19s)
-- fix problem with default queue
-- remove redis-namespace from dependencies
-- update ruby versions in travis
-
-v 0.5.0
--------
-- add docker support
-- all crons are now evaluated in UTC
-- fix rufus scheduler & timezones problems
-- add support for sidekiq 4.2.1
-- fix readme
-- add Russian locale
-- user Rack.env in tests
-- faster enque of jobs
-- permit to use ActiveJob::Base.queue_name_delimiter
-- fix problem with multiple times enque #84
-- fix problem with enque of unknown class
-
-v 0.4.0
--------
-
-- enable to work with sidekiq >= 4.0.0
-- fix readme
-
-v 0.3.1
--------
-
-- add CSRF tags to forms so it will work with sidekiq >= 3.4.2
-- remove tilt dependency
-
-v 0.3.0
--------
-
-- suport for Active Job
-- sidekiq cron web ui needs to be loaded by: require 'sidekiq/cron/web'
-- add load_from_hash! and load_from_array! which cleanup jobs before adding new ones
-
-v 0.1.1
--------
-
-- add Web fontend with enabled/disable job, unqueue now, delete job
-- add cron poller - enqueu cro jobs
-- add cron job - save all needed data to redis
+## 1.2.0
+
+- Updated readme
+- Fix problem with Sidekiq::Launcher and requiring it when not needed
+- Better patching of Sidekiq::Launcher
+- Fixed Dockerfile
+
+## 1.1.0
+
+- Updated readme
+- Fix unit tests - changed argument error when getting invalid cron format
+- When fallbacking old job enqueued time use `Time.parse` without format (so ruby can decide best method to parse it)
+- Add option `date_as_argument` which will add to your job arguments on last place `Time.now.to_f` when it was eneuqued
+- Add option `description` which will allow you to add notes to your jobs so in web view you can see it
+- Fixed translations
+
+## 1.0.4
+
+- Fix problem with upgrading to 1.0.x - parsing last enqued time didn't count with old time format stored in Redis
+
+## 1.0.0
+
+- Use [fugit](https://github.com/floraison/fugit) instead of [rufus-scheduler](https://github.com/jmettraux/rufus-scheduler) - API of cron didn't change (rufus scheduler is using fugit)
+- Better working with Timezones
+- Translations for JA, zh-CN
+- Cron without timezone are considered as UTC, to add Timezone to cron use format `* * * * * Europe/Berlin`
+- Be aware that this release can change when your jobs are enqueued (for me it didn't change but it is in one project, in other it can shift by different timezone setup)
+
+## 0.6.0
+
+- Set poller to check jobs every 30s by default (possible to override by `Sidekiq.options[:poll_interval] = 10`)
+- Add group actions (enqueue, enable, disable, delete) all in web view
+- Fix poller to enqueu all jobs in poll start time
+- Add performance test for enqueue of jobs (10 000 jobs in less than 19s)
+- Fix problem with default queue
+- Remove redis-namespace from dependencies
+- Update ruby versions in travis
+
+## 0.5.0
+
+- Add Docker support
+- All crons are now evaluated in UTC
+- Fix rufus scheduler & timezones problems
+- Add support for Sidekiq 4.2.1
+- Fix readme
+- Add Russian locale
+- User Rack.env in tests
+- Faster enqueue of jobs
+- Permit to use ActiveJob::Base.queue_name_delimiter
+- Fix problem with multiple times enqueue #84
+- Fix problem with enqueue of unknown class
+
+## 0.4.0
+
+- Enable to work with Sidekiq >= 4.0.0
+- Fix readme
+
+## 0.3.1
+
+- Add CSRF tags to forms so it will work with Sidekiq >= 3.4.2
+- Remove Tilt dependency
+
+## 0.3.0
+
+- Suport for Active Job
+- Sidekiq cron web ui needs to be loaded by: require 'sidekiq/cron/web'
+- Add load_from_hash! and load_from_array! which cleanup jobs before adding new ones
+
+## 0.1.1
+
+- Add Web front-end with enabled/disable job, enqueue now, delete job
+- Add cron poller - enqueue cron jobs
+- Add cron job - save all needed data to Redis

data/README.md

@@ -1,15 +1,15 @@
 # Sidekiq-Cron
 
-[![Gem Version](https://badge.fury.io/rb/sidekiq-cron.svg)](http://badge.fury.io/rb/sidekiq-cron)
+[![Gem Version](https://badge.fury.io/rb/sidekiq-cron.svg)](https://badge.fury.io/rb/sidekiq-cron)
 [![Build Status](https://github.com/ondrejbartas/sidekiq-cron/workflows/CI/badge.svg?branch=master)](https://github.com/ondrejbartas/sidekiq-cron/actions)
 [![Coverage Status](https://coveralls.io/repos/github/ondrejbartas/sidekiq-cron/badge.svg?branch=master)](https://coveralls.io/github/ondrejbartas/sidekiq-cron?branch=master)
 [![Join the chat at https://gitter.im/ondrejbartas/sidekiq-cron](https://badges.gitter.im/ondrejbartas/sidekiq-cron.svg)](https://gitter.im/ondrejbartas/sidekiq-cron?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-> A scheduling add-on for [Sidekiq](http://sidekiq.org)
+> A scheduling add-on for [Sidekiq](https://sidekiq.org/)
 
 🎬 [Introduction video about Sidekiq-Cron by Drifting Ruby](https://www.driftingruby.com/episodes/periodic-tasks-with-sidekiq-cron)
 
-Sidekiq-Cron runs a thread alongside Sidekiq workers to schedule jobs at specified times (using cron notation `* * * * *` parsed by [Fugit](https://github.com/floraison/fugit), more about [cron notation](http://www.nncron.ru/help/EN/working/cron-format.htm).
+Sidekiq-Cron runs a thread alongside Sidekiq workers to schedule jobs at specified times (using cron notation `* * * * *` parsed by [Fugit](https://github.com/floraison/fugit)).
 
 Checks for new jobs to schedule every 30 seconds and doesn't schedule the same job multiple times when more than one Sidekiq worker is running.
 
@@ -21,65 +21,83 @@ Works with ActiveJob (Rails 4.2+).
 
 You don't need Sidekiq PRO, you can use this gem with plain Sidekiq.
 
-## Upgrade from <0.6x to 1.0.x
+## Upgrade from < 0.6 to 1.0
 
-Please be aware that Sidekiq-Cron < 1.0 was relying on rufus-scheduler < 3.5. Using those older sidekiq-cron with rufus-scheduler >= 3.5 ends up with jobs failing on creation. Sidekiq-cron 1.0 includes a patch that switches from rufus-scheduler to rufus-scheduler's core dependency, fugit.
+Please be aware that Sidekiq-Cron < 1.0 was relying on rufus-scheduler < 3.5. Using those older versions with rufus-scheduler >= 3.5 ends up with jobs failing on creation. Sidekiq-Cron 1.0 includes a patch that switches from rufus-scheduler to rufus-scheduler's core dependency, fugit.
 
 ## Changelog
 
-Before upgrading to new version, please read our [ChangeLog](Changes.md).
+Before upgrading to a new version, please read our [Changelog](Changes.md).
 
 ## Installation
 
 ### Requirements
 
-- Redis 2.8 or greater is required. (Redis 3.0.3 or greater is recommended for large scale use)
-- Sidekiq 5, or 4, or 3 and greater is required (for Sidekiq < 4 use version sidekiq-cron 0.3.1)
+- Redis 2.8 or greater is required (Redis 3.0.3 or greater is recommended for large scale use)
+- Sidekiq 4.2 or greater is required (for Sidekiq < 4 use version sidekiq-cron 0.3.1)
+- Sidekiq 6.5 requires Sidekiq-Cron 1.5+
 
 Install the gem:
 
-    $ gem install sidekiq-cron
+```
+$ gem install sidekiq-cron
+```
 
 Or add to your `Gemfile` and run `bundle install`:
 
-    gem "sidekiq-cron", "~> 1.1"
+```ruby
+gem "sidekiq-cron"
+```
 
-## Getting Started
+**NOTE** If you are not using Rails, you need to add `require 'sidekiq-cron'` somewhere after `require 'sidekiq'`.
 
-If you are not using Rails, you need to add `require 'sidekiq-cron'` somewhere after `require 'sidekiq'`.
+## Getting Started
 
 **Job properties:**
 
 ```ruby
 {
- 'name' => 'name_of_job', # must be uniq!
- 'cron' => '1 * * * *',  # execute at 1 minute of every hour, ex: 12:01, 13:01, 14:01, 15:01, ... (HH:MM)
- 'class' => 'MyClass',
- # OPTIONAL
- 'queue' => 'name of queue',
- 'args' => '[Array or Hash] of arguments which will be passed to perform method',
- 'date_as_argument' => true, # add the time of execution as last argument of the perform method
- 'active_job' => true,  # enqueue job through rails 4.2+ active job interface
- 'queue_name_prefix' => 'prefix', # rails 4.2+ active job queue with prefix
- 'queue_name_delimiter' => '.',  # rails 4.2+ active job queue with custom delimiter
- 'description' => 'A sentence describing what work this job performs.'
+  'name' => 'name_of_job', # must be uniq!
+  'cron' => '1 * * * *',  # execute at 1 minute of every hour, ex: 12:01, 13:01, 14:01, 15:01, ... (HH:MM)
+  'class' => 'MyClass',
+  # OPTIONAL
+  'queue' => 'name of queue',
+  'args' => '[Array or Hash] of arguments which will be passed to perform method',
+  'date_as_argument' => true, # add the time of execution as last argument of the perform method
+  'active_job' => true,  # enqueue job through rails 4.2+ active job interface
+  'queue_name_prefix' => 'prefix', # rails 4.2+ active job queue with prefix
+  'queue_name_delimiter' => '.',  # rails 4.2+ active job queue with custom delimiter
+  'description' => 'A sentence describing what work this job performs.'
+  'status' => 'disabled' # default: enabled
 }
 ```
 
-### Time, cron and sidekiq-cron
+### Time, cron and Sidekiq-Cron
 
 For testing your cron notation you can use [crontab.guru](https://crontab.guru).
 
-Sidekiq-Cron uses [Fugit](https://github.com/floraison/fugit) to parse the cronline.
+Sidekiq-Cron uses [Fugit](https://github.com/floraison/fugit) to parse the cronline. So please, check Fugit documentation for further information about allowed formats.
 
 If using Rails, this is evaluated against the timezone configured in Rails, otherwise the default is UTC.
 
 If you want to have your jobs enqueued based on a different time zone you can specify a timezone in the cronline,
 like this `'0 22 * * 1-5 America/Chicago'`.
 
-See [rufus-scheduler documentation](https://github.com/jmettraux/rufus-scheduler#a-note-about-timezones) for more information.
+#### Second-precision (sub-minute) cronlines
+
+In addition to the standard 5-parameter cronline format, sidekiq-cron supports scheduling jobs with second-precision using a modified 6-parameter cronline format:
+
+`Seconds Minutes Hours Days Months DayOfWeek`
 
-**NOTE** Rufus scheduler is using Fugit under the hood, so documentation for Rufus Scheduler can help you also.
+For example: `"*/30 * * * * *"` would schedule a job to run every 30 seconds.
+
+Note that if you plan to schedule jobs with second precision you may need to override the default schedule poll interval so it is lower than the interval of your jobs:
+
+```ruby
+Sidekiq.options[:average_scheduled_poll_interval] = 10
+```
+
+The default value at time of writing is 30 seconds. See [under the hood](#under-the-hood) for more details.
 
 ### What objects/classes can be scheduled
 
@@ -114,7 +132,7 @@ end
 For Active jobs you can use `symbolize_args: true` in `Sidekiq::Cron::Job.create` or in Hash configuration,
 which will ensure that arguments you are passing to it will be symbolized when passed back to `perform` method in worker.
 
-#### Adding Cron job:
+#### Adding Cron job
 
 ```ruby
 class HardWorker
@@ -187,8 +205,8 @@ Sidekiq::Cron::Job.load_from_array array
 Bang-suffixed methods will remove jobs that are not present in the given hash/array, update jobs that have the same names, and create new ones when the names are previously unknown.
 
 ```ruby
-Sidekiq::Cron::Job#load_from_hash! hash
-Sidekiq::Cron::Job#load_from_array! array
+Sidekiq::Cron::Job.load_from_hash! hash
+Sidekiq::Cron::Job.load_from_array! array
 ```
 
 Or from YAML (same notation as Resque-scheduler):
@@ -218,6 +236,20 @@ if File.exist?(schedule_file) && Sidekiq.server?
 end
 ```
 
+From version 3.x it is better not to use separate initializer of schedule instead add `config.on(:startup)` to your Sidekiq configuration:
+
+```ruby
+Sidekiq.configure_server do |config|
+  config.on(:startup) do
+    schedule_file = "config/schedule.yml"
+
+    if File.exist?(schedule_file)
+      Sidekiq::Cron::Job.load_from_hash YAML.load_file(schedule_file)
+    end
+  end
+end
+```
+
 Or you can use for loading jobs from yml file [sidekiq-cron-tasks](https://github.com/coverhound/sidekiq-cron-tasks) which will add rake task `bundle exec rake sidekiq_cron:load` to your rails application.
 
 ### Finding jobs
@@ -235,7 +267,7 @@ Sidekiq::Cron::Job.find name: "Job Name"
 # if job can't be found nil is returned
 ```
 
-### Destroy jobs:
+### Destroy jobs
 
 ```ruby
 # destroy all jobs
@@ -248,7 +280,7 @@ Sidekiq::Cron::Job.destroy "Job Name"
 Sidekiq::Cron::Job.find('Job name').destroy
 ```
 
-### Work with job:
+### Work with job
 
 ```ruby
 job = Sidekiq::Cron::Job.find('Job name')
@@ -271,7 +303,9 @@ job.enque!
 
 Just start Sidekiq workers by running:
 
-    $ sidekiq
+```
+$ sidekiq
+```
 
 ### Web UI for Cron Jobs
 
@@ -279,33 +313,34 @@ If you are using Sidekiq's web UI and you would like to add cron jobs too to thi
 add `require 'sidekiq/cron/web'` after `require 'sidekiq/web'`.
 
 With this, you will get:
-![Web UI](https://github.com/ondrejbartas/sidekiq-cron/raw/master/examples/web-cron-ui.png)
 
-### Forking Processes
+![Web UI](examples/web-cron-ui.png)
+
+### Forking Processes or problem with `NotImplementedError`
 
 If you're using a forking web server like Unicorn you may run into an issue where the Redis connection is used
-before the process forks, causing the following exception:
+before the process forks, causing the following exception to occur:
 
-    Redis::InheritedError: Tried to use a connection from a child process without reconnecting. You need to reconnect to Redis after forking.
+```
+Redis::InheritedError: Tried to use a connection from a child process without reconnecting. You need to reconnect to Redis after forking.
+```
 
-to occur. To avoid this, wrap your job creation in the call to `Sidekiq.configure_server`:
+To avoid this, wrap your job creation in the call to `Sidekiq.configure_server`:
 
 ```ruby
 Sidekiq.configure_server do |config|
-  schedule_file = "config/schedule.yml"
+  config.on(:startup) do
+    schedule_file = "config/schedule.yml"
 
-  if File.exist?(schedule_file)
-    Sidekiq::Cron::Job.load_from_hash YAML.load_file(schedule_file)
+    if File.exist?(schedule_file)
+      Sidekiq::Cron::Job.load_from_hash YAML.load_file(schedule_file)
+    end
   end
 end
 ```
 
 **NOTE** This API is only available in Sidekiq 3.x.
 
-## Tests in Sidekiq-Cron
-
-If you need to check code of sidekiq-cron run `rake test` in this repository.
-
 ## Under the hood
 
 When you start the Sidekiq process, it starts one thread with `Sidekiq::Poller` instance, which perform the adding of scheduled jobs to queues, retries etc.
@@ -315,95 +350,31 @@ Sidekiq-Cron adds itself into this start procedure and starts another thread wit
 Sidekiq-Cron is checking jobs to be enqueued every 30s by default, you can change it by setting:
 
 ```ruby
-# For Sidekiq >= 3.4
 Sidekiq.options[:average_scheduled_poll_interval] = 10
-
-# For older versions of Sidekiq
-Sidekiq.options[:poll_interval] = 10
 ```
 
-Sidekiq-Cron is safe to use with multiple sidekiq processes or nodes. It uses a Redis sorted set to determine that only the first process who asks can enqueue scheduled jobs into the queue.
-
-## Thanks to
-* [@284km](https://github.com/284km)
-* [@7korobi](https://github.com/7korobi)
-* [@adrianobarroso](https://github.com/adrianobarroso])
-* [@alexeyramazanov](https://github.com/alexeyramazanov)
-* [@antulik](https://github.com/antulik)
-* [@arthurbryant](https://github.com/arthurbryant)
-* [@cabello](https://github.com/cabello)
-* [@camkidman](https://github.com/camkidman)
-* [@cgunther](https://github.com/cgunther)
-* [@chuchuva](https://github.com/chuchuva)
-* [@corroded](https://github.com/corroded)
-* [@D1ceWard](https://github.com/D1ceWard])
-* [@davidtrogers](https://github.com/davidtrogers)
-* [@denispeplin](https://github.com/denispeplin)
-* [@dwarburt](https://github.com/dwarburt)
-* [@Envek](https://github.com/Envek)
-* [@Eunix](https://github.com/Eunix)
-* [@felixbuenemann](https://github.com/felixbuenemann)
-* [@film42](https://github.com/film42])
-* [@giriss](https://github.com/giriss)
-* [@gitter](https://github.com/gitter)
-* [@gstark](https://github.com/gstark)
-* [@h0jeZvgoxFepBQ2C](https://github.com/h0jeZvgoxFepBQ2C)
-* [@incubus](https://github.com/incubus)
-* [@jack0pan](https://github.com/jack0pan)
-* [@jmettraux](https://github.com/jmettraux)
-* [@johnathanludwig](https://github.com/johnathanludwig)
-* [@joshuacronemeyer](https://github.com/joshuacronemeyer)
-* [@jpserra](https://github.com/jpserra)
-* [@Junyulive](https://github.com/Junyulive)
-* [@le0pard](https://github.com/le0pard)
-* [@lepfhty](https://github.com/lepfhty)
-* [@macool](https://github.com/macool)
-* [@masayukioguni](https://github.com/masayukioguni)
-* [@matsimitsu](https://github.com/matsimitsu)
-* [@merrington](https://github.com/merrington)
-* [@MikeRogers0](https://github.com/MikeRogers0)
-* [@MMartyn](https://github.com/MMartyn)
-* [@mrchucho](https://github.com/mrchucho)
-* [@n00dle](https://github.com/n00dle)
-* [@ngouy](https://github.com/ngouy)
-* [@nhoffmann](https://github.com/nhoffmann)
-* [@nicolasleger](https://github.com/nicolasleger)
-* [@nikolai-b](https://github.com/nikolai-b)
-* [@oivoodoo](https://github.com/oivoodoo)
-* [@paniko0](https://github.com/paniko0)
-* [@petergoldstein](https://github.com/petergoldstein)
-* [@RajRoR](https://github.com/RajRoR)
-* [@rmm5t](https://github.com/rmm5t)
-* [@romeuhcf](https://github.com/romeuhcf)
-* [@rylwin](https://github.com/rylwin)
-* [@ryohashimoto](https://github.com/ryohashimoto)
-* [@safeforge](https://github.com/safeforge)
-* [@siruguri](https://github.com/siruguri)
-* [@Soliah](https://github.com/Soliah)
-* [@spk](https://github.com/spk)
-* [@stephankaag](https://github.com/stephankaag)
-* [@stormsilver](https://github.com/stormsilver)
-* [@sue445](https://github.com/sue445)
-* [@sylg](https://github.com/sylg)
-* [@tai2](https://github.com/tai2)
-* [@tfluehmann](https://github.com/tfluehmann)
-* [@timminkov](https://github.com/timminkov)
-* [@tisba](https://github.com/tisba)
-* [@tmeinlschmidt](https://github.com/tmeinlschmidt)
-* [@tomprats](https://github.com/tomprats)
-* [@zedtux](https://github.com/zedtux)
-* [@zerobearing2](https://github.com/zerobearing2)
-
-## Contributing to sidekiq-cron
+Sidekiq-Cron is safe to use with multiple Sidekiq processes or nodes. It uses a Redis sorted set to determine that only the first process who asks can enqueue scheduled jobs into the queue.
+
+## Contributing
+
+**Thanks to all [contributors](https://github.com/ondrejbartas/sidekiq-cron/graphs/contributors), you’re awesome and this wouldn’t be possible without you!**
 
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
 * Fork the project.
 * Start a feature/bugfix branch.
 * Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+* Make sure to add tests for it. This is important so we don't break it in a future version unintentionally.
+* Open a pull request!
+
+### Testing
+
+You can execute the test suite by running:
+
+```
+$ bundle exec rake test
+```
 
-## Copyright
+## License
 
 Copyright (c) 2013 Ondrej Bartas. See [LICENSE](LICENSE.txt) for further details.

data/Rakefile

@@ -1,25 +1,10 @@
-# encoding: utf-8
-
-require 'rubygems'
-require 'bundler/setup'
-require 'bundler'
-
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'rake'
-
-#TESTING
-
+require 'bundler/gem_tasks'
 require 'rake/testtask'
+
 task :default => :test
 
 Rake::TestTask.new(:test) do |t|
-  t.test_files = FileList['test/functional/**/*_test.rb', 'test/unit/**/*_test.rb','test/integration/**/*_test.rb']
+  t.test_files = FileList['test/unit/**/*_test.rb', 'test/integration/**/*_test.rb']
   t.warning = false
   t.verbose = false
 end
@@ -31,12 +16,6 @@ namespace :test do
     t.verbose = false
   end
 
-  Rake::TestTask.new(:functional) do |t|
-    t.test_files = FileList['test/functional/**/*_test.rb']
-    t.warning = false
-    t.verbose = false
-  end
-
   Rake::TestTask.new(:integration) do |t|
     t.test_files = FileList['test/integration/**/*_test.rb']
     t.warning = false

data/lib/sidekiq/cron/job.rb

@@ -1,15 +1,10 @@
 require 'fugit'
 require 'sidekiq'
-require 'sidekiq/util'
 require 'sidekiq/cron/support'
 
 module Sidekiq
   module Cron
-
     class Job
-      include Util
-      extend Util
-
       #how long we would like to store informations about previous enqueues
       REMEMBER_THRESHOLD = 24 * 60 * 60
       LAST_ENQUEUE_TIME_FORMAT = '%Y-%m-%d %H:%M:%S %z'
@@ -76,7 +71,7 @@ module Sidekiq
 
         save_last_enqueue_time
         add_jid_history jid
-        logger.debug { "enqueued #{@name}: #{@message}" }
+        Sidekiq.logger.debug { "enqueued #{@name}: #{@message}" }
       end
 
       def is_active_job?
@@ -468,7 +463,7 @@ module Sidekiq
           time = Time.now.utc
           conn.zadd(job_enqueued_key, time.to_f.to_s, formated_last_time(time).to_s) unless conn.public_send(REDIS_EXISTS_METHOD, job_enqueued_key)
         end
-        logger.info { "Cron Jobs - add job with name: #{@name}" }
+        Sidekiq.logger.info { "Cron Jobs - added job with name: #{@name}" }
       end
 
       def save_last_enqueue_time
@@ -509,7 +504,7 @@ module Sidekiq
           #delete main job
           conn.del redis_key
         end
-        logger.info { "Cron Jobs - deleted job with name: #{@name}" }
+        Sidekiq.logger.info { "Cron Jobs - deleted job with name: #{@name}" }
       end
 
       # remove all job from cron
@@ -517,7 +512,7 @@ module Sidekiq
         all.each do |job|
           job.destroy
         end
-        logger.info { "Cron Jobs - deleted all jobs" }
+        Sidekiq.logger.info { "Cron Jobs - deleted all jobs" }
       end
 
       # remove "removed jobs" between current jobs and new jobs