sidekiq-clutch 2.1.0 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d471e4ebb14bcae3bcbb03c855ab949b1029b9a2bbb0210927bc6f38b7f8906d
-  data.tar.gz: 5059ca6f29a0a3de77bef0060112b7bd448a64db5c18672a859fa91b70f1b7d7
+  metadata.gz: 20afe5d56df439c45d8866da01d4a61f4e9b29ffa795544cae880c158650d15f
+  data.tar.gz: 51226b9dfd3846b652dfd0b17b45a057d16a4ee55b21ad1eeae1701c22279cb8
 SHA512:
-  metadata.gz: 9fec12c8483a7f59a466db621b77cf123bd4bb09671181b397926062b4f1c2a058be992581bb1a8b931394921da372ce737b3e365aff3dd420fe2562b818efc2
-  data.tar.gz: a9fc7e8afac8d30c45fa15766cc26eacb524b4f324ded0d6dfda9d314270dabed274831523ed728c8ec08900f9d3f6e540505ff05593daed26badac7cef08c89
+  metadata.gz: 33e799264f3bf4c2a7cf6b564e92076b34a491269d5572a3a5623d0b52d766d9a0dd67fdb5f383ee1b4b3480a724bb45fe04c3b645008718cd6c2a990ab7f63c
+  data.tar.gz: 074af1df0fd3b46e8ee4e6b73d79093f096298a7feb21af74ab03e6aa56ae0b04ce3c50d098af49b910e9041af96989dc4592b66575f72fe0466f03c30d68d45

data/.circleci/config.yml

@@ -3,10 +3,11 @@ jobs:
   build:
     parallelism: 1
     docker:
-    - image: circleci/ruby:2.5
+    - image: cimg/ruby:3.3
     - image: redis:3.2
     steps:
     - checkout
+    - run: sed -i "s/spec.add_dependency 'sidekiq', '>= 5.0.0'/spec.add_dependency 'sidekiq', '>= 5.0.0', '< 7.0.0'/" sidekiq-clutch.gemspec
     - run: gem install bundler
     - run: bundle install
     - run: bundle exec rspec

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# 2.1.2 - Feb 18, 2025
+
+* FIX: Don't leave orphaned redis keys laying around
+* CHANGE: Prefix redis keys for easier identification
+
+# 2.1.1 - Sep 14, 2021
+
+* FIX: Call correct clean up method when legacy jobs are finished
+
 # 2.1.0 - Sep 10, 2021
 
 * PERF: Don't pass step data in success callback to every batch

data/lib/sidekiq/clutch/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   class Clutch
-    VERSION = '2.1.0'.freeze
+    VERSION = '2.1.2'.freeze
   end
 end

data/lib/sidekiq/clutch.rb

@@ -14,8 +14,8 @@ module Sidekiq
     end
 
     attr_reader :batch, :queue, :parallel_key
-
     attr_accessor :current_result_key, :on_failure
+    attr_writer :key_base
 
     def parallel
       @parallel_key = SecureRandom.uuid
@@ -87,8 +87,9 @@ module Sidekiq
       end
       parent_batch = Sidekiq::Batch.new(status.parent_bid)
       service = self.class.new(parent_batch)
+      service.key_base = @key_base
       service.jobs.raw = remaining_jobs
-      service.current_result_key = "#{key_base}-#{options['result_key_index']}"
+      service.current_result_key = "#{key_base}:result-#{options['result_key_index']}"
       service.engage
     end
 
@@ -104,7 +105,7 @@ module Sidekiq
     def on_success_legacy(status, options)
       @key_base = options['result_key'].sub(/-\d+$/, '')
       if options['jobs'].empty?
-        clean_up_result_keys
+        clean_up_temporary_keys
         return
       end
       parent_batch = Sidekiq::Batch.new(status.parent_bid)
@@ -115,11 +116,11 @@ module Sidekiq
     end
 
     def key_base
-      @key_base ||= SecureRandom.uuid
+      @key_base ||= "clutch:#{SecureRandom.uuid}"
     end
 
     def jobs_key
-      "#{key_base}-jobs"
+      "#{key_base}:jobs"
     end
 
     def set_jobs_data_in_redis(data)
@@ -154,7 +155,7 @@ module Sidekiq
 
     def enqueue_job(klass, params, result_key_index)
       job_options = Object.const_get(klass).sidekiq_options
-      result_key = "#{key_base}-#{result_key_index}"
+      result_key = "#{key_base}:result-#{result_key_index}"
       options = {
         'class'     => JobWrapper,
         'queue'     => queue || job_options['queue'],
@@ -171,7 +172,7 @@ module Sidekiq
         redis.del(jobs_key)
         result_key_index = 1
         loop do
-          result = redis.del("#{key_base}-#{result_key_index}")
+          result = redis.del("#{key_base}:result-#{result_key_index}")
           result_key_index += 1
           break if result == 0
         end

data/sidekiq-clutch.gemspec

@@ -21,7 +21,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'sidekiq', '>= 5.0.0'
 
-  spec.add_development_dependency 'bundler', '~> 2.2.4'
   spec.add_development_dependency 'rake', '~> 13.0.1'
   spec.add_development_dependency 'rspec', '~> 3.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-clutch
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.2
 platform: ruby
 authors:
 - Tim Morgan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-10 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.0.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.4
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -93,7 +79,7 @@ homepage: https://github.com/seven1m/sidekiq-clutch
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -108,8 +94,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: An ergonomic wrapper API for Sidekiq Batches
 test_files: []