sibit 0.32.8 → 0.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8dbaecce413d6a977eee8d4d440a066a666f2054ad7d2b4cec0b21c6da4efe8e
-  data.tar.gz: 39431e80439522e9d000404ee29856f558ba3b4406976e9345e550f4efbf3974
+  metadata.gz: f9835f6fa0e5abbd809c650561dc79b4bddd69281bcc6f34c28d703c1ff7e27e
+  data.tar.gz: f64fa06396983ea189f42d7d1028842831f082c6c12660858916111b62f6be28
 SHA512:
-  metadata.gz: dc62197de1ada4a3e155148fa09926ffd02861178f1049203b1212a363b60d01d11fe3881f3e61d86a57b666464084d511aec4b4664e8fd038904468b9fb315f
-  data.tar.gz: f1ec0c729a1ccca0b2b9728ea23348db8cb5e5d80b22ec06dc33a682fb04a76c47cd0b487d578d8b19d2e62dfb7ac3c4f638aac03a9f8fa7a4c791f882e10259
+  metadata.gz: bc3cc86f77d6418d88c327f87758de829b98644adf439f736c4c6a8db24e7f0f15a1faad58dc3f36a45b3ac5693995dcda0bb117ece14178fc0d437131139ab8
+  data.tar.gz: 49982a64fedb0281e093d4dd2176e649bc721f56b8743819c536ab28ac324e230097c5e4d741553da6a7b25e248b32f0933a14b8052d2fd705afc1222feec53e

data/Gemfile

@@ -6,10 +6,8 @@
 source 'https://rubygems.org'
 gemspec
 
-# gem 'debase', '0.2.4.1', require: false
-
 gem 'aruba', '~>2.2', require: false
-gem 'cucumber', '~>10.0', require: false
+gem 'cucumber', '~>11.0', require: false
 gem 'donce', '~>0.2', require: false
 gem 'logger', '~>1.7', require: false
 gem 'minitest', '~>6.0', require: false
@@ -18,8 +16,9 @@ gem 'nokogiri', '~>1.18', require: false
 gem 'os', '~>1.1', require: false
 gem 'qbash', '~>0.0', require: false
 gem 'rake', '~>13.2', require: false
-gem 'rdoc', '~>7.0', require: false
-gem 'rubocop', '~>1.62', require: false
+gem 'rdoc', '~>8.0', require: false
+gem 'rubocop', '~>1.72', require: false
+gem 'rubocop-elegant', '~>0.5', require: false
 gem 'rubocop-minitest', '~>0.38', require: false
 gem 'rubocop-performance', '~>1.25', require: false
 gem 'rubocop-rake', '~>0.7', require: false

data/Gemfile.lock

@@ -16,133 +16,152 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.8)
+    addressable (2.9.0)
       public_suffix (>= 2.0.2, < 8.0)
-    ansi (1.5.0)
-    aruba (2.3.3)
+    ansi (1.6.0)
+    aruba (2.4.1)
       bundler (>= 1.17)
       contracts (>= 0.16.0, < 0.18.0)
-      cucumber (>= 8.0, < 11.0)
+      cucumber (>= 8.0, < 12.0)
+      irb (~> 1.16)
       rspec-expectations (>= 3.4, < 5.0)
       thor (~> 1.0)
     ast (2.4.3)
     backtrace (0.4.1)
     base64 (0.3.0)
-    bigdecimal (4.0.1)
+    bigdecimal (4.1.2)
     builder (3.3.0)
     contracts (0.17.3)
     crack (1.0.1)
       bigdecimal
       rexml
-    cucumber (10.2.0)
+    cucumber (11.1.1)
       base64 (~> 0.2)
       builder (~> 3.2)
       cucumber-ci-environment (> 9, < 12)
-      cucumber-core (> 15, < 17)
+      cucumber-core (>= 16.2.0, < 17)
       cucumber-cucumber-expressions (> 17, < 20)
-      cucumber-html-formatter (> 21, < 23)
+      cucumber-html-formatter (> 21, < 24)
       diff-lcs (~> 1.5)
       logger (~> 1.6)
       mini_mime (~> 1.1)
       multi_test (~> 1.1)
-      sys-uname (~> 1.3)
+      sys-uname (~> 1.5)
     cucumber-ci-environment (11.0.0)
-    cucumber-core (16.1.1)
+    cucumber-core (16.2.0)
       cucumber-gherkin (> 36, < 40)
       cucumber-messages (> 31, < 33)
       cucumber-tag-expressions (> 6, < 9)
-    cucumber-cucumber-expressions (18.0.1)
+    cucumber-cucumber-expressions (19.0.1)
       bigdecimal
-    cucumber-gherkin (37.0.1)
-      cucumber-messages (>= 31, < 32)
-    cucumber-html-formatter (22.3.0)
+    cucumber-gherkin (39.1.0)
+      cucumber-messages (>= 31, < 33)
+    cucumber-html-formatter (23.1.0)
       cucumber-messages (> 23, < 33)
-    cucumber-messages (31.2.0)
+    cucumber-messages (32.3.1)
     cucumber-tag-expressions (8.1.0)
-    date (3.5.1)
     decoor (0.1.0)
     diff-lcs (1.6.2)
     docile (1.4.1)
-    donce (0.4.0)
+    donce (0.7.0)
       backtrace (~> 0.3)
       os (~> 1.1)
       qbash (~> 0.3)
-    elapsed (0.2.2)
+    drb (2.2.3)
+    elapsed (0.3.1)
       loog (~> 0.6)
       tago (~> 0.1)
     ellipsized (0.3.0)
-    erb (6.0.1)
-    ffi (1.17.3-arm64-darwin)
-    ffi (1.17.3-x86_64-linux-gnu)
+    erb (6.0.4)
+    ffi (1.17.4-arm64-darwin)
+    ffi (1.17.4-x86_64-linux-gnu)
     hashdiff (1.2.1)
-    iri (0.11.6)
-    json (2.18.0)
+    io-console (0.8.2)
+    irb (1.18.0)
+      pp (>= 0.6.0)
+      prism (>= 1.3.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    iri (0.11.8)
+    json (2.19.9)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
-    loog (0.6.1)
+    loog (0.8.0)
+      ellipsized
       logger (~> 1.0)
     memoist3 (1.0.0)
     mini_mime (1.1.5)
-    minitest (6.0.1)
+    minitest (6.0.6)
+      drb (~> 2.0)
       prism (~> 1.5)
-    minitest-reporters (1.7.1)
+    minitest-reporters (1.8.0)
       ansi
       builder
-      minitest (>= 5.0)
+      minitest (>= 5.0, < 7)
       ruby-progressbar
     multi_test (1.1.0)
-    nokogiri (1.19.0-arm64-darwin)
+    nokogiri (1.19.4-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.19.0-x86_64-linux-gnu)
+    nokogiri (1.19.4-x86_64-linux-gnu)
       racc (~> 1.4)
-    openssl (3.3.2)
+    openssl (3.3.3)
     os (1.1.4)
-    parallel (1.27.0)
-    parser (3.3.10.0)
+    parallel (2.1.0)
+    parser (3.3.11.1)
       ast (~> 2.4.1)
       racc
-    prism (1.8.0)
-    psych (5.3.1)
-      date
-      stringio
-    public_suffix (7.0.2)
-    qbash (0.5.0)
+    pp (0.6.3)
+      prettyprint
+    prettyprint (0.2.0)
+    prism (1.9.0)
+    public_suffix (7.0.5)
+    qbash (0.8.4)
       backtrace (> 0)
       elapsed (> 0)
       loog (> 0)
       tago (> 0)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.3.1)
-    rdoc (7.1.0)
+    rake (13.4.2)
+    rbs (4.0.3)
+      logger
+      prism (>= 1.6.0)
+      tsort
+    rdoc (8.0.0)
       erb
-      psych (>= 4.0.0)
+      prism (>= 1.6.0)
+      rbs (>= 4.0.0)
       tsort
-    regexp_parser (2.11.3)
-    retriable (3.1.2)
+    regexp_parser (2.12.0)
+    reline (0.6.3)
+      io-console (~> 0.5)
+    retriable (3.8.0)
     retriable_proxy (1.0.2)
       retriable (>= 2.0, < 4.0)
     rexml (3.4.4)
     rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.6)
-    rubocop (1.82.1)
+    rspec-support (3.13.7)
+    rubocop (1.88.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
-      parallel (~> 1.10)
+      parallel (>= 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.48.0, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.0)
+    rubocop-ast (1.49.1)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
-    rubocop-minitest (0.38.2)
+    rubocop-elegant (0.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.75)
+    rubocop-minitest (0.39.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
@@ -163,17 +182,16 @@ GEM
       simplecov (~> 0.19)
     simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
-    stringio (3.2.0)
-    sys-uname (1.4.1)
+    sys-uname (1.5.1)
       ffi (~> 1.1)
       memoist3 (~> 1.0.0)
-    tago (0.6.0)
+    tago (0.7.0)
     thor (1.5.0)
     tsort (0.2.0)
     unicode-display_width (3.2.0)
       unicode-emoji (~> 4.1)
     unicode-emoji (4.2.0)
-    webmock (3.26.1)
+    webmock (3.26.2)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
@@ -182,11 +200,12 @@ PLATFORMS
   arm64-darwin-22
   arm64-darwin-23
   arm64-darwin-24
+  arm64-darwin-25
   x86_64-linux
 
 DEPENDENCIES
   aruba (~> 2.2)
-  cucumber (~> 10.0)
+  cucumber (~> 11.0)
   donce (~> 0.2)
   logger (~> 1.7)
   minitest (~> 6.0)
@@ -195,8 +214,9 @@ DEPENDENCIES
   os (~> 1.1)
   qbash (~> 0.0)
   rake (~> 13.2)
-  rdoc (~> 7.0)
-  rubocop (~> 1.62)
+  rdoc (~> 8.0)
+  rubocop (~> 1.72)
+  rubocop-elegant (~> 0.5)
   rubocop-minitest (~> 0.38)
   rubocop-performance (~> 1.25)
   rubocop-rake (~> 0.7)

data/README.md

@@ -7,7 +7,7 @@
 [![rake](https://github.com/yegor256/sibit/actions/workflows/rake.yml/badge.svg)](https://github.com/yegor256/sibit/actions/workflows/rake.yml)
 [![PDD status](https://www.0pdd.com/svg?name=yegor256/sibit)](https://www.0pdd.com/p?name=yegor256/sibit)
 [![Gem Version](https://badge.fury.io/rb/sibit.svg)](https://badge.fury.io/rb/sibit)
-[![License](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/yegor256/takes/sibit/master/LICENSE.txt)
+[![License](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/yegor256/sibit/blob/master/LICENSE.txt)
 [![Test Coverage](https://img.shields.io/codecov/c/github/yegor256/sibit.svg)](https://codecov.io/github/yegor256/sibit?branch=master)
 [![Hits-of-Code](https://hitsofcode.com/github/yegor256/sibit)](https://hitsofcode.com/view/github/yegor256/sibit)
 
@@ -80,7 +80,7 @@ Not all [UTXOs] may be used, but only the necessary amount of them.
 
 By default, the fee is paid on top of the payment amount you are sending.
 Say, you are sending 0.5 BTC and the fee is 0.0001 BTC.
-Totally, you spend 0.5001.
+In total, you spend 0.5001 BTC.
 However, you can make Sibit deduct the fee from the payment amount.
 In this case you should provide a negative amount
   of the fee or one of `S-`, `M-`, `L-`, `XL-`.
@@ -91,6 +91,18 @@ It is recommended to run it with `--dry --verbose` options first,
 If everything looks correct, remove the `--dry` and run again,
   the transaction is pushed to the network.
 
+To require a minimum number of confirmations on every UTXO before it is
+  spent, or before it counts toward the reported balance, pass `--trust`:
+
+```bash
+sibit --trust=6 balance 1PfsYNygsuVL8fvBarJNQnHytkg4rGih1U
+sibit --trust=6 pay 10000 S P1,P2 TARGET CHANGE
+```
+
+The default is `0`, which preserves the existing behavior.
+The same option is available from the Ruby SDK via the `trust:` keyword
+  argument on `Sibit#balance` and `Sibit#pay`.
+
 To use an HTTPS proxy for all requests:
 
 ```bash
@@ -135,6 +147,7 @@ At the moment we work with the following APIs:
 * [Bitcoinchain.com] - `Sibit::Bitcoinchain`
 * [Blockchair.com] - `Sibit::Blockchair`
 * [Cex.io] - `Sibit::Cex`
+* [SoChain] - `Sibit::Sochain`
 
 The first one in this list is used by default.
 If you want to use a different one,
@@ -211,6 +224,7 @@ If it's clean and you don't see any error messages, submit your pull request.
 [Cex.io]: https://cex.io/rest-api
 [Cryptoapis.io]: https://docs.cryptoapis.io/rest-apis/blockchain-as-a-service-apis/btc/index
 [Electrum]: https://electrum.org/
+[SoChain]: https://sochain.com/api
 [miner fee]: https://en.bitcoin.it/wiki/Miner_fees
 [private key]: https://en.bitcoin.it/wiki/Private_key
 [Ruby]: https://www.ruby-lang.org/en/

data/Rakefile

@@ -35,7 +35,7 @@ task :picks do
   next if OS.windows?
   %w[lib].each do |d|
     Dir["#{d}/**/*.rb"].each do |f|
-      qbash("bundle exec ruby #{Shellwords.escape(f)}", log: $stdout, env: { 'PICKS' => 'yes' })
+      qbash("bundle exec ruby #{Shellwords.escape(f)}", stdout: $stdout, env: { 'PICKS' => 'yes' })
     end
   end
 end

data/bin/sibit

@@ -10,23 +10,25 @@ require 'backtrace'
 require 'loog'
 require_relative '../lib/sibit'
 require_relative '../lib/sibit/bin'
-require_relative '../lib/sibit/http'
-require_relative '../lib/sibit/httpproxy'
 require_relative '../lib/sibit/bitcoinchain'
 require_relative '../lib/sibit/blockchain'
 require_relative '../lib/sibit/blockchair'
 require_relative '../lib/sibit/btc'
 require_relative '../lib/sibit/cex'
+require_relative '../lib/sibit/cryptoapis'
 require_relative '../lib/sibit/dry'
 require_relative '../lib/sibit/fake'
 require_relative '../lib/sibit/firstof'
+require_relative '../lib/sibit/http'
+require_relative '../lib/sibit/httpproxy'
+require_relative '../lib/sibit/sochain'
 require_relative '../lib/sibit/version'
 
 begin
   Sibit::Bin.start(ARGV)
 rescue StandardError => e
-  verbose = !ARGV.include?('--quiet') &&
-            (ARGV.include?('--verbose') || ENV.fetch('SIBIT_VERBOSE', nil))
+  wants = ARGV.include?('--verbose') || ENV.fetch('SIBIT_VERBOSE', nil)
+  verbose = !ARGV.include?('--quiet') && wants
   log = verbose ? Loog::VERBOSE : Loog::REGULAR
   if verbose
     log.error(Backtrace.new(e))

data/cross/alpine.df

@@ -0,0 +1,6 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM alpine:3.21
+
+RUN apk add --no-cache ruby ruby-dev gcc make musl-dev openssl-dev bash

data/cross/centos.df

@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM quay.io/centos/centos:stream9
+
+RUN dnf install -y epel-release && \
+    dnf config-manager --set-enabled crb && \
+    dnf install -y gcc make openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel tar && \
+    curl -fsSL https://github.com/rbenv/ruby-build/archive/refs/heads/master.tar.gz | tar -xz && \
+    PREFIX=/usr/local ./ruby-build-master/install.sh && \
+    ruby-build 3.2.6 /usr/local && \
+    rm -rf ruby-build-master && \
+    dnf clean all

data/cross/debian.df

@@ -0,0 +1,9 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM debian:trixie
+
+RUN apt-get update && \
+    apt-get install -y ruby ruby-dev gcc make libssl-dev && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*

data/cross/fedora.df

@@ -0,0 +1,7 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM fedora:41
+
+RUN dnf install -y ruby ruby-devel gcc make openssl-devel && \
+    dnf clean all

data/cross/opensuse.df

@@ -0,0 +1,9 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM opensuse/tumbleweed
+
+RUN zypper --non-interactive install ruby ruby-devel gcc make libopenssl-devel bash && \
+    zypper clean --all && \
+    gem update --system --no-document && \
+    sed -i '/format.executable/d' /etc/gemrc

data/cross/rocky.df

@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM rockylinux:9
+
+RUN dnf install -y epel-release && \
+    dnf config-manager --set-enabled crb && \
+    dnf install -y gcc make openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel tar && \
+    curl -fsSL https://github.com/rbenv/ruby-build/archive/refs/heads/master.tar.gz | tar -xz && \
+    PREFIX=/usr/local ./ruby-build-master/install.sh && \
+    ruby-build 3.2.6 /usr/local && \
+    rm -rf ruby-build-master && \
+    dnf clean all

data/cross/ubuntu.df

@@ -0,0 +1,9 @@
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+FROM ubuntu:24.04
+
+RUN apt-get update && \
+    apt-get install -y ruby ruby-dev gcc make libssl-dev && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*

data/features/cli.feature

@@ -44,6 +44,7 @@ Feature: Command Line Processing
     When I run bin/sibit with "pay --help"
     Then Exit code is zero
     And Stdout contains "--skip-utxo"
+    And Stdout contains "--price"
 
   Scenario: Unknown option shows error message
     When I run bin/sibit with "generate --foo"

data/features/step_definitions/steps.rb

@@ -3,9 +3,9 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
+require 'English'
 require 'nokogiri'
 require 'tmpdir'
-require 'English'
 require_relative '../../lib/sibit'
 
 Before do
@@ -32,19 +32,19 @@ When(%r{^I run bin/sibit with "([^"]*)"$}) do |arg|
 end
 
 Then(/^Stdout contains "([^"]*)"$/) do |txt|
-  raise "STDOUT doesn't contain '#{txt}':\n#{@stdout}" unless @stdout.include?(txt)
+  raise(StandardError, "STDOUT doesn't contain '#{txt}':\n#{@stdout}") unless @stdout.include?(txt)
 end
 
 Then(/^Stdout is empty$/) do
-  raise "STDOUT is not empty:\n#{@stdout}" unless @stdout == ''
+  raise(StandardError, "STDOUT is not empty:\n#{@stdout}") unless @stdout == ''
 end
 
 Then(/^Exit code is zero$/) do
-  raise "Non-zero exit #{@exitstatus}:\n#{@stdout}" unless @exitstatus.zero?
+  raise(StandardError, "Non-zero exit #{@exitstatus}:\n#{@stdout}") unless @exitstatus.zero?
 end
 
 Then(/^Exit code is not zero$/) do
-  raise 'Zero exit code' if @exitstatus.zero?
+  raise(StandardError, 'Zero exit code') if @exitstatus.zero?
 end
 
 When(/^I run bash with "([^"]*)"$/) do |text|

data/features/support/env.rb

@@ -3,6 +3,6 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
-require 'simplecov'
 require 'aruba/cucumber'
+require 'simplecov'
 require_relative '../../lib/sibit'

data/lib/sibit/base58.rb

@@ -23,28 +23,25 @@ class Sibit
     end
 
     def encode
-      bytes = [@data].pack('H*')
-      leading = bytes.match(/^\x00*/)[0].length
       num = @data.to_i(16)
       result = ''
       while num.positive?
         num, remainder = num.divmod(58)
         result = ALPHABET[remainder] + result
       end
-      ('1' * leading) + result
+      ('1' * [@data].pack('H*').match(/^\x00*/)[0].length) + result
     end
 
     def decode
-      leading = @data.match(/^1*/)[0].length
       num = 0
       @data.each_char do |c|
         idx = ALPHABET.index(c)
-        raise Sibit::Error, "Invalid Base58 character '#{c}' in address '#{@data}'" if idx.nil?
+        raise(Sibit::Error, "Invalid Base58 character '#{c}' in address '#{@data}'") if idx.nil?
         num = (num * 58) + idx
       end
       hex = num.zero? ? '' : num.to_s(16)
       hex = "0#{hex}" if hex.length.odd?
-      ('00' * leading) + hex
+      ('00' * @data.match(/^1*/)[0].length) + hex
     end
 
     def check

data/lib/sibit/bech32.rb

@@ -19,15 +19,13 @@ class Sibit
     GENERATOR = [0x3b6a57b2, 0x26508e6d, 0x1ea119fa, 0x3d4233dd, 0x2a1462b3].freeze
 
     def self.encode(hrp, ver, prog)
-      bytes = [prog].pack('H*').bytes
-      data = [ver] + bits(bytes, 8, 5, true)
+      data = [ver] + bits([prog].pack('H*').bytes, 8, 5, true)
       chk = checksum(hrp, data)
       "#{hrp}1#{(data + chk).map { |d| CHARSET[d] }.join}"
     end
 
     def self.checksum(hrp, data)
-      values = expanded(hrp) + data + [0, 0, 0, 0, 0, 0]
-      poly = pm(values) ^ 1
+      poly = pm(expanded(hrp) + data + [0, 0, 0, 0, 0, 0]) ^ 1
       (0..5).map { |i| (poly >> (5 * (5 - i))) & 31 }
     end
 
@@ -68,9 +66,8 @@ class Sibit
 
     def witness
       hrp, data = parse
-      raise Sibit::Error, "Invalid Bech32 checksum in '#{@addr}'" unless verified?(hrp, data)
-      prog = convert(data[1..-7], 5, 8, false)
-      prog.pack('C*').unpack1('H*')
+      raise(Sibit::Error, "Invalid Bech32 checksum in '#{@addr}'") unless verified?(hrp, data)
+      convert(data[1..-7], 5, 8, false).pack('C*').unpack1('H*')
     end
 
     def version
@@ -82,18 +79,16 @@ class Sibit
 
     def parse
       pos = @addr.rindex('1')
-      raise Sibit::Error, "Invalid Bech32 address '#{@addr}': no separator" if pos.nil? || pos < 1
-      hrp = @addr[0...pos]
+      raise(Sibit::Error, "Invalid Bech32 address '#{@addr}': no separator") if pos.nil? || pos < 1
       rest = @addr[(pos + 1)..]
-      raise Sibit::Error, "Invalid Bech32 address '#{@addr}': data too short" if rest.length < 6
+      raise(Sibit::Error, "Invalid Bech32 address '#{@addr}': data too short") if rest.length < 6
       data = rest.chars.map { |c| CHARSET.index(c) }
-      raise Sibit::Error, "Invalid Bech32 character in '#{@addr}'" if data.include?(nil)
-      [hrp, data]
+      raise(Sibit::Error, "Invalid Bech32 character in '#{@addr}'") if data.include?(nil)
+      [@addr[0...pos], data]
     end
 
     def verified?(hrp, data)
-      chk = polymod(expand(hrp) + data)
-      [1, 0x2bc830a3].include?(chk)
+      [1, 0x2bc830a3].include?(polymod(expand(hrp) + data))
     end
 
     def expand(hrp)

data/lib/sibit/bestof.rb

@@ -83,21 +83,24 @@ class Sibit::BestOf
   private
 
   def best_of(method)
-    return yield @list unless @list.is_a?(Array)
+    return yield(@list) unless @list.is_a?(Array)
     results = []
     errors = []
     @list.each do |api|
       results << yield(api)
     rescue Sibit::NotSupportedError
-      # Just ignore it
+      nil
     rescue Sibit::Error => e
       errors << e
       @log.debug("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
     end
     if results.empty?
       errors.each { |e| @log.debug(Backtrace.new(e).to_s) }
-      raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
-#{@list.map { |a| a.class.name }.join(', ')}"
+      raise(
+        Sibit::Error,
+        "No APIs out of #{@list.length} managed to succeed at #{method}(): " \
+        "#{@list.map { |a| a.class.name }.join(', ')}"
+      )
     end
     results.group_by(&:to_s).values.max_by(&:size)[0]
   end