sibit 0.19.2 → 0.20.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db71c5de986c5aeacfb60ddde907c84eade4b53e2b764f513cd6ea20c7a95c45
-  data.tar.gz: c79bc1c5b9c544bcc16a61fff3912f09dd5b05152d5cbf667b418d5207d37575
+  metadata.gz: 0734db295c639e548f4b51d170e87bbabe2c6b94d7d4ba7e858716b74f145185
+  data.tar.gz: 9ff51aecc8e78f13917907f62e6485800531dd7d36198df80b5a089831fcbfcc
 SHA512:
-  metadata.gz: 951c554ef902b64007c6807976c99f44f909a28730bff366135d5fb2728cae935df206fd065f9500d4f885982c10175c9775ba3001bb37de42ad2f2969dd45ee
-  data.tar.gz: b60396b85498717187962637e00008b394eddcb030cdfb5839b3d043bfc086974f05f638057940f621ab1d7d60016857ed19d7bb0354325adcd3e5ebc964f3da
+  metadata.gz: '0095805aee3fbe209a73bcda6a9832e9aa26b43414232c6fa59d6fbed09a7648bcd6739e76a558106f86a152a9ebbf5b36c32afffd927f9a2f5feaa34fa4c4d4'
+  data.tar.gz: 0fde0492c34a1f636180f01d0a331da019e8b461b0819909869cd9f0b5b3f6fb9070f1d79fa6a80f87f3f8903975abeeb7a6e30e9b9b8a4fa5de7f8fbf522794

data/.rultor.yml

@@ -5,7 +5,7 @@ install: |
   sudo bundle install --no-color "--gemfile=$(pwd)/Gemfile"
 release:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
     sed -i "s/1\.0\.snapshot/${tag}/g" lib/sibit/version.rb
     git add lib/sibit/version.rb
     git commit -m "version set to ${tag}"
@@ -14,7 +14,7 @@ release:
     gem push *.gem --config-file ../rubygems.yml
 merge:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
 deploy:
   script: |-
     echo "There is nothing to deploy"

data/bin/sibit

@@ -29,9 +29,12 @@ require 'retriable_proxy'
 require_relative '../lib/sibit'
 require_relative '../lib/sibit/version'
 require_relative '../lib/sibit/blockchain'
+require_relative '../lib/sibit/blockchair'
 require_relative '../lib/sibit/btc'
 require_relative '../lib/sibit/bitcoinchain'
+require_relative '../lib/sibit/cex'
 require_relative '../lib/sibit/earn'
+require_relative '../lib/sibit/fake'
 require_relative '../lib/sibit/firstof'
 
 begin
@@ -62,7 +65,7 @@ Options are:"
       o.array(
         '--api',
         'Ordered List of APIs to use, e.g. "earn,blockchain,btc,bitcoinchain"',
-        default: %w[earn blockchain btc bitcoinchain]
+        default: %w[earn blockchain btc bitcoinchain blockchair cex]
       )
     end
   rescue Slop::Error => ex
@@ -79,6 +82,12 @@ Options are:"
       api = Sibit::Btc.new(http: http, log: log, dry: opts[:dry])
     elsif a == 'bitcoinchain'
       api = Sibit::Bitcoinchain.new(http: http, log: log, dry: opts[:dry])
+    elsif a == 'blockchair'
+      api = Sibit::Blockchair.new(http: http, log: log, dry: opts[:dry])
+    elsif a == 'cex'
+      api = Sibit::Cex.new(http: http, log: log, dry: opts[:dry])
+    elsif a == 'fake'
+      api = Sibit::Fake.new
     elsif a == 'earn'
       api = Sibit::Earn.new(http: http, log: log, dry: opts[:dry])
     else
@@ -87,7 +96,7 @@ Options are:"
     api = RetriableProxy.for_object(api, on: Sibit::Error) if opts[:attempts] > 1
     api
   end
-  sibit = Sibit.new(log: log, api: Sibit::FirstOf.new(apis, log: log))
+  sibit = Sibit.new(log: log, api: Sibit::FirstOf.new(apis, log: log, verbose: true))
   case opts.arguments[0]
   when 'price'
     puts sibit.price

data/features/cli.feature

@@ -31,5 +31,5 @@ Feature: Command Line Processing
     Then Exit code is zero
 
   Scenario: Bitcoin fees can be printed
-    When I run bin/sibit with "fees --verbose"
+    When I run bin/sibit with "fees --verbose --api=fake"
     Then Exit code is zero

data/lib/sibit/bestof.rb

@@ -32,9 +32,10 @@ class Sibit
   # Best of API.
   class BestOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -106,7 +107,7 @@ class Sibit
         begin
           results << yield(api)
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       if results.empty?

data/lib/sibit/btc.rb

@@ -58,7 +58,16 @@ class Sibit
         @log.info("The balance of #{address} is zero (not found)")
         return 0
       end
-      txns = json['data']['list']
+      data = json['data']
+      if data.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
+      txns = data['list']
+      if txns.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
       balance = txns.map { |tx| tx['value'] }.inject(&:+) || 0
       @log.info("The balance of #{address} is #{balance}, total txns: #{txns.count}")
       balance
@@ -86,6 +95,7 @@ class Sibit
       data = json['data']
       raise Sibit::Error, "The block #{hash} not found" if data.nil?
       h = data['height']
+      raise Sibit::Error, "The block #{hash} found but the height is absent" if h.nil?
       @log.info("The height of #{hash} is #{h}")
       h
     end
@@ -115,7 +125,9 @@ class Sibit
         )
         data = json['data']
         raise Sibit::Error, "The address #{hash} not found" if data.nil?
-        data['list'].each do |u|
+        txns = data['list']
+        next if txns.nil?
+        txns.each do |u|
           outs = Sibit::Json.new(http: @http, log: @log).get(
             URI("https://chain.api.btc.com/v3/tx/#{u['tx_hash']}?verbose=3")
           )['data']['outputs']
@@ -164,9 +176,13 @@ class Sibit
       psize = 50
       all = []
       loop do
-        txns = Sibit::Json.new(http: @http, log: @log).get(
+        data = Sibit::Json.new(http: @http, log: @log).get(
           URI("https://chain.api.btc.com/v3/block/#{hash}/tx?page=#{page}&pagesize=#{psize}")
-        )['data']['list'].map do |t|
+        )['data']
+        raise Sibit::Error, "The block #{hash} has no data at page #{page}" if data.nil?
+        list = data['list']
+        raise Sibit::Error, "The list is empty for block #{hash} at page #{page}" if list.nil?
+        txns = list.map do |t|
           {
             hash: t['hash'],
             outputs: t['outputs'].reject { |o| o['spent_by_tx'] }.map do |o|

data/lib/sibit/firstof.rb

@@ -32,9 +32,10 @@ class Sibit
   # First of API.
   class FirstOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -104,12 +105,13 @@ class Sibit
       done = false
       result = nil
       @list.each do |api|
+        @log.info("Calling #{api.class.name}##{method}()...")
         begin
           result = yield api
           done = true
           break
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       unless done

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.19.2'
+  VERSION = '0.20.2'
 end

data/sibit.gemspec

@@ -55,7 +55,7 @@ and Ruby 2.3+.'
   s.add_runtime_dependency 'retriable_proxy', '1.0.2'
   s.add_runtime_dependency 'slop', '~> 4.6'
   s.add_development_dependency 'aruba', '~> 0.14.1'
-  s.add_development_dependency 'codecov', '0.1.10'
+  s.add_development_dependency 'codecov', '0.2.8'
   s.add_development_dependency 'cucumber', '~> 1.3.17'
   s.add_development_dependency 'debase', '0.2.2'
   s.add_development_dependency 'minitest', '5.5.0'

data/test/test_btc.rb

@@ -42,6 +42,28 @@ class TestBtc < Minitest::Test
     assert_equal(0, balance)
   end
 
+  def test_get_zero_balance_no_txns
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{"data":{}}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
+  def test_get_broken_balance
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
   def test_get_empty_balance
     stub_request(
       :get,
@@ -64,6 +86,18 @@ class TestBtc < Minitest::Test
     assert_equal(123, balance)
   end
 
+  def test_fetch_block_broken
+    hash = '000000000000000007341915521967247f1dec17b3a311b8a8f4495392f1439b'
+    stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}")
+      .to_return(body: '{"data": {"next_block_hash": "n", "hash": "h", "prev_block_hash": "p"}}')
+    stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}/tx?page=1&pagesize=50")
+      .to_return(body: '{}')
+    sibit = Sibit::Btc.new
+    assert_raises Sibit::Error do
+      sibit.block(hash)
+    end
+  end
+
   def test_fetch_block
     hash = '000000000000000007341915521967247f1dec17b3a311b8a8f4495392f1439b'
     stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.19.2
+  version: 0.20.2
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2020-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.10
+        version: 0.2.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.10
+        version: 0.2.8
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement