sibit 0.19.1 → 0.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63efa03d475df765f994bd609f8f5deb31cea1450566f1e68a8c5a8ac497ec0c
-  data.tar.gz: c36540c991e462bf6825d9a48109a3f0c1a4ca1934b4741a17074a3cf8503565
+  metadata.gz: 3b0578e225f53b1d3904fae19aa6f41ba7aea719bd137587821b3e2fba2a0373
+  data.tar.gz: 82178b4a20da5d18d99101649c31ad8fd3188c88a4ea74577cf2413d1bf6f9e2
 SHA512:
-  metadata.gz: 98cc194b64718dc11ba35650a6c1bda4b52e4ca04cd935784f45387fb6dbdb552de00343d5e7dfd90ba796137500028bf5c31177006a087f2ec2a754751d3a5e
-  data.tar.gz: 161f739388531e1b79ca07860d374023c0ff8109de32b35d35dc487892b4fa09e2db2471a524983aa8f2e35723806053dcbeb0e98ecc9ff2e8ecfe2e1da737ec
+  metadata.gz: 756a8a1273e053f4a880220f8d33db38544e36f4a0d38118ee72cc1421d21311900859b9fbac5732c24260a9c48d7599f0865970db27e7046543ad52b2ceb223
+  data.tar.gz: 64650acdb47d4671028075dd84e1d3f7f5c8eefb9c67e5b45212e5d6c5aaec1e1576419a126808b20a4e11fc6dc2bd16ea5f473accbb0d1dac936c2896308ecc

data/.rultor.yml

@@ -5,7 +5,7 @@ install: |
   sudo bundle install --no-color "--gemfile=$(pwd)/Gemfile"
 release:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
     sed -i "s/1\.0\.snapshot/${tag}/g" lib/sibit/version.rb
     git add lib/sibit/version.rb
     git commit -m "version set to ${tag}"
@@ -14,7 +14,7 @@ release:
     gem push *.gem --config-file ../rubygems.yml
 merge:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
 deploy:
   script: |-
     echo "There is nothing to deploy"

data/lib/sibit/bestof.rb

@@ -32,9 +32,10 @@ class Sibit
   # Best of API.
   class BestOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -106,12 +107,12 @@ class Sibit
         begin
           results << yield(api)
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       if results.empty?
-        raise Sibit::Error, "No APIs out of #{@api.length} managed to succeed at #{method}(): \
-#{@api.map { |a| a.class.name }.join(', ')}"
+        raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
+#{@list.map { |a| a.class.name }.join(', ')}"
       end
       results.group_by(&:to_s).values.max_by(&:size)[0]
     end

data/lib/sibit/btc.rb

@@ -58,7 +58,16 @@ class Sibit
         @log.info("The balance of #{address} is zero (not found)")
         return 0
       end
-      txns = json['data']['list']
+      data = json['data']
+      if data.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
+      txns = data['list']
+      if txns.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
       balance = txns.map { |tx| tx['value'] }.inject(&:+) || 0
       @log.info("The balance of #{address} is #{balance}, total txns: #{txns.count}")
       balance
@@ -164,9 +173,13 @@ class Sibit
       psize = 50
       all = []
       loop do
-        txns = Sibit::Json.new(http: @http, log: @log).get(
+        data = Sibit::Json.new(http: @http, log: @log).get(
           URI("https://chain.api.btc.com/v3/block/#{hash}/tx?page=#{page}&pagesize=#{psize}")
-        )['data']['list'].map do |t|
+        )['data']
+        raise Sibit::Error, "The block #{hash} has no data at page #{page}" if data.nil?
+        list = data['list']
+        raise Sibit::Error, "The list is empty for block #{hash} at page #{page}" if list.nil?
+        txns = list.map do |t|
           {
             hash: t['hash'],
             outputs: t['outputs'].reject { |o| o['spent_by_tx'] }.map do |o|

data/lib/sibit/firstof.rb

@@ -32,9 +32,10 @@ class Sibit
   # First of API.
   class FirstOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -109,12 +110,12 @@ class Sibit
           done = true
           break
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       unless done
-        raise Sibit::Error, "No APIs out of #{@api.length} managed to succeed at #{method}(): \
-#{@api.map { |a| a.class.name }.join(', ')}"
+        raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
+#{@list.map { |a| a.class.name }.join(', ')}"
       end
       result
     end

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.19.1'
+  VERSION = '0.20.1'
 end

data/test/test_bestof.rb

@@ -47,4 +47,16 @@ class TestBestOf < Minitest::Test
     assert_equal(64, sibit.latest.length)
     assert_equal(12, sibit.fees[:S])
   end
+
+  def test_all_fail
+    api = Class.new do
+      def latest
+        raise Sibit::Error, 'intentionally'
+      end
+    end.new
+    sibit = Sibit::BestOf.new([api, api])
+    assert_raises Sibit::Error do
+      sibit.latest
+    end
+  end
 end

data/test/test_btc.rb

@@ -42,6 +42,28 @@ class TestBtc < Minitest::Test
     assert_equal(0, balance)
   end
 
+  def test_get_zero_balance_no_txns
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{"data":{}}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
+  def test_get_broken_balance
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
   def test_get_empty_balance
     stub_request(
       :get,
@@ -64,6 +86,18 @@ class TestBtc < Minitest::Test
     assert_equal(123, balance)
   end
 
+  def test_fetch_block_broken
+    hash = '000000000000000007341915521967247f1dec17b3a311b8a8f4495392f1439b'
+    stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}")
+      .to_return(body: '{"data": {"next_block_hash": "n", "hash": "h", "prev_block_hash": "p"}}')
+    stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}/tx?page=1&pagesize=50")
+      .to_return(body: '{}')
+    sibit = Sibit::Btc.new
+    assert_raises Sibit::Error do
+      sibit.block(hash)
+    end
+  end
+
   def test_fetch_block
     hash = '000000000000000007341915521967247f1dec17b3a311b8a8f4495392f1439b'
     stub_request(:get, "https://chain.api.btc.com/v3/block/#{hash}")

data/test/test_firstof.rb

@@ -47,4 +47,16 @@ class TestFirstOf < Minitest::Test
     assert_equal(64, sibit.latest.length)
     assert_equal(12, sibit.fees[:S])
   end
+
+  def test_all_fail
+    api = Class.new do
+      def latest
+        raise Sibit::Error, 'intentionally'
+      end
+    end.new
+    sibit = Sibit::FirstOf.new([api, api])
+    assert_raises Sibit::Error do
+      sibit.latest
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.19.1
+  version: 0.20.1
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-17 00:00:00.000000000 Z
+date: 2020-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace