sibit 0.19.0 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c16c2d9c8fd8acd2635dc38d1b97599dc2138851ffc162db62aa3dc35feec993
-  data.tar.gz: b17f0c383453182402041ac8793eb2e308480b660e4bd79577a846a6517cf66e
+  metadata.gz: 4b0e095b8a42b4036cc160bf0c7cd2d8d80801fb4aa609c34846fe42e711a9a8
+  data.tar.gz: 5da2b30520ff7ac48783d6a264c501b8b26dbbcf4934a2927e1b9252803f5666
 SHA512:
-  metadata.gz: 3a7234573110a1fd17ed0e67257474f5c07801e0fd74a0212ca1e08453e9088aeae00b803382814119b9e16fe1b22a9f2fab1974724fdc5c1f5f0d11649e5e29
-  data.tar.gz: '089e4b96cf9c5fb0b3e17bd1692e9ee66f553c2752fd8669a520008a533dacc60063c473264f0469d394a5c272209419026f4920dfa3f3f97bbfc422fe359751'
+  metadata.gz: b60bbbaf728cc95fc71078096d850f675f2d933ee889a1edb38798f21267ad4e22b7904f786853bcb8c1507aac7a29c3fa195a56d7be5da41d067a6832983c69
+  data.tar.gz: fa7e0c793d4e21d151c1e5758b2c2c8f98fdd1aaa92368bf3c70527083185b85a6b2a769a51f56b9a5a24e6105e0fb6eac0cb0d78470d8de7f1eb236b0f46423

data/.rultor.yml

@@ -5,7 +5,7 @@ install: |
   sudo bundle install --no-color "--gemfile=$(pwd)/Gemfile"
 release:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
     sed -i "s/1\.0\.snapshot/${tag}/g" lib/sibit/version.rb
     git add lib/sibit/version.rb
     git commit -m "version set to ${tag}"
@@ -14,7 +14,7 @@ release:
     gem push *.gem --config-file ../rubygems.yml
 merge:
   script: |-
-    bundle exec rake
+    bundle exec rake clean test rubocop copyright
 deploy:
   script: |-
     echo "There is nothing to deploy"

data/lib/sibit.rb

@@ -214,13 +214,13 @@ class Sibit
         end
         checked += 1
       end
+      count += 1
       @log.info("We checked #{checked} txns and #{checked_outputs} outputs in block #{block}")
       block = json[:next]
       if block.nil?
         @log.info("The next_block is empty in block #{json[:hash]}, this is the end of Blockchain")
         break
       end
-      count += 1
       if count > max
         @log.info("Too many blocks (#{count}) in one go, let's get back to it next time")
         break

data/lib/sibit/bestof.rb

@@ -32,9 +32,10 @@ class Sibit
   # Best of API.
   class BestOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -106,12 +107,12 @@ class Sibit
         begin
           results << yield(api)
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       if results.empty?
-        raise Sibit::Error, "No APIs out of #{@api.length} managed to succeed at #{method}(): \
-#{@api.map { |a| a.class.name }.join(', ')}"
+        raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
+#{@list.map { |a| a.class.name }.join(', ')}"
       end
       results.group_by(&:to_s).values.max_by(&:size)[0]
     end

data/lib/sibit/btc.rb

@@ -58,7 +58,16 @@ class Sibit
         @log.info("The balance of #{address} is zero (not found)")
         return 0
       end
-      txns = json['data']['list']
+      data = json['data']
+      if data.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
+      txns = data['list']
+      if txns.nil?
+        @log.info("The balance of #{address} is probably zero (not found)")
+        return 0
+      end
       balance = txns.map { |tx| tx['value'] }.inject(&:+) || 0
       @log.info("The balance of #{address} is #{balance}, total txns: #{txns.count}")
       balance

data/lib/sibit/firstof.rb

@@ -32,9 +32,10 @@ class Sibit
   # First of API.
   class FirstOf
     # Constructor.
-    def initialize(list, log: Sibit::Log.new)
+    def initialize(list, log: Sibit::Log.new, verbose: false)
       @list = list
       @log = log
+      @verbose = verbose
     end
 
     # Current price of BTC in USD (float returned).
@@ -109,12 +110,12 @@ class Sibit
           done = true
           break
         rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}")
+          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       unless done
-        raise Sibit::Error, "No APIs out of #{@api.length} managed to succeed at #{method}(): \
-#{@api.map { |a| a.class.name }.join(', ')}"
+        raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
+#{@list.map { |a| a.class.name }.join(', ')}"
       end
       result
     end

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.19.0'
+  VERSION = '0.20.0'
 end

data/test/test_bestof.rb

@@ -47,4 +47,16 @@ class TestBestOf < Minitest::Test
     assert_equal(64, sibit.latest.length)
     assert_equal(12, sibit.fees[:S])
   end
+
+  def test_all_fail
+    api = Class.new do
+      def latest
+        raise Sibit::Error, 'intentionally'
+      end
+    end.new
+    sibit = Sibit::BestOf.new([api, api])
+    assert_raises Sibit::Error do
+      sibit.latest
+    end
+  end
 end

data/test/test_btc.rb

@@ -42,6 +42,28 @@ class TestBtc < Minitest::Test
     assert_equal(0, balance)
   end
 
+  def test_get_zero_balance_no_txns
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{"data":{}}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
+  def test_get_broken_balance
+    stub_request(
+      :get,
+      'https://chain.api.btc.com/v3/address/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f/unspent'
+    ).to_return(body: '{}')
+    sibit = Sibit::Btc.new
+    balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')
+    assert(balance.is_a?(Integer))
+    assert_equal(0, balance)
+  end
+
   def test_get_empty_balance
     stub_request(
       :get,

data/test/test_firstof.rb

@@ -47,4 +47,16 @@ class TestFirstOf < Minitest::Test
     assert_equal(64, sibit.latest.length)
     assert_equal(12, sibit.fees[:S])
   end
+
+  def test_all_fail
+    api = Class.new do
+      def latest
+        raise Sibit::Error, 'intentionally'
+      end
+    end.new
+    sibit = Sibit::FirstOf.new([api, api])
+    assert_raises Sibit::Error do
+      sibit.latest
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.20.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-17 00:00:00.000000000 Z
+date: 2020-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace