shutl_resource 0.10.5 → 0.10.6

data/lib/shutl/resource/configuration.rb

@@ -1,9 +1,9 @@
 require 'logger'
 
 module Shutl::Resource
-
   class << self
-    attr_writer :raise_exceptions_on_validation
+    attr_writer :raise_exceptions_on_validation,
+                :raise_exceptions_on_no_quotes_generated
 
     def raise_exceptions_on_validation
       if @raise_exceptions_on_validation.nil?
@@ -12,6 +12,14 @@ module Shutl::Resource
 
       @raise_exceptions_on_validation
     end
+
+    def raise_exceptions_on_no_quotes_generated
+      if @raise_exceptions_on_no_quotes_generated.nil?
+        @raise_exceptions_on_no_quotes_generated = true
+      end
+
+      @raise_exceptions_on_no_quotes_generated
+    end
   end
 
   def configure(*args, &block)

data/lib/shutl/resource/rest_class_methods.rb

@@ -234,7 +234,13 @@ module Shutl::Resource
     def check_fail response, message
       c             = response.code
       failure_klass = case c
-                      when 299 then Shutl::NoQuotesGenerated
+                      when 299
+                        if Shutl::Resource.raise_exceptions_on_no_quotes_generated
+                          Shutl::NoQuotesGenerated
+                        else
+                          nil
+                        end
+
                       when 400 then Shutl::BadRequest
                       when 401 then Shutl::UnauthorizedAccess
                       when 403 then Shutl::ForbiddenAccess

data/lib/shutl/resource/version.rb

@@ -1,5 +1,5 @@
 module Shutl
   module Resource
-    VERSION = '0.10.5'
+    VERSION = '0.10.6'
   end
 end

data/spec/rest_resource_spec.rb

@@ -81,15 +81,44 @@ describe Shutl::Resource::Rest do
         resource.instance_variable_get('@b').should == 2
       end
 
-      Shutl::Resource.raise_exceptions_on_validation = true
+      context "299" do
+        specify do
+          @default = Shutl::Resource.raise_exceptions_on_no_quotes_generated
+          Shutl::Resource.raise_exceptions_on_no_quotes_generated = false
+
+          stub_request(:get, 'http://host/test_rests/b').
+            to_return(status: 299, :body => '{"errors": {"base":["No quotes for you today"]}}')
+
+          expect(-> { TestRest.find('b') }).not_to raise_error Shutl::NoQuotesGenerated
+          Shutl::Resource.raise_exceptions_on_no_quotes_generated = @default
+        end
+      end
+
+      context "422" do
+        before do
+          @default = Shutl::Resource.raise_exceptions_on_validation
+          Shutl::Resource.raise_exceptions_on_validation = true
+        end
+
+        after do
+          Shutl::Resource.raise_exceptions_on_validation = @default
+        end
+        specify do
+          stub_request(:get, 'http://host/test_rests/b').
+            to_return(status: 422)
+
+          expect(-> { TestRest.find('b') }).to raise_error(Shutl::ResourceInvalid)
+        end
+      end
+
       {
+        299      => Shutl::NoQuotesGenerated,
         400      => Shutl::BadRequest,
         401      => Shutl::UnauthorizedAccess,
         403      => Shutl::ForbiddenAccess,
         404      => Shutl::ResourceNotFound,
         409      => Shutl::ResourceConflict,
         410      => Shutl::ResourceGone,
-        422      => Shutl::ResourceInvalid,
         503      => Shutl::ServiceUnavailable,
         501..502 => Shutl::ServerError,
         504..599 => Shutl::ServerError
@@ -112,6 +141,7 @@ describe Shutl::Resource::Rest do
         end
       end
 
+
       it 'should add a id based on the resource id' do
         resource = TestRest.find('a')
 
@@ -124,9 +154,9 @@ describe Shutl::Resource::Rest do
         to_return(:status  => 200, :body => '{"test_rest": {}}',
                   :headers => headers)
 
-      TestRest.find('new resource')
+        TestRest.find('new resource')
 
-      request.should have_been_requested
+        request.should have_been_requested
     end
 
     context 'with url arguments' do
@@ -299,9 +329,9 @@ describe Shutl::Resource::Rest do
         with(body:    '{"test_rest":{"a":"a","b":"b"}}',
              headers: headers)
 
-      TestRest.create(a: 'a', b: 'b')
+        TestRest.create(a: 'a', b: 'b')
 
-      request.should have_been_requested
+        request.should have_been_requested
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shutl_resource
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.10.6
   prerelease: 
 platform: ruby
 authors:
@@ -15,7 +15,7 @@ date: 2013-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70115703855460 !ruby/object:Gem::Requirement
+  requirement: &70172591200440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -23,10 +23,10 @@ dependencies:
         version: 0.10.0
   type: :runtime
   prerelease: false
-  version_requirements: *70115703855460
+  version_requirements: *70172591200440
 - !ruby/object:Gem::Dependency
   name: shutl_auth
-  requirement: &70115703853480 !ruby/object:Gem::Requirement
+  requirement: &70172591199320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -34,10 +34,10 @@ dependencies:
         version: 0.8.0
   type: :runtime
   prerelease: false
-  version_requirements: *70115703853480
+  version_requirements: *70172591199320
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70115703852820 !ruby/object:Gem::Requirement
+  requirement: &70172591198300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -45,10 +45,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70115703852820
+  version_requirements: *70172591198300
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70115703850460 !ruby/object:Gem::Requirement
+  requirement: &70172591220740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115703850460
+  version_requirements: *70172591220740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70115703870120 !ruby/object:Gem::Requirement
+  requirement: &70172591214620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -67,10 +67,10 @@ dependencies:
         version: 2.11.0
   type: :development
   prerelease: false
-  version_requirements: *70115703870120
+  version_requirements: *70172591214620
 - !ruby/object:Gem::Dependency
   name: debugger
-  requirement: &70115703885320 !ruby/object:Gem::Requirement
+  requirement: &70172591232420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115703885320
+  version_requirements: *70172591232420
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70115703884340 !ruby/object:Gem::Requirement
+  requirement: &70172591231420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -89,7 +89,7 @@ dependencies:
         version: 1.8.7
   type: :development
   prerelease: false
-  version_requirements: *70115703884340
+  version_requirements: *70172591231420
 description: Shutl Rest resource
 email:
 - davidr@shutl.co.uk
@@ -140,7 +140,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1303369992111380096
+      hash: -655986128022496311
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -149,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1303369992111380096
+      hash: -655986128022496311
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.11