shut_up_assets 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcdbbf1627dfe985fc25972091cbe62f422406c5
-  data.tar.gz: 25829a4b001ef53509ade664e8889700698f6a8f
+  metadata.gz: 4326c7c5389cda01fd84579e6996319ce2e591f1
+  data.tar.gz: 26469a1f1c7d7217798f1acbcd751ddf665c70b1
 SHA512:
-  metadata.gz: b6112d1cac18e632c5cf9a40a829b8ee1be40bf5c65a67f9192fea727925dbc7816b1038eb8e7f15e46f3c01a7a63bb21bdce98a1185180c45d37c8bb186541a
-  data.tar.gz: d44c6281d225d2b78a3f735212c1336b7be0bc2b94fa7c3290dd907a955673b890f51921c46ae3883f526c15bda5a8509fc27bd465422c4d222370c7ab1b9538
+  metadata.gz: 2b6eb26d5d60a2af9b4023f4bad78a4dddedd0537e4ec6b779d3edbc6d1bf554fe2c0fadb28665c0e98bdc94dc4a475c292c4b396783c6c1719b70c842b12f6d
+  data.tar.gz: 2430e6122cfeb7484ec60ee4f0b41a9c38d0b7cefdcf089a205973464cb54f94fcea5f53232ddbfe67fede312b7f334f297a1ffc1d73b34cfe0a5ec155664c3f

data/Gemfile

@@ -2,12 +2,7 @@ source 'https://rubygems.org'
 
 gemspec
 
-group :development, :test do
-  gem 'rails', '~> 4.2'
-end
-
 group :test do
   gem 'minitest'
-  gem 'minitest-spec-rails'
   gem 'minitest-reporters'
 end

data/README.md

@@ -28,7 +28,7 @@ place the following in your `config/application.rb` file:
 
 If you need to supress output for other paths you can do so by specifying:
 
-    config.quiet_assets_paths << '/silent/'
+    config.shut_up_assets.paths << '/silent/'
 
 ## License
 

data/lib/shut_up_assets.rb

@@ -3,20 +3,36 @@ require 'rails/rack/logger'
 require 'active_support/configurable'
 
 class ShutUpAssets < Rails::Railtie # :nodoc-all:
-  class << self
-    def enabled?
-      config.quiet_assets
-    end
+  def self.enabled?
+    config.quiet_assets
+  end
 
-    def suppress_on?(request)
-      enabled? && request.get? && request.filtered_path =~ config.shut_up_assets.pattern
-    end
+  def self.suppress_on?(request)
+    enabled? && request.get? && request.filtered_path =~ config.shut_up_assets.pattern
   end
 
   class RackLogger < Rails::Rack::Logger
+    EMPTY_LINE = "\n".freeze
+
     def call_app(request, env)
-      return super unless ShutUpAssets.suppress_on?(request)
-      logger.silence(::Logger::WARN) { super }
+      suppressed = ShutUpAssets.suppress_on?(request)
+
+      # Put some space between requests in development logs.
+      logger.debug { EMPTY_LINE } if development? && !suppressed
+
+      instrumenter = ActiveSupport::Notifications.instrumenter
+      instrumenter.start 'request.action_dispatch', request: request
+
+      logger.info { started_request_message(request) } unless suppressed
+
+      resp = @app.call(env)
+      resp[2] = ::Rack::BodyProxy.new(resp[2]) { finish(request) }
+      resp
+    rescue Exception
+      finish(request)
+      raise
+    ensure
+      ActiveSupport::LogSubscriber.flush_all!
     end
   end
 

data/shut_up_assets.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'shut_up_assets'
-  spec.version       = '2.0.0'
+  spec.version       = '2.0.1'
   spec.authors       = ['Dmitry Karpunin', 'Dmitry Vorotilin', 'Anton Semenov']
   spec.email         = %w(koderfunk@gmail.com d.vorotilin@gmail.com anton.estum@gmail.com)
   spec.homepage      = 'https://github.com/estum/shut_up_assets'

data/test/integration_test.rb

@@ -4,9 +4,15 @@ class HomeController < ActionController::Base
   def index
     render :text => 'Hi there!'
   end
+
+  def error
+    raise "Breaking"
+    render :text => 'Hi there!'
+  end
 end
 
 class IntegrationTest < ActionController::TestCase
+  EMPTY_LINE = ""
   attr_accessor :app, :output
 
   def initialize!(&block)
@@ -15,7 +21,7 @@ class IntegrationTest < ActionController::TestCase
     app.initialize!
 
     Rails.logger = ActiveSupport::Logger.new(output)
-    # Rails.logger.formatter = lambda { |s, d, p, m| "#{m}\n" }
+    Rails.logger.formatter = lambda { |s, d, p, m| "#{m}\n" }
   end
 
   def request(uri)
@@ -31,7 +37,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('/assets/picture')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 
   def test_assets_url_with_turned_on_option
@@ -39,7 +45,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('/assets/picture')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 
   def test_in_multi_thread_env
@@ -64,7 +70,7 @@ class IntegrationTest < ActionController::TestCase
 
     n = output.string.lines.select{|i| i.match(/Started GET "\/"/) }
 
-    assert_equal n.size, 1
+    assert_equal 1, n.size
   end
 
   def test_assets_url_with_turned_off_option
@@ -88,7 +94,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('http://some-url.com//assets/picture')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 
   def test_quiet_url
@@ -104,7 +110,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('/quiet/this')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 
   def test_quiet_url_with_paths_option_as_string_appending
@@ -112,7 +118,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('/quiet/this')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 
   def test_quiet_url_with_paths_option_as_array
@@ -120,7 +126,7 @@ class IntegrationTest < ActionController::TestCase
 
     app.call request('/quiet/this')
 
-    assert_equal '', output.string
+    assert_equal EMPTY_LINE, output.string
   end
 end
 

data/test/test_helper.rb

@@ -1,6 +1,7 @@
 require 'bundler/setup'
 require 'minitest/autorun'
 require 'rails'
+require 'action_pack'
 require 'action_controller'
 require 'shut_up_assets'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shut_up_assets
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Dmitry Karpunin
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-14 00:00:00.000000000 Z
+date: 2015-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties