shrine 3.0.0.rc → 3.0.0

data/lib/shrine/plugins/model.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/model.md] on GitHub.
-    #
-    # [doc/plugins/model.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/model.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/model
     module Model
       def self.load_dependencies(uploader, **)
         uploader.plugin :entity
@@ -61,7 +59,7 @@ class Shrine
           return super unless model?
 
           if !record.instance_variable_get(:"@#{@name}_attacher") || options.any?
-            attacher = record.class.send(:"#{@name}_attacher", options)
+            attacher = class_attacher(options)
             attacher.load_model(record, @name)
 
             record.instance_variable_set(:"@#{@name}_attacher", attacher)

data/lib/shrine/plugins/module_include.rb

@@ -4,9 +4,7 @@ Shrine.deprecation("The module_include plugin is deprecated and will be removed
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/module_include.md] on GitHub.
-    #
-    # [doc/plugins/module_include.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/module_include.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/module_include
     module ModuleInclude
       module ClassMethods
         def attachment_module(mod = nil, &block)

data/lib/shrine/plugins/multi_cache.rb

@@ -1,8 +1,8 @@
+# frozen_string_literal: true
+
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/multi_cache.md] on GitHub.
-    #
-    # [doc/plugins/multi_cache.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/multi_cache.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/multi_cache
     module MultiCache
       def self.configure(uploader, **opts)
         uploader.opts[:multi_cache] ||= {}

data/lib/shrine/plugins/presign_endpoint.rb

@@ -6,9 +6,7 @@ require "json"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/presign_endpoint.md] on GitHub.
-    #
-    # [doc/plugins/presign_endpoint.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/presign_endpoint.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/presign_endpoint
     module PresignEndpoint
       def self.configure(uploader, opts = {})
         uploader.opts[:presign_endpoint] ||= {}

data/lib/shrine/plugins/pretty_location.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/pretty_location.md] on GitHub.
-    #
-    # [doc/plugins/pretty_location.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/pretty_location.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/pretty_location
     module PrettyLocation
       def self.configure(uploader, **opts)
         uploader.opts[:pretty_location] ||= { identifier: :id }

data/lib/shrine/plugins/processing.rb

@@ -4,9 +4,7 @@ Shrine.deprecation("The processing plugin is deprecated and will be removed in S
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/processing.md] on GitHub.
-    #
-    # [doc/plugins/processing.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/processing.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/processing
     module Processing
       def self.configure(uploader)
         uploader.opts[:processing] ||= {}

data/lib/shrine/plugins/rack_file.rb

@@ -4,9 +4,7 @@ require "forwardable"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/rack_file.md] on GitHub.
-    #
-    # [doc/plugins/rack_file.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/rack_file.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/rack_file
     module RackFile
       module ClassMethods
         # Accepts a Rack uploaded file hash and wraps it in an IO object.

data/lib/shrine/plugins/rack_response.rb

@@ -6,9 +6,7 @@ require "digest"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/rack_response.md] on GitHub.
-    #
-    # [doc/plugins/rack_response.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/rack_response.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/rack_response
     module RackResponse
       module FileMethods
         # Returns a Rack response triple for the uploaded file.

data/lib/shrine/plugins/recache.rb

@@ -4,9 +4,7 @@ Shrine.deprecation("The recache plugin is deprecated and will be removed in Shri
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/recache.md] on GitHub.
-    #
-    # [doc/plugins/recache.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/recache.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/recache
     module Recache
       module AttacherMethods
         def save

data/lib/shrine/plugins/refresh_metadata.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/refresh_metadata.md] on GitHub.
-    #
-    # [doc/plugins/refresh_metadata.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/refresh_metadata.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/refresh_metadata
     module RefreshMetadata
       module AttacherMethods
         def refresh_metadata!(**options)

data/lib/shrine/plugins/remote_url.rb

@@ -4,9 +4,7 @@ require "down"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/remote_url.md] on GitHub.
-    #
-    # [doc/plugins/remote_url.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/remote_url.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/remote_url
     module RemoteUrl
       class DownloadError < Error; end
 

data/lib/shrine/plugins/remove_attachment.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/remove_attachment.md] on GitHub.
-    #
-    # [doc/plugins/remove_attachment.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/remove_attachment.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/remove_attachment
     module RemoveAttachment
       module AttachmentMethods
         def define_model_methods(name)

data/lib/shrine/plugins/remove_invalid.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/remove_invalid.md] on GitHub.
-    #
-    # [doc/plugins/remove_invalid.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/remove_invalid.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/remove_invalid
     module RemoveInvalid
       def self.load_dependencies(uploader)
         uploader.plugin :validation

data/lib/shrine/plugins/restore_cached_data.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/restore_cached_data.md] on GitHub.
-    #
-    # [doc/plugins/restore_cached_data.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/restore_cached_data.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/restore_cached_data
     module RestoreCachedData
       def self.load_dependencies(uploader)
         uploader.plugin :refresh_metadata

data/lib/shrine/plugins/sequel.rb

@@ -4,9 +4,7 @@ require "sequel"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/sequel.md] on GitHub.
-    #
-    # [doc/plugins/sequel.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/sequel.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/sequel
     module Sequel
       def self.load_dependencies(uploader, **)
         uploader.plugin :model
@@ -41,17 +39,23 @@ class Shrine
           if shrine_class.opts[:sequel][:hooks]
             define_method :before_save do
               super()
-              send(:"#{name}_attacher").send(:sequel_before_save)
+              if send(:"#{name}_attacher").changed?
+                send(:"#{name}_attacher").send(:sequel_before_save)
+              end
             end
 
             define_method :after_save do
               super()
-              send(:"#{name}_attacher").send(:sequel_after_save)
+              if send(:"#{name}_attacher").changed?
+                send(:"#{name}_attacher").send(:sequel_after_save)
+              end
             end
 
             define_method :after_destroy do
               super()
-              send(:"#{name}_attacher").send(:sequel_after_destroy)
+              if send(:"#{name}_attacher").attached?
+                send(:"#{name}_attacher").send(:sequel_after_destroy)
+              end
             end
           end
 
@@ -85,15 +89,11 @@ class Shrine
 
         # Calls Attacher#save. Called before model save.
         def sequel_before_save
-          return unless changed?
-
           save
         end
 
         # Finalizes attachment and persists changes. Called after model save.
         def sequel_after_save
-          return unless changed?
-
           record.db.after_commit do
             finalize
             persist
@@ -102,8 +102,6 @@ class Shrine
 
         # Deletes attached files. Called after model destroy.
         def sequel_after_destroy
-          return unless attached?
-
           record.db.after_commit do
             destroy_attached
           end

data/lib/shrine/plugins/signature.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/signature.md] on GitHub.
-    #
-    # [doc/plugins/signature.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/signature.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/signature
     module Signature
       LOG_SUBSCRIBER = -> (event) do
         Shrine.logger.info "Signature (#{event.duration}ms) – #{{

data/lib/shrine/plugins/store_dimensions.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/store_dimensions.md] on GitHub.
-    #
-    # [doc/plugins/store_dimensions.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/store_dimensions.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/store_dimensions
     module StoreDimensions
       LOG_SUBSCRIBER = -> (event) do
         Shrine.logger.info "Image Dimensions (#{event.duration}ms) – #{{

data/lib/shrine/plugins/tempfile.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/tempfile.md] on GitHub.
-    #
-    # [doc/plugins/tempfile.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/tempfile.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/tempfile
     module Tempfile
       module ClassMethods
         def with_file(io)

data/lib/shrine/plugins/upload_endpoint.rb

@@ -7,9 +7,7 @@ require "digest"
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/upload_endpoint.md] on GitHub.
-    #
-    # [doc/plugins/upload_endpoint.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/upload_endpoint.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/upload_endpoint
     module UploadEndpoint
       def self.load_dependencies(uploader, opts = {})
         uploader.plugin :rack_file

data/lib/shrine/plugins/upload_options.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/upload_options.md] on GitHub.
-    #
-    # [doc/plugins/upload_options.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/upload_options.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/upload_options
     module UploadOptions
       def self.configure(uploader, options = {})
         uploader.opts[:upload_options] ||= {}

data/lib/shrine/plugins/url_options.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/url_options.md] on GitHub.
-    #
-    # [doc/plugins/url_options.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/url_options.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/url_options
     module UrlOptions
       def self.configure(uploader, **options)
         uploader.opts[:url_options] ||= {}

data/lib/shrine/plugins/validation.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/validation.md] on GitHub.
-    #
-    # [doc/plugins/validation.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/validation.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/validation
     module Validation
       module AttacherClassMethods
         # Block that is executed in context of Shrine::Attacher during

data/lib/shrine/plugins/validation_helpers.rb

@@ -2,9 +2,7 @@
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/validation_helpers.md] on GitHub.
-    #
-    # [doc/plugins/validation_helpers.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/validation_helpers.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/validation_helpers
     module ValidationHelpers
       DEFAULT_MESSAGES = {
         max_size:            -> (max)  { "size must not be greater than #{PRETTY_FILESIZE.call(max)}" },

data/lib/shrine/plugins/versions.rb

@@ -4,9 +4,7 @@ Shrine.deprecation("The versions plugin is deprecated and will be removed in Shr
 
 class Shrine
   module Plugins
-    # Documentation lives in [doc/plugins/versions.md] on GitHub.
-    #
-    # [doc/plugins/versions.md]: https://github.com/shrinerb/shrine/blob/master/doc/plugins/versions.md
+    # Documentation can be found on https://shrinerb.com/docs/plugins/versions
     module Versions
       def self.load_dependencies(uploader, **)
         uploader.plugin :processing

data/lib/shrine/storage/file_system.rb

@@ -91,7 +91,7 @@ class Shrine
 
       # Deletes the specified directory on the filesystem.
       #
-      #    file_system.delete_prefixed("somekey/derivatives")
+      #    file_system.delete_prefixed("somekey/derivatives/")
       def delete_prefixed(delete_prefix)
         FileUtils.rm_rf directory.join(delete_prefix)
       end

data/lib/shrine/storage/linter.rb

@@ -47,7 +47,7 @@ class Shrine
           storage.upload(io_factory.call, id2 = "a/a/b")
           storage.upload(io_factory.call, id3 = "a/aaa/a")
 
-          lint_delete_prefixed(prefix: "a/a",
+          lint_delete_prefixed(prefix: "a/a/",
                                expect_deleted: [id1, id2],
                                expect_remaining: [id3])
 

data/lib/shrine/storage/memory.rb

@@ -35,7 +35,8 @@ class Shrine
       end
 
       def delete_prefixed(delete_prefix)
-        store.delete_if { |k, _v| k.start_with?(delete_prefix + "/") }
+        delete_prefix = delete_prefix.chomp("/") + "/"
+        store.delete_if { |key, _value| key.start_with?(delete_prefix) }
       end
 
       def clear!

data/lib/shrine/storage/s3.rb

@@ -207,12 +207,12 @@ class Shrine
 
       # Deletes objects at keys starting with the specified prefix.
       #
-      #    s3.delete_prefixed("somekey/derivatives")
+      #    s3.delete_prefixed("somekey/derivatives/")
       def delete_prefixed(delete_prefix)
         # We need to make sure to combine with storage prefix, and
         # that it ends in '/' cause S3 can be squirrely about matching interior.
-        absolute_prefix = [*prefix, delete_prefix + "/"].join("/")
-        bucket.objects(prefix: absolute_prefix).batch_delete!
+        delete_prefix = delete_prefix.chomp("/") + "/"
+        bucket.objects(prefix: [*prefix, delete_prefix].join("/")).batch_delete!
       end
 
       # If block is given, deletes all objects from the storage for which the

data/lib/shrine/version.rb

@@ -9,7 +9,7 @@ class Shrine
     MAJOR = 3
     MINOR = 0
     TINY  = 0
-    PRE   = "rc"
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shrine
 version: !ruby/object:Gem::Version
-  version: 3.0.0.rc
+  version: 3.0.0
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-28 00:00:00.000000000 Z
+date: 2019-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: down
@@ -375,6 +375,10 @@ files:
 - doc/creating_storages.md
 - doc/design.md
 - doc/direct_s3.md
+- doc/external/articles.md
+- doc/external/extensions.md
+- doc/external/misc.md
+- doc/getting_started.md
 - doc/metadata.md
 - doc/multiple_files.md
 - doc/paperclip.md
@@ -550,9 +554,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
 signing_key: