shrine-transloadit 0.5.0 → 1.0.1

data/lib/shrine/plugins/transloadit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "transloadit"
 
 require "uri"
@@ -7,403 +9,246 @@ require "openssl"
 class Shrine
   module Plugins
     module Transloadit
-      class Error < Shrine::Error; end
+      # Transloadit's default destination path for export robots.
+      DEFAULT_PATH = "${unique_prefix}/${file.url_name}"
 
-      class ResponseError < Error
-        attr_reader :response
+      class Error < Shrine::Error
+      end
 
-        def initialize(response)
-          @response = response
-          super("#{response["error"]}: #{response["reason"] || response["message"]}")
-        end
+      class InvalidSignature < Error
       end
 
-      # Accepts Transloadit credentials via `:auth_key` and `:auth_secret`.
-      #
-      # If :cache storage wasn't assigned, it will be assigned to a URL storage
-      # for direct uploads.
-      #
-      # If promoting was not yet overriden, it is set to automatically trigger
-      # Transloadit processing defined in `Shrine#transloadit_process`.
-      def self.configure(uploader, opts = {})
-        uploader.opts[:transloadit_auth_key] = opts.fetch(:auth_key, uploader.opts[:transloadit_auth_key])
-        uploader.opts[:transloadit_auth_secret] = opts.fetch(:auth_secret, uploader.opts[:transloadit_auth_secret])
-
-        raise Error, "The :auth_key is required for transloadit plugin" if uploader.opts[:transloadit_auth_key].nil?
-        raise Error, "The :auth_secret is required for transloadit plugin" if uploader.opts[:transloadit_auth_secret].nil?
-
-        uploader.opts[:backgrounding_promote] ||= proc { transloadit_process }
+      LOG_SUBSCRIBER = -> (event) do
+        Shrine.logger.info "Transloadit (#{event.duration}ms) – #{{
+          processor: event[:processor],
+          uploader:  event[:uploader],
+        }.inspect}"
       end
 
-      # It loads the backgrounding plugin, so that it can override promoting.
-      def self.load_dependencies(uploader, opts = {})
-        uploader.plugin :backgrounding
+      # Accepts Transloadit credentials via `:auth_key` and `:auth_secret`.
+      def self.configure(uploader, log_subscriber: LOG_SUBSCRIBER, **opts)
+        uploader.opts[:transloadit] ||= { processors: {}, savers: {}, credentials: {} }
+        uploader.opts[:transloadit].merge!(opts)
+
+        fail Error, "The :auth option is required" unless uploader.opts[:transloadit][:auth]
+
+        # instrumentation plugin integration
+        uploader.subscribe(:transloadit, &log_subscriber) if uploader.respond_to?(:subscribe)
       end
 
       module AttacherClassMethods
-        # Loads the attacher from the data, and triggers Transloadit
-        # processing. Intended to be used in a background job.
-        def transloadit_process(data)
-          attacher = self.load(data)
-          cached_file = attacher.uploaded_file(data["attachment"])
-          attacher.transloadit_process(cached_file)
-          attacher
+        def transloadit_processor(name = :default, &block)
+          if block
+            shrine_class.opts[:transloadit][:processors][name.to_sym] = block
+          else
+            shrine_class.opts[:transloadit][:processors][name.to_sym] or
+              fail Error, "transloadit processor #{name.inspect} not registered"
+          end
         end
 
-        # This should be called when receiving a webhook, where arguments are
-        # params that Transloadit POSTed to the endpoint. It checks the
-        # signature, loads the attacher, saves processing results to the record.
-        def transloadit_save(params)
-          shrine_class.verify_transloadit_signature!(params)
-          response = JSON.parse(params["transloadit"])
-          data = response["fields"]["attacher"]
-          attacher = self.load(data)
-          cached_file = attacher.uploaded_file(data["attachment"])
-          attacher.transloadit_save(response, valid: attacher.get == cached_file)
-          attacher
+        def transloadit_saver(name = :default, &block)
+          if block
+            shrine_class.opts[:transloadit][:savers][name.to_sym] = block
+          else
+            shrine_class.opts[:transloadit][:savers][name.to_sym] or
+              fail Error, "transloadit saver #{name.inspect} not registered"
+          end
         end
       end
 
       module AttacherMethods
-        # Triggers Transloadit processing defined by the user in
-        # `Shrine#transloadit_process`. It dumps the attacher in the payload of
-        # the request, so that it's included in the webhook and that we know
-        # which webhook belongs to which record/attachment.
-        #
-        # After the Transloadit assembly was submitted, the response is saved
-        # into cached file's metadata, which can then be reloaded at will for
-        # checking progress of the assembly.
-        #
-        # Raises a `Shrine::Plugins::Transloadit::ResponseError` if Transloadit returned an error.
-        def transloadit_process(cached_file = get)
-          assembly = store.transloadit_process(cached_file, context)
-          assembly.options[:fields] ||= {}
-          assembly.options[:fields]["attacher"] = self.dump.merge("attachment" => cached_file.to_json)
-          response = assembly.create!
-          raise ResponseError.new(response.body) if response["error"]
-          cached_file.metadata["transloadit_response"] = response.body.to_json
-          swap(cached_file) or _set(cached_file)
+        def transloadit_process(name = :default, *args, **kwargs)
+          processor = self.class.transloadit_processor(name)
+          instrument_transloadit(name) do
+            instance_exec(*args, **kwargs, &processor)
+          end
         end
 
-        # It receives the result of Transloadit processing, and converts it into
-        # Shrine's representation(s) of an uploaded file (either as a single
-        # file or a hash of versions).
-        #
-        # If attachment has changed in the meanwhile, meaning the result of
-        # this processing is no longer valid, it deletes the processed files
-        # from the main storage.
-        #
-        # Raises a `Shrine::Plugins::Transloadit::ResponseError` if Transloadit returned an error.
-        def transloadit_save(response, valid: true)
-          raise ResponseError.new(response) if response["error"]
-
-          if versions = response["fields"]["versions"]
-            stored_file = versions.inject({}) do |hash, (name, step_name)|
-              results        = response["results"].fetch(step_name)
-              uploaded_files = results.map { |result| store.transloadit_uploaded_file(result) }
-              multiple       = response["fields"]["multiple"].to_h[name]
-
-              if multiple == "list"
-                hash.merge!(name => uploaded_files)
-              elsif uploaded_files.one?
-                hash.merge!(name => uploaded_files[0])
-              else
-                raise Error, "Step produced multiple files but wasn't marked as multiple"
-              end
-            end
-          else
-            results        = response["results"].values.last
-            uploaded_files = results.map { |result| store.transloadit_uploaded_file(result) }
-            multiple       = response["fields"]["multiple"]
-
-            if multiple == "list"
-              stored_file = uploaded_files
-            elsif uploaded_files.one?
-              stored_file = uploaded_files[0]
-            else
-              raise Error, "Step produced multiple files but wasn't marked as multiple"
-            end
+        def transloadit_save(name = :default, *args, **kwargs)
+          unless name.respond_to?(:to_sym)
+            args.prepend(name)
+            name = :default
           end
 
-          if valid
-            swap(stored_file)
-          else
-            _delete(stored_file, action: :abort)
-          end
+          saver = self.class.transloadit_saver(name)
+          instance_exec(*args, **kwargs, &saver)
+        end
+
+        def transloadit_step(*args, **kwargs)
+          shrine_class.transloadit_step(*args, **kwargs)
         end
-      end
 
-      module ClassMethods
-        # Creates a new Transloadit client, so that the expiration timestamp is
-        # refreshed on new processing requests.
         def transloadit
-          ::Transloadit.new(
-            key:    opts[:transloadit_auth_key],
-            secret: opts[:transloadit_auth_secret],
-          )
+          shrine_class.transloadit
         end
 
-        # Checks if the webhook has indeed been triggered by Transloadit, by
-        # checking if sent signature matches the calculated signature, and
-        # raising a `Shrine::Plugins::Transloadit::Error` if signatures don't
-        # match.
-        def verify_transloadit_signature!(params)
-          sent_signature = params["signature"]
-          payload = params["transloadit"]
-          algorithm = OpenSSL::Digest.new('sha1')
-          secret = opts[:transloadit_auth_secret]
-          calculated_signature = OpenSSL::HMAC.hexdigest(algorithm, secret, payload)
-          raise Error, "Received signature doesn't match the calculated signature" if calculated_signature != sent_signature
+        private
+
+        def instrument_transloadit(processor, &block)
+          return yield unless shrine_class.respond_to?(:instrument)
+
+          shrine_class.instrument(:transloadit, processor: processor, &block)
         end
       end
 
-      module InstanceMethods
-        # Converts Transloadit's representation of an uploaded file into
-        # Shrine's representation. It currently only accepts files exported to
-        # S3. All Transloadit's metadata is saved into a "transloadit"
-        # attribute.
-        #
-        # When doing direct uploads to Transloadit you will only get a
-        # temporary URL, which will be saved in the "id" attribute and it's
-        # expected that the URL storage is used.
-        def transloadit_uploaded_file(result)
-          case url = result.fetch("url")
-          when /amazonaws\.com/
-            raise Error, "Cannot save a processed file which wasn't exported: #{url.inspect}" if url.include?("tmp.transloadit.com")
-            path = URI(url).path
-            id = path.match(%r{^(/#{storage.prefix})?/}).post_match
+      module ClassMethods
+        def transloadit_step(name, robot, **options)
+          use = options.delete(:use)
+
+          if Array(use).first.is_a?(::Transloadit::Step)
+            step = transloadit.step(name, robot, **options)
+            step.use(use) if use
+            step
           else
-            raise Error, "The transloadit Shrine plugin doesn't support storage identified by #{url.inspect}"
+            transloadit.step(name, robot, use: use, **options)
           end
-
-          self.class::UploadedFile.new(
-            "id"       => id,
-            "storage"  => storage_key.to_s,
-            "metadata" => {
-              "filename"    => result.fetch("name"),
-              "size"        => result.fetch("size"),
-              "mime_type"   => result.fetch("mime"),
-              "width"       => (result["meta"] && result["meta"]["width"]),
-              "height"      => (result["meta"] && result["meta"]["height"]),
-              "transloadit" => result["meta"],
-            }
-          )
         end
 
-        # Generates a Transloadit import step from the Shrine::UploadedFile.
-        # If it's from the S3 storage, an S3 import step will be generated.
-        # Otherwise either a generic HTTP(S) or an FTP import will be generated.
-        def transloadit_import_step(name, io, **step_options)
-          uri = URI.parse(io.url)
-
-          if defined?(Storage::S3) && io.storage.is_a?(Storage::S3)
-            step = transloadit.step(name, "/s3/import",
-              key:           io.storage.client.config.access_key_id,
-              secret:        io.storage.client.config.secret_access_key,
-              bucket:        io.storage.bucket.name,
-              bucket_region: io.storage.client.config.region,
-              path:          [*io.storage.prefix, io.id].join("/"),
-            )
-          elsif uri.scheme == "http" || uri.scheme == "https"
-            step = transloadit.step(name, "/http/import",
-              url: uri.to_s,
-            )
-          elsif uri.scheme == "ftp"
-            step = transloadit.step(name, "/ftp/import",
-              host:     uri.host,
-              user:     uri.user,
-              password: uri.password,
-              path:     uri.path,
-            )
-          else
-            raise Error, "Cannot construct a transloadit import step from #{io.inspect}"
+        # Verifies the Transloadit signature of a webhook request. Raises
+        # `Shrine::Plugins::Transloadit::InvalidSignature` if signatures
+        # don't match.
+        def transloadit_verify!(params)
+          if transloadit_sign(params["transloadit"]) != params["signature"]
+            raise InvalidSignature, "received signature doesn't match calculated"
           end
+        end
 
-          step.options.update(step_options)
+        # Creates a new Transloadit client each time. This way the expiration
+        # timestamp is refreshed on new processing requests.
+        def transloadit
+          ::Transloadit.new(**opts[:transloadit][:auth])
+        end
 
-          step
+        def transloadit_credentials(storage_key)
+          opts[:transloadit][:credentials][storage_key] or
+            fail Error, "credentials not registered for storage #{storage_key.inspect}"
         end
 
-        # Generates an export step from the current (permanent) storage.
-        # At the moment only Amazon S3 is supported.
-        def transloadit_export_step(name, path: nil, **step_options)
-          if defined?(Storage::S3) && storage.is_a?(Storage::S3)
-            path ||= "${unique_prefix}/${file.url_name}" # Transloadit's default path
-
-            step = transloadit.step(name, "/s3/store",
-              key:           storage.client.config.access_key_id,
-              secret:        storage.client.config.secret_access_key,
-              bucket:        storage.bucket.name,
-              bucket_region: storage.client.config.region,
-              path:          [*storage.prefix, path].join("/"),
-            )
-          else
-            raise Error, "Cannot construct a transloadit export step from #{storage.inspect}"
-          end
+        private
 
-          step.options.update(step_options)
+        # Signs given string with Transloadit secret key.
+        def transloadit_sign(string)
+          algorithm  = OpenSSL::Digest::SHA1.new
+          secret_key = opts[:transloadit][:auth][:secret]
 
-          step
+          OpenSSL::HMAC.hexdigest(algorithm, secret_key, string)
         end
+      end
 
-        # Creates a new TransloaditFile for building steps, with an optional
-        # import step applied.
-        def transloadit_file(io = nil)
-          file = TransloaditFile.new(transloadit: transloadit)
-          file = file.add_step(transloadit_import_step("import", io)) if io
-          file
+      module InstanceMethods
+        def transloadit_files(results)
+          results.map { |result| transloadit_file(result) }
         end
 
-        # Accepts a TransloaditFile, a hash of TransloaditFiles or a template,
-        # and converts it into a Transloadit::Assembly.
-        #
-        # If a hash of versions are given, the version information is saved in
-        # assembly's payload, so that later in the webhook it can be used to
-        # construct a hash of versions.
-        def transloadit_assembly(value, context: {}, **options)
-          options = { steps: [], fields: {} }.merge(options)
-
-          case value
-          when TransloaditFile then transloadit_assembly_update_single!(value, context, options)
-          when Hash            then transloadit_assembly_update_versions!(value, context, options)
-          when String          then transloadit_assembly_update_template!(value, context, options)
-          else
-            raise Error, "Assembly value has to be either a TransloaditFile, a hash of TransloaditFile objects, or a template"
-          end
+        def transloadit_file(result)
+          result = result.first if result.is_a?(Array)
+          uri    = URI.parse(result.fetch("url"))
 
-          if options[:steps].uniq(&:name) != options[:steps]
-            raise Error, "There are different transloadit steps using the same name"
+          if defined?(Storage::S3) && storage.is_a?(Storage::S3)
+            prefix = "#{storage.prefix}/" if storage.prefix
+            id = uri.path.match(%r{^/#{prefix}})&.post_match or
+              fail Error, "URL path doesn't start with storage prefix: #{uri}"
+          elsif defined?(Storage::Url) && storage.is_a?(Storage::Url)
+            id = uri.to_s
+          else
+            fail Error, "storage not supported: #{storage.inspect}"
           end
 
-          transloadit.assembly(options)
+          self.class::UploadedFile.new(
+            id:       id,
+            storage:  storage_key,
+            metadata: result.fetch("meta").merge(
+              "filename"  => result.fetch("name"),
+              "size"      => result.fetch("size"),
+              "mime_type" => result.fetch("mime"),
+            )
+          )
         end
 
-        # An cached instance of a Tranloadit client.
-        def transloadit
-          @transloadit ||= self.class.transloadit
+        def transloadit_export_step(name = "export", **options)
+          unless options.key?(:credentials)
+            options[:credentials] = self.class.transloadit_credentials(storage_key).to_s
+          end
+
+          if defined?(Storage::S3) && storage.is_a?(Storage::S3)
+            transloadit_s3_store_step(name, **options)
+          elsif defined?(Storage::GoogleCloudStorage) && storage.is_a?(Storage::GoogleCloudStorage)
+            transloadit_google_store_step(name, **options)
+          elsif defined?(Storage::YouTube) && storage.is_a?(Storage::YouTube)
+            transloadit_youtube_store_step(name, **options)
+          else
+            fail Error, "cannot construct export step for #{storage.inspect}"
+          end
         end
 
         private
 
-        # Updates assembly options for single files.
-        def transloadit_assembly_update_single!(transloadit_file, context, options)
-          raise Error, "The given TransloaditFile is missing an import step" if !transloadit_file.imported?
-          unless transloadit_file.exported?
-            path = generate_location(transloadit_file, context) + ".${file.ext}"
-            export_step = transloadit_export_step("export", path: path)
-            transloadit_file = transloadit_file.add_step(export_step)
-          end
-          options[:steps] += transloadit_file.steps
-          options[:fields]["multiple"] = transloadit_file.multiple
+        def transloadit_s3_store_step(name, path: DEFAULT_PATH, **options)
+          transloadit_step name, "/s3/store",
+            path: [*storage.prefix, path].join("/"),
+            **options
         end
 
-        # Updates assembly options for a hash of versions.
-        def transloadit_assembly_update_versions!(versions, context, options)
-          raise Error, "The versions Shrine plugin isn't loaded" if !defined?(Shrine::Plugins::Versions)
-          options[:fields]["versions"] = {}
-          options[:fields]["multiple"] = {}
-          versions.each do |name, transloadit_file|
-            raise Error, "The :#{name} version value is not a TransloaditFile" if !transloadit_file.is_a?(TransloaditFile)
-            raise Error, "The given TransloaditFile is missing an import step" if !transloadit_file.imported?
-            unless transloadit_file.exported?
-              path = generate_location(transloadit_file, context.merge(version: name)) + ".${file.ext}"
-              export_step = transloadit_export_step("export_#{name}", path: path)
-              transloadit_file = transloadit_file.add_step(export_step)
-            end
-            options[:steps] |= transloadit_file.steps
-            options[:fields]["versions"][name] = transloadit_file.name
-            options[:fields]["multiple"][name] = transloadit_file.multiple
-          end
+        def transloadit_google_store_step(name, path: DEFAULT_PATH, **options)
+          transloadit_step name, "/google/store",
+            path: [*storage.prefix, path].join("/"),
+            **options
         end
 
-        # Updates assembly options for a template.
-        def transloadit_assembly_update_template!(template, context, options)
-          options[:template_id] = template
+        def transloadit_youtube_store_step(name, **options)
+          transloadit_step name, "/youtube/store",
+            **options
         end
-      end
 
-      module FileMethods
-        # Converts the "transloadit_response" that was saved in cached file's
-        # metadata into a reloadable object which is normally returned by the
-        # Transloadit gem.
-        def transloadit_response
-          @transloadit_response ||= (
-            body = metadata["transloadit_response"] or return
-            body.instance_eval { def body; self; end }
-            response = ::Transloadit::Response.new(body)
-            response.extend ::Transloadit::Response::Assembly
-            response
-          )
+        def transloadit_step(*args, **kwargs)
+          self.class.transloadit_step(*args, **kwargs)
         end
       end
 
-      class TransloaditFile
-        attr_reader :transloadit, :steps
-
-        def initialize(transloadit:, steps: [], multiple: nil)
-          @transloadit = transloadit
-          @steps       = steps
-          @multiple    = multiple
-        end
-
-        # Adds a step to the pipeline, automatically setting :use to the
-        # previous step, so that later multiple pipelines can be seamlessly
-        # joined into a single assembly.
-        #
-        # It returns a new TransloaditFile with the step added.
-        def add_step(*args)
-          if args[0].is_a?(::Transloadit::Step)
-            step = args[0]
+      module FileMethods
+        def transloadit_import_step(name = "import", **options)
+          if defined?(Storage::S3) && storage.is_a?(Storage::S3)
+            transloadit_s3_import_step(name, **options)
+          elsif url && URI(url).is_a?(URI::HTTP)
+            transloadit_http_import_step(name, **options)
+          elsif url && URI(url).is_a?(URI::FTP)
+            transloadit_ftp_import_step(name, **options)
           else
-            step = transloadit.step(*args)
+            fail Error, "cannot construct import step from #{self.inspect}"
           end
-
-          unless step.options[:use]
-            step.use steps.last if steps.any?
-          end
-
-          transloadit_file(steps: steps + [step])
         end
 
-        # Specify the result format.
-        def multiple(format = nil)
-          if format
-            transloadit_file(multiple: format)
-          else
-            @multiple
-          end
-        end
+        private
 
-        # The key that Transloadit will use in its processing results for the
-        # corresponding processed file. This equals to the name of the last
-        # step, unless the last step is an export step.
-        def name
-          if exported?
-            @steps[-2].name
-          else
-            @steps.last.name
+        def transloadit_s3_import_step(name, **options)
+          unless options.key?(:credentials)
+            options[:credentials] = shrine_class.transloadit_credentials(storage_key).to_s
           end
-        end
 
-        # Returns true if this TransloaditFile includes an import step.
-        def imported?
-          @steps.any? && @steps.first.robot.end_with?("/import")
+          transloadit_step name, "/s3/import",
+            path: [*storage.prefix, id].join("/"),
+            **options
         end
 
-        # Returns true if this TransloaditFile includes an export step.
-        def exported?
-          @steps.any? && @steps.last.robot.end_with?("/store")
+        def transloadit_http_import_step(name, **options)
+          transloadit_step name, "/http/import",
+            url: url,
+            **options
         end
 
-        private
+        def transloadit_ftp_import_step(name, **options)
+          uri = URI.parse(url)
 
-        def transloadit_file(**options)
-          TransloaditFile.new(
-            transloadit: @transloadit,
-            steps:       @steps,
-            multiple:    @multiple,
+          transloadit_step name, "/ftp/import",
+            host:     uri.host,
+            user:     uri.user,
+            password: uri.password,
+            path:     uri.path,
             **options
-          )
+        end
+
+        def transloadit_step(*args, **kwargs)
+          shrine_class.transloadit_step(*args, **kwargs)
         end
       end
     end

data/shrine-transloadit.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "shrine-transloadit"
-  gem.version       = "0.5.0"
+  gem.version       = "1.0.1"
 
   gem.required_ruby_version = ">= 2.2"
 
@@ -13,14 +13,12 @@ Gem::Specification.new do |gem|
   gem.files        = Dir["README.md", "LICENSE.txt", "lib/**/*.rb", "*.gemspec"]
   gem.require_path = "lib"
 
-  gem.add_dependency "shrine", "~> 2.9"
+  gem.add_dependency "shrine", "~> 3.0"
   gem.add_dependency "transloadit", "~> 2.0"
 
   gem.add_development_dependency "rake"
   gem.add_development_dependency "minitest"
-  gem.add_development_dependency "minitest-hooks"
-  gem.add_development_dependency "dotenv"
-  gem.add_development_dependency "aws-sdk-s3", "~> 1.2"
-  gem.add_development_dependency "sequel"
-  gem.add_development_dependency "sqlite3"
+  gem.add_development_dependency "aws-sdk-s3", "~> 1.14"
+  gem.add_development_dependency "shrine-url", "~> 2.4"
+  gem.add_development_dependency "dry-monitor"
 end