shrine-google_cloud_storage 2.0.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa8300b784f31a4d398fc656917be9717fb7c05668de36ab15584bad9f85ff25
-  data.tar.gz: 967a2776f9f7246be332f21835478863b254ae9d55247ab14dafb61f715a378b
+  metadata.gz: a34cac58aef221675146d164422739c7479e066f0057c66535316f5c73d2e1b5
+  data.tar.gz: a8d23873e4df8609cd7ee8a4243bf1dc434d88b8bd6e3bd4025393139e461df9
 SHA512:
-  metadata.gz: f53205e5d15a03e3508ff5bf235017050b0281af87095f4643e7ab072cc909195391cd97144d577814274e78d4c547ff6d9e6f9afe8818d55087f71736105dd5
-  data.tar.gz: 81df0875f5f7ce14df49ebfb717aceecaa09c79134fe50c37b6b5fd7b1810c91c03a53221bb0484336bed9b4027d1bc9071c50ed104b007cf6dadceceffffa78
+  metadata.gz: a0e51f47f9fb65a594803b9ad33a7ea3cd1209767176951c0d564ca7e0988838cc046f7866331ae9179739bc597a2bfb18039c1bbaa498358f7c269967ac00ca
+  data.tar.gz: b11dccee9fb4ed67f2ff3e0de94f15d697a9e1dce2f2f24b00e15e3a69786c2f7e873828218584446db048c0df928e7721b2f9bb38e4915d063acf2cd6b6d22c

data/README.md

@@ -12,8 +12,7 @@ gem "shrine-google_cloud_storage"
 
 ## Authentication
 
-The GCS plugin uses Google's [Project and Credential Lookup]. Please check
-documentation for the various ways to provide credentials.
+The GCS plugin uses the `google-cloud-storage` gem. Please refer to [its documentation for setting up authentication](http://googleapis.github.io/google-cloud-ruby/docs/google-cloud-storage/latest/file.AUTHENTICATION.html).
 
 ## Usage
 
@@ -97,4 +96,3 @@ GCS_DEBUG=true
 
 [Google Cloud Storage]: https://cloud.google.com/storage/
 [Shrine]: https://github.com/shrinerb/shrine
-[Project and Credential Lookup]: http://googlecloudplatform.github.io/google-cloud-ruby/#/docs/google-cloud-storage/master/guides/authentication#projectandcredentiallookup

data/lib/shrine/storage/google_cloud_storage.rb

@@ -68,31 +68,27 @@ class Shrine
         end
       end
 
-      # Downloads the file from GCS, and returns a `Tempfile`.
-      def download(id)
-        tempfile = Tempfile.new(["googlestorage", File.extname(id)], binmode: true)
-        get_file(id).download tempfile.path
-        tempfile.tap(&:open)
-      end
-
       # Opens the remote file and returns it as `Down::ChunkedIO` object.
       # @return [Down::ChunkedIO] object
       # @see https://github.com/janko-m/down#downchunkedio
-      def open(id)
+      def open(id, rewindable: true, **options)
         file = get_file(id)
 
+        raise Shrine::FileNotFound, "file #{id.inspect} not found on storage" unless file
+
         # create enumerator which lazily yields chunks of downloaded content
         chunks = Enumerator.new do |yielder|
           # trick to get google client to stream the download
           proc_io = ProcIO.new { |data| yielder << data }
-          file.download(proc_io, verify: :none)
+          file.download(proc_io, verify: :none, **options)
         end
 
         # wrap chunks in an IO-like object which downloads when needed
         Down::ChunkedIO.new(
-          chunks: chunks,
-          size:   file.size,
-          data:   { file: file }
+          chunks:     chunks,
+          size:       file.size,
+          rewindable: rewindable,
+          data:       { file: file },
         )
       end
 

data/shrine-google_cloud_storage.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "shrine-google_cloud_storage"
-  gem.version       = "2.0.1"
+  gem.version       = "3.0.0"
 
   gem.required_ruby_version = ">= 2.1"
 
@@ -13,7 +13,7 @@ Gem::Specification.new do |gem|
   gem.files        = Dir["README.md", "LICENSE.txt", "lib/**/*.rb", "shrine-google_cloud_storage.gemspec"]
   gem.require_path = "lib"
 
-  gem.add_dependency "shrine", "~> 2.11"
+  gem.add_dependency "shrine", "~> 3.0"
   gem.add_dependency "google-cloud-storage", "~> 1.6"
 
   gem.add_development_dependency "rake"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shrine-google_cloud_storage
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Renaud Chaput
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-21 00:00:00.000000000 Z
+date: 2019-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shrine
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: google-cloud-storage
   requirement: !ruby/object:Gem::Requirement