shrine-cloudinary 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7620a61d65d4509c6835b0ab21fc0f47d13cf39a
-  data.tar.gz: d414fe35b912c48e317ed361e5a1a39082c03df7
+  metadata.gz: 12d3db82804fda919a833b89c383245be1231462
+  data.tar.gz: b6445028d38f2702ce59a5e47c8f1dbbc9e7a8ca
 SHA512:
-  metadata.gz: 1a181bb8b94a81a687c2ce4bb671799a7445e39565d558f2538d640d841dff5f61ccfbd883a223ea428d076e873587492e57ef40a997c94f73a057d74a09cc87
-  data.tar.gz: f81035721ad1988bbb369966a2effa215d79cf451165c90eabe5773077335493e0a15f4a90901506d90dcab8db764b97c099aaedd0a60efbbda3b135afacc191
+  metadata.gz: 3683b89aa2464558e29ee230fd16a7aee44cca885b9fc988c453955dfcaade3508baddcf4a94b99c4b017d7e8023e8a7459eff3ddcdb4017fdfc63f4fbd50c87
+  data.tar.gz: fc48706b308d4170b3161c4c1fa468129af7181c8df22c90363fcd043867f68ee62ae64cbb5d05373d776fd82065675e2c77a001478b381cd22afd5a284cf6f7

data/README.md

@@ -54,7 +54,7 @@ side, you can generate a presign inline:
 ```erb
 <input name="file" type="file"
    class="cloudinary-fileupload" data-cloudinary-field="image_id"
-   data-form-data="<%= Shrine.storages[:cache].presign.fields.to_json %>" ></input>
+   data-form-data="<%= Shrine.storages[:cache].presign.fields.to_json %>">
 ```
 
 Alternatively you can add an endpoint to your app which can generate presigns
@@ -271,7 +271,7 @@ This gem has been inspired by Cloudinary's [CarrierWave integration].
 [Cloudinary]: http://cloudinary.com/
 [Shrine]: https://github.com/janko-m/shrine
 [CarrierWave integration]: https://github.com/cloudinary/cloudinary_gem
-[Cloudinary options]: http://cloudinary.com/documentation/upload_images#remote_upload
+[Cloudinary options]: http://cloudinary.com/documentation/image_upload_api_reference#upload
 [Rails image manipulation]: http://cloudinary.com/documentation/rails_image_manipulation
 [responsive breakpoints]: http://cloudinary.com/blog/introducing_intelligent_responsive_image_breakpoints_solutions
 [explicit API]: http://cloudinary.com/documentation/image_upload_api_reference#explicit

data/lib/shrine/storage/cloudinary.rb

@@ -81,8 +81,8 @@ class Shrine
       end
 
       def presign(id = nil, **options)
+        upload_options = id ? {public_id: public_id(id)} : {folder: prefix}
         upload_options.update(@upload_options)
-        upload_options.update(id ? {public_id: public_id(id)} : {folder: prefix})
 
         fields = ::Cloudinary::Uploader.build_upload_params(upload_options.merge(options))
         fields.reject! { |key, value| value.nil? || value == "" }
@@ -114,15 +114,27 @@ class Shrine
         if remote?(io)
           ::Cloudinary::Uploader.upload(io.url, **options)
         else
-          io = io.download if io.is_a?(UploadedFile)
-          if large?(io)
-            ::Cloudinary::Uploader.upload_large(io, chunk_size: chunk_size, **options)
-          else
-            ::Cloudinary::Uploader.upload(io, **options)
+          to_file(io) do |file|
+            if large?(file)
+              ::Cloudinary::Uploader.upload_large(file, chunk_size: chunk_size, **options)
+            else
+              ::Cloudinary::Uploader.upload(file, **options)
+            end
           end
         end
       end
 
+      def to_file(io)
+        if io.is_a?(UploadedFile)
+          file = io.download
+          result = yield file
+          file.delete
+          result
+        else
+          yield io
+        end
+      end
+
       def remote?(io)
         io.is_a?(UploadedFile) && io.url.to_s =~ /^ftp:|^https?:/
       end

data/shrine-cloudinary.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "shrine-cloudinary"
-  gem.version       = "0.4.0"
+  gem.version       = "0.4.1"
 
   gem.required_ruby_version = ">= 2.1"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shrine-cloudinary
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-05 00:00:00.000000000 Z
+date: 2016-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shrine