showcase 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcf0fde90d484b35c54b9cfb8ef72123de71a78d
-  data.tar.gz: fdcc72c89960d828ab4d496974cb45c01045dc19
+  metadata.gz: 2793f52eea58c519b380e4a3e87c7ec768d195c1
+  data.tar.gz: c6c9a09255338c9f737fc2cd4ceb6b9213dbc011
 SHA512:
-  metadata.gz: 72365b989e2d2aeef8f757cbe85607097da0a602510652d03266b6d352f4c5036164dfe81376649407f47620af7296bde6bf7f8def7edc02a31b04fbfbda644b
-  data.tar.gz: c8774f411e41452fc643f952ed6c43413968d2246421cabce9b38d4854f23d80609d43f198328d5be234e8fb7b1f0bf96c4d1496480474044cffb3716a17cf6f
+  metadata.gz: 0c4d859554d4c99b6b10078328057d90a51993ea4719f680d4f81bed35ecd0a702629d97bb558cb41a03a54c4a36769bc73c5b988d51ad99a9f98a770d53d133
+  data.tar.gz: ff084a8d82002aab84dfa4ae740736e39808de657f8d71c804709679d3518cfa17a172e9d97b2fd5de29c785053f31c8cb5e7681bd05f06b2fbd9ff3439e2917

data/lib/showcase/helpers/first_nonblank.rb

@@ -0,0 +1,6 @@
+class FirstNonBlank
+  def self.find(values)
+    Array(values).find(&:presence)
+  end
+end
+

data/lib/showcase/helpers/seo_meta_builder.rb

@@ -1,3 +1,5 @@
+require 'showcase/helpers/first_nonblank'
+
 module Showcase
   module Helpers
     class SeoMetaBuilder
@@ -8,7 +10,7 @@ module Showcase
       end
 
       def title(values, options = {})
-        title = first_nonblank(values)
+        title = FirstNonBlank.find(values)
         title += options[:title_suffix] if options[:title_suffix]
 
         context.content_tag(:title, title) <<
@@ -57,12 +59,8 @@ module Showcase
 
       private
 
-      def first_nonblank(values)
-        Array(values).find(&:presence)
-      end
-
       def seo_meta_tags(*args)
-        value = first_nonblank(args.pop)
+        value = FirstNonBlank.find(args.pop)
 
         return nil unless value.present?
 

data/lib/showcase/traits/share.rb

@@ -1,4 +1,5 @@
 require 'showcase/helpers/config_object'
+require 'showcase/helpers/first_nonblank'
 require 'active_support/core_ext/object/to_query'
 
 module Showcase
@@ -45,7 +46,9 @@ module Showcase
               html_options = meta.html_options || {}
               params = Hash[
                 settings[:params].map do |param, meta_key|
-                  values = [:"#{social}_#{meta_key}", meta_key].map { |key| meta.send(key) }
+                  values = [:"#{social}_#{meta_key}", meta_key].map do |key|
+                    FirstNonBlank.find(meta.send(key))
+                  end
                   [ param, values.find(&:presence) ]
                 end
               ]

data/lib/showcase/version.rb

@@ -1,4 +1,4 @@
 module Showcase
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end
 

data/spec/traits/seo_spec.rb

@@ -17,16 +17,16 @@ module Showcase::Traits
         end
 
         seo do |c|
-          c.title = 'foo'
-          c.description 'bar'
+          c.title = ['', 'foo']
+          c.description = ['', 'bar']
         end
       end
     }
 
     describe '.seo' do
       let(:expected_options) { { title_suffix: ' - qux' } }
-      let(:expected_description) { 'bar' }
-      let(:expected_title) { 'foo' }
+      let(:expected_description) { ['', 'bar'] }
+      let(:expected_title) { ['', 'foo'] }
 
       before do
         Showcase::Helpers::SeoMetaBuilder.stub(:new).with(view).and_return(builder)

data/spec/traits/share_spec.rb

@@ -13,8 +13,8 @@ module Showcase::Traits
 
         share do |c|
           c.url = 'url'
-          c.text = 'text'
-          c.twitter_text = 'twitter text'
+          c.text = ['', 'text']
+          c.twitter_text = ['', 'twitter text']
           c.image_url = 'image'
           c.html_options = { role: 'share' }
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: showcase
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Stefano Verna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-23 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -103,6 +103,7 @@ files:
 - lib/showcase.rb
 - lib/showcase/errors.rb
 - lib/showcase/helpers/config_object.rb
+- lib/showcase/helpers/first_nonblank.rb
 - lib/showcase/helpers/html_options.rb
 - lib/showcase/helpers/module_method_builder.rb
 - lib/showcase/helpers/present.rb