showcase 0.2.0.beta.2 → 0.2.0.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0253c1910b10e27e923304bcc5bd1395bdafc39c
-  data.tar.gz: b8b43388b449c766905202aafa1f92260e10e369
+  metadata.gz: 9d6a631420d19d2a548cdf36d56577c48ae24930
+  data.tar.gz: bd24f9fc93109defc060e10b88d2dc2c57980a6a
 SHA512:
-  metadata.gz: f2dae46e5e237003646b8b439d8a8757aebe87d234a6d3e202c7ad5967705b9775043dee73be6483b2ee7904f6b58936e627fd8f870ecaeb0f520f6287c5243a
-  data.tar.gz: 201d8408f682c934779956fb7db947aa83910afd4732aa769a7acb55caba019d166a81fd68504af2bce4913e3e663e4c9ab0510f6e298bc9a78201df6963d338
+  metadata.gz: df878541e87c19106087fa2f1a8eb7610fca82637b6e7ed13e056a98284fafbb55ec428e9922c0b16d9e9404b8e95a8c543595f0ba9a179472376b76a6a3a4dc
+  data.tar.gz: 2075e6deb475f90d8f4f215478e2b027af35def0f9abb5fc10a4e2f26d068a78957457009a3f4d7877331517a9cdf5a121064d37270c75455b9119a5d4fad82c

data/README.md

@@ -3,7 +3,7 @@
 A simple (< 100 lines of code) but powerful exhibit/presenter implementation.
 It's framework agnostic: works with Rails, Padrino or just Sinatra.
 
-Since version 0.2.0 Showcase is bundled with [a set of "traits"](https://github.com/stefanoverna/showcase#traits)
+Since version 0.2.0 Showcase is bundled with [a set of optional "traits"](https://github.com/stefanoverna/showcase#traits)
 you can pick and choose to augment your presenters with additional sugar
 (available in Rails 3+ only).
 
@@ -15,15 +15,21 @@ See [Avdi's Exhibits introductory post](http://devblog.avdi.org/2012/06/04/displ
 
 Add this line to your application's Gemfile:
 
-    gem 'showcase'
+```ruby
+gem 'showcase'
+```
 
 And then execute:
 
-    $ bundle
+```
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install showcase
+```
+$ gem install showcase
+```
 
 ## Usage
 
@@ -90,7 +96,7 @@ rails generate showcase:presenter User
 
 Will generate `app/presenters/user_presenter.rb`. If your Rails app has the file
 `app/presenters/base_presenter.rb`, the newly created presenter will inherit
-from `BasePresenter` instead of `Shocase::Presenter`.
+from `BasePresenter` instead of `Showcase::Presenter`.
 
 ### Traits
 
@@ -126,7 +132,7 @@ Super useful in acceptance testing to check the presence of a record inside a
 view:
 
 ```erb
-<% present(@project).box do %>
+<% present(@project, class: 'big').box do %>
   <p>Hi there!</p>
 <% end %>
 ```
@@ -134,9 +140,10 @@ view:
 Produces the following:
 
 ```html
-<div class="project" id="project_12">
+<div class="project big" id="project_12">
   <p>Hi there</p>
 </div>
+```
 
 Additional HTML attributes can be optionally specified within a config block 
 inside the presenter:
@@ -228,7 +235,7 @@ In your views:
 #### `Showcase::Traits::Seo`
 
 Useful to produce SEO meta tags (title, description, Facebook OpenGraph,
-Twitter cards, and canonical URL):
+Twitter cards, and canonical URLs):
 
 ```ruby
 class ProjectPresenter < Showcase::Presenter
@@ -242,6 +249,7 @@ class ProjectPresenter < Showcase::Presenter
   end
 end
 ```
+
 In your views:
 
 ```erb

data/lib/showcase/traits/share.rb

@@ -42,6 +42,7 @@ module Showcase
 
             link_to link_name do |c|
               meta = Helpers::ConfigObject.new(self, &block).to_struct
+              html_options = meta.html_options || {}
               params = Hash[
                 settings[:params].map do |param, meta_key|
                   [ param, meta.send(meta_key) ]
@@ -49,7 +50,7 @@ module Showcase
               ]
               c.url "#{settings[:url]}?#{params.to_query}"
               c.label settings[:label]
-              c.html_options = { target: :blank }
+              c.html_options = html_options.reverse_merge(target: '_blank')
             end
           end
         end

data/lib/showcase/version.rb

@@ -1,4 +1,4 @@
 module Showcase
-  VERSION = "0.2.0.beta.2"
+  VERSION = "0.2.0.beta.3"
 end
 

data/spec/traits/share_spec.rb

@@ -15,6 +15,7 @@ module Showcase::Traits
           c.url = 'url'
           c.text = 'text'
           c.image_url = 'image'
+          c.html_options = { role: 'share' }
         end
 
         share :foo do |c|
@@ -39,10 +40,19 @@ module Showcase::Traits
         it "produces a #{provider} share link" do
           expect(subject.send("#{provider}_share_link")).to have_tag(:a)
         end
+
         it "produces a #{provider} share url" do
           expect(subject.send("#{provider}_share_url")).to eq url
         end
 
+        it "adds a target :blank to the link" do
+          expect(subject.send("#{provider}_share_link")).to have_tag(:a, with: { target: '_blank' })
+        end
+
+        it "merges additional html_options" do
+          expect(subject.send("#{provider}_share_link")).to have_tag(:a, with: { role: 'share' })
+        end
+
         context 'with prefix' do
           it 'prefixes link method' do
             expect(subject).to respond_to "foo_#{provider}_share_link"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: showcase
 version: !ruby/object:Gem::Version
-  version: 0.2.0.beta.2
+  version: 0.2.0.beta.3
 platform: ruby
 authors:
 - Stefano Verna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-29 00:00:00.000000000 Z
+date: 2013-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport