shoulda 4.0.0.rc2 → 5.0.0.rc1

data/test/acceptance/integrates_with_rails_test.rb

@@ -1,580 +0,0 @@
-require 'acceptance_test_helper'
-
-class ShouldaIntegratesWithRailsTest < AcceptanceTest
-  # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-  def setup
-    app.create
-
-    app.write_file 'db/migrate/1_create_users.rb', <<-FILE
-      class CreateUsers < #{app.migration_class_name}
-        def self.up
-          create_table :categories_users do |t|
-            t.integer :category_id
-            t.integer :user_id
-          end
-
-          create_table :categories do |t|
-          end
-
-          create_table :cities do |t|
-          end
-
-          create_table :lives do |t|
-            t.integer :user_id
-          end
-
-          create_table :issues do |t|
-            t.integer :user_id
-          end
-
-          create_table :users do |t|
-            t.integer :account_id
-            t.integer :city_id
-            t.string :email
-            t.integer :age
-            t.integer :status
-            t.string :aspects
-          end
-
-          add_index :users, :account_id
-        end
-      end
-    FILE
-
-    app.run_migrations!
-
-    app.write_file 'app/models/category.rb', <<-FILE
-      class Category < ActiveRecord::Base
-      end
-    FILE
-
-    app.write_file 'app/models/city.rb', <<-FILE
-      class City < ActiveRecord::Base
-      end
-    FILE
-
-    app.write_file 'app/models/issue.rb', <<-FILE
-      class Issue < ActiveRecord::Base
-      end
-    FILE
-
-    app.write_file 'app/models/life.rb', <<-FILE
-      class Life < ActiveRecord::Base
-      end
-    FILE
-
-    app.write_file 'app/models/person.rb', <<-FILE
-      class Person
-        # Note: All of these validations are listed in the same order as what's
-        # defined in the test (see below)
-
-        include ActiveModel::Model
-        include ActiveModel::SecurePassword
-
-        attr_accessor(
-          :age,
-          :card_number,
-          :email,
-          :foods,
-          :nothing,
-          :password_digest,
-          :some_other_attribute,
-          :some_other_attribute_confirmation,
-          :something,
-          :terms_of_service,
-          :workouts,
-          :some_other_attribute,
-        )
-
-        validate :email_looks_like_an_email
-
-        delegate :a_method, to: :some_delegate_object
-
-        has_secure_password
-
-        validates_absence_of :nothing
-        validates_acceptance_of :terms_of_service
-        validates_confirmation_of :password
-        validates_exclusion_of :workouts, in: ["biceps"]
-        validates_inclusion_of :foods, in: ["spaghetti"]
-        validates_length_of :card_number, maximum: 16
-        validates_numericality_of :age
-        validates_presence_of :something
-
-        def some_delegate_object
-          Object.new.instance_eval do
-            def a_method; end
-          end
-        end
-
-        private
-
-        def email_looks_like_an_email
-          if email !~ /@/
-            errors.add :email, "invalid"
-          end
-        end
-      end
-    FILE
-
-    app.write_file 'app/models/user.rb', <<-FILE
-      class User < ActiveRecord::Base
-        # Note: All of these validations are listed in the same order as what's
-        # defined in the test (see below)
-
-        belongs_to :city
-        enum status: { inactive: 0, active: 1 }
-        attr_readonly :username
-        has_and_belongs_to_many :categories
-        has_many :issues
-        has_one :life
-        serialize :aspects
-        validates_uniqueness_of :email
-        accepts_nested_attributes_for :issues
-      end
-    FILE
-
-    app.write_file 'app/controllers/examples_controller.rb', <<-FILE
-      class ExamplesController < ApplicationController
-        # Note: All of these validations are listed in the same order as what's
-        # defined in the test (see below)
-
-        before_action :some_before_action
-        after_action :some_after_action
-        around_action :some_around_action
-
-        rescue_from ActiveRecord::RecordNotFound, with: :handle_not_found
-
-        layout "application"
-
-        def index
-          render :index
-          head :ok
-        end
-
-        def create
-          create_params
-          flash[:success] = "Example created"
-          session[:some_key] = "some value"
-          redirect_to action: :index
-        end
-
-        def handle_not_found
-        end
-
-        private
-
-        def some_before_action
-        end
-
-        def some_after_action
-        end
-
-        def some_around_action
-          yield
-        end
-
-        def create_params
-          params.require(:user).permit(:email, :password)
-        end
-      end
-    FILE
-
-    app.write_file 'app/views/examples/index.html.erb', <<-FILE
-      Some content here
-    FILE
-
-    app.write_file 'config/routes.rb', <<-FILE
-      Rails.application.routes.draw do
-        resources :examples, only: [:index, :create]
-      end
-    FILE
-  end
-
-  def test_succeeding_assertions_for_active_model
-    app.write_file 'test/models/person_test.rb', <<-FILE
-      require 'test_helper'
-
-      class PersonTest < ActiveSupport::TestCase
-        # Note: All of these matchers are listed in alphabetical order so we can
-        # compare with what is listed inside of the shoulda-matchers README
-
-        should allow_value("john@smith.com").for(:email)
-        should_not allow_value("john").for(:email)
-
-        should delegate_method(:a_method).to(:some_delegate_object)
-        should_not delegate_method(:some_other_method).to(:some_other_object)
-
-        should have_secure_password
-
-        should validate_absence_of(:nothing)
-        should_not validate_absence_of(:some_other_attribute)
-
-        should validate_acceptance_of(:terms_of_service)
-        should_not validate_acceptance_of(:some_other_attribute)
-
-        should validate_confirmation_of(:password)
-        should_not validate_confirmation_of(:some_other_attribute)
-
-        should validate_exclusion_of(:workouts).in_array(["biceps"])
-        should_not validate_exclusion_of(:some_other_attribute).
-          in_array(["whatever"])
-
-        should validate_inclusion_of(:foods).in_array(["spaghetti"])
-        should_not validate_inclusion_of(:some_other_attribute).
-          in_array(["whatever"])
-
-        should validate_length_of(:card_number).is_at_most(16)
-        should_not validate_length_of(:some_other_attribute).is_at_most(16)
-
-        should validate_numericality_of(:age)
-        should_not validate_numericality_of(:some_other_attribute)
-
-        should validate_presence_of(:something)
-        should_not validate_presence_of(:some_other_attribute)
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 0), result
-  end
-
-  def test_succeeding_assertions_for_active_record
-    app.write_file 'test/models/user_test.rb', <<-FILE
-      require 'test_helper'
-
-      class UserTest < ActiveSupport::TestCase
-        # Note: All of these matchers are listed in alphabetical order so we can
-        # compare with what is listed inside of the shoulda-matchers README
-
-        should belong_to(:city)
-        should_not belong_to(:some_other_attribute)
-
-        should define_enum_for(:status).with_values(inactive: 0, active: 1)
-        should_not define_enum_for(:status).with_values(foo: "bar")
-
-        should have_db_column(:age)
-        should_not have_db_column(:some_other_attribute)
-
-        should have_db_index(:account_id)
-        should_not have_db_index(:some_other_attribute)
-
-        should have_readonly_attribute(:username)
-        should_not have_readonly_attribute(:some_other_attribute)
-
-        should have_and_belong_to_many(:categories)
-        should_not have_and_belong_to_many(:whatevers)
-
-        should have_many(:issues)
-        should_not have_many(:whatevers)
-
-        should have_one(:life)
-        should_not have_one(:whatever)
-
-        should serialize(:aspects)
-        should_not serialize(:age)
-
-        should validate_uniqueness_of(:email)
-        should_not validate_uniqueness_of(:some_other_attribute)
-
-        should accept_nested_attributes_for(:issues)
-        should_not accept_nested_attributes_for(:some_other_attribute)
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 0), result
-  end
-
-  def test_succeeding_assertions_for_action_controller
-    app.write_file 'test/controllers/examples_controller_test.rb', <<-FILE
-      require 'test_helper'
-
-      class ExamplesControllerTest < ActionController::TestCase
-        context "GET #index" do
-          setup do
-            get :index
-          end
-
-          # Note: All of these matchers are listed in alphabetical order so we
-          # can compare with what is listed inside of the shoulda-matchers
-          # README
-
-          should use_before_action(:some_before_action)
-          should_not use_before_action(:some_other_before_action)
-          should use_after_action(:some_after_action)
-          should_not use_after_action(:some_other_after_action)
-          should use_around_action(:some_around_action)
-          should_not use_around_action(:some_other_around_action)
-
-          # This is one of the defaults for Rails
-          should filter_param(:password)
-          should_not filter_param(:some_other_param)
-
-          should rescue_from(ActiveRecord::RecordNotFound).
-            with(:handle_not_found)
-          should_not rescue_from(ActiveRecord::RecordNotFound).
-            with(:some_other_method)
-
-          should render_template(:index)
-          should_not render_template(:some_other_action)
-
-          should render_with_layout("application")
-          should_not render_with_layout("some_other_layout")
-
-          should respond_with(:ok)
-          should_not respond_with(:some_other_status)
-
-          should route(:get, "/examples").to(action: :index)
-          should_not route(:get, "/examples").to(action: :something_else)
-        end
-
-        context "POST #create" do
-          setup do
-            if ActionPack::VERSION::STRING.start_with?("4.")
-              post :create, {
-                user: {
-                  email: "some@email.com",
-                  password: "somepassword"
-                }
-              }
-            else
-              post :create, params: {
-                user: {
-                  email: "some@email.com",
-                  password: "somepassword"
-                }
-              }
-            end
-          end
-
-          should permit(:email, :password).
-            for(:create, params: {
-              user: {
-                email: "some@email.com",
-                password: "somepassword"
-              }
-            }).
-            on(:user)
-          should_not permit(:foo, :bar).
-            for(:create, params: {
-              user: {
-                email: "some@email.com",
-                password: "somepassword"
-              }
-            }).
-            on(:user)
-
-          should redirect_to("/examples")
-          should_not redirect_to("/something_else")
-
-          should set_flash[:success].to("Example created")
-          should_not set_flash[:success].to("Something else")
-
-          should set_session[:some_key].to("some value")
-          should_not set_session[:some_key].to("some other value")
-        end
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 0), result
-  end
-
-  def test_failing_assertions_for_active_model
-    app.write_file 'test/models/person_test.rb', <<-FILE
-      require 'test_helper'
-
-      class PersonTest < ActiveSupport::TestCase
-        # Note: All of these matchers are listed in alphabetical order so we can
-        # compare with what is listed inside of the shoulda-matchers README
-
-        should_not allow_value("john@smith.com").for(:email)
-        should allow_value("john").for(:email)
-
-        # FIXME: See #1187 in shoulda-matchers
-        #should_not have_secure_password
-
-        should_not validate_absence_of(:nothing)
-        should validate_absence_of(:some_other_attribute)
-
-        should_not validate_acceptance_of(:terms_of_service)
-        should validate_acceptance_of(:some_other_attribute)
-
-        should_not validate_confirmation_of(:password)
-        should validate_confirmation_of(:some_other_attribute)
-
-        should_not validate_exclusion_of(:workouts).in_array(["biceps"])
-        should validate_exclusion_of(:some_other_attribute).
-          in_array(["whatever"])
-
-        should_not validate_inclusion_of(:foods).in_array(["spaghetti"])
-        should validate_inclusion_of(:some_other_attribute).
-          in_array(["whatever"])
-
-        should_not validate_length_of(:card_number).is_at_most(16)
-        should validate_length_of(:some_other_attribute).is_at_most(16)
-
-        should_not validate_numericality_of(:age)
-        should validate_numericality_of(:some_other_attribute)
-
-        should_not validate_presence_of(:something)
-        should validate_presence_of(:some_other_attribute)
-
-        should_not delegate_method(:a_method).to(:some_delegate_object)
-        should delegate_method(:some_other_method).to(:some_other_object)
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 20), result
-  end
-
-  def test_failing_assertions_for_active_record
-    app.write_file 'test/models/user_test.rb', <<-FILE
-      require 'test_helper'
-
-      class UserTest < ActiveSupport::TestCase
-        # Note: All of these matchers are listed in alphabetical order so we can
-        # compare with what is listed inside of the shoulda-matchers README
-
-        should_not belong_to(:city)
-        should belong_to(:some_other_attribute)
-
-        should_not define_enum_for(:status).with_values(inactive: 0, active: 1)
-        should define_enum_for(:status).with_values(foo: "bar")
-
-        should_not have_db_column(:age)
-        should have_db_column(:some_other_attribute)
-
-        should_not have_db_index(:account_id)
-        should have_db_index(:some_other_attribute)
-
-        should_not have_readonly_attribute(:username)
-        should have_readonly_attribute(:some_other_attribute)
-
-        should_not have_and_belong_to_many(:categories)
-        should have_and_belong_to_many(:whatevers)
-
-        should_not have_many(:issues)
-        should have_many(:whatevers)
-
-        should_not have_one(:life)
-        should have_one(:whatever)
-
-        should_not serialize(:aspects)
-        should serialize(:age)
-
-        should_not validate_uniqueness_of(:email)
-        should validate_uniqueness_of(:some_other_attribute)
-
-        should_not accept_nested_attributes_for(:issues)
-        should accept_nested_attributes_for(:some_other_attribute)
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 22), result
-  end
-
-  def test_failing_assertions_for_action_controller
-    app.write_file 'test/controllers/examples_controller_test.rb', <<-FILE
-      require 'test_helper'
-
-      class ExamplesControllerTest < ActionController::TestCase
-        context "GET #index" do
-          setup do
-            get :index
-          end
-
-          # Note: All of these matchers are listed in alphabetical order so we
-          # can compare with what is listed inside of the shoulda-matchers
-          # README
-
-          should_not use_before_action(:some_before_action)
-          should use_before_action(:some_other_before_action)
-          should_not use_after_action(:some_after_action)
-          should use_after_action(:some_other_after_action)
-          should_not use_around_action(:some_around_action)
-          should use_around_action(:some_other_around_action)
-
-          should_not filter_param(:password)
-          should filter_param(:some_other_param)
-
-          should_not rescue_from(ActiveRecord::RecordNotFound).
-            with(:handle_not_found)
-          should rescue_from(ActiveRecord::RecordNotFound).
-            with(:some_other_method)
-
-          should_not render_template(:index)
-          should render_template(:some_other_action)
-
-          should_not render_with_layout("application")
-          should render_with_layout("some_other_layout")
-
-          should_not respond_with(:ok)
-          should respond_with(:some_other_status)
-
-          should_not route(:get, "/examples").to(action: :index)
-          should route(:get, "/examples").to(action: :something_else)
-        end
-
-        context "POST #create" do
-          setup do
-            if ActionPack::VERSION::STRING.start_with?("4.")
-              post :create, {
-                user: {
-                  email: "some@email.com",
-                  password: "somepassword"
-                }
-              }
-            else
-              post :create, params: {
-                user: {
-                  email: "some@email.com",
-                  password: "somepassword"
-                }
-              }
-            end
-          end
-
-          should_not permit(:email, :password).
-            for(:create, params: {
-              user: {
-                email: "some@email.com",
-                password: "somepassword"
-              }
-            }).
-            on(:user)
-          should permit(:foo, :bar).
-            for(:create, params: {
-              user: {
-                email: "some@email.com",
-                password: "somepassword"
-              }
-            }).
-            on(:user)
-
-          should_not redirect_to("/examples")
-          should redirect_to("/something_else")
-
-          should_not set_flash[:success].to("Example created")
-          should set_flash[:success].to("Something else")
-
-          should_not set_session[:some_key].to("some value")
-          should set_session[:some_key].to("some other value")
-        end
-      end
-    FILE
-
-    result = app.run_n_unit_test_suite
-
-    assert_accepts indicate_that_tests_were_run(failures: 26), result
-  end
-  # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
-end

data/test/acceptance_test_helper.rb

@@ -1,43 +0,0 @@
-require_relative 'support/current_bundle'
-
-Tests::CurrentBundle.instance.assert_appraisal!
-
-#---
-
-require 'test_helper'
-
-require_relative 'support/acceptance/rails_application_with_shoulda'
-require_relative 'support/acceptance/matchers/have_output'
-require_relative 'support/acceptance/matchers/indicate_that_tests_were_run'
-
-class AcceptanceTest < Minitest::Test
-  include AcceptanceTests::Matchers
-
-  private
-
-  def app
-    @app ||= AcceptanceTests::RailsApplicationWithShoulda.new
-  end
-end
-
-begin
-  require 'rails/test_unit/reporter'
-
-  # Patch Rails' reporter for Minitest so that it looks for the test
-  # correctly under Minitest 5.11
-  # See: <https://github.com/rails/rails/pull/31624>
-  Rails::TestUnitReporter.class_eval do
-    def format_rerun_snippet(result)
-      location, line =
-        if result.respond_to?(:source_location)
-          result.source_location
-        else
-          result.method(result.name).source_location
-        end
-
-      "#{executable} #{relative_path_for(location)}:#{line}"
-    end
-  end
-rescue LoadError
-  # Okay, rails/test_unit/reporter isn't a thing, no big deal
-end

data/test/support/acceptance/add_shoulda_to_project.rb

@@ -1,73 +0,0 @@
-module AcceptanceTests
-  class AddShouldaToProject
-    ROOT_DIRECTORY = Pathname.new('../../..').expand_path(__FILE__)
-
-    def self.call(app, options)
-      new(app, options).call
-    end
-
-    def initialize(app, options)
-      @app = app
-      @options = options
-    end
-
-    def call
-      app.add_gem 'shoulda', gem_options
-
-      unless options[:with_configuration] === false
-        add_configuration_block_to_test_helper
-      end
-    end
-
-    private
-
-    attr_reader :app, :options
-
-    def test_framework
-      options[:test_framework]
-    end
-
-    def libraries
-      options.fetch(:libraries, [])
-    end
-
-    def gem_options
-      gem_options = { path: ROOT_DIRECTORY }
-
-      if options[:manually]
-        gem_options[:require] = false
-      end
-
-      gem_options
-    end
-
-    def add_configuration_block_to_test_helper
-      content = <<-CONTENT
-        Shoulda::Matchers.configure do |config|
-          config.integrate do |with|
-            #{test_framework_config}
-            #{library_config}
-          end
-        end
-      CONTENT
-
-      if options[:manually]
-        content = "require 'shoulda'\n#{content}"
-      end
-
-      app.append_to_file('test/test_helper.rb', content)
-    end
-
-    def test_framework_config
-      if test_framework
-        "with.test_framework :#{test_framework}\n"
-      else
-        ''
-      end
-    end
-
-    def library_config
-      libraries.map { |library| "with.library :#{library}" }.join("\n")
-    end
-  end
-end

data/test/support/acceptance/helpers/array_helpers.rb

@@ -1,13 +0,0 @@
-module AcceptanceTests
-  module ArrayHelpers
-    def to_sentence(array)
-      if array.size == 1
-        array[0]
-      elsif array.size == 2
-        array.join(' and ')
-      else
-        to_sentence(array[1..-2].join(', '), [array[-1]])
-      end
-    end
-  end
-end