shoulda 3.5.0 → 3.6.0

data/test/warnings_spy.rb

@@ -0,0 +1,62 @@
+require 'forwardable'
+
+require File.expand_path('../warnings_spy/filesystem', __FILE__)
+require File.expand_path('../warnings_spy/reader', __FILE__)
+require File.expand_path('../warnings_spy/partitioner', __FILE__)
+require File.expand_path('../warnings_spy/reporter', __FILE__)
+
+class WarningsSpy
+  extend Forwardable
+
+  def initialize(project_name)
+    filesystem = Filesystem.new
+    @warnings_file = filesystem.warnings_file
+    @reader = Reader.new(filesystem)
+    @partitioner = Partitioner.new(reader, filesystem)
+    @reporter = Reporter.new(partitioner, filesystem, project_name)
+  end
+
+  def capture_warnings
+    $stderr.reopen(warnings_file.path)
+  end
+
+  def report_warnings_at_exit
+    at_exit do
+      printing_exceptions do
+        report_and_exit
+      end
+    end
+  end
+
+  protected
+
+  attr_reader :warnings_file, :reader, :partitioner, :reporter
+
+  private
+
+  def_delegators :partitioner, :relevant_warning_groups,
+    :irrelevant_warning_groups
+
+  def report_and_exit
+    reader.read
+    partitioner.partition
+    reporter.report
+    fail_build_if_there_are_any_warnings
+  end
+
+  def fail_build_if_there_are_any_warnings
+    if relevant_warning_groups.any?
+      exit(1)
+    end
+  end
+
+  def printing_exceptions
+    yield
+  rescue => error
+    puts "\n--- ERROR IN AT_EXIT --------------------------------"
+    puts "#{error.class}: #{error.message}"
+    puts error.backtrace.join("\n")
+    puts '-----------------------------------------------------'
+    raise error
+  end
+end

data/test/warnings_spy/filesystem.rb

@@ -0,0 +1,45 @@
+require 'fileutils'
+
+class WarningsSpy
+  class Filesystem
+    PROJECT_DIR = File.expand_path('../../..', __FILE__)
+    TEMP_DIR = File.join(PROJECT_DIR, 'tmp')
+
+    def initialize
+      @files_by_name = Hash.new do |hash, name|
+        FileUtils.mkdir_p(TEMP_DIR)
+        hash[name] = file_for(name)
+      end
+    end
+
+    def warnings_file
+      files_by_name['all_warnings']
+    end
+
+    def irrelevant_warnings_file
+      files_by_name['irrelevant_warnings']
+    end
+
+    def relevant_warnings_file
+      files_by_name['relevant_warnings']
+    end
+
+    def project_dir
+      PROJECT_DIR
+    end
+
+    protected
+
+    attr_reader :files_by_name
+
+    private
+
+    def path_for(name)
+      File.join(TEMP_DIR, "#{name}.txt")
+    end
+
+    def file_for(name)
+      File.open(path_for(name), 'w+')
+    end
+  end
+end

data/test/warnings_spy/partitioner.rb

@@ -0,0 +1,36 @@
+require 'forwardable'
+
+class WarningsSpy
+  class Partitioner
+    extend Forwardable
+
+    attr_reader :relevant_warning_groups, :irrelevant_warning_groups
+
+    def initialize(reader, filesystem)
+      @reader = reader
+      @search_text = filesystem.project_dir
+    end
+
+    def partition
+      @relevant_warning_groups, @irrelevant_warning_groups =
+        warning_groups.partition { |group| relevant_warnings?(group) }
+    end
+
+    protected
+
+    attr_reader :reader, :search_text
+
+    private
+
+    def_delegators :reader, :warning_groups
+
+    def relevant_warnings?(group)
+      first_line = group[0]
+      first_line.start_with?("#{project_root}/lib")
+    end
+
+    def project_root
+      File.expand_path('../../..')
+    end
+  end
+end

data/test/warnings_spy/reader.rb

@@ -0,0 +1,53 @@
+class WarningsSpy
+  class Reader
+    attr_reader :warning_groups
+
+    def initialize(filesystem)
+      @warnings_file = filesystem.warnings_file
+
+      @current_group = []
+      @warning_groups = []
+    end
+
+    def read
+      warnings_file.rewind
+
+      warnings_file.each_line do |line|
+        process_line(line)
+      end
+
+      add_group(current_group)
+    end
+
+    protected
+
+    attr_reader :warnings_file, :current_group
+
+    private
+
+    def process_line(line)
+      if start_of_group?(line)
+        add_group(current_group)
+        @current_group = []
+      end
+
+      current_group << line
+    end
+
+    def start_of_group?(line)
+      line =~ /^\S/
+    end
+
+    def add_group(group)
+      unless group.empty? || group_already_added?(group)
+        warning_groups << group
+      end
+    end
+
+    def group_already_added?(group_to_be_added)
+      warning_groups.any? do |group|
+        group == group_to_be_added
+      end
+    end
+  end
+end

data/test/warnings_spy/reporter.rb

@@ -0,0 +1,88 @@
+require 'forwardable'
+
+class WarningsSpy
+  class Reporter
+    extend Forwardable
+
+    def initialize(partitioner, filesystem, project_name)
+      @partitioner = partitioner
+      @warnings_file = filesystem.warnings_file
+      @relevant_warnings_file = filesystem.relevant_warnings_file
+      @irrelevant_warnings_file = filesystem.irrelevant_warnings_file
+      @project_name = project_name
+    end
+
+    def report
+      reporting_all_groups do
+        report_relevant_warning_groups
+        report_irrelevant_warning_groups
+      end
+    end
+
+    protected
+
+    attr_reader :partitioner, :warnings_file, :relevant_warnings_file,
+      :irrelevant_warnings_file, :project_name
+
+    private
+
+    def_delegators :partitioner, :relevant_warning_groups,
+      :irrelevant_warning_groups
+
+    def report_relevant_warning_groups
+      if relevant_warning_groups.any?
+        print_divider('-', 75, header: " #{project_name} warnings:")
+        relevant_warning_groups.each do |group|
+          group.each do |line|
+            relevant_warnings_file.puts(line)
+            puts line
+          end
+        end
+        print_divider('-', 75)
+        puts "#{project_name} warnings written to #{relevant_warnings_file.path}."
+      end
+    end
+
+    def report_irrelevant_warning_groups
+      if irrelevant_warning_groups.any?
+        irrelevant_warning_groups.each do |group|
+          group.each do |line|
+            irrelevant_warnings_file.puts(line)
+          end
+        end
+        puts "Non #{project_name} warnings were raised during the test run. These have been written to #{irrelevant_warnings_file.path}."
+      end
+    end
+
+    def reporting_all_groups
+      if relevant_warning_groups.any? || irrelevant_warning_groups.any?
+        puts
+        yield
+        puts "All warnings were written to #{warnings_file.path}."
+        puts
+      end
+    end
+
+    def print_divider(character, count, options = {})
+      puts
+
+      if options[:header]
+        first_count = 10
+        second_count = options[:header].length - first_count
+        string =
+          horizontal_rule(character, first_count) +
+          options[:header] +
+          horizontal_rule(character, second_count)
+        puts string
+      else
+        puts horizontal_rule(character, count)
+      end
+
+      puts
+    end
+
+    def horizontal_rule(character, count)
+      character * count
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shoulda
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.6.0
 platform: ruby
 authors:
 - Tammer Saleh
@@ -12,159 +12,94 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-07 00:00:00.000000000 Z
+date: 2018-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  name: shoulda-context
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.1
+  type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.1
-  type: :runtime
-  prerelease: false
-  name: shoulda-context
 - !ruby/object:Gem::Dependency
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.4.1
-    - - <
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.4.1
-    - - <
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  name: shoulda-matchers
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.0
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.0
-  type: :development
-  prerelease: false
-  name: appraisal
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.0.12
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.0.12
-  type: :development
-  prerelease: false
-  name: rails
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.3.2
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.3.2
-  type: :development
-  prerelease: false
-  name: sqlite3
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.7.0
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.7.0
-  type: :development
-  prerelease: false
-  name: rspec-rails
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.0
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
-  type: :development
-  prerelease: false
-  name: cucumber
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.11
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.11
-  type: :development
-  prerelease: false
-  name: aruba
+        version: '3.0'
 description: Making tests easy on the fingers and eyes
 email: support@thoughtbot.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .autotest
-- .gitignore
-- .travis.yml
+- ".autotest"
+- ".gitignore"
+- ".hound.yml"
+- ".hound/ruby.yml"
+- ".rubocop.yml"
+- ".travis.yml"
 - Appraisals
 - CONTRIBUTING.md
 - Gemfile
 - MIT-LICENSE
 - README.md
 - Rakefile
-- features/rails_integration.feature
-- features/step_definitions/rails_steps.rb
-- features/support/env.rb
-- gemfiles/3.0.gemfile
-- gemfiles/3.0.gemfile.lock
-- gemfiles/3.1.gemfile
-- gemfiles/3.1.gemfile.lock
-- gemfiles/3.2.gemfile
-- gemfiles/3.2.gemfile.lock
+- gemfiles/4.2.gemfile
+- gemfiles/4.2.gemfile.lock
+- gemfiles/5.0.gemfile
+- gemfiles/5.0.gemfile.lock
 - lib/shoulda.rb
 - lib/shoulda/version.rb
 - shoulda.gemspec
+- test/acceptance/rails_integration_test.rb
+- test/acceptance_test_helper.rb
+- test/report_warnings.rb
+- test/support/acceptance/add_shoulda_to_project.rb
+- test/support/acceptance/helpers.rb
+- test/support/acceptance/helpers/active_model_helpers.rb
+- test/support/acceptance/helpers/array_helpers.rb
+- test/support/acceptance/helpers/base_helpers.rb
+- test/support/acceptance/helpers/command_helpers.rb
+- test/support/acceptance/helpers/file_helpers.rb
+- test/support/acceptance/helpers/gem_helpers.rb
+- test/support/acceptance/helpers/pluralization_helpers.rb
+- test/support/acceptance/helpers/step_helpers.rb
+- test/support/acceptance/matchers/have_output.rb
+- test/support/acceptance/matchers/indicate_number_of_tests_was_run_matcher.rb
+- test/support/acceptance/matchers/indicate_that_tests_were_run_matcher.rb
+- test/support/tests/bundle.rb
+- test/support/tests/command_runner.rb
+- test/support/tests/current_bundle.rb
+- test/support/tests/filesystem.rb
+- test/support/tests/version.rb
+- test/test_helper.rb
+- test/warnings_spy.rb
+- test/warnings_spy/filesystem.rb
+- test/warnings_spy/partitioner.rb
+- test/warnings_spy/reader.rb
+- test/warnings_spy/reporter.rb
 homepage: https://github.com/thoughtbot/shoulda
 licenses:
 - MIT
@@ -175,21 +110,45 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Making tests easy on the fingers and eyes
 test_files:
-- features/rails_integration.feature
-- features/step_definitions/rails_steps.rb
-- features/support/env.rb
+- test/acceptance/rails_integration_test.rb
+- test/acceptance_test_helper.rb
+- test/report_warnings.rb
+- test/support/acceptance/add_shoulda_to_project.rb
+- test/support/acceptance/helpers.rb
+- test/support/acceptance/helpers/active_model_helpers.rb
+- test/support/acceptance/helpers/array_helpers.rb
+- test/support/acceptance/helpers/base_helpers.rb
+- test/support/acceptance/helpers/command_helpers.rb
+- test/support/acceptance/helpers/file_helpers.rb
+- test/support/acceptance/helpers/gem_helpers.rb
+- test/support/acceptance/helpers/pluralization_helpers.rb
+- test/support/acceptance/helpers/step_helpers.rb
+- test/support/acceptance/matchers/have_output.rb
+- test/support/acceptance/matchers/indicate_number_of_tests_was_run_matcher.rb
+- test/support/acceptance/matchers/indicate_that_tests_were_run_matcher.rb
+- test/support/tests/bundle.rb
+- test/support/tests/command_runner.rb
+- test/support/tests/current_bundle.rb
+- test/support/tests/filesystem.rb
+- test/support/tests/version.rb
+- test/test_helper.rb
+- test/warnings_spy.rb
+- test/warnings_spy/filesystem.rb
+- test/warnings_spy/partitioner.rb
+- test/warnings_spy/reader.rb
+- test/warnings_spy/reporter.rb