shoulda 3.4.0 → 4.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: addcbdbe54c194c8f2c709efb65ac0f82f0a8bbca33f32c3fd8cf4128f3a0d15
+  data.tar.gz: f27dceb02f6f6be6bec42de624d8b5285b99dcc8164c54654e6178f9fbff5c75
+SHA512:
+  metadata.gz: 4b99b87c67f5dce9f8bbf4952e48f79035b81b8590a2a10c00de595a04a8c31e10d019728914970a15bf2c7f4b4f35987e9cdd371afa780ff559ab4901d3b6e0
+  data.tar.gz: ca299a965486164a222563acdec871481a0ddb070c17a2ffc517784db956a7cfd7f9de4a6a7761b7288a4311df105f2b14a5777f4618466caf116fee15f4a013

data/.gitignore

@@ -1,11 +1,13 @@
-test/*/log/*.log
-doc
-coverage
+*.swo
+*.swp
+.DS_Store
+.byebug_history
+.bundle
 .svn/
+Gemfile.lock
+coverage
+doc
 pkg
-*.swp
-*.swo
 tags
+test/*/log/*.log
 tmp
-.bundle
-Gemfile.lock

data/.hound.yml

@@ -0,0 +1,3 @@
+ruby:
+  enabled: true
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,192 @@
+AllCops:
+  TargetRubyVersion: 2.4
+Layout/ParameterAlignment:
+  EnforcedStyle: with_fixed_indentation
+Layout/ConditionPosition:
+  Enabled: false
+Layout/DotPosition:
+  EnforcedStyle: trailing
+Layout/HeredocIndentation:
+  Enabled: false
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+Lint/AmbiguousOperator:
+  Enabled: false
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+Lint/AssignmentInCondition:
+  Enabled: false
+Lint/DeprecatedClassMethods:
+  Enabled: false
+Lint/ElseLayout:
+  Enabled: false
+Lint/SuppressedException:
+  Enabled: false
+Lint/LiteralInInterpolation:
+  Enabled: false
+Lint/Loop:
+  Enabled: false
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+Lint/RequireParentheses:
+  Enabled: false
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false
+Lint/Void:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Metrics/LineLength:
+  IgnoredPatterns:
+    - "^[ ]*describe.+$"
+    - "^[ ]*context.+$"
+    - "^[ ]*shared_context.+$"
+    - "^[ ]*shared_examples_for.+$"
+    - "^[ ]*it.+$"
+    - "^[ ]*'.+?' => '.+?',?$"
+    - "^[ ]*\".+?\" => \".+?\",?$"
+    - "^[ ]*.+?: .+?$"
+Metrics/MethodLength:
+  Max: 30
+Naming/AccessorMethodName:
+  Enabled: false
+Naming/AsciiIdentifiers:
+  Enabled: false
+Naming/BinaryOperatorParameterName:
+  Enabled: false
+Style/ClassVars:
+  Enabled: false
+Style/ColonMethodCall:
+  Enabled: false
+Naming/FileName:
+  Enabled: false
+Rails:
+  Enabled: true
+Rails/Delegate:
+  Enabled: false
+Rails/HttpPositionalArguments:
+  Enabled: false
+Style/Alias:
+  Enabled: false
+Style/ArrayJoin:
+  Enabled: false
+Style/AsciiComments:
+  Enabled: false
+Style/Attr:
+  Enabled: false
+Style/CaseEquality:
+  Enabled: false
+Style/CharacterLiteral:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/CollectionMethods:
+  PreferredMethods:
+    find: detect
+    reduce: inject
+    collect: map
+    find_all: select
+Style/CommentAnnotation:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/DoubleNegation:
+  Enabled: false
+Style/EachWithObject:
+  Enabled: false
+Style/EmptyLiteral:
+  Enabled: false
+Style/Encoding:
+  Enabled: false
+Style/EvenOdd:
+  Enabled: false
+Lint/FlipFlop:
+  Enabled: false
+Style/FormatString:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Enabled: false
+Style/GlobalVars:
+  Enabled: false
+Style/GuardClause:
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Style/IfWithSemicolon:
+  Enabled: false
+Style/InlineComment:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/LambdaCall:
+  Enabled: false
+Style/LineEndConcatenation:
+  Enabled: false
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+Style/ModuleFunction:
+  Enabled: false
+Style/NegatedIf:
+  Enabled: false
+Style/NegatedWhile:
+  Enabled: false
+Style/Next:
+  Enabled: false
+Style/NilComparison:
+  Enabled: false
+Style/Not:
+  Enabled: false
+Style/NumericLiterals:
+  Enabled: false
+Style/NumericPredicate:
+  Enabled: false
+Style/OneLineConditional:
+  Enabled: false
+Style/ParenthesesAroundCondition:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/PerlBackrefs:
+  Enabled: false
+Style/PreferredHashMethods:
+  Enabled: false
+Style/Proc:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Style/RedundantParentheses:
+  Enabled: false
+Style/RegexpLiteral:
+  Enabled: false
+Style/SelfAssignment:
+  Enabled: false
+Style/SignalException:
+  Enabled: false
+Style/SingleLineBlockParams:
+  Enabled: false
+Style/SingleLineMethods:
+  Enabled: false
+Style/SpecialGlobalVars:
+  Enabled: false
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+Style/SymbolArray:
+  Enabled: false
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrivialAccessors:
+  Enabled: false
+Style/WhenThen:
+  Enabled: false
+Style/WhileUntilModifier:
+  Enabled: false
+Style/WordArray:
+  Enabled: false
+Style/VariableInterpolation:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+2.7.1

data/.travis.yml

@@ -1,3 +1,34 @@
+language: ruby
+dist: xenial
+os: linux
+cache:
+  directories:
+    - vendor/bundle
+# Source: <https://docs.travis-ci.com/user/languages/ruby/#bundler-20>
+before_install:
+  - gem update --system '3.1.2' --no-document
+  - gem uninstall -v '< 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2' --no-document
+  - nvm use v11.0.0
+  - bundle config set path vendor/bundle
+install: "bundle install --jobs=3 --retry=3"
+script: "bundle exec rake"
 rvm:
-  - 1.8.7
-  - 1.9.2
+  - 2.4.9
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
+gemfile:
+  - gemfiles/rails_4_2.gemfile
+  - gemfiles/rails_5_0.gemfile
+  - gemfiles/rails_5_1.gemfile
+  - gemfiles/rails_5_2.gemfile
+  - gemfiles/rails_6_0.gemfile
+matrix:
+  exclude:
+    - rvm: 2.4.9
+      gemfile: gemfiles/rails_6_0.gemfile
+    - rvm: 2.6.6
+      gemfile: gemfiles/rails_4_2.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_4_2.gemfile

data/Appraisals

@@ -1,15 +1,116 @@
-appraise '3.0' do
-  gem 'rails', '3.0.12'
+# Note: All of the dependencies here were obtained by running `rails new` with
+# various versions of Rails and copying lines from the generated Gemfile. It's
+# best to keep the gems here in the same order as they're listed there so you
+# can compare them more easily.
+
+shared_rails_dependencies = proc do
+  gem 'sqlite3', '~> 1.3.6'
+  gem 'rubyzip', '~> 1.3.0'
+end
+
+shared_spring_dependencies = proc do
+  gem 'spring'
+  gem 'spring-commands-rspec'
+end
+
+shared_test_dependencies = proc do
+  gem 'minitest-reporters'
 end
 
-appraise '3.1' do
-  gem 'rails', '3.1.4'
+shared_dependencies = proc do
+  instance_eval(&shared_rails_dependencies)
+  instance_eval(&shared_spring_dependencies)
+  instance_eval(&shared_test_dependencies)
+end
+
+appraise 'rails_4_2' do
+  instance_eval(&shared_dependencies)
+
+  gem 'rails', '~> 4.2.10'
+  gem 'sass-rails', '~> 5.0'
+  gem 'uglifier', '>= 1.3.0'
+  gem 'coffee-rails', '~> 4.1.0'
   gem 'jquery-rails'
-  gem 'sass-rails'
+  gem 'turbolinks'
+  gem 'jbuilder', '~> 2.0'
+  gem 'sdoc', '~> 0.4.0', group: :doc
+  gem 'bcrypt', '~> 3.1.7'
+
+  # Other dependencies we use
+  gem 'activeresource', '4.0.0'
+  gem 'json', '~> 1.4'
+  gem 'protected_attributes', '~> 1.0.6'
 end
 
-appraise '3.2' do
-  gem 'rails', '3.2.3'
+appraise 'rails_5_0' do
+  instance_eval(&shared_dependencies)
+
+  gem 'rails', '~> 5.0.7'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.0'
+  gem 'sass-rails', '~> 5.0'
   gem 'jquery-rails'
-  gem 'sass-rails'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'listen', '~> 3.0.5'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+appraise 'rails_5_1' do
+  instance_eval(&shared_dependencies)
+  gem 'rails', '~> 5.1.6'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.7'
+  gem 'sass-rails', '~> 5.0'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'capybara', '~> 2.13'
+  gem 'selenium-webdriver'
+  gem 'listen', '>= 3.0.5', '< 3.2'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+appraise 'rails_5_2' do
+  instance_eval(&shared_dependencies)
+
+  gem 'rails', '~> 5.2.2'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.11'
+  gem 'bootsnap', '>= 1.1.0', require: false
+  gem 'sass-rails', '~> 5.0'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'capybara', '~> 3.1.1'
+  gem 'selenium-webdriver'
+  gem 'chromedriver-helper'
+  gem 'listen', '>= 3.0.5', '< 3.2'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+if Gem::Requirement.new('>= 2.5.0').satisfied_by?(Gem::Version.new(RUBY_VERSION))
+  appraise 'rails_6_0' do
+    instance_eval(&shared_dependencies)
+
+    gem 'rails', '~> 6.0.2'
+    gem 'puma', '~> 4.1'
+    gem 'sass-rails', '>= 6'
+    gem 'webpacker', '~> 4.0'
+    gem 'turbolinks', '~> 5'
+    gem 'jbuilder', '~> 2.7'
+    gem 'bcrypt', '~> 3.1.7'
+    gem 'bootsnap', '>= 1.4.2', require: false
+    gem 'listen', '>= 3.0.5', '< 3.2'
+    gem 'spring-watcher-listen', '~> 2.0.0'
+    gem 'capybara', '>= 2.15'
+    gem 'selenium-webdriver'
+    gem "sqlite3", "~> 1.4.0"
+    gem 'webdrivers'
+
+    # Other dependencies
+    gem 'rails-controller-testing', '>= 1.0.4'
+    gem 'pg', '~> 1.1', platform: :ruby
+  end
 end

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## 4.0.0 (2020-06-13)
+
+* `shoulda` now brings in `shoulda-context` 2.0.0, which adds compatibility for
+  Ruby 2.7, Rails 6.0, and shoulda-matchers 4.0! Note that there are some
+  backward incompatible changes, so please see the [changelog
+  entry][shoulda-context-2-0-0] for this release to learn more.
+
+[shoulda-context-2-0-0]: https://github.com/thoughtbot/shoulda-context/blob/master/CHANGELOG.md#200-2020-06-13

data/CONTRIBUTING.md

@@ -1,4 +1,9 @@
-We love pull requests. Here's a quick guide:
+We love pull requests from everyone. By participating in this project, you
+agree to abide by the thoughtbot [code of conduct].
+
+[code of conduct]: https://thoughtbot.com/open-source-code-of-conduct
+
+Here's a quick guide:
 
 1. Fork the repo.
 

data/Gemfile

@@ -1,3 +1,16 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'appraisal', '~> 2.1'
+gem 'bundler', '~> 1.0'
+gem 'm'
+gem 'minitest', '~> 5.0'
+gem 'minitest-reporters', '~> 1.0'
+gem 'mry'
+gem 'pry', '~> 0.12.0'
+gem 'pry-byebug', '~> 3.6.0'
+gem 'rubocop', '0.71.0', require: false
+gem 'rubocop-rails', require: false
+gem 'snowglobe', '>= 0.3.0'
+gem 'warnings_logger'

data/README.md

@@ -1,108 +1,101 @@
-# shoulda [![Gem Version](https://badge.fury.io/rb/shoulda.png)](http://badge.fury.io/rb/shoulda) [![Build Status](https://secure.travis-ci.org/thoughtbot/shoulda.png)](http://travis-ci.org/thoughtbot/shoulda)
+# Shoulda [![Gem Version][version-badge]][rubygems] [![Build Status][travis-badge]][travis] ![Downloads][downloads-badge] [![Hound][hound-badge]][hound]
 
-The shoulda gem is a meta gem with two dependencies:
+[version-badge]: http://img.shields.io/gem/v/shoulda.svg
+[rubygems]: http://rubygems.org/gems/shoulda
+[travis-badge]: http://img.shields.io/travis/thoughtbot/shoulda/master.svg
+[travis]: http://travis-ci.org/thoughtbot/shoulda
+[downloads-badge]: http://img.shields.io/gem/dtv/shoulda.svg
+[hound-badge]: https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg
+[hound]: https://houndci.com
 
-* [shoulda-context](https://github.com/thoughtbot/shoulda-context)
-* [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers)
+Shoulda helps you write more understandable, maintainable Rails-specific tests
+under Minitest and Test::Unit.
 
-Official documentation for each gem:
+## Quick links
 
-* [shoulda-context](http://rubydoc.info/github/thoughtbot/shoulda-context/master/frames)
-* [shoulda-matchers](http://rubydoc.info/github/thoughtbot/shoulda-matchers/master/frames)
+📢 **[See what's changed in recent versions.][changelog]**
 
-The following describes different use cases and combinations.
+[changelog]: CHANGELOG.md
 
-rspec with shoulda-matchers
----------------------------
+## Overview
 
-This is what thoughtbot currently does. We write tests like:
+As a meta gem, the `shoulda` gem doesn't contain any code of its own but rather
+brings in behavior from two other gems:
 
-```ruby
-describe Post do
-  it { should belong_to(:user) }
-  it { should validate_presence_of(:title) }
-end
-```
+* [Shoulda Context]
+* [Shoulda Matchers]
 
-The belong_to and validate_presence_of methods are the matchers.
-All matchers are Rails 3-specific.
+[Shoulda Context]: https://github.com/thoughtbot/shoulda-context
+[Shoulda Matchers]: https://github.com/thoughtbot/shoulda-matchers
 
-Add rspec-rails and shoulda-matchers to the project's Gemfile:
+For instance:
 
 ```ruby
-group :test do
-  gem 'rspec-rails'
-  gem 'shoulda-matchers'
-end
-```
+require "test_helper"
 
-test/unit with shoulda
-----------------------
+class UserTest < ActiveSupport::TestCase
+  context "associations" do
+    should have_many(:posts)
+  end
 
-For the folks who prefer Test::Unit, they'd write tests like:
+  context "validations" do
+    should validate_presence_of(:email)
+    should allow_value("user@example.com").for(:email)
+    should_not allow_value("not-an-email").for(:email)
+  end
 
-```ruby
-class UserTest < Test::Unit::TestCase
-  should have_many(:posts)
-  should_not allow_value("blah").for(:email)
+  context "#name" do
+    should "consist of first and last name" do
+      user = User.new(first_name: "John", last_name: "Smith")
+      assert_equal "John Smith", user.name
+    end
+  end
 end
 ```
 
-The have_many and allow_value methods are the same kind of matchers
-seen in the RSpec example. They come from the shoulda-matchers gem.
+Here, the `context` and `should` methods come from Shoulda Context; matchers
+(e.g. `have_many`, `allow_value`) come from Shoulda Matchers.
 
-Add shoulda to the project's Gemfile:
+See the READMEs for these projects for more information.
 
-```ruby
-group :test do
-  gem 'shoulda'
-end
-```
+## Compatibility
 
-test/unit with shoulda-context
-------------------------------
+Shoulda Matchers is [tested][travis] and supported against Ruby 2.4+, Rails
+4.2.x+, RSpec 3.x, and Minitest 5.x.
 
-If you're not testing a Rails project or don't want to use the matchers,
-you can use shoulda-context independently to write tests like:
+## Contributing
 
-```ruby
-class CalculatorTest < Test::Unit::TestCase
-  context "a calculator" do
-    setup do
-      @calculator = Calculator.new
-    end
+Shoulda is open source, and we are grateful for [everyone][contributors] who's
+contributed so far.
 
-    should "add two numbers for the sum" do
-      assert_equal 4, @calculator.sum(2, 2)
-    end
+[contributors]: https://github.com/thoughtbot/shoulda/contributors
 
-    should "multiply two numbers for the product" do
-      assert_equal 10, @calculator.product(2, 5)
-    end
-  end
-end
-```
+If you'd like to contribute, please take a look at the
+[instructions](CONTRIBUTING.md) for installing dependencies and crafting a good
+pull request.
 
-Add shoulda-context to the project's Gemfile:
+## Versioning
 
-```ruby
-group :test do
-  gem 'shoulda-context'
-end
-```
+Shoulda follows Semantic Versioning 2.0 as defined at <http://semver.org>.
+
+## License
 
-Credits
--------
+Shoulda is copyright © 2006-2019 thoughtbot, inc. It is free software, and may
+be redistributed under the terms specified in the [MIT-LICENSE](MIT-LICENSE)
+file.
 
-![thoughtbot](http://thoughtbot.com/assets/tm/logo.png)
+## About thoughtbot
 
-Shoulda is maintained and funded by [thoughtbot, inc](http://thoughtbot.com/community)
+![thoughtbot][thoughtbot-logo]
 
-Thank you to all [the contributors](https://github.com/thoughtbot/shoulda/contributors)!
+[thoughtbot-logo]: https://thoughtbot.com/brand_assets/93:44.svg
 
-The names and logos for thoughtbot are trademarks of thoughtbot, inc.
+Shoulda is maintained and funded by thoughtbot, inc. The names and logos for
+thoughtbot are trademarks of thoughtbot, inc.
 
-License
--------
+We love open source software! See [our other projects][community] or [hire
+us][hire] to design, develop, and grow your product.
 
-Shoulda is Copyright © 2006-2013 Tammer Saleh and thoughtbot, inc. It is free software, and may be redistributed under the terms specified in the MIT-LICENSE file.
+[community]: https://thoughtbot.com/community?utm_source=github
+[hire]: https://thoughtbot.com/hire-us?utm_source=github
+[thoughtbot]: https://thoughtbot.com?utm_source=github