shoulda-matchers 4.4.0 → 5.0.0

data/lib/shoulda/matchers/doublespeak.rb

@@ -1,17 +1,10 @@
 require 'forwardable'
+require 'logger'
 
 module Shoulda
   module Matchers
     # @private
     module Doublespeak
-      autoload :Double, 'shoulda/matchers/doublespeak/double'
-      autoload :DoubleCollection, 'shoulda/matchers/doublespeak/double_collection'
-      autoload :DoubleImplementationRegistry, 'shoulda/matchers/doublespeak/double_implementation_registry'
-      autoload :MethodCall, 'shoulda/matchers/doublespeak/method_call'
-      autoload :ObjectDouble, 'shoulda/matchers/doublespeak/object_double'
-      autoload :ProxyImplementation, 'shoulda/matchers/doublespeak/proxy_implementation'
-      autoload :World, 'shoulda/matchers/doublespeak/world'
-
       class << self
         extend Forwardable
 
@@ -28,7 +21,7 @@ module Shoulda
 
         def debug(&block)
           if debugging_enabled?
-            puts block.call
+            puts block.call # rubocop:disable Rails/Output
           end
         end
       end
@@ -36,4 +29,11 @@ module Shoulda
   end
 end
 
+require 'shoulda/matchers/doublespeak/double'
+require 'shoulda/matchers/doublespeak/double_collection'
+require 'shoulda/matchers/doublespeak/double_implementation_registry'
+require 'shoulda/matchers/doublespeak/method_call'
+require 'shoulda/matchers/doublespeak/object_double'
+require 'shoulda/matchers/doublespeak/proxy_implementation'
 require 'shoulda/matchers/doublespeak/stub_implementation'
+require 'shoulda/matchers/doublespeak/world'

data/lib/shoulda/matchers/doublespeak/double.rb

@@ -82,7 +82,7 @@ module Shoulda
               method_name: _method_name,
               args: args,
               block: block,
-              caller: caller
+              caller: caller,
             )
             implementation.call(call)
           end

data/lib/shoulda/matchers/doublespeak/double_collection.rb

@@ -18,19 +18,19 @@ module Shoulda
         end
 
         def activate
-          doubles_by_method_name.each do |method_name, double|
+          doubles_by_method_name.each do |_method_name, double|
             double.activate
           end
         end
 
         def deactivate
-          doubles_by_method_name.each do |method_name, double|
+          doubles_by_method_name.each do |_method_name, double|
             double.deactivate
           end
         end
 
         def calls_by_method_name
-          doubles_by_method_name.reduce({}) do |hash, (method_name, double)|
+          doubles_by_method_name.inject({}) do |hash, (method_name, double)|
             hash.merge method_name => double.calls.map(&:args)
           end
         end

data/lib/shoulda/matchers/doublespeak/double_implementation_registry.rb

@@ -4,23 +4,26 @@ module Shoulda
       # @private
       module DoubleImplementationRegistry
         class << self
-          REGISTRY = {}
-
           def find(type)
             find_class!(type).create
           end
 
           def register(klass, type)
-            REGISTRY[type] = klass
+            registry[type] = klass
           end
 
           private
 
           def find_class!(type)
-            REGISTRY.fetch(type) do
-              raise ArgumentError, "No double implementation class found for '#{type}'"
+            registry.fetch(type) do
+              raise ArgumentError, 'No double implementation class found for'\
+                " '#{type}'"
             end
           end
+
+          def registry
+            @_registry ||= {}
+          end
         end
       end
     end

data/lib/shoulda/matchers/doublespeak/object_double.rb

@@ -27,7 +27,7 @@ module Shoulda
             method_name: method_name,
             args: args,
             block: block,
-            caller: ::Kernel.caller
+            caller: ::Kernel.caller,
           )
           calls << call
           (calls_by_method_name[method_name] ||= []) << call

data/lib/shoulda/matchers/doublespeak/stub_implementation.rb

@@ -14,11 +14,7 @@ module Shoulda
         end
 
         def returns(value = nil, &block)
-          if block
-            @implementation = block
-          else
-            @implementation = proc { value }
-          end
+          @implementation = block || proc { value }
         end
 
         def call(call)

data/lib/shoulda/matchers/doublespeak/world.rb

@@ -39,13 +39,13 @@ module Shoulda
         private
 
         def activate
-          double_collections_by_class.each do |klass, double_collection|
+          double_collections_by_class.each do |_klass, double_collection|
             double_collection.activate
           end
         end
 
         def deactivate
-          double_collections_by_class.each do |klass, double_collection|
+          double_collections_by_class.each do |_klass, double_collection|
             double_collection.deactivate
           end
         end

data/lib/shoulda/matchers/error.rb

@@ -18,7 +18,7 @@ module Shoulda
       end
 
       def message
-        ""
+        ''
       end
 
       def inspect

data/lib/shoulda/matchers/independent.rb

@@ -1,4 +1,5 @@
 require 'shoulda/matchers/independent/delegate_method_matcher'
+require 'shoulda/matchers/independent/delegate_method_matcher/target_not_defined_error'
 
 module Shoulda
   module Matchers

data/lib/shoulda/matchers/independent/delegate_method_matcher.rb

@@ -176,9 +176,6 @@ module Shoulda
 
       # @private
       class DelegateMethodMatcher
-        autoload :StubbedTarget, 'shoulda/matchers/independent/delegate_method_matcher/stubbed_target'
-        autoload :DelegateObjectNotSpecified, 'shoulda/matchers/independent/delegate_method_matcher/target_not_defined_error'
-
         def initialize(delegating_method)
           @delegating_method = delegating_method
 
@@ -222,9 +219,9 @@ module Shoulda
           end
 
           if expects_to_allow_nil_delegate_object?
-            string << ", allowing "
+            string << ', allowing '
             string << formatted_delegate_object_reader_method_name
-            string << " to return nil"
+            string << ' to return nil'
           end
 
           string
@@ -248,7 +245,7 @@ module Shoulda
         def with_prefix(prefix = nil)
           @delegating_method =
             :"#{build_delegating_method_prefix(prefix)}_#{delegate_method}"
-            delegate_method
+          delegate_method
           self
         end
 
@@ -259,8 +256,8 @@ module Shoulda
 
         def build_delegating_method_prefix(prefix)
           case prefix
-            when true, nil then delegate_object_reader_method
-            else prefix
+          when true, nil then delegate_object_reader_method
+          else prefix
           end
         end
 
@@ -347,7 +344,7 @@ module Shoulda
           if options[:include_module]
             class_under_test.to_s
           else
-            ""
+            ''
           end
         end
 
@@ -401,11 +398,12 @@ module Shoulda
                 true
               rescue Module::DelegationError
                 false
-              rescue NoMethodError => error
-                if error.message =~ /undefined method `#{delegate_method}' for nil:NilClass/
+              rescue NoMethodError => e
+                if e.message =~
+                   /undefined method `#{delegate_method}' for nil:NilClass/
                   false
                 else
-                  raise error
+                  raise e
                 end
               end
             else
@@ -442,17 +440,17 @@ module Shoulda
         end
 
         def formatted_calls_on_delegate_object
-          string = ""
+          string = ''
 
           if calls_on_delegate_object.any?
             string << "\n\n"
             calls_on_delegate_object.each_with_index do |call, i|
               name = call.method_name
-              args = call.args.map { |arg| arg.inspect }.join(', ')
-              string << "#{i+1}) #{name}(#{args})\n"
+              args = call.args.map(&:inspect).join(', ')
+              string << "#{i + 1}) #{name}(#{args})\n"
             end
           else
-            string << " (none)"
+            string << ' (none)'
           end
 
           string.rstrip!

data/lib/shoulda/matchers/integrations.rb

@@ -2,12 +2,6 @@ module Shoulda
   module Matchers
     # @private
     module Integrations
-      autoload :Configuration, 'shoulda/matchers/integrations/configuration'
-      autoload :ConfigurationError, 'shoulda/matchers/integrations/configuration_error'
-      autoload :Inclusion, 'shoulda/matchers/integrations/inclusion'
-      autoload :Rails, 'shoulda/matchers/integrations/rails'
-      autoload :Registry, 'shoulda/matchers/integrations/registry'
-
       class << self
         def register_library(klass, name)
           library_registry.register(klass, name)
@@ -39,5 +33,11 @@ module Shoulda
   end
 end
 
+require 'shoulda/matchers/integrations/configuration'
+require 'shoulda/matchers/integrations/configuration_error'
+require 'shoulda/matchers/integrations/inclusion'
+require 'shoulda/matchers/integrations/rails'
+require 'shoulda/matchers/integrations/registry'
+
 require 'shoulda/matchers/integrations/libraries'
 require 'shoulda/matchers/integrations/test_frameworks'

data/lib/shoulda/matchers/integrations/configuration.rb

@@ -60,7 +60,7 @@ EOT
         end
 
         def no_test_frameworks_added?
-          @test_frameworks.empty? || !@test_frameworks.any?(&:present?)
+          @test_frameworks.empty? || @test_frameworks.none?(&:present?)
         end
 
         def no_libraries_added?

data/lib/shoulda/matchers/integrations/libraries/action_controller.rb

@@ -13,7 +13,7 @@ module Shoulda
             test_framework.include(matchers_module, type: :controller)
 
             include_into(::ActionController::TestCase, matchers_module) do
-              def subject
+              def subject # rubocop:disable Lint/NestedMethodDefinition
                 @controller
               end
             end

data/lib/shoulda/matchers/integrations/libraries/rails.rb

@@ -12,8 +12,8 @@ module Shoulda
             :active_model,
             :active_record,
             :action_controller,
-            :routing
-          ]
+            :routing,
+          ].freeze
 
           def integrate_with(test_framework)
             Shoulda::Matchers.assertion_exception_class =

data/lib/shoulda/matchers/integrations/test_frameworks.rb

@@ -1,17 +1,15 @@
+require 'shoulda/matchers/integrations/test_frameworks/active_support_test_case'
 require 'shoulda/matchers/integrations/test_frameworks/minitest_4'
 require 'shoulda/matchers/integrations/test_frameworks/minitest_5'
 require 'shoulda/matchers/integrations/test_frameworks/missing_test_framework'
 require 'shoulda/matchers/integrations/test_frameworks/rspec'
+require 'shoulda/matchers/integrations/test_frameworks/test_unit'
 
 module Shoulda
   module Matchers
     module Integrations
       # @private
       module TestFrameworks
-        autoload :ActiveSupportTestCase, 'shoulda/matchers/integrations/test_frameworks/active_support_test_case'
-        autoload :Minitest4, 'shoulda/matchers/integrations/test_frameworks/minitest_4'
-        autoload :Minitest5, 'shoulda/matchers/integrations/test_frameworks/minitest_5'
-        autoload :TestUnit, 'shoulda/matchers/integrations/test_frameworks/test_unit'
       end
     end
   end

data/lib/shoulda/matchers/integrations/test_frameworks/active_support_test_case.rb

@@ -9,7 +9,7 @@ module Shoulda
           def validate!
           end
 
-          def include(*modules, **options)
+          def include(*modules, **_options)
             test_case_class.include(*modules)
           end
 

data/lib/shoulda/matchers/integrations/test_frameworks/minitest_4.rb

@@ -9,7 +9,7 @@ module Shoulda
           def validate!
           end
 
-          def include(*modules, **options)
+          def include(*modules, **_options)
             test_case_class.class_eval do
               include(*modules)
               extend(*modules)

data/lib/shoulda/matchers/integrations/test_frameworks/minitest_5.rb

@@ -10,7 +10,7 @@ module Shoulda
           def validate!
           end
 
-          def include(*modules, **options)
+          def include(*modules, **_options)
             test_case_class.class_eval do
               include(*modules)
               extend(*modules)

data/lib/shoulda/matchers/integrations/test_frameworks/missing_test_framework.rb

@@ -20,7 +20,7 @@ Shoulda::Matchers.configure do |config|
     with.test_framework :test_unit
   end
 end
-EOT
+            EOT
           end
 
           def include(*modules, **options)

data/lib/shoulda/matchers/integrations/test_frameworks/test_unit.rb

@@ -9,7 +9,7 @@ module Shoulda
           def validate!
           end
 
-          def include(*modules, **options)
+          def include(*modules, **_options)
             test_case_class.class_eval do
               include(*modules)
               extend(*modules)

data/lib/shoulda/matchers/rails_shim.rb

@@ -1,26 +1,14 @@
 module Shoulda
   module Matchers
     # @private
-    module RailsShim
+    module RailsShim # rubocop:disable Metrics/ModuleLength
       class << self
-        def action_pack_gte_5?
-          Gem::Requirement.new('>= 5').satisfied_by?(action_pack_version)
-        end
-
-        def action_pack_lt_5?
-          Gem::Requirement.new('< 5').satisfied_by?(action_pack_version)
-        end
-
         def action_pack_version
           Gem::Version.new(::ActionPack::VERSION::STRING)
         rescue NameError
           Gem::Version.new('0')
         end
 
-        def active_record_gte_5?
-          Gem::Requirement.new('>= 5').satisfied_by?(active_record_version)
-        end
-
         def active_record_gte_6?
           Gem::Requirement.new('>= 6').satisfied_by?(active_record_version)
         end
@@ -57,17 +45,6 @@ module Shoulda
           )
         end
 
-        def make_controller_request(context, verb, action, request_params)
-          params =
-            if action_pack_gte_5?
-              { params: request_params }
-            else
-              request_params
-            end
-
-          context.__send__(verb, action, params)
-        end
-
         def serialized_attributes_for(model)
           attribute_types_for(model).
             inject({}) do |hash, (attribute_name, attribute_type)|
@@ -85,26 +62,10 @@ module Shoulda
           serialized_attributes_for(model)[attribute_name.to_s]
         end
 
-        def tables_and_views(connection)
-          if active_record_gte_5?
-            connection.data_sources
-          else
-            connection.tables
-          end
-        end
-
         def verb_for_update
           :patch
         end
 
-        def validation_message_key_for_association_required_option
-          if active_record_gte_5?
-            :required
-          else
-            :blank
-          end
-        end
-
         def parent_of(mod)
           if mod.respond_to?(:module_parent)
             mod.module_parent
@@ -180,10 +141,12 @@ module Shoulda
           options
         )
           default_translation_keys = [
-            :"activemodel.errors.models.#{model_name}.attributes.#{attribute}.#{type}",
+            :"activemodel.errors.models.#{model_name}.attributes.#{attribute}
+              .#{type}",
             :"activemodel.errors.models.#{model_name}.#{type}",
             :"activemodel.errors.messages.#{type}",
-            :"activerecord.errors.models.#{model_name}.attributes.#{attribute}.#{type}",
+            :"activerecord.errors.models.#{model_name}.attributes.#{attribute}
+              .#{type}",
             :"activerecord.errors.models.#{model_name}.#{type}",
             :"activerecord.errors.messages.#{type}",
             :"errors.attributes.#{attribute}.#{type}",