shoulda-matchers 3.1.3 → 4.0.0.rc1

data/gemfiles/5.2.gemfile

@@ -0,0 +1,40 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", "2.2.0"
+gem "bundler", "~> 1.1"
+gem "pry"
+gem "pry-byebug"
+gem "rake", "12.3.0"
+gem "rspec", "~> 3.6"
+gem "zeus", require: false
+gem "yard"
+gem "redcarpet"
+gem "pygments.rb"
+gem "fssm"
+gem "activerecord-jdbc-adapter", platform: :jruby
+gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
+gem "jdbc-sqlite3", platform: :jruby
+gem "jruby-openssl", platform: :jruby
+gem "therubyrhino", platform: :jruby
+gem "sqlite3", platform: :ruby
+gem "pg", platform: :ruby
+gem "spring"
+gem "spring-commands-rspec"
+gem "minitest-reporters"
+gem "rspec-rails", "~> 3.6"
+gem "shoulda-context", "~> 1.2.0"
+gem "rails", "~> 5.2.1"
+gem "rails-controller-testing", ">= 1.0.1"
+gem "puma", "~> 3.11"
+gem "bootsnap", ">= 1.1.0", require: false
+gem "sass-rails", "~> 5.0"
+gem "turbolinks", "~> 5"
+gem "jbuilder", "~> 2.5"
+gem "bcrypt", "~> 3.1.7"
+gem "capybara", "~> 3.1.1"
+gem "selenium-webdriver"
+gem "chromedriver-helper"
+gem "listen", ">= 3.0.5", "< 3.2"
+gem "spring-watcher-listen", "~> 2.0.0"

data/gemfiles/5.2.gemfile.lock

@@ -0,0 +1,273 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (5.2.1)
+      actionpack (= 5.2.1)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailer (5.2.1)
+      actionpack (= 5.2.1)
+      actionview (= 5.2.1)
+      activejob (= 5.2.1)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.2.1)
+      actionview (= 5.2.1)
+      activesupport (= 5.2.1)
+      rack (~> 2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.2.1)
+      activesupport (= 5.2.1)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.1)
+      activesupport (= 5.2.1)
+      globalid (>= 0.3.6)
+    activemodel (5.2.1)
+      activesupport (= 5.2.1)
+    activerecord (5.2.1)
+      activemodel (= 5.2.1)
+      activesupport (= 5.2.1)
+      arel (>= 9.0)
+    activestorage (5.2.1)
+      actionpack (= 5.2.1)
+      activerecord (= 5.2.1)
+      marcel (~> 0.3.1)
+    activesupport (5.2.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
+    ansi (1.5.0)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    archive-zip (0.11.0)
+      io-like (~> 0.3.0)
+    arel (9.0.0)
+    bcrypt (3.1.12)
+    bootsnap (1.3.1)
+      msgpack (~> 1.0)
+    builder (3.2.3)
+    byebug (10.0.2)
+    capybara (3.1.1)
+      addressable
+      mini_mime (>= 0.1.3)
+      nokogiri (~> 1.8)
+      rack (>= 1.6.0)
+      rack-test (>= 0.6.3)
+      xpath (~> 3.0)
+    childprocess (0.9.0)
+      ffi (~> 1.0, >= 1.0.11)
+    chromedriver-helper (1.2.0)
+      archive-zip (~> 0.10)
+      nokogiri (~> 1.8)
+    coderay (1.1.2)
+    concurrent-ruby (1.0.5)
+    crass (1.0.4)
+    diff-lcs (1.3)
+    erubi (1.7.1)
+    ffi (1.9.25)
+    fssm (0.2.10)
+    globalid (0.4.1)
+      activesupport (>= 4.2.0)
+    i18n (1.1.0)
+      concurrent-ruby (~> 1.0)
+    io-like (0.3.0)
+    jbuilder (2.7.0)
+      activesupport (>= 4.2.0)
+      multi_json (>= 1.2)
+    listen (3.1.5)
+      rb-fsevent (~> 0.9, >= 0.9.4)
+      rb-inotify (~> 0.9, >= 0.9.7)
+      ruby_dep (~> 1.2)
+    loofah (2.2.2)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.0)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.2)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.0)
+    mimemagic (0.3.2)
+    mini_mime (1.0.1)
+    mini_portile2 (2.3.0)
+    minitest (5.11.3)
+    minitest-reporters (1.3.4)
+      ansi
+      builder
+      minitest (>= 5.0)
+      ruby-progressbar
+    msgpack (1.2.4)
+    multi_json (1.13.1)
+    nio4r (2.3.1)
+    nokogiri (1.8.4)
+      mini_portile2 (~> 2.3.0)
+    pg (1.1.2)
+    pry (0.11.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    pry-byebug (3.6.0)
+      byebug (~> 10.0)
+      pry (~> 0.10)
+    public_suffix (3.0.3)
+    puma (3.12.0)
+    pygments.rb (1.2.1)
+      multi_json (>= 1.0.0)
+    rack (2.0.5)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (5.2.1)
+      actioncable (= 5.2.1)
+      actionmailer (= 5.2.1)
+      actionpack (= 5.2.1)
+      actionview (= 5.2.1)
+      activejob (= 5.2.1)
+      activemodel (= 5.2.1)
+      activerecord (= 5.2.1)
+      activestorage (= 5.2.1)
+      activesupport (= 5.2.1)
+      bundler (>= 1.3.0)
+      railties (= 5.2.1)
+      sprockets-rails (>= 2.0.0)
+    rails-controller-testing (1.0.2)
+      actionpack (~> 5.x, >= 5.0.1)
+      actionview (~> 5.x, >= 5.0.1)
+      activesupport (~> 5.x)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.0.4)
+      loofah (~> 2.2, >= 2.2.2)
+    railties (5.2.1)
+      actionpack (= 5.2.1)
+      activesupport (= 5.2.1)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.19.0, < 2.0)
+    rake (12.3.0)
+    rb-fsevent (0.10.3)
+    rb-inotify (0.9.10)
+      ffi (>= 0.5.0, < 2)
+    redcarpet (3.4.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-rails (3.8.0)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      railties (>= 3.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.0)
+    ruby-progressbar (1.10.0)
+    ruby_dep (1.5.0)
+    rubyzip (1.2.2)
+    sass (3.5.7)
+      sass-listen (~> 4.0.0)
+    sass-listen (4.0.0)
+      rb-fsevent (~> 0.9, >= 0.9.4)
+      rb-inotify (~> 0.9, >= 0.9.7)
+    sass-rails (5.0.7)
+      railties (>= 4.0.0, < 6)
+      sass (~> 3.1)
+      sprockets (>= 2.8, < 4.0)
+      sprockets-rails (>= 2.0, < 4.0)
+      tilt (>= 1.1, < 3)
+    selenium-webdriver (3.14.0)
+      childprocess (~> 0.5)
+      rubyzip (~> 1.2)
+    shoulda-context (1.2.2)
+    spring (2.0.2)
+      activesupport (>= 4.2)
+    spring-commands-rspec (1.0.4)
+      spring (>= 0.9.1)
+    spring-watcher-listen (2.0.1)
+      listen (>= 2.7, < 4.0)
+      spring (>= 1.2, < 3.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.3.13)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tilt (2.0.8)
+    turbolinks (5.2.0)
+      turbolinks-source (~> 5.2)
+    turbolinks-source (5.2.0)
+    tzinfo (1.2.5)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.0)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.3)
+    xpath (3.1.0)
+      nokogiri (~> 1.8)
+    yard (0.9.16)
+    zeus (0.15.14)
+      method_source (>= 0.6.7)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord-jdbc-adapter
+  activerecord-jdbcsqlite3-adapter
+  appraisal (= 2.2.0)
+  bcrypt (~> 3.1.7)
+  bootsnap (>= 1.1.0)
+  bundler (~> 1.1)
+  capybara (~> 3.1.1)
+  chromedriver-helper
+  fssm
+  jbuilder (~> 2.5)
+  jdbc-sqlite3
+  jruby-openssl
+  listen (>= 3.0.5, < 3.2)
+  minitest-reporters
+  pg
+  pry
+  pry-byebug
+  puma (~> 3.11)
+  pygments.rb
+  rails (~> 5.2.1)
+  rails-controller-testing (>= 1.0.1)
+  rake (= 12.3.0)
+  redcarpet
+  rspec (~> 3.6)
+  rspec-rails (~> 3.6)
+  sass-rails (~> 5.0)
+  selenium-webdriver
+  shoulda-context (~> 1.2.0)
+  spring
+  spring-commands-rspec
+  spring-watcher-listen (~> 2.0.0)
+  sqlite3
+  therubyrhino
+  turbolinks (~> 5)
+  yard
+  zeus
+
+BUNDLED WITH
+   1.16.1

data/lib/shoulda/matchers/action_controller/callback_matcher.rb

@@ -20,10 +20,14 @@ module Shoulda
       #       should_not use_before_filter(:prevent_ssl)
       #     end
       #
+      # @note This method is only available when using shoulda-matchers under
+      # Rails 4.x.
       # @return [CallbackMatcher]
       #
-      def use_before_filter(callback)
-        CallbackMatcher.new(callback, :before, :filter)
+      if RailsShim.action_pack_lt_5?
+        def use_before_filter(callback)
+          CallbackMatcher.new(callback, :before, :filter)
+        end
       end
 
       # The `use_after_filter` matcher is used to test that an after_filter
@@ -45,10 +49,14 @@ module Shoulda
       #       should_not use_after_filter(:destroy_user)
       #     end
       #
+      # @note This method is only available when using shoulda-matchers under
+      # Rails 4.x.
       # @return [CallbackMatcher]
       #
-      def use_after_filter(callback)
-        CallbackMatcher.new(callback, :after, :filter)
+      if RailsShim.action_pack_lt_5?
+        def use_after_filter(callback)
+          CallbackMatcher.new(callback, :after, :filter)
+        end
       end
 
       # The `use_before_action` matcher is used to test that a before_action
@@ -120,10 +128,14 @@ module Shoulda
       #       should_not use_around_filter(:save_view_context)
       #     end
       #
+      # @note This method is only available when using shoulda-matchers under
+      # Rails 4.x.
       # @return [CallbackMatcher]
       #
-      def use_around_filter(callback)
-        CallbackMatcher.new(callback, :around, :filter)
+      if RailsShim.action_pack_lt_5?
+        def use_around_filter(callback)
+          CallbackMatcher.new(callback, :around, :filter)
+        end
       end
 
       # The `use_around_action` matcher is used to test that an around_action

data/lib/shoulda/matchers/action_controller/permit_matcher.rb

@@ -250,7 +250,12 @@ module Shoulda
           parameters_double_registry.register
 
           Doublespeak.with_doubles_activated do
-            context.__send__(verb, action, request_params)
+            Shoulda::Matchers::RailsShim.make_controller_request(
+              context,
+              verb,
+              action,
+              request_params,
+            )
           end
 
           unpermitted_parameter_names.empty?

data/lib/shoulda/matchers/action_controller/redirect_to_matcher.rb

@@ -28,7 +28,7 @@ module Shoulda
       #       context 'GET #show' do
       #         setup { get :show }
       #
-      #         should redirect_to { posts_path }
+      #         should redirect_to('/posts') { posts_path }
       #         should redirect_to(action: :index)
       #       end
       #     end

data/lib/shoulda/matchers/action_controller/route_matcher.rb

@@ -12,8 +12,8 @@ module Shoulda
       # routing test case. For instance, given these routes:
       #
       #     My::Application.routes.draw do
-      #       get '/posts', controller: 'posts', action: 'index'
-      #       get '/posts/:id' => 'posts#show'
+      #       get '/posts', to: 'posts#index'
+      #       get '/posts/:id', to: 'posts#show'
       #     end
       #
       # You could choose to write tests for these routes alongside other tests
@@ -64,6 +64,42 @@ module Shoulda
       # this controller. In the latter case we specify this using the
       # `controller` key passed to the `to` qualifier.
       #
+      # #### Specifying a port
+      #
+      # If the route you're testing has a constraint on it that limits the route
+      # to a particular port, you can specify it by passing a `port` option to
+      # the matcher:
+      #
+      #     class PortConstraint
+      #       def initialize(port)
+      #         @port = port
+      #       end
+      #
+      #       def matches?(request)
+      #         request.port == @port
+      #       end
+      #     end
+      #
+      #     My::Application.routes.draw do
+      #       get '/posts',
+      #         to: 'posts#index',
+      #         constraints: PortConstraint.new(12345)
+      #     end
+      #
+      #     # RSpec
+      #     describe 'Routing', type: :routing do
+      #       it do
+      #         should route(:get, '/posts', port: 12345).
+      #           to('posts#index')
+      #       end
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class RoutesTest < ActionController::IntegrationTest
+      #       should route(:get, '/posts', port: 12345).
+      #         to('posts#index')
+      #     end
+      #
       # #### Qualifiers
       #
       # ##### to
@@ -71,7 +107,9 @@ module Shoulda
       # Use `to` to specify the action (along with the controller, if needed)
       # that the route resolves to.
       #
-      #     # Three ways of saying the same thing (using the example above)
+      # `to` takes either keyword arguments (`controller` and `action`) or a
+      # string that represents the controller/action pair:
+      #
       #     route(:get, '/posts').to(action: index)
       #     route(:get, '/posts').to(controller: :posts, action: index)
       #     route(:get, '/posts').to('posts#index')
@@ -86,19 +124,20 @@ module Shoulda
       #
       # @return [RouteMatcher]
       #
-      def route(method, path)
-        RouteMatcher.new(method, path, self)
+      def route(method, path, port: nil)
+        RouteMatcher.new(self, method, path, port: port)
       end
 
       # @private
       class RouteMatcher
-        def initialize(method, path, context)
-          @method  = method
-          @path    = path
+        def initialize(context, method, path, port: nil)
           @context = context
+          @method = method
+          @path = add_port_to_path(normalize_path(path), port)
+          @params = {}
         end
 
-        attr_reader :failure_message, :failure_message_when_negated
+        attr_reader :failure_message
 
         def to(*args)
           @params = RouteParams.new(args).normalize
@@ -111,36 +150,57 @@ module Shoulda
         end
 
         def matches?(controller)
-          guess_controller!(controller)
+          guess_controller_if_necessary(controller)
+
           route_recognized?
         end
 
         def description
-          "route #{@method.to_s.upcase} #{@path} to/from #{@params.inspect}"
+          "route #{method.to_s.upcase} #{path} to/from #{params.inspect}"
+        end
+
+        def failure_message_when_negated
+          "Didn't expect to #{description}"
         end
 
         private
 
-        def guess_controller!(controller)
-          @params[:controller] ||= controller.controller_path
+        attr_reader :context, :method, :path, :params
+
+        def normalize_path(path)
+          if path.start_with?('/')
+            path
+          else
+            "/#{path}"
+          end
         end
 
+        def add_port_to_path(path, port)
+          if port
+            "http://example.com:#{port}" + path
+          else
+            path
+          end
+        end
 
-        def route_recognized?
-          begin
-            @context.__send__(:assert_routing,
-                          { method: @method, path: @path },
-                          @params)
 
-            @failure_message_when_negated = "Didn't expect to #{description}"
-            true
-          rescue ::ActionController::RoutingError => error
-            @failure_message = error.message
-            false
-          rescue Shoulda::Matchers.assertion_exception_class => error
-            @failure_message = error.message
-            false
-          end
+        def guess_controller_if_necessary(controller)
+          params[:controller] ||= controller.controller_path
+        end
+
+        def route_recognized?
+          context.send(
+            :assert_routing,
+            { method: method, path: path },
+            params,
+          )
+          true
+        rescue ::ActionController::RoutingError => error
+          @failure_message = error.message
+          false
+        rescue Shoulda::Matchers.assertion_exception_class => error
+          @failure_message = error.message
+          false
         end
       end
     end