shoulda-matchers 3.1.0 → 5.2.0

data/lib/shoulda/matchers/active_record/association_matcher.rb

@@ -11,7 +11,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:organization) }
       #     end
       #
@@ -28,7 +28,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Comment do
+      #     RSpec.describe Comment, type: :model do
       #       it { should belong_to(:commentable) }
       #     end
       #
@@ -49,7 +49,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should belong_to(:family).
       #           conditions(everyone_is_perfect: false)
@@ -72,7 +72,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:previous_company).order('hired_on desc') }
       #     end
       #
@@ -91,7 +91,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:ancient_city).class_name('City') }
       #     end
       #
@@ -109,7 +109,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should belong_to(:great_country).
       #           with_primary_key('country_id')
@@ -131,7 +131,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should belong_to(:great_country).
       #           with_foreign_key('country_id')
@@ -153,7 +153,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:world).dependent(:destroy) }
       #     end
       #
@@ -165,7 +165,7 @@ module Shoulda
       # To assert that *any* `:dependent` option was specified, use `true`:
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:world).dependent(true) }
       #     end
       #
@@ -176,7 +176,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:company).dependent(false) }
       #     end
       #
@@ -190,7 +190,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:organization).counter_cache(true) }
       #     end
       #
@@ -208,7 +208,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should belong_to(:organization).touch(true) }
       #     end
       #
@@ -217,7 +217,7 @@ module Shoulda
       #       should belong_to(:organization).touch(true)
       #     end
       #
-      # #### autosave
+      # ##### autosave
       #
       # Use `autosave` to assert that the `:autosave` option was specified.
       #
@@ -226,7 +226,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Account do
+      #     RSpec.describe Account, type: :model do
       #       it { should belong_to(:bank).autosave(true) }
       #     end
       #
@@ -253,6 +253,73 @@ module Shoulda
       #       should belong_to(:organization).inverse_of(:employees)
       #     end
       #
+      # ##### required
+      #
+      # Use `required` to assert that the association is not allowed to be nil.
+      # (Enabled by default in Rails 5+.)
+      #
+      #     class Person < ActiveRecord::Base
+      #       belongs_to :organization, required: true
+      #     end
+      #
+      #     # RSpec
+      #     describe Person
+      #       it { should belong_to(:organization).required }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class PersonTest < ActiveSupport::TestCase
+      #       should belong_to(:organization).required
+      #     end
+      #
+      # ##### without_validating_presence
+      #
+      # Use `without_validating_presence` with `belong_to` to prevent the
+      # matcher from checking whether the association disallows nil (Rails 5+
+      # only). This can be helpful if you have a custom hook that always sets
+      # the association to a meaningful value:
+      #
+      #     class Person < ActiveRecord::Base
+      #       belongs_to :organization
+      #
+      #       before_validation :autoassign_organization
+      #
+      #       private
+      #
+      #       def autoassign_organization
+      #         self.organization = Organization.create!
+      #       end
+      #     end
+      #
+      #     # RSpec
+      #     describe Person
+      #       it { should belong_to(:organization).without_validating_presence }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class PersonTest < ActiveSupport::TestCase
+      #       should belong_to(:organization).without_validating_presence
+      #     end
+      #
+      # ##### optional
+      #
+      # Use `optional` to assert that the association is allowed to be nil.
+      # (Rails 5+ only.)
+      #
+      #     class Person < ActiveRecord::Base
+      #       belongs_to :organization, optional: true
+      #     end
+      #
+      #     # RSpec
+      #     describe Person
+      #       it { should belong_to(:organization).optional }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class PersonTest < ActiveSupport::TestCase
+      #       should belong_to(:organization).optional
+      #     end
+      #
       # @return [AssociationMatcher]
       #
       def belong_to(name)
@@ -267,7 +334,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:friends) }
       #     end
       #
@@ -284,7 +351,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:pictures) }
       #     end
       #
@@ -305,7 +372,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:coins).conditions(quality: 'mint') }
       #     end
       #
@@ -324,7 +391,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:shirts).order('color') }
       #     end
       #
@@ -343,7 +410,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:hopes).class_name('Dream') }
       #     end
       #
@@ -361,7 +428,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:worries).with_primary_key('worrier_id') }
       #     end
       #
@@ -379,7 +446,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:worries).with_foreign_key('worrier_id') }
       #     end
       #
@@ -397,7 +464,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:secret_documents).dependent(:destroy) }
       #     end
       #
@@ -416,7 +483,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:acquaintances).through(:friends) }
       #     end
       #
@@ -435,7 +502,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_many(:job_offers).
       #           through(:friends).
@@ -459,7 +526,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_many(:ideas).validate(false) }
       #     end
       #
@@ -468,7 +535,7 @@ module Shoulda
       #       should have_many(:ideas).validate(false)
       #     end
       #
-      # #### autosave
+      # ##### autosave
       #
       # Use `autosave` to assert that the `:autosave` option was specified.
       #
@@ -477,7 +544,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Player do
+      #     RSpec.describe Player, type: :model do
       #       it { should have_many(:games).autosave(true) }
       #     end
       #
@@ -486,6 +553,43 @@ module Shoulda
       #       should have_many(:games).autosave(true)
       #     end
       #
+      # ##### index_errors
+      #
+      # Use `index_errors` to assert that the `:index_errors` option was
+      # specified.
+      #
+      #     class Player < ActiveRecord::Base
+      #       has_many :games, index_errors: true
+      #     end
+      #
+      #     # RSpec
+      #     RSpec.describe Player, type: :model do
+      #       it { should have_many(:games).index_errors(true) }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class PlayerTest < ActiveSupport::TestCase
+      #       should have_many(:games).index_errors(true)
+      #     end
+      #
+      # ##### inverse_of
+      #
+      # Use `inverse_of` to assert that the `:inverse_of` option was specified.
+      #
+      #     class Organization < ActiveRecord::Base
+      #       has_many :employees, inverse_of: :company
+      #     end
+      #
+      #     # RSpec
+      #     describe Organization
+      #       it { should have_many(:employees).inverse_of(:company) }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class OrganizationTest < ActiveSupport::TestCase
+      #       should have_many(:employees).inverse_of(:company)
+      #     end
+      #
       # @return [AssociationMatcher]
       #
       def have_many(name)
@@ -500,7 +604,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:partner) }
       #     end
       #
@@ -521,7 +625,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:pet).conditions('weight < 80') }
       #     end
       #
@@ -540,7 +644,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:focus).order('priority desc') }
       #     end
       #
@@ -559,7 +663,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:chance).class_name('Opportunity') }
       #     end
       #
@@ -577,7 +681,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:contract).dependent(:nullify) }
       #     end
       #
@@ -595,7 +699,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:job).with_primary_key('worker_id') }
       #     end
       #
@@ -613,7 +717,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:job).with_foreign_key('worker_id') }
       #     end
       #
@@ -632,7 +736,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:life).through(:partner) }
       #     end
       #
@@ -651,7 +755,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:car).through(:partner).source(:vehicle) }
       #     end
       #
@@ -669,7 +773,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_one(:parking_card).validate(false) }
       #     end
       #
@@ -678,7 +782,7 @@ module Shoulda
       #       should have_one(:parking_card).validate(false)
       #     end
       #
-      # #### autosave
+      # ##### autosave
       #
       # Use `autosave` to assert that the `:autosave` option was specified.
       #
@@ -687,7 +791,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Account do
+      #     RSpec.describe Account, type: :model do
       #       it { should have_one(:bank).autosave(true) }
       #     end
       #
@@ -696,6 +800,25 @@ module Shoulda
       #       should have_one(:bank).autosave(true)
       #     end
       #
+      # ##### required
+      #
+      # Use `required` to assert that the association is not allowed to be nil.
+      # (Rails 5+ only.)
+      #
+      #     class Person < ActiveRecord::Base
+      #       has_one :brain, required: true
+      #     end
+      #
+      #     # RSpec
+      #     describe Person
+      #       it { should have_one(:brain).required }
+      #     end
+      #
+      #     # Minitest (Shoulda)
+      #     class PersonTest < ActiveSupport::TestCase
+      #       should have_one(:brain).required
+      #     end
+      #
       # @return [AssociationMatcher]
       #
       def have_one(name)
@@ -711,7 +834,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it { should have_and_belong_to_many(:awards) }
       #     end
       #
@@ -732,7 +855,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_and_belong_to_many(:issues).
       #           conditions(difficulty: 'hard')
@@ -755,7 +878,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_and_belong_to_many(:projects).
       #           order('time_spent')
@@ -778,7 +901,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_and_belong_to_many(:places_visited).
       #           class_name('City')
@@ -797,21 +920,21 @@ module Shoulda
       # asserts that the table you're referring to actually exists.
       #
       #     class Person < ActiveRecord::Base
-      #       has_and_belongs_to_many :issues, join_table: 'people_tickets'
+      #       has_and_belongs_to_many :issues, join_table: :people_tickets
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_and_belong_to_many(:issues).
-      #           join_table('people_tickets')
+      #           join_table(:people_tickets)
       #       end
       #     end
       #
       #     # Minitest (Shoulda)
       #     class PersonTest < ActiveSupport::TestCase
       #       should have_and_belong_to_many(:issues).
-      #         join_table('people_tickets')
+      #         join_table(:people_tickets)
       #     end
       #
       # ##### validate
@@ -823,7 +946,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Person do
+      #     RSpec.describe Person, type: :model do
       #       it do
       #         should have_and_belong_to_many(:interviews).
       #           validate(false)
@@ -836,7 +959,7 @@ module Shoulda
       #         validate(false)
       #     end
       #
-      # #### autosave
+      # ##### autosave
       #
       # Use `autosave` to assert that the `:autosave` option was specified.
       #
@@ -845,7 +968,7 @@ module Shoulda
       #     end
       #
       #     # RSpec
-      #     describe Publisher do
+      #     RSpec.describe Publisher, type: :model do
       #       it { should have_and_belong_to_many(:advertisers).autosave(true) }
       #     end
       #
@@ -862,6 +985,13 @@ module Shoulda
 
       # @private
       class AssociationMatcher
+        MACROS = {
+          'belongs_to' => 'belong to',
+          'has_many' => 'have many',
+          'has_one' => 'have one',
+          'has_and_belongs_to_many' => 'have and belong to many',
+        }.freeze
+
         delegate :reflection, :model_class, :associated_class, :through?,
           :polymorphic?, to: :reflector
 
@@ -873,42 +1003,63 @@ module Shoulda
           @options = {}
           @submatchers = []
           @missing = ''
+
+          if macro == :belongs_to
+            required(belongs_to_required_by_default?)
+          end
         end
 
         def through(through)
-          through_matcher = AssociationMatchers::ThroughMatcher.new(through, name)
-          add_submatcher(through_matcher)
+          add_submatcher(
+            AssociationMatchers::ThroughMatcher,
+            through,
+            name,
+          )
           self
         end
 
         def dependent(dependent)
-          dependent_matcher = AssociationMatchers::DependentMatcher.new(dependent, name)
-          add_submatcher(dependent_matcher)
+          add_submatcher(
+            AssociationMatchers::DependentMatcher,
+            dependent,
+            name,
+          )
           self
         end
 
         def order(order)
-          order_matcher = AssociationMatchers::OrderMatcher.new(order, name)
-          add_submatcher(order_matcher)
+          add_submatcher(
+            AssociationMatchers::OrderMatcher,
+            order,
+            name,
+          )
           self
         end
 
         def counter_cache(counter_cache = true)
-          counter_cache_matcher = AssociationMatchers::CounterCacheMatcher.new(counter_cache, name)
-          add_submatcher(counter_cache_matcher)
+          add_submatcher(
+            AssociationMatchers::CounterCacheMatcher,
+            counter_cache,
+            name,
+          )
           self
         end
 
         def inverse_of(inverse_of)
-          inverse_of_matcher =
-            AssociationMatchers::InverseOfMatcher.new(inverse_of, name)
-          add_submatcher(inverse_of_matcher)
+          add_submatcher(
+            AssociationMatchers::InverseOfMatcher,
+            inverse_of,
+            name,
+          )
           self
         end
 
         def source(source)
-          source_matcher = AssociationMatchers::SourceMatcher.new(source, name)
-          add_submatcher(source_matcher)
+          add_submatcher(
+            AssociationMatchers::SourceMatcher,
+            source,
+            name,
+          )
           self
         end
 
@@ -922,6 +1073,11 @@ module Shoulda
           self
         end
 
+        def index_errors(index_errors)
+          @options[:index_errors] = index_errors
+          self
+        end
+
         def class_name(class_name)
           @options[:class_name] = class_name
           self
@@ -937,6 +1093,26 @@ module Shoulda
           self
         end
 
+        def required(required = true)
+          remove_submatcher(AssociationMatchers::OptionalMatcher)
+          add_submatcher(
+            AssociationMatchers::RequiredMatcher,
+            name,
+            required,
+          )
+          self
+        end
+
+        def optional(optional = true)
+          remove_submatcher(AssociationMatchers::RequiredMatcher)
+          add_submatcher(
+            AssociationMatchers::OptionalMatcher,
+            name,
+            optional,
+          )
+          self
+        end
+
         def validate(validate = true)
           @options[:validate] = validate
           self
@@ -952,9 +1128,16 @@ module Shoulda
           self
         end
 
+        def without_validating_presence
+          remove_submatcher(AssociationMatchers::RequiredMatcher)
+          self
+        end
+
         def description
           description = "#{macro_description} #{name}"
-          description += " class_name => #{options[:class_name]}" if options.key?(:class_name)
+          if options.key?(:class_name)
+            description += " class_name => #{options[:class_name]}"
+          end
           [description, submatchers.map(&:description)].flatten.join(' ')
         end
 
@@ -970,12 +1153,14 @@ module Shoulda
           @subject = subject
           association_exists? &&
             macro_correct? &&
+            validate_inverse_of_through_association &&
             (polymorphic? || class_exists?) &&
             foreign_key_exists? &&
             primary_key_exists? &&
             class_name_correct? &&
             join_table_correct? &&
             autosave_correct? &&
+            index_errors_correct? &&
             conditions_correct? &&
             validate_correct? &&
             touch_correct? &&
@@ -987,7 +1172,8 @@ module Shoulda
         end
 
         def option_verifier
-          @option_verifier ||= AssociationMatchers::OptionVerifier.new(reflector)
+          @_option_verifier ||=
+            AssociationMatchers::OptionVerifier.new(reflector)
         end
 
         protected
@@ -995,44 +1181,49 @@ module Shoulda
         attr_reader :submatchers, :missing, :subject, :macro
 
         def reflector
-          @reflector ||= AssociationMatchers::ModelReflector.new(subject, name)
+          @_reflector ||= AssociationMatchers::ModelReflector.new(subject, name)
         end
 
-        def add_submatcher(matcher)
-          @submatchers << matcher
+        def add_submatcher(matcher_class, *args)
+          remove_submatcher(matcher_class)
+          submatchers << matcher_class.new(*args)
         end
 
-        def macro_description
-          case macro.to_s
-          when 'belongs_to'
-            'belong to'
-          when 'has_many'
-            'have many'
-          when 'has_one'
-            'have one'
-          when 'has_and_belongs_to_many'
-            'have and belong to many'
+        def remove_submatcher(matcher_class)
+          submatchers.delete_if do |submatcher|
+            submatcher.is_a?(matcher_class)
           end
         end
 
+        def macro_description
+          MACROS[macro.to_s]
+        end
+
         def expectation
-          "#{model_class.name} to have a #{macro} association called #{name}"
+          expectation =
+            "#{model_class.name} to have a #{macro} association called #{name}"
+
+          if through?
+            expectation << " through #{reflector.has_and_belongs_to_many_name}"
+          end
+
+          expectation
         end
 
         def missing_options
           missing_options = [missing, missing_options_for_failing_submatchers]
-          missing_options.flatten.compact.join(', ')
+          missing_options.flatten.select(&:present?).join(', ')
         end
 
         def failing_submatchers
-          @failing_submatchers ||= submatchers.reject do |matcher|
+          @_failing_submatchers ||= submatchers.reject do |matcher|
             matcher.matches?(subject)
           end
         end
 
         def missing_options_for_failing_submatchers
-          if defined?(@failing_submatchers)
-            @failing_submatchers.map(&:missing_option)
+          if defined?(@_failing_submatchers)
+            @_failing_submatchers.map(&:missing_option)
           else
             []
           end
@@ -1059,6 +1250,14 @@ module Shoulda
           end
         end
 
+        def validate_inverse_of_through_association
+          reflector.validate_inverse_of_through_association!
+          true
+        rescue ::ActiveRecord::ActiveRecordError => e
+          @missing = e.message
+          false
+        end
+
         def macro_supports_primary_key?
           macro == :belongs_to ||
             ([:has_many, :has_one].include?(macro) && !through?)
@@ -1084,10 +1283,14 @@ module Shoulda
 
         def class_name_correct?
           if options.key?(:class_name)
-            if option_verifier.correct_for_constant?(:class_name, options[:class_name])
+            if option_verifier.correct_for_constant?(
+              :class_name,
+              options[:class_name],
+            )
               true
             else
-              @missing = "#{name} should resolve to #{options[:class_name]} for class_name"
+              @missing = "#{name} should resolve to #{options[:class_name]}"\
+                ' for class_name'
               false
             end
           else
@@ -1096,7 +1299,10 @@ module Shoulda
         end
 
         def join_table_correct?
-          if macro != :has_and_belongs_to_many || join_table_matcher.matches?(@subject)
+          if (
+            macro != :has_and_belongs_to_many ||
+            join_table_matcher.matches?(@subject)
+          )
             true
           else
             @missing = join_table_matcher.failure_message
@@ -1105,8 +1311,10 @@ module Shoulda
         end
 
         def join_table_matcher
-          @join_table_matcher ||=
-            AssociationMatchers::JoinTableMatcher.new(self, reflector)
+          @_join_table_matcher ||= AssociationMatchers::JoinTableMatcher.new(
+            self,
+            reflector,
+          )
         end
 
         def class_exists?
@@ -1119,10 +1327,14 @@ module Shoulda
 
         def autosave_correct?
           if options.key?(:autosave)
-            if option_verifier.correct_for_boolean?(:autosave, options[:autosave])
+            if option_verifier.correct_for_boolean?(
+              :autosave,
+              options[:autosave],
+            )
               true
             else
-              @missing = "#{name} should have autosave set to #{options[:autosave]}"
+              @missing = "#{name} should have autosave set to"\
+                " #{options[:autosave]}"
               false
             end
           else
@@ -1130,12 +1342,32 @@ module Shoulda
           end
         end
 
+        def index_errors_correct?
+          return true unless options.key?(:index_errors)
+
+          if option_verifier.correct_for_boolean?(
+            :index_errors,
+            options[:index_errors],
+          )
+            true
+          else
+            @missing =
+              "#{name} should have index_errors set to " +
+              options[:index_errors].to_s
+            false
+          end
+        end
+
         def conditions_correct?
           if options.key?(:conditions)
-            if option_verifier.correct_for_relation_clause?(:conditions, options[:conditions])
+            if option_verifier.correct_for_relation_clause?(
+              :conditions,
+              options[:conditions],
+            )
               true
             else
-              @missing = "#{name} should have the following conditions: #{options[:conditions]}"
+              @missing = "#{name} should have the following conditions:" +
+                         " #{options[:conditions]}"
               false
             end
           else
@@ -1162,24 +1394,49 @@ module Shoulda
         end
 
         def class_has_foreign_key?(klass)
-          if options.key?(:foreign_key)
-            option_verifier.correct_for_string?(:foreign_key, options[:foreign_key])
+          @missing = validate_foreign_key(klass)
+
+          @missing.nil?
+        end
+
+        def validate_foreign_key(klass)
+          if options.key?(:foreign_key) && !foreign_key_correct?
+            foreign_key_failure_message(klass, options[:foreign_key])
+          elsif !has_column?(klass, actual_foreign_key)
+            foreign_key_failure_message(klass, actual_foreign_key)
+          end
+        end
+
+        def has_column?(klass, column)
+          case column
+          when Array
+            column.all? { |c| has_column?(klass, c.to_s) }
           else
-            if klass.column_names.include?(foreign_key)
-              true
-            else
-              @missing = "#{klass} does not have a #{foreign_key} foreign key."
-              false
-            end
+            column_names_for(klass).include?(column.to_s)
           end
         end
 
+        def foreign_key_correct?
+          option_verifier.correct_for_string?(
+            :foreign_key,
+            options[:foreign_key],
+          )
+        end
+
+        def foreign_key_failure_message(klass, foreign_key)
+          "#{klass} does not have a #{foreign_key} foreign key."
+        end
+
         def primary_key_correct?(klass)
           if options.key?(:primary_key)
-            if option_verifier.correct_for_string?(:primary_key, options[:primary_key])
+            if option_verifier.correct_for_string?(
+              :primary_key,
+              options[:primary_key],
+            )
               true
             else
-              @missing = "#{klass} does not have a #{options[:primary_key]} primary key"
+              @missing = "#{klass} does not have a #{options[:primary_key]}"\
+                ' primary key'
               false
             end
           else
@@ -1187,19 +1444,27 @@ module Shoulda
           end
         end
 
-        def foreign_key
-          if foreign_key_reflection
-            if foreign_key_reflection.respond_to?(:foreign_key)
-              foreign_key_reflection.foreign_key.to_s
-            else
-              foreign_key_reflection.primary_key_name.to_s
-            end
+        def actual_foreign_key
+          return unless foreign_key_reflection
+
+          if foreign_key_reflection.options[:foreign_key]
+            foreign_key_reflection.options[:foreign_key]
+          elsif foreign_key_reflection.respond_to?(:foreign_key)
+            foreign_key_reflection.foreign_key
+          else
+            foreign_key_reflection.primary_key_name
           end
         end
 
         def foreign_key_reflection
-          if [:has_one, :has_many].include?(macro) && reflection.options.include?(:inverse_of)
-            associated_class.reflect_on_association(reflection.options[:inverse_of])
+          if (
+            [:has_one, :has_many].include?(macro) &&
+            reflection.options.include?(:inverse_of) &&
+            reflection.options[:inverse_of] != false
+          )
+            associated_class.reflect_on_association(
+              reflection.options[:inverse_of],
+            )
           else
             reflection
           end
@@ -1208,6 +1473,16 @@ module Shoulda
         def submatchers_match?
           failing_submatchers.empty?
         end
+
+        def column_names_for(klass)
+          klass.column_names
+        rescue ::ActiveRecord::StatementInvalid
+          []
+        end
+
+        def belongs_to_required_by_default?
+          ::ActiveRecord::Base.belongs_to_required_by_default
+        end
       end
     end
   end