shoulda-matchers 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d2511e64aa43fb787466f5a74f3988cbd42b3ff
-  data.tar.gz: d8ca90b46025cb37d4acd8111b1686902837257e
+  metadata.gz: 2fe80273c48fdbadb3d479406470fa875abfcf61
+  data.tar.gz: 3cac554e34d73023e1e3cd5a65bc23291159ff87
 SHA512:
-  metadata.gz: 57e1a16493c88afaedc21664cd8725e140b4c5528941de796543a53086644d60c43aa980229bdbed70bd4340e415bf9e66c9825ac3bffdd74d2d8c281933363e
-  data.tar.gz: 7e8e7a91c8073833e9f1ee756201eebea1e67037c141d2d4602be1656407e192fea3c254177f8c05072625235c24d8d9f171d14bd1d4a5b9e7b6d086634e023e
+  metadata.gz: df7679b9a7384f93e221a7a9a07411bd6e6f93cd3dc267e262e803b3c7359b3272b4adb037039e09662bf7bb6e9b31d094748109dec3e9050967df8d3691f8f8
+  data.tar.gz: f5c6cea2751c9cf331b96447af1d8f70c6ecd1edae2aac4c587361e438a14caa8cd8da563873135b0421450f28663e1c1b7c4f542182b9a5311cee1480d29520

data/.yardopts

@@ -1,8 +1,10 @@
 --no-private
 --protected
 --readme README.md
---files NEWS.md
 --markup markdown
 --hide-tag return
 --hide-tag param
 -e ./doc_config/yard/setup.rb
+-
+NEWS.md
+docs/**/*.md

data/Gemfile

@@ -5,8 +5,7 @@ gem 'bundler', '~> 1.1'
 gem 'pry', github: 'pry/pry'
 gem 'pry-byebug'
 gem 'rake', '~> 10.0'
-gem 'rspec-core', '>= 3.2.0', '< 4'
-gem 'rspec-expectations', '>= 3.2.0', '< 4'
+gem 'rspec', '~> 3.2'
 
 # YARD
 gem 'yard'

data/Gemfile.lock

@@ -30,11 +30,18 @@ GEM
       yajl-ruby (~> 1.1.0)
     rake (10.4.2)
     redcarpet (3.0.0)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
     rspec-core (3.3.2)
       rspec-support (~> 3.3.0)
     rspec-expectations (3.3.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
+    rspec-mocks (3.3.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
     slop (3.6.0)
     thor (0.19.1)
@@ -53,8 +60,7 @@ DEPENDENCIES
   pygments.rb
   rake (~> 10.0)
   redcarpet
-  rspec-core (>= 3.2.0, < 4)
-  rspec-expectations (>= 3.2.0, < 4)
+  rspec (~> 3.2)
   yard
 
 BUNDLED WITH

data/NEWS.md

@@ -1,3 +1,29 @@
+# 3.0.1
+
+### Bug fixes
+
+* Fix `validate_inclusion_of` + `in_array` when used against a date or datetime
+  column/attribute so that it does not raise a CouldNotSetAttributeError.
+  ([#783], [8fa97b4])
+
+* Fix `validate_numericality_of` when used against a numeric column so that it
+  no longer raises a CouldNotSetAttributeError if the matcher has been qualified
+  in any way (`only_integer`, `greater_than`, `odd`, etc.). ([#784], [#812])
+
+### Improvements
+
+* `validate_uniqueness_of` now raises a NonCaseSwappableValueError if the value
+  the matcher is using to test uniqueness cannot be case-swapped -- in other
+  words, if it doesn't contain any alpha characters. When this is the case, the
+  matcher cannot work effectively. ([#789], [ada9bd3])
+
+[#783]: https://github.com/thoughtbot/shoulda-matchers/pull/783
+[8fa97b4]: https://github.com/thoughtbot/shoulda-matchers/commit/8fa97b4ff33b57ce16dfb96be1ec892502f2aa9e
+[#784]: https://github.com/thoughtbot/shoulda-matchers/pull/784
+[#789]: https://github.com/thoughtbot/shoulda-matchers/pull/789
+[ada9bd3]: https://github.com/thoughtbot/shoulda-matchers/commit/ada9bd3a1b9f2bb9fa74d0dfe1f8f7080314298c
+[#812]: https://github.com/thoughtbot/shoulda-matchers/pull/812
+
 # 3.0.0
 
 ### Backward-incompatible changes
@@ -150,7 +176,7 @@
 
     ([9d9dc4e])
 
-* `validate_uniqueness_of` is now properly case-insensitive by default, to match
+* `validate_uniqueness_of` is now properly case-sensitive by default, to match
   the default behavior of the validation itself. This is a backward-incompatible
   change because this test which incorrectly passed before will now fail:
 
@@ -215,6 +241,8 @@
 [#752]: https://github.com/thoughtbot/shoulda-matchers/pull/752
 [9d9dc4e]: https://github.com/thoughtbot/shoulda-matchers/commit/9d9dc4e6b9cf2c19df66a1b4ba432ad8d3e5dded
 [32c0e62]: https://github.com/thoughtbot/shoulda-matchers/commit/32c0e62596b87e37a301f87bbe21cfcc77750552
+[af98a23]: https://github.com/thoughtbot/shoulda-matchers/commit/af98a23091551fb40aded5a8d4f9e5be926f53a9
+[8cf449b]: https://github.com/thoughtbot/shoulda-matchers/commit/8cf449b4ca37d0d7446d2cabbfa5a1582358256d
 
 ### Bug fixes
 

data/README.md

@@ -4,10 +4,7 @@ Shoulda Matchers provides RSpec- and Minitest-compatible one-liners that test
 common Rails functionality. These tests would otherwise be much longer, more
 complex, and error-prone.
 
-[View the official documentation for the latest version (2.8.0).][rubydocs]
-
-**Heads up! This is the README for the master branch. [You might be more
-interested in the README for 2.8.0 instead.][2.8.0-README]**
+[View the official documentation for the latest version (3.0.0).][rubydocs]
 
 ----
 
@@ -108,7 +105,7 @@ Include `shoulda-matchers` in your Gemfile:
 
 ``` ruby
 group :test do
-  gem 'shoulda-matchers'
+  gem 'shoulda-matchers', '~> 3.0'
 end
 ```
 
@@ -144,7 +141,7 @@ gem in your Gemfile instead:
 
 ```ruby
 group :test do
-  gem 'shoulda'
+  gem 'shoulda', '~> 3.5'
 end
 ```
 
@@ -161,10 +158,6 @@ end
 
 ### Configuration
 
-**NOTE: The new configuration syntax isn't available in a public release just
-yet -- please refer to the [README for 2.8.0][2.8.0-README] for the current
-installation instructions.**
-
 Before you can use Shoulda Matchers, you'll need to tell it a couple of things:
 
 * Which test framework you're using
@@ -255,4 +248,3 @@ We are [available for hire][hire].
 [contributors]: https://github.com/thoughtbot/shoulda-matchers/contributors
 [shoulda]: http://github.com/thoughtbot/shoulda
 [shoulda-context]: http://github.com/thoughtbot/shoulda-context
-[2.8.0-README]: https://github.com/thoughtbot/shoulda-matchers/tree/v2.8.0#shoulda-matchers---

data/doc_config/yard/templates/default/fulldoc/html/css/global.css

@@ -43,3 +43,20 @@ ul, ol {
   margin-left: 1em;
   padding-left: 1em;
 }
+
+p, blockquote {
+  margin-bottom: 1.25em;
+}
+
+blockquote {
+  font-style: italic;
+  padding-top: 0;
+  padding-bottom: 0;
+  padding-left: 1em;
+}
+
+blockquote p {
+  font-size: inherit;
+  font-weight: inherit;
+  line-height: inherit;
+}

data/doc_config/yard/templates/default/fulldoc/html/css/style.css

@@ -91,7 +91,7 @@ h4 + h5 {
 #menu, #search {
   height: 6rem;
   line-height: 6rem;
-  text-transform: uppercase;
+  font-size: 1.1em;
 }
 #main {
   top: 6rem;
@@ -99,10 +99,9 @@ h4 + h5 {
 
 #menu {
   float: left;
-  letter-spacing: 1px;
   padding-left: 2em;
   position: relative;
-  width: 30em;
+  width: 45em;
 }
 
 #menu .noframes {
@@ -111,7 +110,6 @@ h4 + h5 {
 
 #search {
   float: right;
-  font-size: 0.9em;
 }
 
   #search ul {
@@ -201,6 +199,7 @@ h4 + h5 {
   padding: 10px;
   text-align: center;
   text-shadow: 0 1px 1px rgba(0,0,0,0.4);
+  font-size: 0.9em;
 }
 
 #footer a {

data/doc_config/yard/templates/default/layout/html/breadcrumb.erb

@@ -5,7 +5,7 @@
     </span> &raquo;
   <% end %>
   <% if @contents || @file %>
-    <span class="title"><%= @breadcrumb_title %></span>
+    <span class="title"><%= @breadcrumb_title.sub(/\AFile: /, "") %></span>
   <% elsif object.is_a?(CodeObjects::Base) %>
     <%= @breadcrumb.map {|obj| "<span class='title'>" + linkify(obj, obj.name) + "</span>" }.join(" &raquo; ") %>
     <%= @breadcrumb.size > 0 ? " &raquo; " : "" %>

data/doc_config/yard/templates/default/layout/html/footer.erb

@@ -0,0 +1,6 @@
+<div id="footer">
+  Generated on
+  <%= Time.now.strftime("%B %-d, %Y") %>
+  by
+  <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">YARD</a>.
+</div>

data/docs/errors/NonCaseSwappableValueError.md

@@ -0,0 +1,111 @@
+# @title NonCaseSwappableValueError
+
+# NonCaseSwappableValueError
+
+This error is raised when using `validate_uniqueness_of`. This matcher, of
+course, tests that an attribute disallows a non-unique value -- and what
+constitutes as "unique" depends on whether the case-sensitivity of that value
+matters. If it does matter -- meaning that the uniqueness validation in your
+model isn't using `case_sensitive: false` and you haven't qualified the matcher
+with `case_insensitive` -- then the matcher will run the following test:
+
+> Creating first a record with a value of "A":
+>
+> * A new record with a value of "A" should not be valid (failing the uniqueness
+>   validation)
+> * A new record with a value of "a" should be valid
+
+The test value we're using is in this case "A", and this is what the matcher
+will use if an existing record is not already present in the database. But if
+a record already exists, then the matcher will use it as comparison -- it will
+read the attribute under test off of the record and use its value. So a better
+example might be:
+
+> Given an existing record with a value:
+>
+> * A new record with the same value should not be valid (failing the uniqueness
+>   validation)
+> * A new record with the same value, but where the case is swapped (using
+>   String#swapcase), should be valid
+
+Now, what happens if an existing record is there, but the value being used is
+not one whose case can be swapped, such as `"123"` or `"{-#%}"`? Then the second
+assertion cannot be made effectively.
+
+So this is why you're getting this exception. What can you do about it? As the
+error message explains, you have two options:
+
+1. If you want the uniqueness validation in the model to operate
+   case-sensitively and you didn't mean to use a non-case-swappable value,
+   then you need to provide an existing record with a different value, one that
+   contains alpha characters. Here's an example:
+
+        # Model
+        class User < ActiveRecord::Base
+          validates_uniqueness_of :username
+        end
+
+        # RSpec
+        describe User do
+          context "validations" do
+            subject do
+              # Note that "123" == "123".swapcase. This is a problem!
+              User.new(username: "123")
+            end
+
+            it do
+              # So you can either override it like this, or just fix the subject.
+              user = User.create!(username: "john123")
+              expect(user).to validate_uniqueness_of(:username)
+            end
+          end
+        end
+
+        # Minitest (Shoulda)
+        class UserTest < ActiveSupport::TestCase
+          context "validations" do
+            subject do
+              # Note that "123" == "123".swapcase. This is a problem!
+              User.new(username: "123")
+            end
+
+            should "validate uniqueness of :username" do
+              # So you can either override it like this, or just fix the subject.
+              user = User.create!(username: "john123")
+              assert_accepts validate_uniqueness_of(:username), record
+            end
+          end
+        end
+
+2. If you don't want the uniqueness validation to operate case-sensitively,
+   then you need to add `case_sensitive: false` to the validation and add
+   `case_insensitive` to the matcher:
+
+        # Model
+        class User < ActiveRecord::Base
+          validates_uniqueness_of :username, case_sensitive: false
+        end
+        
+        # RSpec
+        describe User do
+          context "validations" do
+            subject do
+              # Note that "123" == "123".swapcase, but it's okay
+              User.new(username: "123")
+            end
+
+            it { should validate_uniqueness_of(:username).case_insensitive }
+          end
+        end
+        
+        # Minitest (Shoulda)
+        class UserTest < ActiveSupport::TestCase
+          context "validations" do
+            subject do
+              # Note that "123" == "123".swapcase, but it's okay
+              User.new(username: "123")
+            end
+
+            should validate_uniqueness_of(:username).case_insensitive
+          end
+        end

data/gemfiles/4.0.0.gemfile

@@ -7,8 +7,7 @@ gem "bundler", "~> 1.1"
 gem "pry", :github => "pry/pry"
 gem "pry-byebug"
 gem "rake", "~> 10.0"
-gem "rspec-core", ">= 3.2.0", "< 4"
-gem "rspec-expectations", ">= 3.2.0", "< 4"
+gem "rspec", "~> 3.2"
 gem "yard"
 gem "redcarpet"
 gem "pygments.rb"

data/gemfiles/4.0.0.gemfile.lock

@@ -118,6 +118,10 @@ GEM
     rake (10.4.2)
     rdoc (4.2.0)
     redcarpet (3.3.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
     rspec-core (3.3.2)
       rspec-support (~> 3.3.0)
     rspec-expectations (3.3.1)
@@ -199,8 +203,7 @@ DEPENDENCIES
   rails (= 4.0.0)
   rake (~> 10.0)
   redcarpet
-  rspec-core (>= 3.2.0, < 4)
-  rspec-expectations (>= 3.2.0, < 4)
+  rspec (~> 3.2)
   rspec-rails (>= 3.2.0, < 4)
   sass-rails (~> 4.0.0)
   sdoc

data/gemfiles/4.0.1.gemfile

@@ -7,8 +7,7 @@ gem "bundler", "~> 1.1"
 gem "pry", :github => "pry/pry"
 gem "pry-byebug"
 gem "rake", "~> 10.0"
-gem "rspec-core", ">= 3.2.0", "< 4"
-gem "rspec-expectations", ">= 3.2.0", "< 4"
+gem "rspec", "~> 3.2"
 gem "yard"
 gem "redcarpet"
 gem "pygments.rb"

data/gemfiles/4.0.1.gemfile.lock

@@ -120,6 +120,10 @@ GEM
     rake (10.4.2)
     rdoc (4.2.0)
     redcarpet (3.3.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
     rspec-core (3.3.2)
       rspec-support (~> 3.3.0)
     rspec-expectations (3.3.1)
@@ -201,8 +205,7 @@ DEPENDENCIES
   rails (= 4.0.1)
   rake (~> 10.0)
   redcarpet
-  rspec-core (>= 3.2.0, < 4)
-  rspec-expectations (>= 3.2.0, < 4)
+  rspec (~> 3.2)
   rspec-rails (>= 3.2.0, < 4)
   sass-rails (~> 4.0.0)
   sdoc

data/gemfiles/4.1.gemfile

@@ -7,8 +7,7 @@ gem "bundler", "~> 1.1"
 gem "pry", :github => "pry/pry"
 gem "pry-byebug"
 gem "rake", "~> 10.0"
-gem "rspec-core", ">= 3.2.0", "< 4"
-gem "rspec-expectations", ">= 3.2.0", "< 4"
+gem "rspec", "~> 3.2"
 gem "yard"
 gem "redcarpet"
 gem "pygments.rb"

data/gemfiles/4.1.gemfile.lock

@@ -116,6 +116,10 @@ GEM
     rake (10.4.2)
     rdoc (4.2.0)
     redcarpet (3.3.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
     rspec-core (3.3.2)
       rspec-support (~> 3.3.0)
     rspec-expectations (3.3.1)
@@ -196,8 +200,7 @@ DEPENDENCIES
   rails (~> 4.1.0)
   rake (~> 10.0)
   redcarpet
-  rspec-core (>= 3.2.0, < 4)
-  rspec-expectations (>= 3.2.0, < 4)
+  rspec (~> 3.2)
   rspec-rails (>= 3.2.0, < 4)
   sass-rails (~> 4.0.3)
   sdoc (~> 0.4.0)