shoulda-matchers 2.8.0 → 3.0.0.rc1

data/spec/support/tests/current_bundle.rb

@@ -0,0 +1,47 @@
+require 'bundler'
+require 'appraisal'
+
+module Tests
+  class CurrentBundle
+    AppraisalNotSpecified = Class.new(ArgumentError)
+
+    include Singleton
+
+    def assert_appraisal!
+      unless appraisal?
+        message = <<EOT
+
+
+Please run tests starting with `appraisal <appraisal_name>`.
+Possible appraisals are: #{possible_appraisals}
+
+EOT
+        raise AppraisalNotSpecified, message
+      end
+    end
+
+    private
+
+    def possible_appraisals
+      appraisals = []
+
+      Appraisal::File.each do |appraisal|
+        appraisals << appraisal.name
+      end
+
+      appraisals
+    end
+
+    def path
+      Bundler.default_gemfile
+    end
+
+    def appraisal?
+      path.dirname == root.join('gemfiles')
+    end
+
+    def root
+      Pathname.new('../../../..').expand_path(__FILE__)
+    end
+  end
+end

data/spec/support/tests/database.rb

@@ -0,0 +1,28 @@
+require_relative 'database_configuration'
+
+module Tests
+  class Database
+    NAME = 'shoulda-matchers-test'
+    ADAPTER_NAME = ENV.fetch('DATABASE_ADAPTER', 'sqlite3').to_sym
+
+    include Singleton
+
+    attr_reader :config
+
+    def initialize
+      @config = Tests::DatabaseConfiguration.for(NAME, ADAPTER_NAME)
+    end
+
+    def name
+      config.database
+    end
+
+    def adapter_name
+      config.adapter
+    end
+
+    def adapter_class
+      config.adapter_class
+    end
+  end
+end

data/spec/support/tests/database_adapters/postgresql.rb

@@ -0,0 +1,25 @@
+module Tests
+  module DatabaseAdapters
+    class PostgreSQL
+      def self.name
+        :postgresql
+      end
+
+      attr_reader :database
+
+      def initialize(database)
+        @database = database
+      end
+
+      def adapter
+        self.class.name
+      end
+
+      def require_dependencies
+        require 'pg'
+      end
+    end
+
+    DatabaseConfigurationRegistry.instance.register(PostgreSQL)
+  end
+end

data/spec/support/tests/database_adapters/sqlite3.rb

@@ -0,0 +1,26 @@
+module Tests
+  module DatabaseAdapters
+    class SQLite3
+      def self.name
+        :sqlite3
+      end
+
+      def initialize(_database)
+      end
+
+      def adapter
+        self.class.name
+      end
+
+      def database
+        'db/db.sqlite3'
+      end
+
+      def require_dependencies
+        require 'sqlite3'
+      end
+    end
+
+    DatabaseConfigurationRegistry.instance.register(SQLite3)
+  end
+end

data/spec/support/tests/database_configuration.rb

@@ -0,0 +1,33 @@
+require_relative 'database_configuration_registry'
+require 'delegate'
+
+module Tests
+  class DatabaseConfiguration < SimpleDelegator
+    ENVIRONMENTS = %w(development test production)
+
+    attr_reader :adapter_class
+
+    def self.for(database_name, adapter_name)
+      config_class = DatabaseConfigurationRegistry.instance.get(adapter_name)
+      config = config_class.new(database_name)
+      new(config)
+    end
+
+    def initialize(config)
+      @adapter_class = config.class.to_s.split('::').last
+      super(config)
+    end
+
+    def to_hash
+      ENVIRONMENTS.each_with_object({}) do |env, config_as_hash|
+        config_as_hash[env] = inner_config_as_hash
+      end
+    end
+
+    private
+
+    def inner_config_as_hash
+      { 'adapter' => adapter.to_s, 'database' => database.to_s }
+    end
+  end
+end

data/spec/support/tests/database_configuration_registry.rb

@@ -0,0 +1,28 @@
+require 'singleton'
+
+module Tests
+  class DatabaseConfigurationRegistry
+    include Singleton
+
+    def initialize
+      @registry = {}
+    end
+
+    def register(config_class)
+      registry[config_class.name] = config_class
+    end
+
+    def get(name)
+      registry.fetch(name) do
+        raise KeyError, "No such adapter registered: #{name}"
+      end
+    end
+
+    protected
+
+    attr_reader :registry
+  end
+end
+
+require_relative 'database_adapters/postgresql'
+require_relative 'database_adapters/sqlite3'

data/spec/support/tests/filesystem.rb

@@ -69,9 +69,32 @@ module Tests
     end
 
     def remove_from_file(path, pattern)
+      unless pattern.is_a?(Regexp)
+        pattern = Regexp.new('^' + Regexp.escape(pattern) + '$')
+      end
+
+      transform(path) do |lines|
+        lines.reject { |line| line =~ pattern }
+      end
+    end
+
+    def comment_lines_matching(path, pattern)
+      transform(path) do |lines|
+        lines.map do |line|
+          if line =~ pattern
+            "###{line}"
+          else
+            line
+          end
+        end
+      end
+    end
+
+    def transform(path)
       content = read(path)
-      content.sub!(/#{pattern}\n/, '')
-      write(path, content)
+      lines = content.split(/\n/)
+      transformed_lines = yield lines
+      write(path, transformed_lines.join("\n") + "\n")
     end
   end
 end

data/spec/support/unit/helpers/active_record_versions.rb

@@ -12,5 +12,17 @@ module UnitTests
     def active_record_can_raise_range_error?
       active_record_version >= 4.2
     end
+
+    def active_record_supports_enum?
+      defined?(::ActiveRecord::Enum)
+    end
+
+    def active_record_supports_has_secure_password?
+      active_record_version >= 3.1
+    end
+
+    def active_record_supports_array_columns?
+      active_record_version > 4.2
+    end
   end
 end

data/spec/support/unit/helpers/class_builder.rb

@@ -57,8 +57,12 @@ module UnitTests
       namespace.const_get(name_without_namespace).tap do |constant|
         constant.unloadable
 
-        if block_given?
-          constant.class_eval(&block)
+        if block
+          if block.arity == 0
+            constant.class_eval(&block)
+          else
+            block.call(constant)
+          end
         end
       end
     end

data/spec/support/unit/helpers/column_type_helpers.rb

@@ -0,0 +1,26 @@
+module UnitTests
+  module ColumnTypeHelpers
+    def self.configure_example_group(example_group)
+      example_group.include(self)
+    end
+
+    def column_type_class_namespace
+      if database_adapter == :postgresql
+        ActiveRecord::ConnectionAdapters::PostgreSQL
+      else
+        ActiveRecord::Type
+      end
+    end
+
+    def column_type_class_for(type)
+      namespace =
+        if type == :integer && database_adapter == :postgresql
+          column_type_class_namespace::OID
+        else
+          column_type_class_namespace
+        end
+
+      namespace.const_get(type.to_s.camelize)
+    end
+  end
+end

data/spec/support/unit/helpers/controller_builder.rb

@@ -52,34 +52,6 @@ module UnitTests
       $test_app.create_temp_view(path, contents)
     end
 
-    def controller_for_resource_with_strong_parameters(options = {}, &action_body)
-      model_name = options.fetch(:model_name, 'User')
-      controller_name = options.fetch(:controller_name, 'UsersController')
-      collection_name = controller_name.
-        to_s.sub(/Controller$/, '').underscore.
-        to_sym
-      action_name = options.fetch(:action, :some_action)
-      routes ||= options.fetch(:routes, -> { resources collection_name })
-
-      define_model(model_name)
-
-      controller_class = define_controller(controller_name) do
-        define_method action_name do
-          if action_body
-            instance_eval(&action_body)
-          end
-
-          render nothing: true
-        end
-      end
-
-      setup_rails_controller_test(controller_class)
-
-      define_routes(&routes)
-
-      controller_class
-    end
-
     def delete_temporary_views
       $test_app.delete_temp_views
     end

data/spec/support/unit/helpers/database_helpers.rb

@@ -0,0 +1,18 @@
+module UnitTests
+  module DatabaseHelpers
+    def self.configure_example_group(example_group)
+      example_group.include(self)
+      example_group.extend(self)
+    end
+
+    def database_adapter
+      Tests::Database.instance.adapter_name
+    end
+
+    def database_supports_uuid_columns?
+      database_adapter == :postgresql
+    end
+    alias_method :database_supports_array_columns?,
+      :database_supports_uuid_columns?
+  end
+end

data/spec/support/unit/helpers/model_builder.rb

@@ -32,10 +32,18 @@ module UnitTests
     end
 
     def define_active_model_class(class_name, options = {}, &block)
+      accessors = options.fetch(:accessors, [])
+
       define_class(class_name) do
         include ActiveModel::Validations
 
-        options[:accessors].each do |column|
+        def initialize(attributes = {})
+          attributes.each do |name, value|
+            __send__("#{name}=", value)
+          end
+        end
+
+        accessors.each do |column|
           attr_accessor column.to_sym
         end
 
@@ -52,9 +60,17 @@ module UnitTests
       table_block = lambda do |table|
         columns.each do |column_name, specification|
           if specification.is_a?(Hash)
-            table.column column_name, specification[:type], specification[:options]
+            column_type = specification[:type]
+            column_options = specification.fetch(:options, {})
           else
-            table.column column_name, specification
+            column_type = specification
+            column_options = {}
+          end
+
+          begin
+            table.__send__(column_type, column_name, column_options)
+          rescue NoMethodError
+            raise NoMethodError, "#{Tests::Database.instance.adapter_class} does not support :#{column_type} columns"
           end
         end
       end
@@ -66,13 +82,21 @@ module UnitTests
         create_table(table_name, &table_block)
       end
 
-      define_model_class(class_name).tap do |model|
+      model = define_model_class(class_name).tap do |m|
         if block
-          model.class_eval(&block)
+          if block.arity == 0
+            m.class_eval(&block)
+          else
+            block.call(m)
+          end
         end
 
-        model.table_name = table_name
+        m.table_name = table_name
       end
+
+      defined_models << model
+
+      model
     end
 
     private
@@ -85,6 +109,10 @@ module UnitTests
       elsif ActiveRecord::Base.connection_pool.respond_to?(:clear_cache!)
         ActiveRecord::Base.connection_pool.clear_cache!
       end
+
+      defined_models.each do |model|
+        model.reset_column_information
+      end
     end
 
     def drop_created_tables
@@ -98,5 +126,9 @@ module UnitTests
     def created_tables
       @_created_tables ||= []
     end
+
+    def defined_models
+      @_defined_models ||= []
+    end
   end
 end

data/spec/support/unit/helpers/rails_versions.rb

@@ -21,8 +21,8 @@ module UnitTests
       rails_version >= 4.1
     end
 
-    def active_record_supports_enum?
-      defined?(::ActiveRecord::Enum)
+    def rails_gte_4_2?
+      rails_version >= 4.2
     end
   end
 end

data/spec/support/unit/matchers/fail_with_message_including_matcher.rb

@@ -20,15 +20,17 @@ module UnitTests
       end
 
       def failure_message
-        msg = "Expectation should have failed with message including '#{expected}'"
+        lines = ['Expectation should have failed with message including:']
+        lines << Shoulda::Matchers::Util.indent(expected, 2)
 
         if @actual
-          msg << ",\nactually failed with '#{@actual}'"
+          lines << 'Actually failed with:'
+          lines << Shoulda::Matchers::Util.indent(@actual, 2)
         else
-          msg << ", but did not fail."
+          lines << 'However, the expectation did not fail.'
         end
 
-        msg
+        lines.join("\n")
       end
 
       def failure_message_for_should
@@ -36,10 +38,9 @@ module UnitTests
       end
 
       def failure_message_when_negated
-        msg  = "Expectation should not have failed with message including '#{expected}'"
-        msg << ", but did."
-
-        msg
+        lines = ['Expectation should not have failed with message including:']
+        lines << Shoulda::Matchers::Util.indent(expected, 2)
+        lines.join("\n")
       end
 
       def failure_message_for_should_not