shoulda-matchers 1.0.0 → 1.1.0

data/lib/shoulda/matchers/active_model/validate_numericality_of_matcher.rb

@@ -1,16 +1,17 @@
 module Shoulda # :nodoc:
   module Matchers
     module ActiveModel # :nodoc:
-
       # Ensure that the attribute is numeric
       #
       # Options:
       # * <tt>with_message</tt> - value the test expects to find in
       #   <tt>errors.on(:attribute)</tt>. Regexp or string.  Defaults to the
       #   translation for <tt>:not_a_number</tt>.
+      # * <tt>only_integer</tt> - allows only integer values
       #
-      # Example:
-      #   it { should validate_numericality_of(:age) }
+      # Examples:
+      #   it { should validate_numericality_of(:price) }
+      #   it { should validate_numericality_of(:age).only_integer }
       #
       def validate_numericality_of(attr)
         ValidateNumericalityOfMatcher.new(attr)
@@ -18,22 +19,51 @@ module Shoulda # :nodoc:
 
       class ValidateNumericalityOfMatcher < ValidationMatcher # :nodoc:
 
+        def only_integer
+          @only_integer = true
+          self
+        end
+
         def with_message(message)
-          @expected_message = message if message
+          if message
+            @expected_message = message
+          end
           self
         end
 
         def matches?(subject)
           super(subject)
-          @expected_message ||= :not_a_number
-          disallows_value_of('abcd', @expected_message)
+          disallows_non_integers? && disallows_text?
         end
 
         def description
-          "only allow numeric values for #{@attribute}"
+          "only allow #{allowed_type} values for #{@attribute}"
         end
-      end
 
+        private
+
+        def allowed_type
+          if @only_integer
+            "integer"
+          else
+            "numeric"
+          end
+        end
+
+        def disallows_non_integers?
+          if @only_integer
+            message = @expected_message || :not_an_integer
+            disallows_value_of(0.1, message) && disallows_value_of('0.1', message)
+          else
+            true
+          end
+        end
+
+        def disallows_text?
+          message = @expected_message || :not_a_number
+          disallows_value_of('abcd', message)
+        end
+      end
     end
   end
 end

data/lib/shoulda/matchers/active_model/validation_matcher.rb

@@ -1,9 +1,7 @@
 module Shoulda # :nodoc:
   module Matchers
     module ActiveModel # :nodoc:
-
       class ValidationMatcher # :nodoc:
-
         attr_reader :failure_message
 
         def initialize(attribute)
@@ -49,8 +47,6 @@ module Shoulda # :nodoc:
           end
         end
       end
-
     end
   end
-
-    end
+end

data/lib/shoulda/matchers/active_record.rb

@@ -2,7 +2,9 @@ require 'shoulda/matchers/active_record/association_matcher'
 require 'shoulda/matchers/active_record/have_db_column_matcher'
 require 'shoulda/matchers/active_record/have_db_index_matcher'
 require 'shoulda/matchers/active_record/have_readonly_attribute_matcher'
-
+require 'shoulda/matchers/active_record/serialize_matcher'
+require 'shoulda/matchers/active_record/query_the_database_matcher'
+require 'shoulda/matchers/active_record/accept_nested_attributes_for_matcher'
 
 module Shoulda
   module Matchers

data/lib/shoulda/matchers/active_record/accept_nested_attributes_for_matcher.rb

@@ -0,0 +1,127 @@
+module Shoulda
+  module Matchers
+    module ActiveRecord
+      # Ensures that the model can accept nested attributes for the specified
+      # association.
+      #
+      # Options:
+      # * <tt>allow_destroy</tt> - Whether or not to allow destroy
+      # * <tt>limit</tt> - Max number of nested attributes
+      # * <tt>update_only</tt> - Only allow updates
+      #
+      # Example:
+      #   it { should accept_nested_attributes_for(:friends) }
+      #   it { should accept_nested_attributes_for(:friends).
+      #                 allow_destroy(true).
+      #                 limit(4) }
+      #   it { should accept_nested_attributes_for(:friends).
+      #                 update_only(true) }
+      #
+      def accept_nested_attributes_for(name)
+        AcceptNestedAttributesForMatcher.new(name)
+      end
+
+      class AcceptNestedAttributesForMatcher
+        def initialize(name)
+          @name = name
+          self
+        end
+
+        def allow_destroy(allow_destroy)
+          @allow_destroy = allow_destroy
+          self
+        end
+
+        def limit(limit)
+          @limit = limit
+          self
+        end
+
+        def update_only(update_only)
+          @update_only = update_only
+          self
+        end
+
+        def matches?(subject)
+          @subject = subject
+          exists? &&
+            allow_destroy_correct? &&
+            limit_correct? &&
+            update_only_correct?
+        end
+
+        def failure_message
+          "Expected #{expectation} (#{@problem})"
+        end
+
+        def negative_failure_message
+          "Did not expect #{expectation}"
+        end
+
+        def description
+          description = "accepts_nested_attributes_for :#{@name}"
+          description += " allow_destroy => #{@allow_destroy}" if @allow_destroy
+          description += " limit => #{@limit}" if @limit
+          description += " update_only => #{@update_only}" if @update_only
+          description
+        end
+
+        protected
+
+        def exists?
+          if config
+            true
+          else
+            @problem = "is not declared"
+            false
+          end
+        end
+
+        def allow_destroy_correct?
+          if @allow_destroy.nil? || @allow_destroy == config[:allow_destroy]
+            true
+          else
+            @problem = (@allow_destroy ? "should" : "should not") +
+              " allow destroy"
+            false
+          end
+        end
+
+        def limit_correct?
+          if @limit.nil? || @limit == config[:limit]
+            true
+          else
+            @problem = "limit should be #@limit, got #{config[:limit]}"
+            false
+          end
+        end
+
+        def update_only_correct?
+          if @update_only.nil? || @update_only == config[:update_only]
+            true
+          else
+            @problem = (@update_only ? "should" : "should not") +
+              " be update only"
+            false
+          end
+        end
+
+        def config
+          model_config[@name]
+        end
+
+        def model_config
+          model_class.nested_attributes_options
+        end
+
+        def model_class
+          @subject.class
+        end
+
+        def expectation
+          "#{model_class.name} to accept nested attributes for #{@name}"
+        end
+      end
+    end
+  end
+end

data/lib/shoulda/matchers/active_record/association_matcher.rb

@@ -1,7 +1,6 @@
 module Shoulda # :nodoc:
   module Matchers
     module ActiveRecord # :nodoc:
-
       # Ensure that the belongs_to relationship exists.
       #
       #   it { should belong_to(:parent) }
@@ -166,7 +165,7 @@ module Shoulda # :nodoc:
           if @through == reflection.options[:through]
             true
           else
-            @missing = "Expected #{model_class.name} to have #{@name} through #{@through}, " <<
+            @missing = "Expected #{model_class.name} to have #{@name} through #{@through}, " +
               "but got it through #{reflection.options[:through]}"
             false
           end
@@ -210,7 +209,7 @@ module Shoulda # :nodoc:
 
         def join_table_exists?
           if @macro != :has_and_belongs_to_many ||
-              ::ActiveRecord::Base.connection.tables.include?(join_table.to_s)
+              ::ActiveRecord::Base.connection.tables.include?(join_table)
             true
           else
             @missing = "join table #{join_table} doesn't exist"
@@ -219,7 +218,7 @@ module Shoulda # :nodoc:
         end
 
         def class_has_foreign_key?(klass)
-          if klass.column_names.include?(foreign_key.to_s)
+          if klass.column_names.include?(foreign_key)
             true
           else
             @missing = "#{klass} does not have a #{foreign_key} foreign key."
@@ -232,7 +231,7 @@ module Shoulda # :nodoc:
         end
 
         def join_table
-          reflection.options[:join_table]
+          reflection.options[:join_table].to_s
         end
 
         def associated_class
@@ -240,7 +239,13 @@ module Shoulda # :nodoc:
         end
 
         def foreign_key
-          reflection.respond_to?(:foreign_key) ? reflection.foreign_key : reflection.primary_key_name
+          if foreign_key_reflection
+            if foreign_key_reflection.respond_to?(:foreign_key)
+              foreign_key_reflection.foreign_key.to_s
+            else
+              foreign_key_reflection.primary_key_name.to_s
+            end
+          end
         end
 
         def through?
@@ -251,6 +256,14 @@ module Shoulda # :nodoc:
           @reflection ||= model_class.reflect_on_association(@name)
         end
 
+        def foreign_key_reflection
+          if [:has_one, :has_many].include?(@macro) && reflection.options.include?(:inverse_of)
+            associated_class.reflect_on_association(reflection.options[:inverse_of])
+          else
+            reflection
+          end
+        end
+
         def through_reflection
           @through_reflection ||= model_class.reflect_on_association(@through)
         end
@@ -269,7 +282,6 @@ module Shoulda # :nodoc:
           end
         end
       end
-
     end
   end
 end

data/lib/shoulda/matchers/active_record/have_db_column_matcher.rb

@@ -16,12 +16,11 @@ module Shoulda # :nodoc:
       #                 with_options(:precision => 10, :scale => 2) }
       #
       def have_db_column(column)
-        HaveDbColumnMatcher.new(:have_db_column, column)
+        HaveDbColumnMatcher.new(column)
       end
 
       class HaveDbColumnMatcher # :nodoc:
-        def initialize(macro, column)
-          @macro  = macro
+        def initialize(column)
           @column = column
         end
 
@@ -36,6 +35,7 @@ module Shoulda # :nodoc:
           @default   = opts[:default]
           @null      = opts[:null]
           @scale     = opts[:scale]
+          @primary   = opts[:primary]
           self
         end
 
@@ -47,7 +47,8 @@ module Shoulda # :nodoc:
             correct_limit? &&
             correct_default? &&
             correct_null? &&
-            correct_scale?
+            correct_scale? &&
+            correct_primary?
         end
 
         def failure_message
@@ -151,6 +152,21 @@ module Shoulda # :nodoc:
           end
         end
 
+        def correct_primary?
+          return true if @primary.nil?
+          if matched_column.primary == @primary
+            true
+          else
+            @missing = "#{model_class} has a db column named #{@column} "
+            if @primary
+              @missing << "that is not primary, but should be"
+            else
+              @missing << "that is primary, but should not be"
+            end
+            false
+          end
+        end
+
         def matched_column
           model_class.columns.detect { |each| each.name == @column.to_s }
         end
@@ -163,7 +179,6 @@ module Shoulda # :nodoc:
           expected = "#{model_class.name} to #{description}"
         end
       end
-
     end
   end
 end

data/lib/shoulda/matchers/active_record/have_db_index_matcher.rb

@@ -19,12 +19,11 @@ module Shoulda # :nodoc:
       #   it { should have_db_index(:ssn).unique(true) }
       #
       def have_db_index(columns)
-        HaveDbIndexMatcher.new(:have_index, columns)
+        HaveDbIndexMatcher.new(columns)
       end
 
       class HaveDbIndexMatcher # :nodoc:
-        def initialize(macro, columns)
-          @macro = macro
+        def initialize(columns)
           @columns = normalize_columns_to_array(columns)
         end
 
@@ -84,7 +83,7 @@ module Shoulda # :nodoc:
         end
 
         def expectation
-          expected = "#{model_class.name} to #{description}"
+          "#{model_class.name} to #{description}"
         end
 
         def index_type
@@ -99,14 +98,9 @@ module Shoulda # :nodoc:
         end
 
         def normalize_columns_to_array(columns)
-          if columns.class == Array
-            columns.collect { |each| each.to_s }
-          else
-            [columns.to_s]
-          end
+          Array.wrap(columns).map(&:to_s)
         end
       end
-
     end
   end
 end

data/lib/shoulda/matchers/active_record/have_readonly_attribute_matcher.rb

@@ -12,16 +12,16 @@ module Shoulda # :nodoc:
       end
 
       class HaveReadonlyAttributeMatcher # :nodoc:
-
         def initialize(attribute)
           @attribute = attribute.to_s
         end
 
+        attr_reader :failure_message, :negative_failure_message
+
         def matches?(subject)
           @subject = subject
           if readonly_attributes.include?(@attribute)
-            @negative_failure_message =
-              "Did not expect #{@attribute} to be read-only"
+            @negative_failure_message = "Did not expect #{@attribute} to be read-only"
             true
           else
             if readonly_attributes.empty?
@@ -36,8 +36,6 @@ module Shoulda # :nodoc:
           end
         end
 
-        attr_reader :failure_message, :negative_failure_message
-
         def description
           "make #{@attribute} read-only"
         end
@@ -51,9 +49,7 @@ module Shoulda # :nodoc:
         def class_name
           @subject.class.name
         end
-
       end
-
     end
   end
 end