shotgun_api_ruby 0.0.8.4 → 0.1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40d52da8cf4bb1e972a1a4dd4cd0ec8aa8b572c356dbfa47e6b84ff466a1eb33
-  data.tar.gz: 64ee5ecaa4ed9b50fbf1b811ebca28dddf5b3150e99d61824ee327b5913da209
+  metadata.gz: ebb179d1404b03fd02a47b587b48e8a3cbbdfa69aa56141f2c4b3a9d73819eaf
+  data.tar.gz: ce95e7a5d7e7567ada62ac2604a6fc6f639cdacc3c61804fdd171a04de8309f1
 SHA512:
-  metadata.gz: 1caeabca35f814c45e40a477c4130cddc48d15ced65c1854e8db4d56d0574f4cb20ade9e028ccb8c05256c42bb5dcbfb82b30ec3086837ec5f11ea96423fcdd6
-  data.tar.gz: b9b6ba452f09ad70cae2a0c961c7a1712dbf21fba4f985ca2ae467c2bee2aa911cab213eecf6dbc73e671367ea8e0204e25b6e039c3ce61d81d0a04d49f43e8f
+  metadata.gz: 03fb2158143962471d55adc758434ed2817e6d04989d00694025bb2f876d6d7f2bc44525c5eb16832fe55f6dd87e9bb9335a7bbf55d9af5be011bcf9ffb29b55
+  data.tar.gz: 9d7d48612614d7db28ad1c10342dc604a6bd19638c019fcc6c5599da93623c65414be561c8855ff63e8bd97de3ed745c81f39f9fe8666914e1d6e0eab438917a

data/.github/workflows/test_and_publish.yml

@@ -2,72 +2,57 @@ name: Test and Release
 
 on:
   push:
-    branches: 
+    branches:
       - main
 
 jobs:
-  test-2_5:
+  tests:
+    strategy:
+      matrix:
+        ruby: [2.6, 2.7, 3.0]
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.5
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
-  test-2_6:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run linter
+        run: bundle exec rubocop
+      - name: Run tests
+        run: bundle exec rspec
+  prettier:
     runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.6
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
-  test-2_7:
-    runs-on: ubuntu-latest
-
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.7
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
+      - uses: actions/checkout@v2
+      - name: Set up Node
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14'
+      - name: Install yarn dep
+        run: yarn install
+      - name: Check prettier
+        run: yarn prettier -c '**/*.rb'
   release:
-    needs: [test-2_5, test-2_6, test-2_7]
+    needs: [tests, prettier]
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.7
-    - name: Install dependencies
-      run: bundle install
-    - name: Prepare credentials
-      env:
-        RUBYGEM_KEY: ${{ secrets.RUBYGEM_KEY }}
-      run: "echo -e \"---\\r\\n:rubygems_api_key: $RUBYGEM_KEY\" > ~/.gem/credentials && chmod 0600 ~/.gem/credentials"
-    - name: Setup username/email
-      run: "git config --global user.email zaratan@hey.com && git config --global user.name \"Denis <Zaratan> Pasin\""
-    - name: Publish
-      run: rake release
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0
+          bundler-cache: true
+      - name: Prepare credentials
+        env:
+          RUBYGEM_KEY: ${{ secrets.RUBYGEM_KEY }}
+        run: "mkdir -p ~/.gem && echo -e \"---\\r\\n:rubygems_api_key: $RUBYGEM_KEY\" > ~/.gem/credentials && chmod 0600 ~/.gem/credentials"
+      - name: Setup username/email
+        run: 'git config --global user.email zaratan@hey.com && git config --global user.name "Denis <Zaratan> Pasin"'
+      - name: Fetch tags from remote
+        run: 'git fetch -t'
+      - name: Publish if version change
+        run: 'git diff `git tag | tail -1` -- lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" && rake release || echo "No release for now"'

data/.github/workflows/test_only.yml

@@ -2,52 +2,36 @@ name: Tests
 
 on:
   push:
-    branches-ignore: 
+    branches-ignore:
       - main
 
 jobs:
-  test-2_5:
+  tests:
+    strategy:
+      matrix:
+        ruby: [2.6, 2.7, 3.0]
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.5
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
-  test-2_6:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run linter
+        run: bundle exec rubocop
+      - name: Run tests
+        run: bundle exec rspec
+  prettier:
     runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.6
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
-  test-2_7:
-    runs-on: ubuntu-latest
-
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.7
-    - name: Install dependencies
-      run: bundle install
-    - name: Run linter
-      run: bundle exec rubocop
-    - name: Run tests
-      run: bundle exec rspec
+      - uses: actions/checkout@v2
+      - name: Set up Node
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14'
+      - name: Install yarn dep
+        run: yarn install
+      - name: Check prettier
+        run: yarn prettier -c '**/*.rb'

data/.github/workflows/verify_version_change.yml

@@ -14,10 +14,8 @@ jobs:
       - name: Fetch main branch
         run: git fetch origin main:main
       - name: Verify if there's a change in version
-        run: "git diff main lib/shotgun_api_ruby/version.rb | grep VERSION"
+        run: "git diff main -- lib/shotgun_api_ruby/version.rb | grep VERSION"
       - name: Print new version
-        run: 'git diff main lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?"'
+        run: 'git diff main -- lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?"'
       - name: Verify if higher version
-        run: '[[ $(git diff main lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?") > $(git diff main lib/shotgun_api_ruby/version.rb | grep -E "^-.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?") ]]'
-      - name: Verify if version is updated in Gemfile.lock
-        run: '[[ $(cat Gemfile.lock | grep "$(git diff main lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?")") ]]'
+        run: '[[ $(git diff main -- lib/shotgun_api_ruby/version.rb | grep -E "^\+.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?") > $(git diff main -- lib/shotgun_api_ruby/version.rb | grep -E "^-.*VERSION" | grep -E -o "[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?") ]]'

data/.gitignore

@@ -11,3 +11,4 @@
 .rspec_status
 .env
 Gemfile.lock
+Gemfile.lock

data/.overcommit.yml

@@ -6,7 +6,16 @@ PreCommit:
     enabled: true
   BundleAudit:
     enabled: true
+  Prettier:
+    enabled: true
+    required_executable: './bin/prettirun'
 PrePush:
   RSpec:
     enabled: true
     command: ['bundle', 'exec', 'rspec', '-f', 'p'] # Invoke within Bundler context
+  Prettier:
+    enabled: true
+    required_executable: './bin/prettirun'
+  Rubocop:
+    enabled: true
+    required_executable: './bin/ruborun'

data/.prettierrc.js

@@ -0,0 +1,4 @@
+module.exports = {
+  trailingComma: "es5",
+  singleQuote: true,
+};

data/.rubocop.yml

@@ -1,6 +1,9 @@
 inherit_from:
   - http://relaxed.ruby.style/rubocop.yml
 
+inherit_gem:
+  prettier: rubocop.yml
+
 require: 
   - rubocop-performance
 
@@ -8,56 +11,11 @@ AllCops:
   NewCops: enable
   DisplayStyleGuide: true
   DisplayCopNames: true
+  SuggestExtensions: false
   Exclude:
-    - 'db/schema.rb'
-
-Style/GlobalVars:
-  Enabled: false
-
-Gemspec/RequiredRubyVersion:
-  Enabled: false
-
-Layout/DotPosition:
-  Enabled: true
-  EnforcedStyle: trailing
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
-
-Layout/MultilineArrayLineBreaks:
-  Enabled: true
-
-Layout/MultilineHashKeyLineBreaks:
-  Enabled: true
-
-Layout/MultilineMethodArgumentLineBreaks:
-  Enabled: true
-
-Layout/FirstArrayElementLineBreak:
-  Enabled: true
-
-Layout/FirstHashElementLineBreak:
-  Enabled: true
-
-Layout/FirstMethodArgumentLineBreak:
-  Enabled: true
-
-Layout/MultilineAssignmentLayout:
-  Enabled: true
-
-Layout/LineLength:
-  Enabled: true
-  Max: 120
-  AutoCorrect: true
-  Exclude:
-    - Gemfile
-    - Guardfile
-    - spec/interactors/send_gdpr_response_spec.rb
+    - 'bin/*'
+    - 'vendor/**/*'
+    - 'node_modules/**/*'
 
 Metrics/BlockLength:
   Exclude:
@@ -66,3 +24,10 @@ Metrics/BlockLength:
     - 'config/environments/*.rb'
     - 'lib/tasks/*.rake'
     - 'shotgun_api_ruby.gemspec'
+      
+### Prettier
+Style:
+  Enabled: false
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false

data/CHANGELOG.md

@@ -6,6 +6,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.1.0] - 2021-06-14
+### Added
+- Complete test coverage (Unit + Integration tests)
+- Adding minimum coverage for tests
+- Adding Guard
+
+### Changed
+- Fixed many edge-case bugs
+
+### Removed
+- Removed the `Gemfile.lock` since it shouldn't be commited in gems
+
+## [0.0.8.5] - 2021-01-15
+### Added
+- Added prettier for ruby style
+
 ## [0.0.8.4] - 2021-01-07
 ### Changed
 - Safer eager_load
@@ -26,7 +42,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Entities: delete
 - Entities: revive
 
-[Unreleased]: https://github.com/shotgunsoftware/shotgun_api_ruby/compare/v0.0.8.4...HEAD
+[Unreleased]: https://github.com/shotgunsoftware/shotgun_api_ruby/compare/v0.1.0...HEAD
+[0.1.0]: https://github.com/shotgunsoftware/shotgun_api_ruby/releases/tag/v0.1.0
+[0.0.8.5]: https://github.com/shotgunsoftware/shotgun_api_ruby/releases/tag/v0.0.8.5
 [0.0.8.4]: https://github.com/shotgunsoftware/shotgun_api_ruby/releases/tag/v0.0.8.4
 [0.0.8.3]: https://github.com/shotgunsoftware/shotgun_api_ruby/releases/tag/v0.0.8.3
 [0.0.8]: https://github.com/shotgunsoftware/shotgun_api_ruby/releases/tag/v0.0.8

data/Guardfile

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # map lib files to corresponding file
+  watch(%r{lib/(.*)/([^/]*).rb}) { |m| rspec.spec.call("#{m[1]}/#{m[2]}") }
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/Rakefile

@@ -1,8 +1,3 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-task default: :spec
+require 'bundler/gem_tasks'

data/bin/console

@@ -1,17 +1,26 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "bundler/setup"
-require "shotgun_api_ruby"
+require 'bundler/setup'
+require 'shotgun_api_ruby'
 
 require 'dotenv/load'
 
 if ENV['SITE_NAME'] && ENV['SCRIPT_NAME'] && ENV['SCRIPT_KEY']
-  $cl = ShotgunApiRuby.new(
-    shotgun_site: ENV['SITE_NAME'],
-    auth: { client_id: ENV['SCRIPT_NAME'], client_secret: ENV['SCRIPT_KEY'] }
-  )
+  $cl =
+    ShotgunApiRuby.new(
+      shotgun_site: ENV['SITE_NAME'],
+      auth: { client_id: ENV['SCRIPT_NAME'], client_secret: ENV['SCRIPT_KEY'] },
+    )
 end
+if ENV['SITE_URL'] && ENV['SCRIPT_NAME'] && ENV['SCRIPT_KEY']
+  $cl =
+    ShotgunApiRuby.new(
+      site_url: ENV['SITE_URL'],
+      auth: { client_id: ENV['SCRIPT_NAME'], client_secret: ENV['SCRIPT_KEY'] },
+    )
+end
+
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
@@ -19,5 +28,5 @@ end
 # require "pry"
 # Pry.start
 
-require "pry"
+require 'pry'
 Pry.start(__FILE__)