shoryuken 4.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f28614380213b13c17dea0f85aae332f8e335f6
-  data.tar.gz: 34e084982c8aa8ec9b0306f04f548cc1321eec13
+  metadata.gz: 020543c4df213954780e2db9436ab1ff93d481c5
+  data.tar.gz: fe7346621ec5e094ff5d13fcfb12591595ab678e
 SHA512:
-  metadata.gz: 40a160284600447798e3e1ebc61ec1e8bf596b0aa9d5558301d7f647e1ab1af285b845a9ec052eb52e157714d4066d3888f6f2192762898d9fc52decf1503a3b
-  data.tar.gz: 7f3d7584167804ad724dc3ca3a661cef8a4a60cadccebe333ceacb10333c0eb1bc7db9247439ddce875a1b7cb771769e9516afcda0ae5703991db780acd165d3
+  metadata.gz: f902d276c0255c23c2103375aac35f545fd8a3ad477e940a0f2628ed6d00874aa5dab09731f8c1554ebf1a9426b858075f16b20921c08536e54c26424f34de16
+  data.tar.gz: b95c4a300b3df721c5a11a7871870b08d77068bdabb46773d276dc98d040f56a66407e5dc6a6cda08d843d5f69ccc1d953ce6e718e593a0950c8da344bc45ec7

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## [v4.0.2] - 2018-11-26
+
+- Fix the delegated methods to public warning
+  - [#536](https://github.com/phstc/shoryuken/pull/536)
+
+- Specify exception class to `raise_error` matcher warning
+  - [#537](https://github.com/phstc/shoryuken/pull/537)
+
+- Fix spelling of "visibility"
+  - [#538](https://github.com/phstc/shoryuken/pull/538)
+
 ## [v4.0.1] - 2018-11-21
 
 - Allow caching visibility_timeout lookups

data/lib/shoryuken.rb

@@ -78,8 +78,8 @@ module Shoryuken
     :on_start,
     :on_stop,
     :on,
-    :cache_visiblity_timeout?,
-    :cache_visiblity_timeout=
+    :cache_visibility_timeout?,
+    :cache_visibility_timeout=
   )
 end
 

data/lib/shoryuken/options.rb

@@ -23,7 +23,7 @@ module Shoryuken
     @@stop_callback                   = nil
     @@worker_executor                 = Worker::DefaultExecutor
     @@launcher_executor               = nil
-    @@cache_visiblity_timeout         = false
+    @@cache_visibility_timeout        = false
 
     class << self
       def active_job?
@@ -199,6 +199,18 @@ module Shoryuken
         options[:lifecycle_events][event] << block
       end
 
+      def server?
+        defined?(Shoryuken::CLI)
+      end
+
+      def cache_visibility_timeout?
+        @@cache_visibility_timeout
+      end
+
+      def cache_visibility_timeout=(cache_visibility_timeout)
+        @@cache_visibility_timeout = cache_visibility_timeout
+      end
+
       private
 
       def default_server_middleware
@@ -217,18 +229,6 @@ module Shoryuken
       def default_client_middleware
         Middleware::Chain.new
       end
-
-      def server?
-        defined?(Shoryuken::CLI)
-      end
-
-      def cache_visiblity_timeout?
-        @@cache_visiblity_timeout
-      end
-
-      def cache_visiblity_timeout=(cache_visiblity_timeout)
-        @@cache_visiblity_timeout = cache_visiblity_timeout
-      end
     end
   end
 end

data/lib/shoryuken/queue.rb

@@ -14,9 +14,9 @@ module Shoryuken
     end
 
     def visibility_timeout
-      # Always lookup for the latest visiblity when cache is disabled
+      # Always lookup for the latest visibility when cache is disabled
       # setting it to nil, forces re-lookup
-      @_visibility_timeout = nil unless Shoryuken.cache_visiblity_timeout?
+      @_visibility_timeout = nil unless Shoryuken.cache_visibility_timeout?
       @_visibility_timeout ||= queue_attributes.attributes[VISIBILITY_TIMEOUT_ATTR].to_i
     end
 

data/lib/shoryuken/version.rb

@@ -1,3 +1,3 @@
 module Shoryuken
-  VERSION = '4.0.1'.freeze
+  VERSION = '4.0.2'.freeze
 end

data/spec/shoryuken/middleware/server/auto_extend_visibility_spec.rb

@@ -53,7 +53,7 @@ RSpec.describe Shoryuken::Middleware::Server::AutoExtendVisibility do
     allow(sqs_msg).to receive(:queue) { sqs_queue }
     expect(sqs_msg).to_not receive(:change_visibility)
 
-    expect { Runner.new.run_and_raise(TestWorker.new, queue, sqs_msg) }.to raise_error
+    expect { Runner.new.run_and_raise(TestWorker.new, queue, sqs_msg) }.to raise_error(RuntimeError)
   end
 
   it 'does not extend message visibility if auto_visibility_timeout is not true' do

data/spec/shoryuken/queue_spec.rb

@@ -235,7 +235,7 @@ RSpec.describe Shoryuken::Queue do
     end
   end
 
-  describe '#visiblity_timeout' do
+  describe '#visibility_timeout' do
     let(:attribute_response) { double 'Aws::SQS::Types::GetQueueAttributesResponse' }
 
     before do
@@ -247,7 +247,7 @@ RSpec.describe Shoryuken::Queue do
 
     context 'when cache is disabled' do
       specify do
-        Shoryuken.cache_visiblity_timeout = false
+        Shoryuken.cache_visibility_timeout = false
 
         expect(sqs).to(
           receive(:get_queue_attributes).with(queue_url: queue_url, attribute_names: ['All']).and_return(attribute_response).exactly(3).times
@@ -260,7 +260,7 @@ RSpec.describe Shoryuken::Queue do
 
     context 'when cache is enabled' do
       it 'memoizes response' do
-        Shoryuken.cache_visiblity_timeout = true
+        Shoryuken.cache_visibility_timeout = true
 
         expect(sqs).to(
           receive(:get_queue_attributes).with(queue_url: queue_url, attribute_names: ['All']).and_return(attribute_response).once

data/spec/spec_helper.rb

@@ -61,7 +61,7 @@ RSpec.configure do |config|
 
     Shoryuken.sqs_client_receive_message_opts.clear
 
-    Shoryuken.cache_visiblity_timeout = false
+    Shoryuken.cache_visibility_timeout = false
 
     allow(Concurrent).to receive(:global_io_executor).and_return(Concurrent::ImmediateExecutor.new)
     allow(Shoryuken).to receive(:active_job?).and_return(false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shoryuken
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Pablo Cantero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-21 00:00:00.000000000 Z
+date: 2018-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler