shortener 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f83263f62775a48c270b4d54188ad42b61f33180
-  data.tar.gz: 1a942c5240508df45fd79872054c2378af3fdf8f
+  metadata.gz: 0ff66256668eb71d5b42010c191233c7346c2651
+  data.tar.gz: f4cf3ffadd4b4f74ae6076be7f9fa13edf55b5ea
 SHA512:
-  metadata.gz: 327d337f3a099622a910aa5b840ccff3dc397968452879fa2e061d54f2e969611da8f1a0a5c8ea557b58ad7dd32fd1e6f726de97a5d64c4067f7f067a5dea2db
-  data.tar.gz: e4ab931bd972959a8a95eaa8cddfe973a00b57ed4cb5712c6e03c7e640fcd9f1d840b8c7ca6026b4c84175bb9b8b545b74aa1f91ff81e4686892b28c404f3ee1
+  metadata.gz: c88fd4cda719d6759af9f1faa5fc70829f18ff99662f77dc10ae33f20e9debcfabd051c5fe7157a75b505f45d164752cd40ead26ed110be6c09c1427e81e382e
+  data.tar.gz: 0e4ae113ede69db12a0b9901747bb20bb0ed4a72e51817e619524c166cc8cf1a8159f69c0352af843a48650773c3aa98e62d92a44f5e5ffcbcfd083265a0c629

data/README.rdoc

@@ -60,17 +60,16 @@ migration:
 * A unique alphanumeric code of generated for each shortened link, this means that we can get more unique combinations than if we just used numbers;
 * The link records a count of how many times it has been “un-shortened”;
 * The link can be associated with a user, this allows for stats of the link usage for a particular user and other interesting things;
-* The controller spawns a new thread to record information to the database, allowing the redirect to happen as quickly as possible;
 
 === Future improvements:
 
 * There has not been an attempt to remove ambiguous characters (i.e. 1 l and capital i, or 0 and O etc.) from the unique key generated for the link. This means people might copy the link incorrectly if copying the link by hand;
 * The system could pre-generate unique keys in advance, avoiding the database penalty when checking that a newly generated key is unique;
-* The system could store the shortened URL if the url is to be continually rendered;
+* The system could store/cache the shortened URL if the url is to be continually rendered;
 
 == Installation
 
-Shortener is compatible with Rails v3 and v4. To install, add to your Gemfile:
+Shortener is compatible with Rails v3, v4 & v5. To install, add to your Gemfile:
 
   gem 'shortener'
 

data/app/models/shortener/shortened_url.rb

@@ -7,7 +7,12 @@ class Shortener::ShortenedUrl < ActiveRecord::Base
   before_create :generate_unique_key
 
   # allows the shortened link to be associated with a user
-  belongs_to :owner, polymorphic: true
+  if ActiveRecord::VERSION::MAJOR >= 5
+    # adds rails 5 compatibility to have nil values as owner
+    belongs_to :owner, polymorphic: true, optional: true
+  else
+    belongs_to :owner, polymorphic: true
+  end
 
   # exclude records in which expiration time is set and expiration time is greater than current time
   scope :unexpired, -> { where(arel_table[:expires_at].eq(nil).or(arel_table[:expires_at].gt(::Time.current.to_s(:db)))) }

data/lib/shortener/version.rb

@@ -1,3 +1,3 @@
 module Shortener
-  VERSION = '0.7.2'
+  VERSION = '0.8.0'.freeze
 end

data/spec/dummy/config/initializers/new_framework_default.rb

@@ -0,0 +1,11 @@
+# This file extends the new Rails (aka version 5) framework default initializers.
+# It sets the application defaults therefore and because of this dummy application
+# supports new version should contain this file.
+# It isn't adding all defaults as the rails 5 does because of 5.1 and 5.2
+# contains different settings, therefore, it is scoping the settings that this gem
+# requires.
+if ActiveRecord::VERSION::MAJOR >= 5
+  # Require `belongs_to` associations by default. Previous versions had false.
+  Rails.application.config.active_record.belongs_to_required_by_default = true
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shortener
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - James P. McGrath
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-01 00:00:00.000000000 Z
+date: 2018-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: voight_kampff
@@ -174,6 +174,7 @@ files:
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/new_framework_default.rb
 - spec/dummy/config/initializers/secret_token.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/locales/en.yml