short_circuit 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82ba9bf7e740eb2c2d50b767e63025893c51c11f
-  data.tar.gz: 75510a972b29489923a5fbe7b25285afd57dce0b
+  metadata.gz: d93e00b341cbd357c7c7a62d8557d44fdd7df9e3
+  data.tar.gz: 0b2407c1a4bf746bbcc315ce191fe9370779f3d2
 SHA512:
-  metadata.gz: 172e84d9ae5b7c5c8965061ab49048e2a16f8266cf65cf38daee8e74d1e045867112b30b2b6242f2192fdcb4473b0b95c615dbe4bf74f3f0ea2f58a0e58a90dc
-  data.tar.gz: 48fba1a87f641240f4e8aafb6b07d42d2a01694252b6f3d13b25c5d48010020a526072696f4ba8d0b6fd853a7fc2eb2dce7e39fb7c9510d7c03b64d365e48124
+  metadata.gz: ef89a8b63fbaae886ecea3bdf9f2d4145a346435876d447acc716be6b2d821738955a1b7ce00f3b816f9f56d8bde42e6bd728d49c70eb8ff4e7054ae22713aea
+  data.tar.gz: fceb9078d1575cc3182a62e51bed2e0949b6127beb46f50bb75448fc60269ea0346c9de13f36cebde4ca4324c2f8fc687a45aab1a15b606def300b33d0e5bd44

data/README.md

@@ -102,11 +102,10 @@ In the view, you don't need to instantiate any presenter/decorator objects, just
 @user.present! :not_a_real_method # NoMethodError
 ```
 
-Design goals for short_circuit
-===============================
+Design goals
+============
 * Minimize project size and scope
 * Preserve direct access to model attributes
 * Create a separate access point for presenter methods
-* Integrate with ActiveRecord models by default
 * Silence accessor errors by default
 * Delegate missing presenter methods to the model object

data/lib/short_circuit.rb

@@ -1,6 +1,6 @@
 module ShortCircuit
   require 'active_support/all'
-  
+
   require 'short_circuit/version'
   require 'short_circuit/presenter'
   require 'short_circuit/presentable'

data/lib/short_circuit/presentable.rb

@@ -5,11 +5,9 @@ module ShortCircuit
     end
 
     def present(method, *args, &block)
-      begin
-        present!(method, *args, &block)
-      rescue Exception => error
-        presenter.error_response(error, method, *args, &block)
-      end
+      present!(method, *args, &block)
+    rescue Exception => error
+      presenter.error_response(error, method, *args, &block)
     end
 
     def present!(method, *args, &block)
@@ -21,7 +19,7 @@ module ShortCircuit
     def find_presenter
       presenter_class_name = "#{self.class.name}Presenter"
       presenter_class = Object.const_get(presenter_class_name)
-      
+
       presenter_class.new(self)
     end
   end

data/lib/short_circuit/presenter.rb

@@ -5,7 +5,9 @@ module ShortCircuit
     delegate :url_helpers, to: 'Rails.application.routes'
 
     def initialize(presentable_object)
-      instance_variable_set("@#{presentable_object.class.to_s.underscore}", presentable_object)
+      instance_variable_set(
+        "@#{presentable_object.class.to_s.underscore}",
+        presentable_object)
 
       super(presentable_object)
     end
@@ -13,7 +15,7 @@ module ShortCircuit
     def error_response(error, method, *args, &block)
       ''
     end
-    
+
     private
 
     def controller_helpers
@@ -22,13 +24,12 @@ module ShortCircuit
 
     def method_missing(method, *args, &block)
       if controller_helpers.respond_to?(method)
-        controller_helpers.send(method, *args, &block)  
+        controller_helpers.send(method, *args, &block)
       elsif url_helpers.respond_to?(method)
         url_helpers.send(method, *args, &block)
       else
         super(method, *args, &block)
-      end 
+      end
     end
-
   end
 end

data/lib/short_circuit/version.rb

@@ -1,3 +1,3 @@
 module ShortCircuit
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/short_circuit/presentable_spec.rb

@@ -34,7 +34,7 @@ module ShortCircuit
         let(:method) { :fake_method }
 
         it 'does not throw an error' do
-          expect{model.present(method)}.to_not raise_error
+          expect { model.present(method) }.to_not raise_error
         end
 
         it 'calls the error_response method' do
@@ -58,7 +58,7 @@ module ShortCircuit
         let(:method) { :fake_method }
 
         it 'throws an error' do
-          expect{model.present!(method)}.to raise_error(NoMethodError)
+          expect { model.present!(method) }.to raise_error
         end
       end
     end

data/spec/short_circuit/presenter_spec.rb

@@ -2,7 +2,9 @@ require 'spec_helper'
 
 module ShortCircuit
   describe Presenter do
-    let(:presentable_object) { mock_model('TestModel', test_method: 'Test Method') }
+    let(:presentable_object) do
+      mock_model('TestModel', test_method: 'Test Method')
+    end
 
     let(:presenter) { Presenter.new(presentable_object) }
 
@@ -29,7 +31,8 @@ module ShortCircuit
       end
 
       it 'set an instance variable for presentable_object' do
-        expect(presenter.instance_variable_get("@#{presentable_object.class.to_s.underscore}")).to eq(presentable_object)
+        var = "@#{presentable_object.class.to_s.underscore}"
+        expect(presenter.instance_variable_get(var)).to eq(presentable_object)
       end
     end
 
@@ -49,6 +52,5 @@ module ShortCircuit
         expect(error_response).to be_empty
       end
     end
-    
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'coveralls'
+Coveralls.wear!
+
 ENV['RAILS_ENV'] ||= 'test'
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: short_circuit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jim Pruetting