shopify_transporter 2.4.2 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 80de7ac44ca88bbd5594673844b78f83194c5bbf
-  data.tar.gz: d79f3023a4f0bcdbba5a2171fc48f6cf7022c2dd
+SHA256:
+  metadata.gz: 9332dbc1df8f90380027783d5e079153d4cb82e0268a46a0e79d2dbfdcc994ba
+  data.tar.gz: 11118012b99e576de3f579d2f04764f67d3b38d3f19e9de9747fd6a66a98813a
 SHA512:
-  metadata.gz: d07717c588c29b89a2732a08db6f6510fad13ce53a0c97c66e0eb574db8a2f95fa66d437094f9d1fe6d3232f8413cc54bc74ae53aafb6a2098b50e1debf1c70f
-  data.tar.gz: 725505e741bcff8f844240fee6885c29be1714d77fec5248312e8392e8ab4352c3ece52158e59ff8f62b50fee89161558d9e3ddc063e726a607b49c591aead57
+  metadata.gz: 449e03e75680cad6c9c37df3265c14fb96fa7147db69f923f7f9452ee556cf30086b540b5c3b984f59b2e836a7e6a9affa1c851a112cd4a1fa0e7450aa67e4c5
+  data.tar.gz: 67453eaca770aca247c342540772cfd1cdf96acd2a47470088e64b5546bd73825bb94ce6729332547e09660242a5f21071f994a522a4c8682baef0f231840f1d

data/lib/shopify_transporter/exporters/magento/soap.rb

@@ -74,12 +74,16 @@ module ShopifyTransporter
 
         def soap_client
           @soap_client ||= Savon.client(
-            wsdl: "https://#{@hostname}/api/v2_soap?wsdl",
+            wsdl: "#{hostname_with_scheme}/api/v2_soap?wsdl",
             open_timeout: 500,
             read_timeout: 500,
           )
         end
 
+        def hostname_with_scheme
+          URI.parse(@hostname).scheme.present? ? @hostname : 'https://' + @hostname
+        end
+
         def soap_session_id
           return @soap_session_id if @soap_session_id.present?
 

data/lib/shopify_transporter/pipeline/magento/order/discounts.rb

@@ -82,9 +82,11 @@ module ShopifyTransporter
           def qualifies_for_percentage_discount?(hash)
             return false unless line_items?(hash)
 
-            return true if line_items(hash).is_a?(Hash) && value_as_float(line_items(hash), 'discount_percent') > 0
-
-            all_discount_percentages(hash).length == 1 && all_discount_percentages(hash).first > 0
+            if line_items(hash).is_a?(Hash)
+              value_as_float(line_items(hash), 'discount_percent') > 0
+            else
+              all_discount_percentages(hash).length == 1 && all_discount_percentages(hash).first > 0
+            end
           end
 
           def line_items?(hash)

data/lib/shopify_transporter/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ShopifyTransporter
-  VERSION = '2.4.2'
+  VERSION = '2.5.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_transporter
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.5.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-05 00:00:00.000000000 Z
+date: 2018-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Tools for migrating to Shopify