shopify_transporter 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d74afe8f2cffa7be367716d17ee580cb69e793f4
-  data.tar.gz: 5193dbb1507a03df56e4c945f07fedfa29fdc2f1
+  metadata.gz: 823030a7648b9b678e18cb921609e0edb03030bd
+  data.tar.gz: 79dfaf0eba75e19ec062f07587595512e46fd877
 SHA512:
-  metadata.gz: 3a0fc07d7ab1c33b3d5556c9a3464c5a120b89e71b48072b0579e9098093c20933c29e3a152ba8ea59c678bf4a0952e968c07736babad5418aa90f318a7453ae
-  data.tar.gz: c7d9751cfd089ee8d73383ac09635350a6a72b1555ddd8aec67c23a9b5607d80ff895492e1d0fc49b487857cedeb20a46a8a491363d39d12989542cc3cccdcac
+  metadata.gz: ab3dc89742dacbeb311125ea2b01d9560f16b2a268b715b12e870fb937d61ee62f7c7077c8b8e574fafc0e0fc305ebe9633b5a2265ff5bc564cf6dc585dd9785
+  data.tar.gz: 22e0a658fcc3e7848152d7e377d123daf2c5afb4e5a1c86cd9ea9a9e3205a723d838bd5cb6a272ca9a59c8e1ed751f6f56d9a311c4ea9d8c905444c8cc3fdca5

data/lib/shopify_transporter/exporters/magento/soap.rb

@@ -7,6 +7,13 @@ module ShopifyTransporter
   module Exporters
     module Magento
       class Soap
+        class FailedLoginError < Exporters::ExportError
+          def initialize(error_message)
+            sep = $INPUT_RECORD_SEPARATOR
+            super("Unable to obtain SOAP session ID from server.#{sep + sep}Details:#{sep + error_message}")
+          end
+        end
+
         RETRY_SLEEP_TIME = 0.1
         MAX_RETRIES = 4
 
@@ -74,13 +81,20 @@ module ShopifyTransporter
         end
 
         def soap_session_id
-          @soap_session_id ||= soap_client.call(
+          return @soap_session_id if @soap_session_id.present?
+
+          result = soap_client.call(
             :login,
             message: {
               username: @username,
               api_key: @api_key,
             }
-          ).body[:login_response][:login_return]
+          ).body
+
+          session_id = result&.dig(:login_response, :login_return)
+          raise FailedLoginError, result.to_s unless session_id.present?
+
+          @soap_session_id ||= session_id
         end
 
         def batching_filter(starting_id, ending_id, batch_index_column)

data/lib/shopify_transporter/pipeline/magento/order/shipping_lines.rb

@@ -8,7 +8,7 @@ module ShopifyTransporter
       module Order
         class ShippingLines < Pipeline::Stage
           def convert(input, record)
-            record.merge(
+            record.merge!(
               {
                 shipping_lines: shipping_lines(input),
               }.stringify_keys

data/lib/shopify_transporter/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ShopifyTransporter
-  VERSION = '2.4.0'
+  VERSION = '2.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_transporter
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-31 00:00:00.000000000 Z
+date: 2018-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler