shopify_app 6.4.2 → 7.0.0

data/test/generators/routes_generator_test.rb

@@ -1,26 +0,0 @@
-require 'test_helper'
-require 'generators/shopify_app/routes/routes_generator'
-
-class ControllerGeneratorTest < Rails::Generators::TestCase
-  tests ShopifyApp::Generators::RoutesGenerator
-  destination File.expand_path("../tmp", File.dirname(__FILE__))
-
-  setup do
-    prepare_destination
-    provide_existing_routes_file
-    provide_existing_initializer_file
-  end
-
-  test "copies ShopifyApp routes to the host application" do
-    run_generator
-
-    assert_file "config/routes.rb" do |routes|
-      assert_match "get 'login' => :new, :as => :login", routes
-      assert_match "post 'login' => :create, :as => :authenticate", routes
-      assert_match "get 'auth/shopify/callback' => :callback", routes
-      assert_match "get 'logout' => :destroy, :as => :logout", routes
-      refute_match "mount ShopifyApp::Engine, at: '/'", routes
-    end
-  end
-
-end

data/test/generators/shop_model_generator_test.rb

@@ -1,39 +0,0 @@
-require 'test_helper'
-require 'generators/shopify_app/shop_model/shop_model_generator'
-
-class ShopModelGeneratorTest < Rails::Generators::TestCase
-  tests ShopifyApp::Generators::ShopModelGenerator
-  destination File.expand_path("../tmp", File.dirname(__FILE__))
-  setup :prepare_destination
-
-  test "create the shop model" do
-    run_generator
-    assert_file "app/models/shop.rb" do |shop|
-      assert_match "class Shop < ActiveRecord::Base", shop
-      assert_match "include ShopifyApp::Shop", shop
-      assert_match "include ShopifyApp::SessionStorage", shop
-    end
-  end
-
-  test "creates ShopModel migration" do
-    run_generator
-    assert_migration "db/migrate/create_shops.rb" do |migration|
-      assert_match "create_table :shops  do |t|", migration
-    end
-  end
-
-  test "adds the shopify_session_repository initializer" do
-    run_generator
-    assert_file "config/initializers/shopify_session_repository.rb" do |file|
-      assert_match "ShopifyApp::SessionRepository.storage = Shop", file
-    end
-  end
-
-  test "creates default shop fixtures" do
-    run_generator
-    assert_file "test/fixtures/shops.yml" do |file|
-      assert_match "regular_shop:", file
-    end
-  end
-
-end

data/test/generators/shopify_app_generator.rb

@@ -1,15 +0,0 @@
-require 'test_helper'
-require 'generators/shopify_app/shopify_app_generator'
-
-class ViewsGeneratorTest < Rails::Generators::TestCase
-  tests ShopifyApp::Generators::ViewsGenerator
-  destination File.expand_path("../tmp", File.dirname(__FILE__))
-  setup :prepare_destination
-
-  test "copies ShopifyApp views to the host application" do
-    run_generator
-    assert_directory "app/views"
-    assert_file "app/views/sessions/new.html.erb"
-  end
-
-end

data/test/generators/views_generator_test.rb

@@ -1,15 +0,0 @@
-require 'test_helper'
-require 'generators/shopify_app/views/views_generator'
-
-class ViewsGeneratorTest < Rails::Generators::TestCase
-  tests ShopifyApp::Generators::ViewsGenerator
-  destination File.expand_path("../tmp", File.dirname(__FILE__))
-  setup :prepare_destination
-
-  test "copies ShopifyApp views to the host application" do
-    run_generator
-    assert_directory "app/views"
-    assert_file "app/views/sessions/new.html.erb"
-  end
-
-end

data/test/shopify_app/configuration_test.rb

@@ -1,49 +0,0 @@
-require 'test_helper'
-
-class ConfigurationTest < ActiveSupport::TestCase
-
-  setup do
-    ShopifyApp.configuration = nil
-  end
-
-  test "configure" do
-    ShopifyApp.configure do |config|
-      config.embedded_app = true
-    end
-
-    assert_equal true, ShopifyApp.configuration.embedded_app
-  end
-
-  test "defaults to myshopify_domain" do
-    assert_equal "myshopify.com", ShopifyApp.configuration.myshopify_domain
-  end
-
-  test "can set myshopify_domain" do
-    ShopifyApp.configure do |config|
-      config.myshopify_domain = 'myshopify.io'
-    end
-
-    assert_equal "myshopify.io", ShopifyApp.configuration.myshopify_domain
-  end
-
-  test "can configure webhooks for creation" do
-    webhook = {topic: 'carts/update', address: 'example-app.com/webhooks', format: 'json'}
-
-    ShopifyApp.configure do |config|
-      config.webhooks = [webhook]
-    end
-
-    assert_equal webhook, ShopifyApp.configuration.webhooks.first
-  end
-
-  test "has_webhooks? is true if webhooks have been configured" do
-    refute ShopifyApp.configuration.has_webhooks?
-
-    ShopifyApp.configure do |config|
-      config.webhooks = [{topic: 'carts/update', address: 'example-app.com/webhooks', format: 'json'}]
-    end
-
-    assert ShopifyApp.configuration.has_webhooks?
-  end
-
-end

data/test/shopify_app/in_memory_session_store_test.rb

@@ -1,35 +0,0 @@
-require 'test_helper'
-
-class InMemorySessionStoreTest < ActiveSupport::TestCase
-  teardown do
-    InMemorySessionStore.clear
-  end
-
-  test "storing a session" do
-    uuid = InMemorySessionStore.store('something')
-    assert_equal 'something', InMemorySessionStore.repo[uuid]
-  end
-
-  test "retrieving a session" do
-    InMemorySessionStore.repo['abra'] = 'something'
-    assert_equal 'something', InMemorySessionStore.retrieve('abra')
-  end
-
-  test "clearing the store" do
-    uuid = InMemorySessionStore.store('data')
-    assert_equal 'data', InMemorySessionStore.retrieve(uuid)
-    InMemorySessionStore.clear
-    assert !InMemorySessionStore.retrieve(uuid), 'The sessions should have been removed'
-  end
-
-  test "it should raise when the environment is not valid" do
-    Rails.env.stubs(:production?).returns(true)
-    assert_raises InMemorySessionStore::EnvironmentError do
-      InMemorySessionStore.store('data')
-    end
-
-    assert_raises InMemorySessionStore::EnvironmentError do
-      InMemorySessionStore.retrieve('abracadabra')
-    end
-  end
-end

data/test/shopify_app/login_protection_test.rb

@@ -1,100 +0,0 @@
-require 'test_helper'
-require 'action_controller'
-require 'action_controller/base'
-
-class LoginProtectionController < ActionController::Base
-  include ShopifyApp::LoginProtection
-  helper_method :shop_session
-
-  around_action :shopify_session, only: [:index]
-  before_action :login_again_if_different_shop, only: [:second_login]
-
-  def index
-    render nothing: true
-  end
-
-  def second_login
-    render nothing: true
-  end
-end
-
-class LoginProtectionTest < ActionController::TestCase
-  tests LoginProtectionController
-
-  setup do
-    ShopifyApp::SessionRepository.storage = InMemorySessionStore
-  end
-
-  test "calling shop session returns nil when session is nil" do
-    with_application_test_routes do
-      session[:shopify] = nil
-      get :index
-      assert_nil @controller.shop_session
-    end
-  end
-
-  test "calling shop session retreives session from storage" do
-    with_application_test_routes do
-      session[:shopify] = "foobar"
-      get :index
-      ShopifyApp::SessionRepository.expects(:retrieve).returns(session).once
-      assert @controller.shop_session
-    end
-  end
-
-  test "shop session is memoized and does not retreive session twice" do
-    with_application_test_routes do
-      session[:shopify] = "foobar"
-      get :index
-      ShopifyApp::SessionRepository.expects(:retrieve).returns(session).once
-      assert @controller.shop_session
-      assert @controller.shop_session
-    end
-  end
-
-  test "login_again_if_different_shop removes current session and redirects to login path" do
-    with_application_test_routes do
-      session[:shopify] = "foobar"
-      session[:shopify_domain] = "foobar"
-      sess = stub(url: 'https://foobar.myshopify.com')
-      ShopifyApp::SessionRepository.expects(:retrieve).returns(sess).once
-      get :second_login, shop: 'other_shop'
-      assert_redirected_to @controller.send(:login_path, shop: 'other_shop')
-      assert_nil session[:shopify]
-      assert_nil session[:shopify_domain]
-    end
-  end
-
-  test '#shopify_session with no Shopify session, redirects to the login path' do
-    with_application_test_routes do
-      get :index, shop: 'foobar'
-      assert_redirected_to @controller.send(:login_path, shop: 'foobar')
-    end
-  end
-
-  test '#shopify_session with no Shopify session, sets session[:return_to]' do
-    with_application_test_routes do
-      get :index, shop: 'foobar'
-      assert_equal '/?shop=foobar', session[:return_to]
-    end
-  end
-
-  test '#shopify_session with no Shopify session, when the request is an XHR, returns an HTTP 401' do
-    with_application_test_routes do
-      xhr :get, :index, shop: 'foobar'
-      assert_equal 401, response.status
-    end
-  end
-
-  private
-
-  def with_application_test_routes
-    with_routing do |set|
-      set.draw do
-        get '/' => 'login_protection#index'
-        get '/second_login' => 'login_protection#second_login'
-      end
-      yield
-    end
-  end
-end

data/test/shopify_app/shopify_session_repository_test.rb

@@ -1,73 +0,0 @@
-require 'test_helper'
-
-class TestSessionStore
-  attr_reader :storage
-
-  def initialize
-    @storage = []
-  end
-
-  def retrieve(id)
-    storage[id]
-  end
-
-  def store(session)
-    id = storage.length
-    storage[id] = session
-    id
-  end
-end
-
-class TestSessionStoreClass
-  def self.store(session)
-  end
-
-  def self.retrieve(id)
-  end
-end
-
-class ShopifySessionRepositoryTest < ActiveSupport::TestCase
-  attr_reader :session_store, :session
-
-  setup do
-    @session_store = TestSessionStore.new
-    @session = ShopifyAPI::Session.new('shop.myshopify.com', 'abracadabra')
-    ShopifyApp::SessionRepository.storage = session_store
-  end
-
-  teardown do
-    ShopifyApp::SessionRepository.storage = nil
-  end
-
-  test "adding a session to the repository" do
-    assert_equal 0, ShopifyApp::SessionRepository.store(session)
-    assert_equal session, session_store.retrieve(0)
-  end
-
-  test "retrieving a session from the repository" do
-    session_store.storage[9] = session
-    assert_equal session, ShopifyApp::SessionRepository.retrieve(9)
-  end
-
-  test "retrieving a session for an id that does not exist" do
-    ShopifyApp::SessionRepository.store(session)
-    assert !ShopifyApp::SessionRepository.retrieve(100), "The session with id 100 should not exist in the Repository"
-  end
-
-  test "retrieving a session for a misconfigured shops repository" do
-    ShopifyApp::SessionRepository.storage = nil
-    assert_raises ShopifyApp::SessionRepository::ConfigurationError do
-      ShopifyApp::SessionRepository.retrieve(0)
-    end
-
-    assert_raises ShopifyApp::SessionRepository::ConfigurationError do
-      ShopifyApp::SessionRepository.store(session)
-    end
-  end
-
-  test "accepts a string and constantizes it" do
-    ShopifyApp::SessionRepository.storage = 'TestSessionStoreClass'
-    assert_equal TestSessionStoreClass, ShopifyApp::SessionRepository.storage
-  end
-
-end

data/test/shopify_app/utils_test.rb

@@ -1,30 +0,0 @@
-require 'test_helper'
-
-class UtilsTest < ActiveSupport::TestCase
-
-  setup do
-    ShopifyApp.configuration = nil
-  end
-
-  ['my-shop', 'my-shop.myshopify.com', 'https://my-shop.myshopify.com', 'http://my-shop.myshopify.com'].each do |good_url|
-    test "sanitize_shop_domain for (#{good_url})" do
-      ShopifyApp.configuration.embedded_app = true
-      assert ShopifyApp::Utils.sanitize_shop_domain(good_url)
-    end
-  end
-
-  ['my-shop', 'my-shop.myshopify.io', 'https://my-shop.myshopify.io', 'http://my-shop.myshopify.io'].each do |good_url|
-    test "sanitize_shop_domain URL (#{good_url}) with custom myshopify_domain" do
-      ShopifyApp.configuration.embedded_app = true
-      ShopifyApp.configuration.myshopify_domain = 'myshopify.io'
-      assert ShopifyApp::Utils.sanitize_shop_domain(good_url)
-    end
-  end
-
-  ['myshop.com', 'myshopify.com', 'shopify.com', 'two words', 'store.myshopify.com.evil.com', '/foo/bar'].each do |bad_url|
-    test "sanitize_shop_domain for a non-myshopify URL (#{bad_url})" do
-      assert_nil ShopifyApp::Utils.sanitize_shop_domain(bad_url)
-    end
-  end
-
-end

data/test/shopify_app/webhooks_controller_test.rb

@@ -1,50 +0,0 @@
-require 'test_helper'
-require 'action_controller'
-require 'action_controller/base'
-
-class WebhooksController < ActionController::Base
-  include ShopifyApp::WebhooksController
-  def carts_update
-    head :ok
-  end
-end
-
-class WebhooksControllerTest < ActionController::TestCase
-  tests WebhooksController
-
-  setup do
-    ShopifyApp::SessionRepository.storage = InMemorySessionStore
-    ShopifyApp.configure do |config|
-      config.secret = 'secret'
-    end
-  end
-
-  test "#carts_update should verify request" do
-    with_application_test_routes do
-      data = {foo: :bar}.to_json
-      @controller.expects(:validate_hmac).with('secret', data.to_s).returns(true)
-      post :carts_update, data
-      assert_response :ok
-    end
-  end
-
-  test "un-verified request returns unauthorized" do
-    with_application_test_routes do
-      data = {foo: :bar}.to_json
-      @controller.expects(:validate_hmac).with('secret', data.to_s).returns(false)
-      post :carts_update, data
-      assert_response :unauthorized
-    end
-  end
-
-  private
-
-  def with_application_test_routes
-    with_routing do |set|
-      set.draw do
-        get '/carts_update' => 'webhooks#carts_update'
-      end
-      yield
-    end
-  end
-end

data/test/shopify_app/webhooks_manager_test.rb

@@ -1,86 +0,0 @@
-require 'test_helper'
-
-class ShopifyApp::WebhooksManagerTest < ActiveSupport::TestCase
-
-  setup do
-    ShopifyApp.configure do |config|
-      config.webhooks = [
-        {topic: 'app/uninstalled', address: "https://example-app.com/webhooks/app_uninstalled"},
-        {topic: 'orders/create', address: "https://example-app.com/webhooks/order_create"},
-        {topic: 'orders/updated', address: "https://example-app.com/webhooks/order_updated"},
-      ]
-    end
-
-    @manager = ShopifyApp::WebhooksManager.new("regular-shop.myshopify.com", "token")
-  end
-
-  test "#create_webhooks makes calls to create webhooks" do
-    ShopifyAPI::Webhook.stubs(all: [])
-
-    expect_webhook_creation('app/uninstalled', "https://example-app.com/webhooks/app_uninstalled")
-    expect_webhook_creation('orders/create', "https://example-app.com/webhooks/order_create")
-    expect_webhook_creation('orders/updated', "https://example-app.com/webhooks/order_updated")
-
-    @manager.create_webhooks
-  end
-
-  test "#create_webhooks when creating a webhook fails, raises an error" do
-    ShopifyAPI::Webhook.stubs(all: [])
-    webhook = stub(persisted?: false)
-    ShopifyAPI::Webhook.stubs(create: webhook)
-
-    assert_raise ShopifyApp::WebhooksManager::CreationFailed do
-      @manager.create_webhooks
-    end
-  end
-
-  test "#create_webhooks when creating a webhook fails and the webhook exists, do not raise an error" do
-    webhook = stub(persisted?: false)
-    webhooks = all_webhook_topics.map{|t| stub(topic: t)}
-    ShopifyAPI::Webhook.stubs(create: webhook, all: webhooks)
-
-    assert_nothing_raised ShopifyApp::WebhooksManager::CreationFailed do
-      @manager.create_webhooks
-    end
-  end
-
-  test "#recreate_webhooks! destroys all webhooks and recreates" do
-    @manager.expects(:destroy_webhooks)
-    @manager.expects(:create_webhooks)
-
-    @manager.recreate_webhooks!
-  end
-
-  test "#destroy_webhooks makes calls to destroy webhooks" do
-    ShopifyAPI::Webhook.stubs(:all).returns(Array.wrap(all_mock_webhooks.first))
-    ShopifyAPI::Webhook.expects(:delete).with(all_mock_webhooks.first.id)
-
-    @manager.destroy_webhooks
-  end
-
-  test "#destroy_webhooks does not destroy webhooks that do not have a matching address" do
-    ShopifyAPI::Webhook.stubs(:all).returns([stub(address: 'http://something-or-the-other.com/webhooks/product_update', id: 7214109)])
-    ShopifyAPI::Webhook.expects(:delete).never
-
-    @manager.destroy_webhooks
-  end
-
-  private
-
-  def expect_webhook_creation(topic, address)
-    stub_webhook = stub(persisted?: true)
-    ShopifyAPI::Webhook.expects(:create).with(topic: topic, address: address, format: 'json').returns(stub_webhook)
-  end
-
-  def all_webhook_topics
-    @webhooks ||= ['app/uninstalled', 'orders/create', 'orders/updated']
-  end
-
-  def all_mock_webhooks
-    [
-      stub(id: 1, address: "https://example-app.com/webhooks/app_uninstalled", topic: 'app/uninstalled'),
-      stub(id: 2, address: "https://example-app.com/webhooks/order_create", topic: 'orders/create'),
-      stub(id: 3, address: "https://example-app.com/webhooks/order_updated", topic: 'orders/updated'),
-    ]
-  end
-end