shopify_app 6.4.0 → 6.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fdbb7537a49e1636bfed63000bcad7c99080486
-  data.tar.gz: fd61682e6ec442674b7fd0e340ad25ea5c1a1ed1
+  metadata.gz: f747bbf0aada63a6273ade2d8a3e0f6cbd360b76
+  data.tar.gz: 7aa89ed00eec5148493ef63d46bfacdcee4cd9f3
 SHA512:
-  metadata.gz: 02d042ee94d3c5a9beab3a1c2df59472b88acf4a415c70982689f28af8ff5f5552f28b16a24901afea9071a5753da6e27cd6ffb8b3e0d9675666748c109fb052
-  data.tar.gz: 56d11b9ded7132222e769d140f60107c16ae67531dfbe3fa37351bdca0dd997eb64ff76666a2e7292e7b1076652d23669adeb270805e8db603f5720e4ab77d62
+  metadata.gz: 32bb09b8483aa1e7c6fc23d0216d9ab32a7f13a93b421cee0fe398f8f8bc33ade76ab5b08d7a1390670289c179bb836758c903f0b885bc7d5cae43b35f805538
+  data.tar.gz: 772be6347dd75c8d791a97a8080b4c519beb9ebeef0cfba97b916f2074022013223d01ff2753cbc8a40942d808afc17832e8fb4b03938fcf2223cdeb14d8155e

data/README.md

@@ -156,7 +156,7 @@ The WebhooksManager uses ActiveJob, if ActiveJob is not configured then by defau
 ShopifyApp::SessionRepository
 -----------------------------
 
-`ShopifyApp::SessionRepository` allows you as a developer to define how your sessions are retrieved and stored for a shop. The `SessionRepository` is configured using the `config/initializers/shopify_session_repository.rb` file and can be set to any object the implements `self.store(shopify_session)` which stores the session and returns a unique identifier and `self.retrieve(id)` which returns a `ShopifyAPI::Session` for the passed id. See either the `InMemorySessionStore` or the `SessionStorage` module for examples.
+`ShopifyApp::SessionRepository` allows you as a developer to define how your sessions are retrieved and stored for a shop. The `SessionRepository` is configured using the `config/initializers/shopify_session_repository.rb` file and can be set to any object that implements `self.store(shopify_session)` which stores the session and returns a unique identifier and `self.retrieve(id)` which returns a `ShopifyAPI::Session` for the passed id. See either the `InMemorySessionStore` or the `SessionStorage` module for examples.
 
 If you only run the install generator then by default you will have an in memory store but it **won't work** on multi-server environments including Heroku. If you ran all the generators including the shop_model generator then the Shop model itself will be the `SessionRepository`. If you look at the implementation of the generated shop model you'll see that this gem provides an activerecord mixin for the `SessionRepository`. You can use this mixin on any model that responds to `shopify_domain` and `shopify_token`.
 

data/lib/generators/shopify_app/home_controller/home_controller_generator.rb

@@ -0,0 +1,32 @@
+require 'rails/generators/base'
+
+module ShopifyApp
+  module Generators
+    class HomeControllerGenerator < Rails::Generators::Base
+      source_root File.expand_path('../templates', __FILE__)
+
+      def create_home_controller
+        template 'home_controller.rb', 'app/controllers/home_controller.rb'
+      end
+
+      def create_home_index_view
+        copy_file 'index.html.erb', 'app/views/home/index.html.erb'
+        if embedded_app?
+          prepend_to_file(
+            'app/views/home/index.html.erb',
+            File.read(File.expand_path(find_in_source_paths('shopify_app_ready_script.html.erb')))
+          )
+        end
+      end
+
+      def add_home_index_route
+        route "mount ShopifyApp::Engine, at: '/'"
+        route "root :to => 'home#index'"
+      end
+
+      def embedded_app?
+        ShopifyApp.configuration.embedded_app?
+      end
+    end
+  end
+end

data/lib/generators/shopify_app/install/install_generator.rb

@@ -67,31 +67,12 @@ module ShopifyApp
         end
       end
 
-      def create_home_controller
-        template 'home_controller.rb', 'app/controllers/home_controller.rb'
-      end
-
-      def create_home_index_view
-        copy_file 'index.html.erb', 'app/views/home/index.html.erb'
-        if embedded_app?
-          prepend_to_file(
-            'app/views/home/index.html.erb',
-            File.read(File.expand_path(find_in_source_paths('shopify_app_ready_script.html.erb')))
-          )
-        end
-      end
-
-      def add_home_index_route
-        route "mount ShopifyApp::Engine, at: '/'"
-        route "root :to => 'home#index'"
-      end
 
       private
 
       def embedded_app?
         opts[:embedded] != 'false'
       end
-
     end
   end
 end

data/lib/generators/shopify_app/shopify_app_generator.rb

@@ -9,6 +9,7 @@ module ShopifyApp
 
       def run_all_generators
         generate "shopify_app:install #{@opts.join(' ')}"
+        generate "shopify_app:home_controller"
         generate "shopify_app:shop_model"
 
         generate "shopify_app:controllers"

data/lib/shopify_app/version.rb

@@ -1,3 +1,3 @@
 module ShopifyApp
-  VERSION = '6.4.0'
+  VERSION = '6.4.1'
 end

data/test/generators/home_controller_generator_test.rb

@@ -0,0 +1,50 @@
+require 'test_helper'
+require 'generators/shopify_app/home_controller/home_controller_generator'
+
+class HomeControllerGeneratorTest < Rails::Generators::TestCase
+  tests ShopifyApp::Generators::HomeControllerGenerator
+  destination File.expand_path("../tmp", File.dirname(__FILE__))
+
+  setup do
+    ShopifyApp.configure do |config|
+      config.embedded_app = true
+    end
+
+    prepare_destination
+    provide_existing_application_file
+    provide_existing_routes_file
+    provide_existing_application_controller
+  end
+
+  test "creates the home controller" do
+    run_generator
+    assert_file "app/controllers/home_controller.rb"
+  end
+
+  test "creates the home index view with embedded options" do
+    run_generator
+    assert_file "app/views/home/index.html.erb" do |index|
+      assert_match "ShopifyApp.ready", index
+    end
+  end
+
+  test "creates the home index view with embedded false" do
+    stub_embedded_false
+    run_generator
+    assert_file "app/views/home/index.html.erb" do |index|
+      refute_match "ShopifyApp.ready", index
+    end
+  end
+
+  test "adds engine and home route to routes" do
+    run_generator
+    assert_file "config/routes.rb" do |routes|
+      assert_match "mount ShopifyApp::Engine, at: '/'", routes
+      assert_match "root :to => 'home#index'", routes
+    end
+  end
+
+  def stub_embedded_false
+    ShopifyApp.configuration.embedded_app = false
+  end
+end

data/test/generators/install_generator_test.rb

@@ -76,34 +76,6 @@ class InstallGeneratorTest < Rails::Generators::TestCase
     assert_file "app/views/layouts/_flash_messages.html.erb"
   end
 
-  test "creates the home controller" do
-    run_generator
-    assert_file "app/controllers/home_controller.rb"
-  end
-
-  test "creates the home index view with embedded options" do
-    run_generator
-    assert_file "app/views/home/index.html.erb" do |index|
-      assert_match "ShopifyApp.ready", index
-    end
-  end
-
-  test "creates the home index view with embedded false" do
-    stub_embedded_false
-    run_generator
-    assert_file "app/views/home/index.html.erb" do |index|
-      refute_match "ShopifyApp.ready", index
-    end
-  end
-
-  test "adds engine and home route to routes" do
-    run_generator
-    assert_file "config/routes.rb" do |routes|
-      assert_match "mount ShopifyApp::Engine, at: '/'", routes
-      assert_match "root :to => 'home#index'", routes
-    end
-  end
-
   private
 
   def stub_embedded_false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_app
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.4.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-05 00:00:00.000000000 Z
+date: 2016-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -149,14 +149,15 @@ files:
 - app/views/sessions/new.html.erb
 - config/routes.rb
 - lib/generators/shopify_app/controllers/controllers_generator.rb
+- lib/generators/shopify_app/home_controller/home_controller_generator.rb
+- lib/generators/shopify_app/home_controller/templates/home_controller.rb
+- lib/generators/shopify_app/home_controller/templates/index.html.erb
+- lib/generators/shopify_app/home_controller/templates/shopify_app_ready_script.html.erb
 - lib/generators/shopify_app/install/install_generator.rb
 - lib/generators/shopify_app/install/templates/_flash_messages.html.erb
 - lib/generators/shopify_app/install/templates/embedded_app.html.erb
-- lib/generators/shopify_app/install/templates/home_controller.rb
-- lib/generators/shopify_app/install/templates/index.html.erb
 - lib/generators/shopify_app/install/templates/omniauth.rb
 - lib/generators/shopify_app/install/templates/shopify_app.rb
-- lib/generators/shopify_app/install/templates/shopify_app_ready_script.html.erb
 - lib/generators/shopify_app/install/templates/shopify_provider.rb
 - lib/generators/shopify_app/install/templates/shopify_session_repository.rb
 - lib/generators/shopify_app/routes/routes_generator.rb
@@ -204,6 +205,7 @@ files:
 - test/dummy/config/routes.rb
 - test/dummy/config/secrets.yml
 - test/generators/controllers_generator_test.rb
+- test/generators/home_controller_generator_test.rb
 - test/generators/install_generator_test.rb
 - test/generators/routes_generator_test.rb
 - test/generators/shop_model_generator_test.rb